Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-24 Thread Michael R. Crusoe 
Hello László,

I can confirm the fix. You could add the following as an autopkg test:

dependencies: libprotobuf-dev pkg-config protobuf-compiler-grpc
protobuf-compiler libgrpc-dev libgrpc++-dev

$ cd /examples/cpp/helloworld
$ make
$ ./greeter_server & ./greeter_client
# Server listening on 0.0.0.0:50051
Greeter received: Hello world


Thanks!

On Fri, Jul 24, 2020 at 6:12 PM László Böszörményi (GCS) 
wrote:

> On Fri, Jul 24, 2020 at 3:48 PM Benjamin Barenblat 
> wrote:
> > I’ve just reuploaded Abseil with an shlibs file instead of a symbols
> > file. The symbols file doesn’t buy us a whole lot anyway, since Abseil
> > is going to break ABI with every release.
>  It worked, builds are correct this time. Just uploaded gRPC 1.30.2 to
> unstable now.
> @Michael: Please test it and report back if it still hangs for you and
> / or any other patch you need applied.
>

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-24 Thread GCS 
On Fri, Jul 24, 2020 at 3:48 PM Benjamin Barenblat  wrote:
> I’ve just reuploaded Abseil with an shlibs file instead of a symbols
> file. The symbols file doesn’t buy us a whole lot anyway, since Abseil
> is going to break ABI with every release.
 It worked, builds are correct this time. Just uploaded gRPC 1.30.2 to
unstable now.
@Michael: Please test it and report back if it still hangs for you and
/ or any other patch you need applied.

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-24 Thread Benjamin Barenblat 
I’ve just reuploaded Abseil with an shlibs file instead of a symbols
file. The symbols file doesn’t buy us a whole lot anyway, since Abseil
is going to break ABI with every release.

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-23 Thread GCS 
On Thu, Jul 23, 2020 at 11:50 PM Benjamin Barenblat  wrote:
> On Wednesday, July 22, 2020, at  6:22 PM +0200, László Böszörményi (GCS) 
> wrote:
> > Benjamin, please upload abseil to Sid when you have time.
>
> I just did so. I've successfully built it on all official architectures
> manually, so I don't expect any build failures, but I'll keep an eye on
> the builders nonetheless.
 Thanks. Most builds came in and failed with symbols difference.
Except m68k where the pthreads library can't be found to link with.

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-23 Thread Benjamin Barenblat 
On Wednesday, July 22, 2020, at  6:22 PM +0200, László Böszörményi (GCS) wrote:
> Benjamin, please upload abseil to Sid when you have time.

I just did so. I've successfully built it on all official architectures
manually, so I don't expect any build failures, but I'll keep an eye on
the builders nonetheless.

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-22 Thread GCS 
On Sat, Jul 18, 2020 at 11:23 AM László Böszörményi (GCS)
 wrote:
> On Fri, Jul 17, 2020 at 8:15 PM Michael R. Crusoe  wrote:
> > Hello! As part of creating the new bazel-bootstrap we have run into a
> > bug fixed upstream in 1.30 https://github.com/grpc/grpc/issues/21213 but
> > we woudl like to not have to wait for abseil to pass the NEW queue.
>  Tried not to bark into abseil packaging anymore, but I think we
> should move forward. It was already checked by FTP Masters and got
> rejected. Benjamin fixed that issue and uploaded it. Then again weeks
> passed. :(
> Please FTP Masters re-check abseil and accept it to the archives if
> everything is in order this time.
 It has been accepted to the archives, but will fail to build all over
in experimental. Reason is simple, Sid has GCC 9.3.0 while
experimental has GCC 10.1.0 causing library symbol difference.
Benjamin, please upload abseil to Sid when you have time.

Thanks,
Laszlo/GCS

Bug#888705: Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-18 Thread GCS 
Hi,

On Fri, Jul 17, 2020 at 8:15 PM Michael R. Crusoe  wrote:
> Hello! As part of creating the new bazel-bootstrap we have run into a
> bug fixed upstream in 1.30 https://github.com/grpc/grpc/issues/21213 but
> we woudl like to not have to wait for abseil to pass the NEW queue.
 Tried not to bark into abseil packaging anymore, but I think we
should move forward. It was already checked by FTP Masters and got
rejected. Benjamin fixed that issue and uploaded it. Then again weeks
passed. :(
Please FTP Masters re-check abseil and accept it to the archives if
everything is in order this time.

Thanks,
Laszlo/GCS

Bug#965217: libgrpc++1: ServerBuilder::BuildAndStart hangs

2020-07-17 Thread Michael R. Crusoe 
Package: libgrpc++1
Version: 1.26.0-3
Severity: important
Tags: patch upstream
X-Debbugs-Cc: o...@debian.org, debian-scie...@lists.debian.org

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hello! As part of creating the new bazel-bootstrap we have run into a
bug fixed upstream in 1.30 https://github.com/grpc/grpc/issues/21213 but
we woudl like to not have to wait for abseil to pass the NEW queue.

Attached is a cherry-picked patch from upstream that fixes the issue. If
you could accept it and release 1.26.0-4 with it, then that would be
very appreciated!

Thanks in advance,

- -- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, arm64

Kernel: Linux 5.7.0-1-amd64 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages libgrpc++1 depends on:
ii  libc6  2.30-8
ii  libgcc-s1  10.1.0-4
pn  libgrpc9   
ii  libprotobuf22  3.11.4-5
pn  libprotobuf23  
ii  libstdc++6 10.1.0-4
ii  zlib1g 1:1.2.11.dfsg-2

libgrpc++1 recommends no packages.

libgrpc++1 suggests no packages.

-BEGIN PGP SIGNATURE-

iQJGBAEBCgAwFiEEck1gkzcRPHEFUNdHPCZ2P2xn5uIFAl8R6lESHGNydXNvZUBk
ZWJpYW4ub3JnAAoJEDwmdj9sZ+biy0EP/jl6/H02JabrQnRCTdfQuTwg6iouu+8r
n1zD4695e3OFUBHLFQuOcPsIEjGVqv/N3q6lB1grUGV9oUrjeG5UXpvcIKIx/+V6
tC2UPK7vTAiiw9KcWBobR+M4pEMcCO0XzpH1DRcjvnB3qtnYnsqSIjTfJ2cxVRE/
ssmLd0MZ6YHVCIanEFtWz1dPp4raJJ4UxAm9yOYgPgAm/D1ZDidSZfSgSkJ+xGER
9yBOjRi7hGkQs/6l0FBhUpCwHliWkZTuqyMswaPn3gRREkJdsWLyK7ULn2ZnO8cl
KPkxz/PdAlxLfUw6AG27RLEq4ZPEtuNapq3vks3OtbLyB8zZ8ISssrg1aI937Pq5
rcILKzUN/2PiwanxAR3trn0PCMwoV6lJVc0Ipp/85WPzh1WC4clSlfy9lpGm0ymU
VX0nRl2Sstej+a1AKYU3mRzLmz2OVGHTheSMdAkxtOcgdCxNAjPjHuEau9J2f1gR
It3UGlBd8wjSNcrlvUV7csAOJKWrYRJkG4/3bXCTnltMDtdIGfIs+NpKhzNc6urj
CrZV5afIrrDeZkqLp3xklbpAWCDUgdb6KQ5WiRkUyN8Fz3I8sQTHf2OIAprm4ozs
X7fx0voBUIaIvyA7o2QXQ2JupzI/tgH/VH1E1SZdy2uCTBOClVS1/KfcQWEbiC1J
Xa6qNMrlZM+F
=OAEa
-END PGP SIGNATURE-
diff -Nru grpc-1.26.0/debian/changelog grpc-1.26.0/debian/changelog
--- grpc-1.26.0/debian/changelog2020-04-30 23:13:54.0 +0200
+++ grpc-1.26.0/debian/changelog2020-07-17 18:27:14.0 +0200
@@ -1,3 +1,11 @@
+grpc (1.26.0-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Cherry-pick patch from upstream while we wait for grpc version 1.3.0 which 
is
+waiting for abseil to pass the NEW queue.
+
+ -- Michael R. Crusoe   Fri, 17 Jul 2020 18:27:14 +0200
+
 grpc (1.26.0-3) unstable; urgency=medium
 
   * Don't check for Sphinx version (closes: #955064).
diff -Nru grpc-1.26.0/debian/patches/remove_grpc_sources_from_grpc++.patch 
grpc-1.26.0/debian/patches/remove_grpc_sources_from_grpc++.patch
--- grpc-1.26.0/debian/patches/remove_grpc_sources_from_grpc++.patch
1970-01-01 01:00:00.0 +0100
+++ grpc-1.26.0/debian/patches/remove_grpc_sources_from_grpc++.patch
2020-07-17 18:27:09.0 +0200
@@ -0,0 +1,1979 @@
+From e7a9415a8d79a378deb3cec3a24ee2d03903f4c8 Mon Sep 17 00:00:00 2001
+From: Esun Kim 
+Date: Tue, 14 Jan 2020 16:35:23 -0800
+Subject: [PATCH] Remove grpc sources from grpc++
+Origin: 
upstream,https://github.com/grpc/grpc/pull/21662/commits/e7a9415a8d79a378deb3cec3a24ee2d03903f4c8
+
+"This is a rollback of commit in #20988, which introduced the ODR
+violation which causes an undefined behavior, in this case, segfault in
+trying to initialize the same global variable multiple times."
+
+---
+ BUILD.gn| 240 -
+ CMakeLists.txt  | 396 
+ Makefile| 396 
+ build.yaml  |   1 -
+ grpc.gyp| 396 
+ tools/doxygen/Doxyfile.c++.internal | 240 -
+ 6 files changed, 1669 deletions(-)
+
+--- grpc-1.26.0.orig/BUILD.gn
 grpc-1.26.0/BUILD.gn
+@@ -1191,135 +1191,32 @@
+ "include/grpcpp/support/sync_stream_impl.h",
+ "include/grpcpp/support/time.h",
+ "include/grpcpp/support/validate_service_config.h",
+-"src/core/ext/filters/client_channel/backend_metric.cc",
+-"src/core/ext/filters/client_channel/backend_metric.h",
+-"src/core/ext/filters/client_channel/backup_poller.cc",
+-"src/core/ext/filters/client_channel/backup_poller.h",
+-"src/core/ext/filters/client_channel/channel_connectivity.cc",
+-"src/core/ext/filters/client_channel/client_channel.cc",
+-"src/core/ext/filters/client_channel/client_channel.h",
+-"src/core/ext/filters/client_channel/client_channel_channelz.cc",
+-"src/core/ext/filters/client_channel/client_channel_channelz.h",
+-