Control: tags -1 + patch
On Mon, 24 Jul 2023 at 01:25:49 +0100, Simon McVittie wrote:
> On Mon, 17 Jul 2023 at 15:36:41 +0200, Bastian Germann wrote:
> > The package builds fine without the build dependency libgtk2.0-dev.
> > Please just drop it with your next upload.
>
> This doesn't seem to be the correct change: it has the side-effect of
> disabling code paths that rely on gdk-pixbuf-2.0, which is not obsolete.
>
> Swapping the build-dependency from libgtk2.0-dev to libgdk-pixbuf-2.0-dev
> seems more correct. I'm testing that change now.
I have confirmed using diffoscope that the attached patch (also available
as https://salsa.debian.org/debian/libgsf/-/merge_requests/4) does not
alter the contents of the binary packages.
Removing the libgtk2.0-dev B-D without replacing it with
libgdk-pixbuf-2.0-dev *does* affect the contents of the binary packages,
so is probably undesired.
smcv
>From 940df51d1039fa7f70cb953a08d06ddbe0e9b89f Mon Sep 17 00:00:00 2001
From: Simon McVittie
Date: Mon, 24 Jul 2023 01:18:33 +0100
Subject: [PATCH] Build-depend on libgdk-pixbuf-2.0-dev instead of
libgtk2.0-dev
GTK 2 is obsolete, but this package was relying on libgtk2.0-dev to
pull in gdk-pixbuf (which is not obsolete) as a dependency. Swap the
build-dependency to the library that is actually used.
Closes: #967580
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index 9073837..5607aae 100644
--- a/debian/control
+++ b/debian/control
@@ -7,10 +7,10 @@ Build-Depends: debhelper-compat (= 13), dh-buildinfo
,gtk-doc-tools
,intltool
,libbz2-dev
+ ,libgdk-pixbuf-2.0-dev
,libgirepository1.0-dev
,libglib2.0-dev
,libglib2.0-doc
- ,libgtk2.0-dev
,libxml2-dev
,unzip
,zlib1g-dev
--
2.40.1
