Bug#968735: libdap: Please switch to TI RPC implementation

2020-09-13 Thread Gianfranco Costamagna
Hello,

On Thu, 20 Aug 2020 19:46:44 +0200 Aurelien Jarno  wrote:
> Source: libdap
> Version: 3.20.6-3
> Severity: wishlist
> User: debian-gl...@lists.debian.org
> Usertags: rpc-remova
> 
> Dear maintainer,
> 
> The glibc SunRPC implementation has been marked obsolete for some time.
> It will get removed from glibc in version 2.32 that has been released a
> few weeks ago.  The TI RPC implementation should be used instead, which
> also brings new features (IPv6, Kerberos support, ...).
> 
> Fortunately libdap already supports using the TI RPC implementation and
> will automatically use it if found. Therefore all that you have to do is
> to add a build-depend on libtirpc-dev.
> 

unfortunately, while it detects it correctly, it seems to be forgetting to add 
the required headers and libs
to the cflags/ldflags in pkg-config and dap-config files.

The following "hacky" patch should do the trick, not tagging as patch because 
ideally we should use some autoconf macros and variable sto automatically feed 
the value

G.

Description: Fix build of reverse-dependencies now that tirpc is used (and 
rpc.h is removed in glibc 2.32)
Author: Gianfranco Costamagna 
Last-Update: 2020-09-13

--- libdap-3.20.6.orig/dap-config.in
+++ libdap-3.20.6/dap-config.in
@@ -56,11 +56,11 @@ while test $# -gt 0; do
;;

 --cflags)
-   echo "-I${includedir}/libdap @XML2_CFLAGS@ @CURL_CFLAGS@"
+   echo "-I${includedir}/libdap -I/usr/include/tirpc/ @XML2_CFLAGS@ 
@CURL_CFLAGS@"
;;

 --libs)
-   echo "-L${libdir64} -L${libdir} -ldap -ldapserver -ldapclient 
@CURL_LIBS@ @XML2_LIBS@ @PTHREAD_LIBS@ @UUID_LIBS@ @LIBS@"
+   echo "-L${libdir64} -L${libdir} -ldap -ldapserver -ldapclient 
-ltirpc @CURL_LIBS@ @XML2_LIBS@ @PTHREAD_LIBS@ @UUID_LIBS@ @LIBS@"
 ;;
 #
 #   Changed CURL_STATIC_LIBS to CURL_LIBS because the former was including a
--- libdap-3.20.6.orig/libdapclient.pc.in
+++ libdap-3.20.6/libdapclient.pc.in
@@ -9,8 +9,8 @@ Name: libdapclient
 Description: Client side of the OPeNDAP C++ implementation of the Data Access 
Protocol
 Version: @VERSION@
 Requires: libdap
-Libs: -L${libdir} -ldapclient
+Libs: -L${libdir} -ldapclient -ltirpc
 Libs.private: @curlprivatelibs@
 Requires.private: @curlprivatereq@, uuid
-Cflags: -I${includedir}/libdap
+Cflags: -I${includedir}/libdap -I${includedir}/tirpc/
 
Description: Fix build of reverse-dependencies now that tirpc is used (and rpc.h is removed in glibc 2.32)
Author: Gianfranco Costamagna 
Last-Update: 2020-09-13

--- libdap-3.20.6.orig/dap-config.in
+++ libdap-3.20.6/dap-config.in
@@ -56,11 +56,11 @@ while test $# -gt 0; do
 	;;
 
 --cflags)
-	echo "-I${includedir}/libdap @XML2_CFLAGS@ @CURL_CFLAGS@"
+	echo "-I${includedir}/libdap -I/usr/include/tirpc/ @XML2_CFLAGS@ @CURL_CFLAGS@"
 	;;
 
 --libs)
-   	echo "-L${libdir64} -L${libdir} -ldap -ldapserver -ldapclient @CURL_LIBS@ @XML2_LIBS@ @PTHREAD_LIBS@ @UUID_LIBS@ @LIBS@"
+   	echo "-L${libdir64} -L${libdir} -ldap -ldapserver -ldapclient -ltirpc @CURL_LIBS@ @XML2_LIBS@ @PTHREAD_LIBS@ @UUID_LIBS@ @LIBS@"
 ;;
 #
 #   Changed CURL_STATIC_LIBS to CURL_LIBS because the former was including a
--- libdap-3.20.6.orig/libdapclient.pc.in
+++ libdap-3.20.6/libdapclient.pc.in
@@ -9,8 +9,8 @@ Name: libdapclient
 Description: Client side of the OPeNDAP C++ implementation of the Data Access Protocol
 Version: @VERSION@
 Requires: libdap
-Libs: -L${libdir} -ldapclient
+Libs: -L${libdir} -ldapclient -ltirpc
 Libs.private: @curlprivatelibs@
 Requires.private: @curlprivatereq@, uuid
-Cflags: -I${includedir}/libdap
+Cflags: -I${includedir}/libdap -I${includedir}/tirpc/
 


Bug#968735: libdap: Please switch to TI RPC implementation

2020-08-20 Thread Aurelien Jarno
Source: libdap
Version: 3.20.6-3
Severity: wishlist
User: debian-gl...@lists.debian.org
Usertags: rpc-remova

Dear maintainer,

The glibc SunRPC implementation has been marked obsolete for some time.
It will get removed from glibc in version 2.32 that has been released a
few weeks ago.  The TI RPC implementation should be used instead, which
also brings new features (IPv6, Kerberos support, ...).

Fortunately libdap already supports using the TI RPC implementation and
will automatically use it if found. Therefore all that you have to do is
to add a build-depend on libtirpc-dev.

Thanks,
Aurelien