Bug#969225: python3-electrum: Please relax dependency on python3-qdarkstyle

2020-08-30 Thread intrigeri
Hi Tristan,

Tristan Seligmann (2020-08-30):
> On Sat, 29 Aug 2020 at 16:45,  wrote:
>> On top of that, since 4.0.2-1, python3-electrum has "Depends:
>> python3-qdarkstyle". Is this absolute dependency needed?
>> (See Policy 7.2¹ for details.)
>
> This dependency was picked up mostly by accident; upstream specifies a
> dependency on qdarkstyle in setup.py so when python3-qdarkstyle is
> installed at build-time, dh_python3 automatically translates the
> requires.txt entry into a Depends: in the binary package. Electrum is
> perfectly functional without this, though (it will just give you a
> warning if you try to activate dark mode), so I will filter the dep
> out at build time.

Thanks a lot for the quick fix!



Bug#969225: python3-electrum: Please relax dependency on python3-qdarkstyle

2020-08-30 Thread Tristan Seligmann
On Sat, 29 Aug 2020 at 16:45,  wrote:
> On top of that, since 4.0.2-1, python3-electrum has "Depends:
> python3-qdarkstyle". Is this absolute dependency needed?
> (See Policy 7.2¹ for details.)

This dependency was picked up mostly by accident; upstream specifies a
dependency on qdarkstyle in setup.py so when python3-qdarkstyle is
installed at build-time, dh_python3 automatically translates the
requires.txt entry into a Depends: in the binary package. Electrum is
perfectly functional without this, though (it will just give you a
warning if you try to activate dark mode), so I will filter the dep
out at build time.



Bug#969225: python3-electrum: Please relax dependency on python3-qdarkstyle

2020-08-29 Thread intrigeri
Package: python3-electrum
Version: 4.0.2-1
Severity: normal
User: tails-...@boum.org
Usertags: misc-reported

Hi,

I see that electrum has "Recommends: python3-qdarkstyle"; so far,
so good.

On top of that, since 4.0.2-1, python3-electrum has "Depends:
python3-qdarkstyle". Is this absolute dependency needed?
(See Policy 7.2¹ for details.)

I'm asking because:

 - As far as I can tell, electrum and python3-electrum 4.0.2-0.1
   worked just fine without this dependency. So I'm wondering why
   4.0.2-1 differs in this respect.

 - python3-qdarkstyle depends on python3-qtpy, which itself pulls in
   a big pile of python3-pyqt5.*. This causes trouble in the context
   of Tails as this would make our live images and updates
   significantly larger.

[1] 
https://www.debian.org/doc/debian-policy/ch-relationships.html#binary-dependencies-depends-recommends-suggests-enhances-pre-depends

Thank you for maintaining Electrum in Debian,
cheers!