Bug#969538: vips/ruby-vips: autopkgtest regression on arm64 and ppc64el
On Wed, Oct 7, 2020 at 3:39 PM Gianfranco Costamagna wrote: > According to upstream, this might fix the issue I'm not sure if Kleis Auke is part of upstream. But testing his fix on ARM64 - please give me some time as it's just an emulation for me and not very fast. Going to upload the fixed package if that works. Regards, Laszlo/GCS
Bug#969538: vips/ruby-vips: autopkgtest regression on arm64 and ppc64el
According to upstream, this might fix the issue diff -Nru vips-8.10.1/debian/changelog vips-8.10.1/debian/changelog --- vips-8.10.1/debian/changelog2020-10-03 18:41:08.0 +0200 +++ vips-8.10.1/debian/changelog2020-10-07 13:20:49.0 +0200 @@ -1,3 +1,12 @@ +vips (8.10.1-2ubuntu1) groovy; urgency=medium + + * debian/patches/143c815a0a85cb187bc6f690dab0555fd617063e.patch: +- cherry-pick an upstream fix for autopkgtests on arm64 and ppc64el + ( See Debian bug: #969538 and +https://github.com/libvips/libvips/issues/1846 ) + + -- Gianfranco Costamagna Wed, 07 Oct 2020 13:20:49 +0200 + vips (8.10.1-2) unstable; urgency=medium * Backport upstream fix for docs building with gobject-introspection 1.66+ diff -Nru vips-8.10.1/debian/patches/143c815a0a85cb187bc6f690dab0555fd617063e.patch vips-8.10.1/debian/patches/143c815a0a85cb187bc6f690dab0555fd617063e.patch --- vips-8.10.1/debian/patches/143c815a0a85cb187bc6f690dab0555fd617063e.patch 1970-01-01 01:00:00.0 +0100 +++ vips-8.10.1/debian/patches/143c815a0a85cb187bc6f690dab0555fd617063e.patch 2020-10-07 13:20:49.0 +0200 @@ -0,0 +1,37 @@ +Origin: https://github.com/kleisauke/libvips/commit/143c815a0a85cb187bc6f690dab0555fd617063e +Bug: https://github.com/libvips/libvips/issues/1846 +From 143c815a0a85cb187bc6f690dab0555fd617063e Mon Sep 17 00:00:00 2001 +From: kleisauke +Date: Wed, 7 Oct 2020 15:20:18 +0200 +Subject: [PATCH] Try a patch for libvips/libvips#1846 + +--- + libvips/morphology/morph.c | 8 + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/libvips/morphology/morph.c b/libvips/morphology/morph.c +index 7f7ffc485..07a6fc517 100644 +--- a/libvips/morphology/morph.c b/libvips/morphology/morph.c +@@ -449,8 +449,8 @@ vips_dilate_gen( VipsRegion *or, + seq->ss = 0; + seq->cs = 0; + for( y = 0; y < M->Ysize; y++ ) +- for( x = 0; x < M->Xsize; x++ ) +- switch( t[x] ) { ++ for( x = 0; x < M->Xsize; x++, t++ ) ++ switch( *t ) { + case 255: + soff[seq->ss++] = + VIPS_REGION_ADDR( ir, +@@ -560,8 +560,8 @@ vips_erode_gen( VipsRegion *or, + seq->ss = 0; + seq->cs = 0; + for( y = 0; y < M->Ysize; y++ ) +- for( x = 0; x < M->Xsize; x++ ) +- switch( t[x] ) { ++ for( x = 0; x < M->Xsize; x++, t++ ) ++ switch( *t ) { + case 255: + soff[seq->ss++] = + VIPS_REGION_ADDR( ir, diff -Nru vips-8.10.1/debian/patches/series vips-8.10.1/debian/patches/series --- vips-8.10.1/debian/patches/series 2020-10-03 18:41:08.0 +0200 +++ vips-8.10.1/debian/patches/series 2020-10-07 13:20:49.0 +0200 @@ -1,2 +1,3 @@ reproducible-build.patch fix_build_with_goi_1.66+.patch +143c815a0a85cb187bc6f690dab0555fd617063e.patch G.
Bug#969538: vips/ruby-vips: autopkgtest regression on arm64 and ppc64el
control: forwarded -1 https://github.com/libvips/libvips/issues/1846 thanks G.
Bug#969538: vips/ruby-vips: autopkgtest regression on arm64 and ppc64el
control: affects -1 ruby-vips G. On Fri, 4 Sep 2020 17:14:23 +0200 Gianfranco Costamagna wrote: > Source: vips > Version: 8.10.0-1 > Severity: serious > > Hello, your package regressed its testsuite on arm64 in Debian and Ubuntu (in > Ubuntu also ppc64el, in Debian I didn't check but the failure is the same) > > https://ci.debian.net/packages/r/ruby-vips/testing/arm64/ > > > ??? Checking Rubygems dependency resolution on ruby2.7 >??? > > > GEM_PATH= ruby2.7 -e gem\ \"ruby-vips\" > > > ??? Run tests for ruby2.7 from debian/ruby-tests.rake >??? > > > mv lib .gem2deb.lib > RUBYLIB=. GEM_PATH= ruby2.7 -S rake -f debian/ruby-tests.rake > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/rake_task.rb:125: > warning: deprecated Object#=~ is called on Array; it always returns nil > /usr/bin/ruby2.7 > -I/usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib:/usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/exe/rspec > --pattern ./spec/\*\*/\*_spec.rb --backtrace -r ./spec/spec_helper.rb > ./usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing > the given block using Proc.new is deprecated; use `` instead > /usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given > block using Proc.new is deprecated; use `` instead > ./usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given > block using Proc.new is deprecated; use `` instead > ../usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given > block using Proc.new is deprecated; use `` instead > /usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given > block using Proc.new is deprecated; use `` instead > ..F > > Failures: > > 1) Vips::Image can dilate > Failure/Error: expect(im.getpoint(11, 12)).to eq([255]) > >expected: [255] > got: [0.0] > >(compared using ==) > # > /usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib/rspec/support.rb:97:in > `block in ' > # > /usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib/rspec/support.rb:106:in > `notify_failure' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/fail_with.rb:35:in > `fail_with' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:38:in > `handle_failure' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:50:in > `block in handle_matcher' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:27:in > `with_matcher' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:48:in > `handle_matcher' > # > /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/expectation_target.rb:65:in > `to' > # ./spec/image_spec.rb:477:in `block (2 levels) in ' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:257:in > `instance_exec' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:257:in > `block in run' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:503:in > `block in with_around_and_singleton_context_hooks' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:460:in > `block in with_around_example_hooks' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/hooks.rb:472:in > `block in run' > # > /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/hooks.rb:610:in >
Bug#969538: vips/ruby-vips: autopkgtest regression on arm64 and ppc64el
Source: vips Version: 8.10.0-1 Severity: serious Hello, your package regressed its testsuite on arm64 in Debian and Ubuntu (in Ubuntu also ppc64el, in Debian I didn't check but the failure is the same) https://ci.debian.net/packages/r/ruby-vips/testing/arm64/ ??? Checking Rubygems dependency resolution on ruby2.7 ??? GEM_PATH= ruby2.7 -e gem\ \"ruby-vips\" ??? Run tests for ruby2.7 from debian/ruby-tests.rake ??? mv lib .gem2deb.lib RUBYLIB=. GEM_PATH= ruby2.7 -S rake -f debian/ruby-tests.rake /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/rake_task.rb:125: warning: deprecated Object#=~ is called on Array; it always returns nil /usr/bin/ruby2.7 -I/usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib:/usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/exe/rspec --pattern ./spec/\*\*/\*_spec.rb --backtrace -r ./spec/spec_helper.rb ./usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given block using Proc.new is deprecated; use `` instead /usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given block using Proc.new is deprecated; use `` instead ./usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given block using Proc.new is deprecated; use `` instead ../usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given block using Proc.new is deprecated; use `` instead /usr/lib/ruby/vendor_ruby/vips/object.rb:269: warning: Capturing the given block using Proc.new is deprecated; use `` instead ..F Failures: 1) Vips::Image can dilate Failure/Error: expect(im.getpoint(11, 12)).to eq([255]) expected: [255] got: [0.0] (compared using ==) # /usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib/rspec/support.rb:97:in `block in ' # /usr/share/rubygems-integration/all/gems/rspec-support-3.9.2/lib/rspec/support.rb:106:in `notify_failure' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/fail_with.rb:35:in `fail_with' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:38:in `handle_failure' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:27:in `with_matcher' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher' # /usr/share/rubygems-integration/all/gems/rspec-expectations-3.9.0/lib/rspec/expectations/expectation_target.rb:65:in `to' # ./spec/image_spec.rb:477:in `block (2 levels) in ' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:257:in `instance_exec' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:257:in `block in run' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:503:in `block in with_around_and_singleton_context_hooks' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:460:in `block in with_around_example_hooks' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/hooks.rb:472:in `block in run' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/hooks.rb:610:in `run_around_example_hooks_for' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/hooks.rb:472:in `run' # /usr/share/rubygems-integration/all/gems/rspec-core-3.9.1/lib/rspec/core/example.rb:460:in `with_around_example_hooks' #