Bug#970006: unused-override is reported with new tag name
Hi Jelmer, On Fri, Sep 11, 2020 at 5:08 AM Jelmer Vernooij wrote: > > For example, see iio-sensor-proxy. Its debian/source/lintian-overrides has: > > iio-sensor-proxy: binary-without-manpage usr/bin/monitor-sensor > iio-sensor-proxy: binary-without-manpage usr/sbin/iio-sensor-proxy > iio-sensor-proxy: systemd-service-file-missing-documentation-key > lib/systemd/system/iio-sensor-proxy.service That is not quite what I am seeing. I believe these overrides are incorrectly listed as source overrides in d/source/lintian-overrides. [1] The tags are for installation packages, so their overrides in the source package remain unused (one unrelated tag was removed): % bin/lintian /mirror/debian/pool/main/i/iio-sensor-proxy/iio-sensor-proxy_3.0-1.dsc I: iio-sensor-proxy source: unused-override no-manual-page usr/bin/monitor-sensor I: iio-sensor-proxy source: unused-override no-manual-page usr/sbin/iio-sensor-proxy I: iio-sensor-proxy source: unused-override systemd-service-file-missing-documentation-key lib/systemd/system/iio-sensor-proxy.service P: iio-sensor-proxy source: renamed-tag binary-without-manpage => no-manual-page in line 2 P: iio-sensor-proxy source: renamed-tag binary-without-manpage => no-manual-page in line 3 As a courtesy, Lintian also reminds the user that the tag was renamed. For the installation package, on the other hand, Lintian reports (some unrelated tags were removed): % bin/lintian /mirror/debian/pool/main/i/iio-sensor-proxy/iio-sensor-proxy_3.0-1_amd64.deb W: iio-sensor-proxy: no-manual-page usr/bin/monitor-sensor W: iio-sensor-proxy: no-manual-page usr/sbin/iio-sensor-proxy I: iio-sensor-proxy: package-supports-alternative-init-but-no-init.d-script lib/systemd/system/iio-sensor-proxy.service I: iio-sensor-proxy: systemd-service-file-missing-documentation-key lib/systemd/system/iio-sensor-proxy.service I: iio-sensor-proxy: systemd-service-file-missing-install-key lib/systemd/system/iio-sensor-proxy.service As far as I can tell, Lintian reports what was intended. Can you please try moving the file in [1] to debian/iio-sensor-proxy.lintian-overrides? Kind regards Felix Lechner [1] https://sources.debian.org/src/iio-sensor-proxy/3.0-1/debian/source/lintian-overrides/
Bug#970006: unused-override is reported with new tag name
Package: lintian Version: 2.93.0 Severity: normal lintian reports unused overrides lines with the new tag name, but checks against the old tag name (which is unused for obvious reasons). For example, see iio-sensor-proxy. Its debian/source/lintian-overrides has: # no documentation man pages available iio-sensor-proxy: binary-without-manpage usr/bin/monitor-sensor iio-sensor-proxy: binary-without-manpage usr/sbin/iio-sensor-proxy iio-sensor-proxy: systemd-service-file-missing-documentation-key lib/systemd/system/iio-sensor-proxy.service However, lintian reports: I unused-override no-manual-page usr/bin/monitor-sensor I unused-override no-manual-page usr/sbin/iio-sensor-proxy I unused-override systemd-service-file-missing-documentation-key lib/systemd/system/iio-sensor-proxy.service P renamed-tag binary-without-manpage => no-manual-page at line 2 P renamed-tag binary-without-manpage => no-manual-page at line 3 W no-manual-page usr/bin/monitor-sensor W no-manual-page usr/sbin/iio-sensor-proxy note that the unused-override line says "no-manual-page" rather than "binary-without-manpage". https://lintian.debian.org/sources/iio-sensor-proxy/3.0-1.html -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 5.7.0-1-amd64 (SMP w/2 CPU threads) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages lintian depends on: ii binutils2.35-2 ii bzip2 1.0.8-4 ii diffstat1.63-1 ii dpkg1.20.5 ii dpkg-dev1.20.5 ii file1:5.38-5 ii gettext 0.19.8.1-10 ii gpg 2.2.20-1 ii intltool-debian 0.35.0+20060710.5 ii libapt-pkg-perl 0.1.36+b3 ii libarchive-zip-perl 1.68-1 ii libcapture-tiny-perl0.48-1 ii libclass-xsaccessor-perl1.19-3+b5 ii libclone-perl 0.45-1 ii libconfig-tiny-perl 2.24-1 ii libcpanel-json-xs-perl 4.23-1 ii libdata-dpath-perl 0.58-1 ii libdata-validate-domain-perl0.10-1 ii libdevel-size-perl 0.83-1+b1 ii libdpkg-perl1.20.5 ii libemail-address-xs-perl1.04-1+b2 ii libfile-basedir-perl0.08-1 ii libfile-find-rule-perl 0.34-1 ii libfont-ttf-perl1.06-1 ii libhtml-html5-entities-perl 0.004-1 ii libipc-run3-perl0.048-2 ii libjson-maybexs-perl1.004002-1 ii liblist-compare-perl0.55-1 ii liblist-moreutils-perl 0.416-1+b5 ii liblist-utilsby-perl0.11-1 ii libmoo-perl 2.004000-1 ii libmoox-aliases-perl0.001006-1 ii libnamespace-clean-perl 0.27-1 ii libpath-tiny-perl 0.114-1 ii libperlio-gzip-perl 0.19-1+b6 ii libproc-processtable-perl 0.59-2 ii libsereal-decoder-perl 4.018+ds-1 ii libsereal-encoder-perl 4.018+ds-1 ii libtext-glob-perl 0.11-1 ii libtext-levenshteinxs-perl 0.03-4+b7 ii libtext-markdown-discount-perl 0.12-1 ii libtext-xslate-perl 3.5.8-1 ii libtime-duration-perl 1.21-1 ii libtime-moment-perl 0.44-1+b2 ii libtimedate-perl2.3300-1 ii libtry-tiny-perl0.30-1 ii libtype-tiny-perl 1.010005-1 ii libunicode-utf8-perl0.62-1+b1 ii liburi-perl 1.76-2 ii libxml-libxml-perl 2.0134+dfsg-2 ii libyaml-libyaml-perl0.82+repack-1 ii lzip1.21-8 ii lzop1.04-1 ii man-db 2.9.3-2 ii patchutils 0.4.2-1 ii perl [libdigest-sha-perl] 5.30.3-4 ii t1utils 1.41-4 ii unzip 6.0-25 ii xz-utils5.2.4-1+b1 lintian recommends no packages. Versions of packages lintian suggests: pn binutils-multiarch ii libtext-template-perl 1.59-1 -- no debconf information