Bug#970443: mira: FTBFS due to race condition during doc build

2020-09-16 Thread Sven Mueller
Ooops, sorry, forgot the attachment.

Am Mi., 16. Sept. 2020 um 14:58 Uhr schrieb Andreas Tille :

> Hi Sven,
>
> On Wed, Sep 16, 2020 at 02:49:54PM +0200, Sven Mueller wrote:
> > Package: mira
> > Version: 4.9.6-4
> > Tags: patch
>
> Thanks a lot for your investigation.  You promised some patch and you
> also tagged the bug that way.  But I did not found any actual patch
> attached to this bug report.  Did you possibly just forgot to attach it?
>
> Kind regards
>
>Andreas.
>
> --
> http://fam-tille.de
>
Index: mira-4.9.6/doc/docbook/Makefile.am
===
--- mira-4.9.6.orig/doc/docbook/Makefile.am
+++ mira-4.9.6/doc/docbook/Makefile.am
@@ -19,7 +19,7 @@ EXTRA_DIST = ${CHAP_XML} book_definitive
 clean-local:
 	rm -rf *html *pdf versionfile
 
-%_part.html: %_part.xml
+%_part.html: %_part.xml versionfile
 	@echo "Making .html out of _part.xml" $@
 	@$(SHELL) -ec 'xsltproc --nonet --xinclude --output $@  $(top_srcdir)/doc/docbook/mira.xsl $<'
 


Bug#970443: mira: FTBFS due to race condition during doc build

2020-09-16 Thread Andreas Tille
Hi Sven,

On Wed, Sep 16, 2020 at 02:49:54PM +0200, Sven Mueller wrote:
> Package: mira
> Version: 4.9.6-4
> Tags: patch

Thanks a lot for your investigation.  You promised some patch and you
also tagged the bug that way.  But I did not found any actual patch
attached to this bug report.  Did you possibly just forgot to attach it?

Kind regards

   Andreas.

-- 
http://fam-tille.de



Bug#970443: mira: FTBFS due to race condition during doc build

2020-09-16 Thread Sven Mueller
Package: mira
Version: 4.9.6-4
Tags: patch

When building concurrently, the doc/docbook/*_part.html files can fail to
generate. The reason is - as far as I can tell, that the %_part.html rule
in doc/docbook/Makefile.in doesn't list versionfile as a dependency, but
several of the _part.xml files actually depend on the file to be both
present and parsable. The error actually indicates the "could not load
versionfile" error - It is unclear though if it is not present or not
completely generated. But with "make -j 8", this is fails reproducibly (not
always, but very often). Changing Makefile.am as in the attached patch
seems to fix this.

Site note: Strictly speaking, most rules should also have a dependency on
the copyright file, as the output would change if the
copyrightfile changes. But since there is no rule to re-generate that file
and no generated files are shipped with the package, that seems minor.

Here is the snippet from the build log:

make[2]: Entering directory '/<>/doc'
Making all in docbook
make[3]: Entering directory '/<>/doc/docbook'
Making versionfile
Making .html out of _part.xml chap_bitsandpieces_part.html
Making .html out of _part.xml chap_mirautils_part.html
Making .html out of _part.xml chap_est_part.html
Making .html out of _part.xml chap_faq_part.html
Making .html out of _part.xml chap_hard_part.html
Making .html out of _part.xml chap_logfiles_part.html
Making .html out of _part.xml chap_maf_part.html
versionfile:3: parser error : Start tag expected, '<' not found

^
chap_bitsandpieces_part.xml:5: element include: XInclude error : could not
load versionfile, and no fallback was found
Making .html out of _part.xml chap_reference_part.html
versionfile:3: parser error : Start tag expected, '<' not found

^
chap_est_part.xml:5: element include: XInclude error : could not load
versionfile, and no fallback was found
make[3]: *** [Makefile:484: chap_bitsandpieces_part.html] Error 6
make[3]: *** Waiting for unfinished jobs
make[3]: *** [Makefile:484: chap_est_part.html] Error 6
make[3]: Leaving directory '/<>/doc/docbook'
make[2]: *** [Makefile:381: all-recursive] Error 1
make[2]: Leaving directory '/<>/doc'
dh_auto_build: error: cd doc && make -j8 "INSTALL=install
--strip-program=true" returned exit code 2
make[1]: *** [debian/rules:37: override_dh_auto_build-indep] Error 25
make[1]: Leaving directory '/<>'
make: *** [debian/rules:14: build] Error 2