Bug#971402: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

2020-10-03 Thread Vagrant Cascadian
On 2020-09-29, Vagrant Cascadian wrote:
> On 2020-09-29, Vagrant Cascadian wrote:
>> When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
>> clang does not support the -ffile-prefix-map argument:
>>
>>   clang: clang: error: error: unknown argument: 
>> '-ffile-prefix-map=/<>=.'unknown argument: 
>> '-ffile-prefix-map=/<>=.'
>
> This is actually supported in clang-10, and appears to build fine with
> clang-10.
>
> New patch attached which switches to clang-10.

And it has come to my attention that the default clang will likely end
up being clang 11 for bullseye, so maybe testing with clang-11 instead,
or waiting till the clang default is upgraded in bullseye.


live well,
  vagrant


signature.asc
Description: PGP signature


Bug#971402: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

2020-09-29 Thread Vagrant Cascadian
On 2020-09-29, Vagrant Cascadian wrote:
> When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
> clang does not support the -ffile-prefix-map argument:
>
>   clang: clang: error: error: unknown argument: 
> '-ffile-prefix-map=/<>=.'unknown argument: 
> '-ffile-prefix-map=/<>=.'

This is actually supported in clang-10, and appears to build fine with
clang-10.

New patch attached which switches to clang-10.

live well,
  vagrant
From f39dec30b7ac4c5356473a0ac0489b85974db22c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian 
Date: Wed, 30 Sep 2020 00:26:00 +
Subject: [PATCH 6/6] Switch to clang-10 to support -ffile-prefix-map (Closes:
 #971402).

---
 debian/control | 4 ++--
 debian/rules   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index ed101bf..3605c05 100644
--- a/debian/control
+++ b/debian/control
@@ -4,8 +4,8 @@ Priority: optional
 Maintainer: Sophie Brun 
 Uploaders: Raphaƫl Hertzog 
 Build-Depends: debhelper-compat (= 12),
-   clang-9,
-   libfuzzer-9-dev,
+   clang-10,
+   libfuzzer-10-dev,
liblzma-dev,
libssl-dev,
libyaml-dev,
diff --git a/debian/rules b/debian/rules
index 90bf280..277142b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,7 @@
 #!/usr/bin/make -f
 
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export CC = clang-9
+export CC = clang-10
 
 override_dh_auto_build:
 	dh_auto_build -- V=1
-- 
2.20.1



signature.asc
Description: PGP signature


Bug#971402: vboot-utils: FTBFS when fixfilepath is enabled from dpkg-buildflags

2020-09-29 Thread Vagrant Cascadian
Source: vboot-utils
Severity: normal
Version: 0~R81-12871.B-1
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: fixfilepath ftbfs
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

When the dpkg-buildflags "fixfilepath" is enabled, vboot-utils FTBFS, as
clang does not support the -ffile-prefix-map argument:

  clang: clang: error: error: unknown argument: 
'-ffile-prefix-map=/<>=.'unknown argument: 
'-ffile-prefix-map=/<>=.'


This can be tested by passing the following DEB_BUILD_OPTIONS:

  DEB_BUILD_OPTIONS=reproducible=+fixfilepath

The "fixfilepath" is not currently enabled by dpkg-buildflags by
default, but might become the default at some point in the future.

The attached patch disables use of this feature in debian/rules and
enables the remaining reproducibility related build flags.


Thanks for maintaining vboot-utils!

live well,
  vagrant
From ec585212c265af22d69249459dcd05dbbc17b78f Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian 
Date: Tue, 29 Sep 2020 21:40:28 +
Subject: [PATCH 2/2] debian/rules: Disable use of fixfilepath with
 DEB_BUILD_MAINT_OPTIONS.

clang does not currently support it, and the build fails with:

  clang: clang: error: error: unknown argument: '-ffile-prefix-map=/<>=.'unknown argument: '-ffile-prefix-map=/<>=.'

Enable other reproducible related build flags (fixdebugpath,
timeless), as these still work and are the current defaults for
dpkg-buildflags.
---
 debian/rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index 90bf280..a2c916e 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,6 @@
 #!/usr/bin/make -f
 
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all reproducible=-fixfilepath,+fixdebugpath,+timeless
 export CC = clang-9
 
 override_dh_auto_build:
-- 
2.28.0



signature.asc
Description: PGP signature