Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Mon, 25 Jan 2021 09:35:30 +0100, Dominique Dumont wrote: > On Sunday, 24 January 2021 15:47:29 CET you wrote: > > Right, I had the feeling that this regexp is a bit broad; thanks for > > the suggestion, committed. > I'm fine with these changes. Feel free to release a new version on libconfig- > model-dpkg-perl. Great, uploaded. > Thanks for the fix Thanks for your guidance. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Arlo Guthrie: Alice's Restaurant signature.asc Description: Digital Signature
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Sunday, 24 January 2021 15:47:29 CET you wrote: > Right, I had the feeling that this regexp is a bit broad; thanks for > the suggestion, committed. I'm fine with these changes. Feel free to release a new version on libconfig- model-dpkg-perl. Thanks for the fix
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Tue, 19 Jan 2021 10:11:42 +0100, Dominique Dumont wrote: > On Sunday, 17 January 2021 19:57:39 CET you wrote: > > I just pushed the changes as proposed, looking forward to > > reviews/feedback. > Thanks for the patch (with test and doc ! :-) ) Thanks for the review! > There's no issue, but 2 comments for the new _is_virtual function: > > - in cme dpkg, I tend to use function signatures for new function instead of > Perl'd old way of passing parameters. I know that I should convert all > functions to signatures, but I've not taken the time to do it... Ah, good idea. Changed. > - the regexp /^dh-sequence-.+/ also matches dh-sequence-!@#. Given the list > of > dh-sequence-* package names removed from the code, I'd suggest a more > restrictive regexp like /^dh-sequence-[a-z0-9-]+$/ Right, I had the feeling that this regexp is a bit broad; thanks for the suggestion, committed. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Various Artists: Sweet Sixteen signature.asc Description: Digital Signature
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Sunday, 17 January 2021 19:57:39 CET you wrote: > I just pushed the changes as proposed, looking forward to > reviews/feedback. Thanks for the patch (with test and doc ! :-) ) There's no issue, but 2 comments for the new _is_virtual function: - in cme dpkg, I tend to use function signatures for new function instead of Perl'd old way of passing parameters. I know that I should convert all functions to signatures, but I've not taken the time to do it... - the regexp /^dh-sequence-.+/ also matches dh-sequence-!@#. Given the list of dh-sequence-* package names removed from the code, I'd suggest a more restrictive regexp like /^dh-sequence-[a-z0-9-]+$/ All the best
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Sun, 11 Oct 2020 16:59:09 +0200, Dominique Dumont wrote:
> On mercredi 7 octobre 2020 16:49:30 CEST you wrote:
> > Maybe adding a regexp to
> >
> > if ( @res == 0 and not $virtual_hash{$pkg}) {
> >
> > would be enough? Like (untested pseudo-code)
> >
> > … and $pkg =! /^dh-sequence-.+/
>
> That's a good start.
>
> But %virtual_hash is used in 2 other places.
>
> I'd suggest:
> - create a method _is_virtual that uses %virtual_hash and the regexp you
> suggested
> - use this method instead of directly reading $virtual_hash($pkg_name)
>
> gregoa, do you want to try fixing this bug ?
After a slight delay *cough*:
Yes, I want to try :)
I just pushed the changes as proposed, looking forward to
reviews/feedback.
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Leonard Cohen: Show Me The Place
signature.asc
Description: Digital Signature
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On mercredi 7 octobre 2020 16:49:30 CEST you wrote:
> Maybe adding a regexp to
>
> if ( @res == 0 and not $virtual_hash{$pkg}) {
>
> would be enough? Like (untested pseudo-code)
>
> … and $pkg =! /^dh-sequence-.+/
That's a good start.
But %virtual_hash is used in 2 other places.
I'd suggest:
- create a method _is_virtual that uses %virtual_hash and the regexp you
suggested
- use this method instead of directly reading $virtual_hash($pkg_name)
gregoa, do you want to try fixing this bug ?
All the best
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
Le 07/10/2020 à 16:53, Xavier a écrit :
> Le 07/10/2020 à 16:49, gregor herrmann a écrit :
>> On Wed, 07 Oct 2020 10:32:42 +0200, Xavier Guimard wrote:
>>
>>> Since all dh-sequence-* build dependencies are virtual packages, cme
>>> should ignore related warnings.
>>
>> Right, the handling of dh-sequence-* could be improved.
>>
>> Currently it's an array of static entries in
>> lib/Config/Model/Dpkg/Dependency.pm
>> (@virtual_list) which is then converted into a hash which is then
>> checked to exclude warnings. Maybe adding a regexp to
>>
>> if ( @res == 0 and not $virtual_hash{$pkg}) {
>>
>> would be enough? Like (untested pseudo-code)
>>
>> … and $pkg =! /^dh-sequence-.+/
>
> Yes, sounds enough
>
>> (and removing the list of dh-sequence-* packages from @virtual_list)
>
> easy: no dh-sequence-* for now in this file ;-)
oups, I was not looking at the good branch...
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
Le 07/10/2020 à 16:49, gregor herrmann a écrit :
> On Wed, 07 Oct 2020 10:32:42 +0200, Xavier Guimard wrote:
>
>> Since all dh-sequence-* build dependencies are virtual packages, cme
>> should ignore related warnings.
>
> Right, the handling of dh-sequence-* could be improved.
>
> Currently it's an array of static entries in
> lib/Config/Model/Dpkg/Dependency.pm
> (@virtual_list) which is then converted into a hash which is then
> checked to exclude warnings. Maybe adding a regexp to
>
> if ( @res == 0 and not $virtual_hash{$pkg}) {
>
> would be enough? Like (untested pseudo-code)
>
> … and $pkg =! /^dh-sequence-.+/
Yes, sounds enough
> (and removing the list of dh-sequence-* packages from @virtual_list)
easy: no dh-sequence-* for now in this file ;-)
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
On Wed, 07 Oct 2020 10:32:42 +0200, Xavier Guimard wrote:
> Since all dh-sequence-* build dependencies are virtual packages, cme
> should ignore related warnings.
Right, the handling of dh-sequence-* could be improved.
Currently it's an array of static entries in lib/Config/Model/Dpkg/Dependency.pm
(@virtual_list) which is then converted into a hash which is then
checked to exclude warnings. Maybe adding a regexp to
if ( @res == 0 and not $virtual_hash{$pkg}) {
would be enough? Like (untested pseudo-code)
… and $pkg =! /^dh-sequence-.+/
(and removing the list of dh-sequence-* packages from @virtual_list)
Cheers,
gregor
--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Bettina Wegner: die rose
signature.asc
Description: Digital Signature
Bug#971784: libconfig-model-dpkg-perl: cme should not warn on "unknown dh-sequence-nodejs package"
Package: libconfig-model-dpkg-perl Version: 2.139 Severity: minor Hi, Since all dh-sequence-* build dependencies are virtual packages, cme should ignore related warnings. Cheers, Xavier
