Package: kookbook
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: fixfilepath ftbfs
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

When the reproducible=+fixfilepath feature is enabled (either through
DEB_BUILD_OPTIONS, or using a dpkg that enables this by default),
kookbook fails to build from source:

  
http://qa-logs.debian.net/2020/09/26.fixfilepath/kookbook_0.2.1-1_unstable_fixfilepath.log


While the "fixfilepath" feature is not currently enabled by
dpkg-buildflags by default, it may become the default at some point in
the future, and can be triggered manually by setting
DEB_BUILD_OPTIONS=reproducible=+fixfilepath in the build environment. It
is also used in the tests.reproducible-builds.org infrastructure when
testing unstable and experimental.

More information about this issue is available at:

  
https://tests.reproducible-builds.org/debian/issues/unstable/ftbfs_due_to_f-file-prefix-map_issue.html


I have not identified the exact cause of this issue, but a common
trigger is test suites expecting __FILE__ to resolve to an absolute
path.

The attached patch works around this issue by disabling the fixfilepath
feature in debian/rules using DEB_BUILD_MAINT_OPTIONS=-fixfilepath.


Thanks for maintaining kookbook!


live well,
  vagrant

From 91638d097b1f535450a283647f3ca42618d3ee95 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Fri, 16 Oct 2020 00:11:55 +0000
Subject: [PATCH] debian/rules: Disable fixfilepath feature, as it triggers
 build failures when enabled.

https://tests.reproducible-builds.org/debian/issues/unstable/ftbfs_due_to_f-file-prefix-map_issue.html
---
 debian/rules | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/rules b/debian/rules
index e31c6bd..747b7d3 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,8 @@
 #!/usr/bin/make -f
 
 # Enable additional hardening options.
-export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+# Disable fixfilepath as it triggers build failures.
+export DEB_BUILD_MAINT_OPTIONS = hardening=+all reproducible=-fixfilepath
 export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
 %:
-- 
2.28.0

Attachment: signature.asc
Description: PGP signature

Reply via email to