Bug#972556: ffmpeg: Fails to build from source with newer src:srt
On 10/25/20 3:04 PM, Sebastian Ramacher wrote: > I'd be more comfortable with the patch if it was at least merged on > upstream's master branch. Upstream isn't responding which would mean the package will remain unfixed in Debian for the next months and I will have to keep pinging both you and upstream which would be rather annoying. The guaeded code itself is built on powerpc and ppc64 only so there is no risk in breaking any other architecture. Currently, ffmpeg does not build on powerpc and ppc64 at all which means I will have to build the package locally with the patch applied everytime a new version or Debian revision of the ffmpeg package gets uploaded which I would rather like to avoid. Adrian > [1] https://lists.debian.org/debian-sparc/2017/12/msg00060.html -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
On 2020-10-20 12:08:01, John Paul Adrian Glaubitz wrote: > On 10/20/20 12:05 PM, Sebastian Ramacher wrote: > >> So, this patch and the patch from #968574 would be great! > > > > Has the patch from #968574 been merged upstream in the meantime? > > Apparently not. But merging won't break anything due to the #ifdef guards and > unbreaks ffmpeg > on powerpc and ppc64 which is important due to the way Debian Ports works > with no support > for cruft [1]. I'd be more comfortable with the patch if it was at least merged on upstream's master branch. Cheers > > Adrian > > > [1] https://lists.debian.org/debian-sparc/2017/12/msg00060.html > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaub...@debian.org > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
Control: severity -1 wishlist Control: retitle -1 ffmpeg: re-enable support for libsrt On 2020-10-20 12:05:10 +0200, Sebastian Ramacher wrote: > Control: block -1 by 971754 > > On 2020-10-20 11:42:47, John Paul Adrian Glaubitz wrote: > > Control: tags -1 +patch > > > > Hello! > > > > This FTBFS is fixed by the following upstream patch [1]: > > > > From: Jun Zhao > > Date: Sun, 12 Jul 2020 05:48:48 + (+0800) > > Subject: lavf/srt: fix build fail when used the libsrt 1.4.1 > > X-Git-Url: > > http://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff_plain/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 > > > > lavf/srt: fix build fail when used the libsrt 1.4.1 > > > > libsrt changed the: > > SRTO_SMOOTHER -> SRTO_CONGESTION > > SRTO_STRICTENC -> SRTO_ENFORCEDENCRYPTION > > and removed the front of deprecated options (SRTO_SMOOTHER/SRTO_STRICTENC) > > in the header, it's lead to build fail > > > > fix #8760 > > > > Signed-off-by: Jun Zhao > > FWIW, srt broke its ABI (see the blocking bug). Unless this situation is > sorted out soon, we'd have a ffmpeg that is stuck in unstable. So I'd > consider dropping srt support until the srt situation has been fixed. I have now temporarily disabled support for libsrt. Once libsrt gets unbroken, it can be renabled again. Cheers > > > So, this patch and the patch from #968574 would be great! > > Has the patch from #968574 been merged upstream in the meantime? > > Cheers > > > > > Thanks, > > Adrian > > > > > [1] > > > https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 > > > > -- > > .''`. John Paul Adrian Glaubitz > > : :' : Debian Developer - glaub...@debian.org > > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > > `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > > > > -- > Sebastian Ramacher > -- Sebastian Ramacher signature.asc Description: PGP signature
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
On 10/20/20 12:05 PM, Sebastian Ramacher wrote: >> So, this patch and the patch from #968574 would be great! > > Has the patch from #968574 been merged upstream in the meantime? Apparently not. But merging won't break anything due to the #ifdef guards and unbreaks ffmpeg on powerpc and ppc64 which is important due to the way Debian Ports works with no support for cruft [1]. Adrian > [1] https://lists.debian.org/debian-sparc/2017/12/msg00060.html -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
Control: block -1 by 971754 On 2020-10-20 11:42:47, John Paul Adrian Glaubitz wrote: > Control: tags -1 +patch > > Hello! > > This FTBFS is fixed by the following upstream patch [1]: > > From: Jun Zhao > Date: Sun, 12 Jul 2020 05:48:48 + (+0800) > Subject: lavf/srt: fix build fail when used the libsrt 1.4.1 > X-Git-Url: > http://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff_plain/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 > > lavf/srt: fix build fail when used the libsrt 1.4.1 > > libsrt changed the: > SRTO_SMOOTHER -> SRTO_CONGESTION > SRTO_STRICTENC -> SRTO_ENFORCEDENCRYPTION > and removed the front of deprecated options (SRTO_SMOOTHER/SRTO_STRICTENC) > in the header, it's lead to build fail > > fix #8760 > > Signed-off-by: Jun Zhao FWIW, srt broke its ABI (see the blocking bug). Unless this situation is sorted out soon, we'd have a ffmpeg that is stuck in unstable. So I'd consider dropping srt support until the srt situation has been fixed. > So, this patch and the patch from #968574 would be great! Has the patch from #968574 been merged upstream in the meantime? Cheers > > Thanks, > Adrian > > > [1] > > https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaub...@debian.org > `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de > `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > -- Sebastian Ramacher
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
Control: tags -1 +patch Hello! This FTBFS is fixed by the following upstream patch [1]: From: Jun Zhao Date: Sun, 12 Jul 2020 05:48:48 + (+0800) Subject: lavf/srt: fix build fail when used the libsrt 1.4.1 X-Git-Url: http://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff_plain/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 lavf/srt: fix build fail when used the libsrt 1.4.1 libsrt changed the: SRTO_SMOOTHER -> SRTO_CONGESTION SRTO_STRICTENC -> SRTO_ENFORCEDENCRYPTION and removed the front of deprecated options (SRTO_SMOOTHER/SRTO_STRICTENC) in the header, it's lead to build fail fix #8760 Signed-off-by: Jun Zhao So, this patch and the patch from #968574 would be great! Thanks, Adrian > [1] > https://git.ffmpeg.org/gitweb/ffmpeg.git/commitdiff/7c59e1b0f285cd7c7b35fcd71f49c5fd52cf9315 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `-GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Bug#972556: ffmpeg: Fails to build from source with newer src:srt
Source: ffmpeg Version: 7:4.3.1-4 Severity: serious Justification: FTBFS Hi! ffmpeg recently started to FTBFS, most likely due to the update to src:srt: gcc -I. -Isrc/ -Wdate-time -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avformat -g -O2 -fdebug-prefix-map=/home/glaubitz/ffmpeg/ffmpeg-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -fno-strict-overflow -fstack-protector-all -fPIE -std=c11 -fomit-frame-pointer -fPIC -maltivec -mabi=altivec -mvsx -pthread -I/usr/include/p11-kit-1 -I/usr/include/lilv-0 -I/usr/include/sratom-0 -I/usr/include/sord-0 -I/usr/include/serd-0 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/uuid -I/usr/include/fribidi -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/bs2b-I/usr/include/libdrm -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/openjpeg-2.3 -I/usr/include/opus -I/usr/include/opus -D_REENTRANT -pthread -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/srt -I/usr/include/p11-kit-1 -DX264_API_IMPORTS -isystem /usr/include/mit-krb5 -I/usr/include/pgm-5.3 -I/usr/include/libxml2 -I/usr/include/sphinxbase -I/usr/include/pocketsphinx -I/usr/include/powerpc64le-linux-gnu -I/usr/include/powerpc64le-linux-gnu/sphinxbase -g -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable -Wno-bool-operation -Wno-char-subscripts -O3 -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -Werror=format-security -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type -Werror=vla -Wformat -fdiagnostics-color=auto -Wno-maybe-uninitialized -D_REENTRANT -I/usr/include/SDL2 -MMD -MF libavformat/lrcenc.d -MT libavformat/lrcenc.o -c -o libavformat/lrcenc.o src/libavformat/lrcenc.c gcc -I. -Isrc/ -Wdate-time -D_FORTIFY_SOURCE=2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -DZLIB_CONST -DHAVE_AV_CONFIG_H -DBUILDING_avformat -g -O2 -fdebug-prefix-map=/home/glaubitz/ffmpeg/ffmpeg-4.3.1=. -fstack-protector-strong -Wformat -Werror=format-security -fno-strict-overflow -fstack-protector-all -fPIE -std=c11 -fomit-frame-pointer -fPIC -maltivec -mabi=altivec -mvsx -pthread -I/usr/include/p11-kit-1 -I/usr/include/lilv-0 -I/usr/include/sratom-0 -I/usr/include/sord-0 -I/usr/include/serd-0 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/uuid -I/usr/include/fribidi -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/bs2b-I/usr/include/libdrm -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/fribidi -I/usr/include/openjpeg-2.3 -I/usr/include/opus -I/usr/include/opus -D_REENTRANT -pthread -I/usr/include/librsvg-2.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/powerpc64le-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/srt -I/usr/include/p11-kit-1 -DX264_API_IMPORTS -isystem /usr/include/mit-krb5 -I/usr/include/pgm-5.3 -I/usr/include/libxml2 -I/usr/include/sphinxbase -I/usr/include/pocketsphinx -I/usr/include/powerpc64le-linux-gnu -I/usr/include/powerpc64le-linux-gnu/sphinxbase -g -Wdeclaration-after-statement -Wall -Wdisabled-optimization -Wpointer-arith -Wredundant-decls -Wwrite-strings -Wtype-limits -Wundef -Wmissing-prototypes -Wno-pointer-to-int-cast -Wstrict-prototypes -Wempty-body -Wno-parentheses -Wno-switch -Wno-format-zero-length -Wno-pointer-sign -Wno-unused-const-variable -Wno-bool-operation -Wno-char-subscripts -O3 -fno-math-errno -fno-signed-zeros -fno-tree-vectorize -Werror=format-security -Werror=implicit-function-declaration -Werror=missing-prototypes
