Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
Tobias Frost left as an exercise for the reader: > Said that, personally I'd ignoring file-references-package-build-path > for now, as there will possibly a general fix in the tools soon, > removing the need of code in someone's own d/rules. > (see <87mu07tyk3.fsf@yucca> on debian-devel) I shall do exactly that, then, unless I take a hard look at getting reproducible builds working sometime soon. Thanks! -- nick black -=- https://www.nick-black.com to make an apple pie from scratch, you need first invent a universe.
Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
On Sun, Nov 01, 2020 at 01:32:30AM -0500, Nick Black wrote:
> Tobias Frost left as an exercise for the reader:
> > (Note I'm not planning to sponsor this package. I'm not a python packager,
> > so I
> > can't judge on the python part.
>
> I've uploaded 2.0.2+dfsg.1-2, which includes all fixes I
> described in my initial reply, while also eliminating the
> "python-module-in-wrong-location" lintian warning.
>
> In addition, I have removed the "groff-message" lintian
> overrides which were giving rise to the "unused-override"
> messages.
>
> I notice that since moving to "usr/lib/${DEB_HOST_MULTIARCH}/"
> in my .install files, as you recommended, I now generate
> "file-references-package-build-path" for both
> usr/lib/x86_64-linux-gnu/libnotcurses.so.2.0.2 and
> usr/lib/x86_64-linux-gnu/libnotcurses.a. I'm looking into this.
I'd be suprised if that change would cause this, as dh_install is
run far after build.
Said that, personally I'd ignoring file-references-package-build-path
for now, as there will possibly a general fix in the tools soon,
removing the need of code in someone's own d/rules.
(see <87mu07tyk3.fsf@yucca> on debian-devel)
> If anyone would be willing to pick this up, I believe it to now
> be in much better shape. Thanks for the assistance, Tobias!
>
> --
> nick black -=- https://www.nick-black.com
> to make an apple pie from scratch,
> you need first invent a universe.
Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
Tobias Frost left as an exercise for the reader:
> (Note I'm not planning to sponsor this package. I'm not a python packager, so
> I
> can't judge on the python part.
I've uploaded 2.0.2+dfsg.1-2, which includes all fixes I
described in my initial reply, while also eliminating the
"python-module-in-wrong-location" lintian warning.
In addition, I have removed the "groff-message" lintian
overrides which were giving rise to the "unused-override"
messages.
I notice that since moving to "usr/lib/${DEB_HOST_MULTIARCH}/"
in my .install files, as you recommended, I now generate
"file-references-package-build-path" for both
usr/lib/x86_64-linux-gnu/libnotcurses.so.2.0.2 and
usr/lib/x86_64-linux-gnu/libnotcurses.a. I'm looking into this.
If anyone would be willing to pick this up, I believe it to now
be in much better shape. Thanks for the assistance, Tobias!
--
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.
Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
Tobias Frost left as an exercise for the reader:
--
thanks for the feedback, Tobias. responses inline.
> - d/changelog
> The changelog entries for 1.7.6+dfsg.1-2 is different that the one in
> currently in the archives.
> Please make sure that your packaging repository is in sync with the archives
> and matches it bit per bit.
> See below for a (shortened) diff. [0]
synced, thanks
> - d/control
> There are many versioned B-Ds. Please check if the version constraints can be
> dropped
> (they can if oldstable has the version already) [nitpick]
alas, the only one that seemed able to be removed/relaxed was
indeed cmake, from 3.16 to 3.14. i checked the others, and most
have older versions in oldstable. it is of course possible that
notcurses builds/runs properly with these older versions, but i
have no assurance of that.
> S-V is only 3 digits, the 4th digit is not recorded, as it only denotes
> editorial changes. [nitpick]
Policy Version 4.5.0.3 section 5.6.11:
"either these three components or all four components may be specified."
I have truncated it in the spirit of good comradely fellowship.
> - the lintian overrides for "groff-message" are causing:
> I: notcurses-bin: unused-override groff-message
Yep. See the comment immediately above it and
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/182
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=973313
It's a question of having mentors complain to me, or
salsa+lintian complain to me.
> - *.install: instead of usr/lib/*/, with compat 13, you should write
> usr/lib/${DEB_HOST_MULTIARCH}/
done, thanks.
> - d/copyright, Files-Excluded
> Yes, you can have multiline Files-Excluded, so you can wrap the wrong line.
> (example at [1])
You link to tracker.debian.org. I cannot now (and do not recall
ever being able to) resolve this name.
[schwarzgerat](0) $ dig +short tracker.debian.org
;; connection timed out; no servers could be reached
[schwarzgerat](9) $
> - *.install [bikeshed]
> Not sure if TERMS.md, OTHERS.md and CONTRIBUTIONS.md should be installed
> into the library
> package, as the information within is not really applicable for users of
> the library.
> Does TERMS.md has a relation to notcurses or is it general information? If
> it relates,
> maybe the -dev packge or a (see below) -doc package?
> OTHERS.md, if installed, should go to the -dev package (but I think it is
> not useful,
> as it just lists alternatives.)
> The best place for CONTRIBUTIONS.md is the source package. I wouldn't
> install it in
> binary packages.
Rather than bikeshed which package these <4k files ought go in,
I've just removed them. README.md is still installed in
libnotcurses2. Thanks.
> - As you seem to have doxygen support, maybe generate html docs and have a
> dedicated
> libnotcursed-doc package? [bikeshed]
I don't think the doxygen output is useful enough to package,
and certainly don't want to possibly trigger further round-trips
for this content. Thanks though!
> I hope this review helps a bit. Thanks for your contributions to Debian!
Indeed, appreciated.
--
nick black -=- https://www.nick-black.com
to make an apple pie from scratch,
you need first invent a universe.
signature.asc
Description: PGP signature
Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
Control: tags -1 moreinfo
On Fri, Oct 30, 2020 at 06:08:14AM -0400, Nick Black wrote:
> * Package name: notcurses
>Version : 2.0.2+dfsg.1-1
Hi Nick,
(Note I'm not planning to sponsor this package. I'm not a python packager, so I
can't judge on the python part.
[nitpicks] and [bikesheds] are marked…
Note that the review is not complete, especially I did not do a copyright
review.
- d/changelog
The changelog entries for 1.7.6+dfsg.1-2 is different that the one in currently
in the archives.
Please make sure that your packaging repository is in sync with the archives
and matches it bit per bit.
See below for a (shortened) diff. [0]
- d/control
There are many versioned B-Ds. Please check if the version constraints can be
dropped
(they can if oldstable has the version already) [nitpick]
It seems also that your CMakelists actually is only requiring cmake 3.14 -- is
the B-D version (> 3.16) is too strict [nitpick]
S-V is only 3 digits, the 4th digit is not recorded, as it only denotes
editorial changes. [nitpick]
- the lintian overrides for "groff-message" are causing:
I: notcurses-bin: unused-override groff-message
- *.install: instead of usr/lib/*/, with compat 13, you should write
usr/lib/${DEB_HOST_MULTIARCH}/
- d/copyright, Files-Excluded
Yes, you can have multiline Files-Excluded, so you can wrap the wrong line.
(example at [1])
- *.install [bikeshed]
Not sure if TERMS.md, OTHERS.md and CONTRIBUTIONS.md should be installed into
the library
package, as the information within is not really applicable for users of the
library.
Does TERMS.md has a relation to notcurses or is it general information? If it
relates,
maybe the -dev packge or a (see below) -doc package?
OTHERS.md, if installed, should go to the -dev package (but I think it is not
useful,
as it just lists alternatives.)
The best place for CONTRIBUTIONS.md is the source package. I wouldn't install
it in
binary packages.
- As you seem to have doxygen support, maybe generate html docs and have a
dedicated
libnotcursed-doc package? [bikeshed]
I hope this review helps a bit. Thanks for your contributions to Debian!
--
tobi
[0]
---
/home/tobi/workspace/deb/mentors/NickBlack/notcurses/archive/notcurses-1.7.6+dfsg.1/debian/changelog
+++
/home/tobi/workspace/deb/mentors/NickBlack/notcurses/new/notcurses-2.0.2+dfsg.1/debian/changelog
@@ -1,9 +1,25 @@
(diff shortened)
notcurses (1.7.6+dfsg.1-2) unstable; urgency=medium
- [ Nick Black ]
- * Build in pbuilder to avoid picking up libav-extra, argh
-
- -- Nick Black Tue, 13 Oct 2020 18:41:52 -0400
+ * Actually update symbols for 1.7.6, ugh.
+
+ -- Nick Black Fri, 09 Oct 2020 22:04:50 -0400
notcurses (1.7.6+dfsg.1-1) unstable; urgency=medium
[1]
https://tracker.debian.org/media/packages/d/dhewm3/copyright-1.5.1pregit20200905dfsg-1
signature.asc
Description: PGP signature
Bug#973410: RFS: notcurses/2.0.2+dfsg.1-1 -- Character graphics and TUI library
Package: sponsorship-requests Severity: normal Dear mentors, I am looking for a sponsor for my package "notcurses", which has recently undergone an ABI/soname change, and thus needs be run back through the NEW queue (notcurses has been in the archive for several months). I have built and uploaded it for experimental: * Package name: notcurses Version : 2.0.2+dfsg.1-1 Upstream Author : Nick Black * URL : https://nick-black.com/dankwiki/index.php/Notcurses * License : Apache-2.0 * Vcs : https://salsa.debian.org/debian/notcurses Section : libs It builds those binary packages: python3-notcurses - Character graphics and TUI library (Python) notcurses-data - Multimedia used by notcurses-bin notcurses-bin - Character graphics and TUI library demos libnotcurses2 - Character graphics and TUI library libnotcurses-dev - Character graphics and TUI library (development) libnotcurses++2 - Character graphics and TUI library (C++ wrappers) libnotcurses++-dev - Character graphics and TUI library (C++ development) (and also several debug packages) To access further information about this package, please visit the following URL: https://mentors.debian.net/package/notcurses/ Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/n/notcurses/notcurses_2.0.2+dfsg.1-1.dsc Changes since the last upload: notcurses (2.0.2+dfsg.1-1) experimental; urgency=medium . * New upstream version: * The Notcurses API is now considered stable. Backwards compatibility will be maintained henceforth. * Upload to experimental to begin ABI transition * soname bump 1->2 * Adds ncvisual_render_loop() * Quadblitter perf+transparency improvements * Adds ncmenu_item_set_status() * Relax ncurses-term to Recommends: from Depends: * Add package-does-not-install-examples lintian override * Add groff-message lintian override for now (see https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/182) Regards, -- Nick Black -- nick black -=- https://www.nick-black.com to make an apple pie from scratch, you need first invent a universe. signature.asc Description: PGP signature
