Bug#977198: cups service should start after nslcd service

2020-12-18 Thread Wolfgang Schweer
[ Didier 'OdyX' Raboud, 2020-12-18 ]
> Ah nice.  Note that there's a typo (networ.service), and that an 
> override doesn't need to copy all the lines from the original file.

corrected now, see:
https://salsa.debian.org/debian-edu/debian-edu-config/-/commit/506ad6088ae36e68611c9893557be3d3db814169

Merci bien,

Wolfgang


signature.asc
Description: PGP signature


Bug#977198: cups service should start after nslcd service

2020-12-18 Thread Didier 'OdyX' Raboud
Ah nice.  Note that there's a typo (networ.service), and that an override 
doesn't need to copy all the lines from the original file.

Le December 18, 2020 3:29:52 PM UTC, Wolfgang Schweer  a 
écrit :
>Hi Didier,
>
>[ Didier 'OdyX' Raboud, 2020-12-18 ]
>> Therefore, instead of patching CUPS for each-and-every user
>authentication/
>> provisioning service, could Debian Edu provide a systemd override
>file 
>> instead?
>
>Yes, that has already been done, see:
>https://salsa.debian.org/debian-edu/debian-edu-config/-/commit/665390a69a5e641a83da7225e6b5f62617320ce9
> 
>> I have pushed this patch proposal to the (new) upstream:
>> 
>> https://github.com/OpenPrinting/cups/pull/69
>> 
>> Of course, if upstream accepts this, I'll backport and upload to
>Debian.
>
>Thanks a lot for caring,
>
>Wolfgang


Bug#977198: cups service should start after nslcd service

2020-12-18 Thread Wolfgang Schweer
Hi Didier,

[ Didier 'OdyX' Raboud, 2020-12-18 ]
> Therefore, instead of patching CUPS for each-and-every user authentication/
> provisioning service, could Debian Edu provide a systemd override file 
> instead?

Yes, that has already been done, see:
https://salsa.debian.org/debian-edu/debian-edu-config/-/commit/665390a69a5e641a83da7225e6b5f62617320ce9
 
> I have pushed this patch proposal to the (new) upstream:
> 
> https://github.com/OpenPrinting/cups/pull/69
> 
> Of course, if upstream accepts this, I'll backport and upload to Debian.

Thanks a lot for caring,

Wolfgang


signature.asc
Description: PGP signature


Bug#977198: cups service should start after nslcd service

2020-12-18 Thread Didier 'OdyX' Raboud
Control: forwarded -1 https://github.com/OpenPrinting/cups/pull/69
Control: tags -1 +patch

Le samedi, 12 décembre 2020, 13.38:52 h CET Wolfgang Schweer a écrit :
> while working on Debian Edu 11 Bullseye, I noticed the cups service
> failing randomly after rebooting the system (…):
> 
> Debian Edu uses an LDAP group printer-admins in cups-files.conf like so:
> 
> SystemGroup lpadmin printer-admins
> 
> Please note that Debian Edu uses nslcd.

Therefore, instead of patching CUPS for each-and-every user authentication/
provisioning service, could Debian Edu provide a systemd override file 
instead?

Something like /etc/systemd/system/cups.service.d/debian-edu-nslcd.conf

[Unit]
Description=CUPS Scheduler service dependencies update for Debian Edu
After=nslcd.service

> After adding the nslcd.service (in addition to sssd.service and
> ypbind.service) to the cups.service unit file, things work like
> expected, this is the proposed change:
> 
> diff --git a/scheduler/cups.service.in b/scheduler/cups.service.in
> index 9e70b2973..a3fa0e83f 100644
> --- a/scheduler/cups.service.in
> +++ b/scheduler/cups.service.in
> @@ -1,7 +1,7 @@
>  [Unit]
>  Description=CUPS Scheduler
>  Documentation=man:cupsd(8)
> -After=network.target sssd.service ypbind.service
> +After=network.target sssd.service ypbind.service nslcd.service
>  Requires=cups.socket
> 
>  [Service]
> 
> Please check if the change could be accepted.

I have pushed this patch proposal to the (new) upstream:

https://github.com/OpenPrinting/cups/pull/69

Of course, if upstream accepts this, I'll backport and upload to Debian.

Best regards,
OdyX

signature.asc
Description: This is a digitally signed message part.


Bug#977198: cups service should start after nslcd service

2020-12-12 Thread Wolfgang Schweer
Package: cups
Version: 2.3.3op1-3
Severity: normal
Tags: patch
User: debian-...@lists.debian.org
Usertags: debian-edu

Dear Maintainer,

while working on Debian Edu 11 Bullseye, I noticed the cups service 
failing randomly after rebooting the system:

● cups.service - CUPS Scheduler
 Loaded: loaded (/lib/systemd/system/cups.service; enabled; vendor preset: 
enabled)
 Active: failed (Result: exit-code) since Sat 2020-12-12 10:25:50 CET; 3min 
46s ago
TriggeredBy: ● cups.path
 ● cups.socket
   Docs: man:cupsd(8)
Process: 1201 ExecStart=/usr/sbin/cupsd -l (code=exited, status=1/FAILURE)
   Main PID: 1201 (code=exited, status=1/FAILURE)

Dez 12 10:25:50 tjener.intern systemd[1]: Failed to start CUPS Scheduler.
Dez 12 10:25:50 tjener.intern systemd[1]: cups.service: Scheduled restart job, 
restart counter is at 5.
Dez 12 10:25:50 tjener.intern systemd[1]: Stopped CUPS Scheduler.
Dez 12 10:25:50 tjener.intern systemd[1]: cups.service: Start request repeated 
too quickly.
Dez 12 10:25:50 tjener.intern systemd[1]: cups.service: Failed with result 
'exit-code'.
Dez 12 10:25:50 tjener.intern systemd[1]: Failed to start CUPS Scheduler.

Debian Edu uses an LDAP group printer-admins in cups-files.conf like so:

SystemGroup lpadmin printer-admins

Please note that Debian Edu uses nslcd.

After adding the nslcd.service (in addition to sssd.service and 
ypbind.service) to the cups.service unit file, things work like 
expected, this is the proposed change:

diff --git a/scheduler/cups.service.in b/scheduler/cups.service.in
index 9e70b2973..a3fa0e83f 100644
--- a/scheduler/cups.service.in
+++ b/scheduler/cups.service.in
@@ -1,7 +1,7 @@
 [Unit]
 Description=CUPS Scheduler
 Documentation=man:cupsd(8)
-After=network.target sssd.service ypbind.service
+After=network.target sssd.service ypbind.service nslcd.service
 Requires=cups.socket
 
 [Service]

Please check if the change could be accepted.

Wolfgang


signature.asc
Description: PGP signature