Bug#918755: Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-28 Thread Rick Thomas
As I said, simply adding --no-guess-python to ORPHANOPTS does take care of the 
immediate problem of wanting to delete deluge, but in exchange, it opens up a 
potential can of worms when there is a python package that is indeed an orphan, 
which would then not be deleted by upgrade-system.

So, for the time being, I will "err on the side of caution" and add 
--no-guess-python to ORPHANOPTS.  If upgrade-system is as a result less zealous 
about deleting orphan packages, so be it.  I can live with that.

If someone wants to track down the underlying cause of deborphan's dislike for 
python-cffi-backend, I'll be happy to help in any way I can.

Rick

On Sun, Dec 27, 2020, at 1:02 PM, Martin-Éric Racine wrote:
> Right, so in that case, there is no bug in upgrade-system.
> 
> The backend 'deborphan --guess-all' simply makes broad assumptions
> about what is superflous libraries and, for some reason, it considers
> python-cffi-backend as superflous as explained in bug #918755.
> 
> In your case, the solution indeed is to add --no-guess-python to ORPHANOPTS.
> 
> Martin-Éric



Bug#918755: Bug#978158: Bug#918755: Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-28 Thread Martin-Éric Racine
su 27. jouluk. 2020 klo 23.27 Chris Hofstaedtler (z...@debian.org) kirjoitti:
> * Martin-Éric Racine  [201227 22:06]:
> > Right, so in that case, there is no bug in upgrade-system.
> > In your case, the solution indeed is to add --no-guess-python to ORPHANOPTS.
>
> > su 27. jouluk. 2020 klo 22.47 Rick Thomas (rick.tho...@pobox.com) kirjoitti:
> > >
> > > It looks like the problem is in deborphan.  /etc/upgrade-system.conf has
> > > ORPHANOPTS="--guess-all --libdevel"
>
> deborphan makes absolutely no promises on which packages it will
> return. If upgrade-system uses deborphans output to automatically
> remove packages, this is DANGEROUS, to say the least.

Please stop the drama. The assumptions for --guess-all generally work well.

Meanwhile, you've got two users reporting you a false positive,
involving the exact same package as a dependency for 2 different
packages. Why don't you focus on fixing that instead?

Martin-Éric



Bug#918755: Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-27 Thread Chris Hofstaedtler
Hi,

* Martin-Éric Racine  [201227 22:06]:
> Right, so in that case, there is no bug in upgrade-system.

I must disagree, see below.

> The backend 'deborphan --guess-all' simply makes broad assumptions
> about what is superflous libraries and, for some reason, it considers
> python-cffi-backend as superflous as explained in bug #918755.
> 
> In your case, the solution indeed is to add --no-guess-python to ORPHANOPTS.

[..]
> su 27. jouluk. 2020 klo 22.47 Rick Thomas (rick.tho...@pobox.com) kirjoitti:
> >
> > It looks like the problem is in deborphan.  /etc/upgrade-system.conf has
> > ORPHANOPTS="--guess-all --libdevel"

deborphan makes absolutely no promises on which packages it will
return. If upgrade-system uses deborphans output to automatically
remove packages, this is DANGEROUS, to say the least.

As said above, deborphan very clearly documents `--guess-*` (that
includes `--guess-all`) as "beware when using this!"

I believe this is a serious bug in upgrade-system's default
configuration.  Please stop this.

Chris



Bug#918755: Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-27 Thread Martin-Éric Racine
Right, so in that case, there is no bug in upgrade-system.

The backend 'deborphan --guess-all' simply makes broad assumptions
about what is superflous libraries and, for some reason, it considers
python-cffi-backend as superflous as explained in bug #918755.

In your case, the solution indeed is to add --no-guess-python to ORPHANOPTS.

Martin-Éric

su 27. jouluk. 2020 klo 22.47 Rick Thomas (rick.tho...@pobox.com) kirjoitti:
>
> It looks like the problem is in deborphan.  /etc/upgrade-system.conf has
> ORPHANOPTS="--guess-all --libdevel"
>
> and something about that combination leads deborphan to decide it doesn't 
> need the package "python-cffi-backend", which is a lineal dependent of 
> deborphan.  The reason that upgrade-system wants to purge deluge is that with 
> python-cffi-backend gone, deluge is missing a critical dependency.  This is 
> all described Bug#918755 .
>
> If I add "--no-guess-python" to the option list, deborphan no longer lists 
> python-cffi-backend,  but I'm concerned that doing that will have wider 
> side-effects.
>
> Details:
> rbthomas@monk:~$ deborphan --guess-all --libdevel
> python-cffi-backend
> rbthomas@monk:~$ deborphan --guess-all --no-guess-python --libdevel
> rbthomas@monk:~$
>
> Hope this helps!
> Rick
>
> On Sat, Dec 26, 2020, at 3:03 PM, Martin-Éric Racine wrote:
> > la 26. jouluk. 2020 klo 21.30 Rick Thomas (rbtho...@rcthomas.org) kirjoitti:
> > >
> > > Package: upgrade-system
> > > Version: 1.7.3.1
> > > Severity: normal
> > >
> > > --- Please enter the report below this line. ---
> > >
> > > The package "deluge" is manually (i.e. not "auto") installed on my
> > > system.  I use it daily. But when I try to run "upgrade-system" it lists
> > > deluge and a bunch of other packages that deluge depends on as needing
> > > to be removed.  Why is this?
> >
> > Check the deborphan options you have configured in
> > /etc/upgrade-system.conf for something that tries to purge python
> > packages. To manually fine-tune this, you can run 'sudo deborphan'
> > with different combinations of --guess options.
> >
> > Martin-Éric
> >



Bug#918755: Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-27 Thread Rick Thomas
It looks like the problem is in deborphan.  /etc/upgrade-system.conf has
ORPHANOPTS="--guess-all --libdevel"

and something about that combination leads deborphan to decide it doesn't need 
the package "python-cffi-backend", which is a lineal dependent of deborphan.  
The reason that upgrade-system wants to purge deluge is that with 
python-cffi-backend gone, deluge is missing a critical dependency.  This is all 
described Bug#918755 .

If I add "--no-guess-python" to the option list, deborphan no longer lists 
python-cffi-backend,  but I'm concerned that doing that will have wider 
side-effects.

Details:
rbthomas@monk:~$ deborphan --guess-all --libdevel
python-cffi-backend
rbthomas@monk:~$ deborphan --guess-all --no-guess-python --libdevel
rbthomas@monk:~$

Hope this helps!
Rick

On Sat, Dec 26, 2020, at 3:03 PM, Martin-Éric Racine wrote:
> la 26. jouluk. 2020 klo 21.30 Rick Thomas (rbtho...@rcthomas.org) kirjoitti:
> >
> > Package: upgrade-system
> > Version: 1.7.3.1
> > Severity: normal
> >
> > --- Please enter the report below this line. ---
> >
> > The package "deluge" is manually (i.e. not "auto") installed on my
> > system.  I use it daily. But when I try to run "upgrade-system" it lists
> > deluge and a bunch of other packages that deluge depends on as needing
> > to be removed.  Why is this?
> 
> Check the deborphan options you have configured in
> /etc/upgrade-system.conf for something that tries to purge python
> packages. To manually fine-tune this, you can run 'sudo deborphan'
> with different combinations of --guess options.
> 
> Martin-Éric
>



Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-26 Thread Martin-Éric Racine
la 26. jouluk. 2020 klo 21.30 Rick Thomas (rbtho...@rcthomas.org) kirjoitti:
>
> Package: upgrade-system
> Version: 1.7.3.1
> Severity: normal
>
> --- Please enter the report below this line. ---
>
> The package "deluge" is manually (i.e. not "auto") installed on my
> system.  I use it daily. But when I try to run "upgrade-system" it lists
> deluge and a bunch of other packages that deluge depends on as needing
> to be removed.  Why is this?

Check the deborphan options you have configured in
/etc/upgrade-system.conf for something that tries to purge python
packages. To manually fine-tune this, you can run 'sudo deborphan'
with different combinations of --guess options.

Martin-Éric



Bug#978158: [upgrade-system] upgrade-system wants to delete package deluge and everything it depends on

2020-12-26 Thread Rick Thomas

Package: upgrade-system
Version: 1.7.3.1
Severity: normal

--- Please enter the report below this line. ---

The package "deluge" is manually (i.e. not "auto") installed on my 
system.  I use it daily. But when I try to run "upgrade-system" it lists 
deluge and a bunch of other packages that deluge depends on as needing 
to be removed.  Why is this?


Details:

rbthomas@monk:~$ aptitude search deluge
i   deluge  - bittorrent 
client written in Python/PyGTK
i A deluge-common   - bittorrent 
client written in Python/PyGTK (common files)
i   deluge-console  - bittorrent 
client written in Python/PyGTK (console ui)
i A deluge-gtk  - bittorrent 
client written in Python/PyGTK (GTK+ ui)
p   deluge-torrent  - bittorrent 
client (gtk ui transitional package)
i   deluge-web  - bittorrent 
client written in Python/PyGTK (web ui)
p   deluge-webui    - bittorrent 
client (web ui transitional package)
i   deluged - bittorrent 
client written in Python/PyGTK (daemon)


rbthomas@monk:~$ sudo upgrade-system
1) Updating package lists:
I: Package lists updated.
2) Checking for upgradable packages:
I: No upgradable package to install.
3) Checking for orphan packages:
I: Purging orphan packages...
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be REMOVED:
  deluge* deluge-common* deluge-console* deluge-gtk* deluge-web* 
deluged* libboost-python1.67.0* libboost-random1.67.0*
  libglade2-0* libmad0* libmikmod3* libportmidi0* libsdl-image1.2* 
libsdl-mixer1.2* libsdl2-2.0-0* libtorrent-rasterbar9*
  python-asn1crypto* python-attr* python-automat* python-cffi-backend* 
python-chardet* python-click* python-colorama*
  python-constantly* python-cryptography* python-glade2* 
python-hyperlink* python-idna* python-incremental* python-ipaddress*
  python-libtorrent* python-mako* python-markupsafe* python-notify* 
python-openssl* python-pyasn1* python-pyasn1-modules*
  python-pygame* python-service-identity* python-six* 
python-twisted-bin* python-twisted-core* python-xdg*

  python-zope.interface*
0 upgraded, 0 newly installed, 44 to remove and 0 not upgraded.
After this operation, 43.5 MB disk space will be freed.
Do you want to continue? [Y/n] N




--- System information. ---
Architecture:
Kernel: Linux 4.19.0-13-amd64

Debian Release: 10.7
500 stable-updates ftp-osl.osuosl.org
500 stable security.debian.org
500 stable ftp-osl.osuosl.org
500 oldstable deb.debian.org
100 buster-backports ftp-osl.osuosl.org

--- Package information. ---
Depends (Version) | Installed
-+-===
apt (>= 0.7.0) | 1.8.2.2
deborphan (>= 1.7) | 1.7.31


Recommends (Version) | Installed
=-+-===
debsums | 2.2.3


Package's Suggests field is empty.