Bug#980768: gnupg2: reduce Build-Depends

[Samuel Thibault]

Hello,

Helmut Grohne, le jeu. 21 janv. 2021 20:17:21 +0100, a ecrit:
>  * ghostscript was used to create doc/gnupg-card-architecture.pdf, but
>this step is not performed during build.
>  * imagemagick's convert and transfig's fig2dev are mentioned in
>doc/Makefile.am, but since the relevant artifacts are included in the
>source distribution, they're not run during build.

Ideally they would be rebuilt, so the dependency would make sense.

But it would be indeed useful to at least take them out of a bootstrap
profile (as well as transfig), so that people bootstrapping ports know
that they can use this to build gnupg2 easily (in order to be able to
install apt and properly build packages at all), as the attached patch
does.

>  * librsvg2-bin's rsvg-convert is never mentioned anywhere.

This one was already dropped.

Samuel
--- debian/control.original 2023-11-01 18:32:41.0 +
+++ debian/control  2023-11-01 18:37:27.0 +
@@ -12,9 +12,9 @@
  debhelper-compat (= 13),
  file,
  gettext,
- ghostscript,
+ ghostscript ,
  gpgrt-tools,
- imagemagick,
+ imagemagick ,
  libassuan-dev (>= 2.5.0),
  libbz2-dev,
  libcurl4-gnutls-dev,
@@ -30,7 +30,7 @@
  openssh-client ,
  pkg-config,
  texinfo,
- transfig,
+ transfig ,
  zlib1g-dev | libz-dev,
 Build-Depends-Indep:
  binutils-multiarch [!amd64 !i386],

Bug#980768: [pkg-gnupg-maint] Bug#980768: gnupg2: reduce Build-Depends

[Werner Koch]

>  * libcurl4-gnutls-dev is unused. While curl is mentioned in source
>comments and checked for in configure, it is never actually used.

You mean GnuPG's configure?  I can't find it.  It was tested for in
GnuPG 1 and 2.0 but not anymore since 2.1.  I am just a curious
upstream.


Salam-Shalom,

   Werner

-- 
* Free Assange and protect free journalism!
* Germany: Sign the Treaty on the Prohibition of Nuclear Weapons!


signature.asc
Description: PGP signature

Bug#980768: gnupg2: reduce Build-Depends

[Helmut Grohne]

Source: gnupg2
Version: 2.2.20-1
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

gnupg2 participates in a number of dependency cycles relevant to
architecture bootstrap. Instead of looking into such a hard problem, I
looked into easily droppable dependencies and found some. Since gnupg2
is normally reproducible, I verified that performing a nocheck build
with the following dependencies turned into Build-Conflicts results in
precisely the same binary artifacts as a regular full build.

 * ghostscript was used to create doc/gnupg-card-architecture.pdf, but
   this step is not performed during build.
 * imagemagick's convert and transfig's fig2dev are mentioned in
   doc/Makefile.am, but since the relevant artifacts are included in the
   source distribution, they're not run during build.
 * libcurl4-gnutls-dev is unused. While curl is mentioned in source
   comments and checked for in configure, it is never actually used.
 * librsvg2-bin's rsvg-convert is never mentioned anywhere.

Please consider applying the attached patch.

Helmut
diff --minimal -Nru gnupg2-2.2.20/debian/changelog 
gnupg2-2.2.20/debian/changelog
--- gnupg2-2.2.20/debian/changelog  2020-03-23 20:05:13.0 +0100
+++ gnupg2-2.2.20/debian/changelog  2021-01-21 13:53:34.0 +0100
@@ -1,3 +1,19 @@
+gnupg2 (2.2.20-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Reduce Build-Depends: (Closes: #-1)
++ Drop unused ghostscript. It is used to create
+  doc/gnupg-card-architecture.pdf, but the invocations for doing so are
+  missing from the source.
++ Drop unused imagemagick and transfig. Both convert and fig2dev are used
+  in doc/Makefile.am, but since the relevant output artifacts are
+  included, they're not run.
++ Drop unused libcurl4-gnutls-dev. curl is mentioned in source comments
+  and checked for in configure, but never actually used.
++ Drop unused librsvg2-bin. It is not mentioned anywhere nor used.
+
+ -- Helmut Grohne   Thu, 21 Jan 2021 13:53:34 +0100
+
 gnupg2 (2.2.20-1) unstable; urgency=medium
 
   * New upstream release
diff --minimal -Nru gnupg2-2.2.20/debian/control gnupg2-2.2.20/debian/control
--- gnupg2-2.2.20/debian/control2020-03-23 20:04:11.0 +0100
+++ gnupg2-2.2.20/debian/control2021-01-21 13:53:34.0 +0100
@@ -12,12 +12,9 @@
  debhelper-compat (= 12),
  file,
  gettext,
- ghostscript,
  gpgrt-tools,
- imagemagick,
  libassuan-dev (>= 2.5.0),
  libbz2-dev,
- libcurl4-gnutls-dev,
  libgcrypt20-dev (>= 1.7.0),
  libgnutls28-dev (>= 3.0),
  libgpg-error-dev (>= 1.35),
@@ -25,13 +22,11 @@
  libldap2-dev,
  libnpth0-dev (>= 1.2),
  libreadline-dev,
- librsvg2-bin,
  libsqlite3-dev,
  libusb-1.0-0-dev [!hurd-any],
  openssh-client ,
  pkg-config,
  texinfo,
- transfig,
  zlib1g-dev | libz-dev,
 Build-Depends-Indep:
  binutils-multiarch [!amd64 !i386],