Bug#981253: actually, make that: document minimum and maximum values of all options
ma 22. helmik. 2021 klo 1.33 Santiago Garcia Mantinan (ma...@debian.org) kirjoitti: > > > Document the minimum and maximum values of all options, and tell which > > value is the strongest for each. > > This will take a lot of time, and I don't know if this is worth the effort. [...] > I'll try to gather info for all this, but looks like it will be time > consuming and that the kernel guys may change it again :-( One way to do this would be to revise the man page exactly once at every Debian release, at the start of the soft freeze i.e. once the kernel version is decided, and to have a section where it says something like: -- BUGS The above options, values and meanings are correct as of Linux kernel 5.10, and may have changed since the previous major Linux kernel release. This might indeed mean that changes in the way the Linux kernel handles bridges have altered the way existing options are interpreted. Whenever in doubt, consult older versions of this manual page and compare their contents. -- This way, the manual page would at least be correct for the Debian release it comes with. Martin-Éric
Bug#981253: actually, make that: document minimum and maximum values of all options
> Document the minimum and maximum values of all options, and tell which > value is the strongest for each. This will take a lot of time, and I don't know if this is worth the effort. I'm going to try to go over all of this, as it seems that documentation is wrong, the kernel guys have changed things around and doc doesn't match kernel, for example, you asked for portprio... I had to read the kernel code to know what was happening, right now as of 5.10 this would be... br_stp_if.c:#define BR_MAX_PORT_PRIORITY ((u16)~0 >> BR_PORT_BITS) br_private.h:#define BR_PORT_BITS 10 This means that it is set to an unsigned int of 16 bits which is the complent of 0, which means it is in binary or in hexa, shifted right 10 bits, which makes it 11 or 63 in decimal, so... right now the values go from 0 to 63. It looks like by default... p->priority = 0x8000 >> BR_PORT_BITS; which would be... 0x20 or 32 in decimal. And testing shows lower is higher priority. I'll try to gather info for all this, but looks like it will be time consuming and that the kernel guys may change it again :-( Regards... -- Manty/BestiaTester -> http://manty.net
Bug#981253: actually, make that: document minimum and maximum values of all options
Actually, make that: Document the minimum and maximum values of all options, and tell which value is the strongest for each. -- Martin-Éric
