Bug#981609: gnome-activity-journal: missing dependencies on git packages
On Sun, Feb 7, 2021 at 10:29 PM crvi c wrote: > > The issue is already fixed in git. > > Please refer to > https://gitlab.gnome.org/crvi/gnome-activity-journal/-/issues/1 Ohh, sorry, I misunderstood your previous email. I have now pulled the HEAD from your repo and tested in the setup where it was not working and can confirm that it is working properly now. Thanks @crvi -- Regards Sudip
Bug#981609: gnome-activity-journal: missing dependencies on git packages
The issue is already fixed in git. Please refer to https://gitlab.gnome.org/crvi/gnome-activity-journal/-/issues/1 Thanks! On Mon, 8 Feb 2021 at 03:38, Sudip Mukherjee wrote: > On Sun, Feb 7, 2021 at 9:39 PM crvi c wrote: > > > > Gstreamer packages should be "Suggested" dependencies, not "Recommended". > > No, Jonas is correct. It is working in my setup but after his reply I > started testing on other environments and I can confirm there is > atleast one combination (with Mate + lightdm) where > gnome-activity-journal will not even start if 'gir1.2-gstreamer-1.0' > is not installed. Absence of 'gstreamer1.0-gtk3' has not affected it > till now. > > @crvi I will open an upstream issue for you to fix this issue, and > till then I will mark 'gir1.2-gstreamer-1.0' as a dependency. > > > -- > Regards > Sudip >
Bug#981609: gnome-activity-journal: missing dependencies on git packages
On Sun, Feb 7, 2021 at 9:39 PM crvi c wrote: > > Gstreamer packages should be "Suggested" dependencies, not "Recommended". No, Jonas is correct. It is working in my setup but after his reply I started testing on other environments and I can confirm there is atleast one combination (with Mate + lightdm) where gnome-activity-journal will not even start if 'gir1.2-gstreamer-1.0' is not installed. Absence of 'gstreamer1.0-gtk3' has not affected it till now. @crvi I will open an upstream issue for you to fix this issue, and till then I will mark 'gir1.2-gstreamer-1.0' as a dependency. -- Regards Sudip
Bug#981609: gnome-activity-journal: missing dependencies on git packages
Gstreamer packages should be "Suggested" dependencies, not "Recommended". The issues have been addressed in git master. https://gitlab.gnome.org/crvi/gnome-activity-journal/-/commits/master Thanks! On Mon, 8 Feb 2021 at 01:15, Jonas Smedegaard wrote: > Quoting Sudip Mukherjee (2021-02-07 19:41:03) > > Hi Jonas, > > > > On Tue, Feb 02, 2021 at 12:56:52AM +0100, Jonas Smedegaard wrote: > > > Package: gnome-activity-journal > > > Version: 1.0.0-1 > > > Severity: important > > > > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA512 > > > > > > Package is missing dependencies on at least these packages: > > > > > > gir1.2-gstreamer-1.0 > > > gir1.2-gnomedesktop-3.0:amd64 > > > > Thanks for spotting this. > > 'gir1.2-gnomedesktop-3.0' is indeed a dependency, but > 'gir1.2-gstreamer-1.0' > > is an optional audio preview feature and so I am marking it along with > > 'gstreamer1.0-gtk3' (which is also an optional video preview feature) as > > suggested packages. Please let me know if you think this is wrong. > > Did you (not only look at code, but) actually test how the application > behaves when those optional modules are missing? > > As I recall, the application failed to run for me when they were > missing, which indicates that a suggestion is too weak and they should > at least be recommended. If there is no (exotic) way to make the > application run without them, they should have a hard dependency. > > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private
Bug#981609: gnome-activity-journal: missing dependencies on git packages
Quoting Sudip Mukherjee (2021-02-07 19:41:03) > Hi Jonas, > > On Tue, Feb 02, 2021 at 12:56:52AM +0100, Jonas Smedegaard wrote: > > Package: gnome-activity-journal > > Version: 1.0.0-1 > > Severity: important > > > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA512 > > > > Package is missing dependencies on at least these packages: > > > > gir1.2-gstreamer-1.0 > > gir1.2-gnomedesktop-3.0:amd64 > > Thanks for spotting this. > 'gir1.2-gnomedesktop-3.0' is indeed a dependency, but 'gir1.2-gstreamer-1.0' > is an optional audio preview feature and so I am marking it along with > 'gstreamer1.0-gtk3' (which is also an optional video preview feature) as > suggested packages. Please let me know if you think this is wrong. Did you (not only look at code, but) actually test how the application behaves when those optional modules are missing? As I recall, the application failed to run for me when they were missing, which indicates that a suggestion is too weak and they should at least be recommended. If there is no (exotic) way to make the application run without them, they should have a hard dependency. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: signature
Bug#981609: gnome-activity-journal: missing dependencies on git packages
Hi Jonas, On Tue, Feb 02, 2021 at 12:56:52AM +0100, Jonas Smedegaard wrote: > Package: gnome-activity-journal > Version: 1.0.0-1 > Severity: important > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Package is missing dependencies on at least these packages: > > gir1.2-gstreamer-1.0 > gir1.2-gnomedesktop-3.0:amd64 Thanks for spotting this. 'gir1.2-gnomedesktop-3.0' is indeed a dependency, but 'gir1.2-gstreamer-1.0' is an optional audio preview feature and so I am marking it along with 'gstreamer1.0-gtk3' (which is also an optional video preview feature) as suggested packages. Please let me know if you think this is wrong. -- Regards Sudip
Bug#981609: gnome-activity-journal: missing dependencies on git packages
Package: gnome-activity-journal Version: 1.0.0-1 Severity: important -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Package is missing dependencies on at least these packages: gir1.2-gstreamer-1.0 gir1.2-gnomedesktop-3.0:amd64 Possibly more (which I just happened to have installed already. In my experience, for python packages you need to examine the code itself to ensure all required gir packages are included. - Jonas -BEGIN PGP SIGNATURE- iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmAYlUEACgkQLHwxRsGg ASH4wQ/8CigX9qGIOu6Z1F++ZZNOK6CERZSkd6QWMLfXPwM3NTxVa2mx2HgKukQ7 i3/79h3eA/KxmPlhHA57cFAp/SQPvCd+fyqXV2KE17NQApeigAw6CB7R7uvC2aNP 5s9HoP+G2n4StHG+FlkvCRPNm6TfNaLp/nEQMsJUO6wPuAUkjo/ArGBBySu4m7vA lDGT8DspbkHGePlBNJ3dhbck+OviH3ETTv+X7C8uFTkxwzDxi0CK9Q3nzJJsMvGB k+vuswknzhoMlWkg3VhZYLZ/+nXaMDB/wWE5rCruSGMszEw1PY3iM31zshpP5YXI wbXjsIBM3V2YnLaDIRUasL8AS7zSdFxBx5SLdwDW13NyiCyWHLkxEAf2FTfhtJkd B+CM9tdwcx99RybO2x20d/Qb22rz5M8xa1mkNkv8Iil9TIt7v0PAZU5PfWRkqnP4 QlSRtq3w8PBBIX2Wm1NeoiByDQsAj5obE+IXANO+5/Xyg7iUznpSOOzv7/osHPBF x91IY2Qzt+3tc3DDozkjXvMhNKzLsV25BGeNnMWBHZefRsK7P2jwxM+p6iKjJFde ZlMXAvPi8ykJH2uOekHLt/TrgibanJ8LMUr4vfog6Siu11jD63/0UAiIBak5zi4A AJryEn4aJ5fAyrPTgB+gLebwenvH8L6I6JINk/KOlLLLPRlCj7I= =MG/H -END PGP SIGNATURE-
