Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-19 Thread Antoine Beaupré
Control: tag -1 +pending

That all looks good to me, i'll upload shortly.

-- 
To be naive and easily deceived is impermissible, today more than
ever, when the prevailing untruths may lead to a catastrophe because
they blind people to real dangers and real possibilities.
- Erich Fromm



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-19 Thread Peter Colberg
On Fri, Nov 18, 2022 at 01:18:05PM -0500, Antoine Beaupré wrote:
> It looks like it ships a third-party library, nanosvg. I don't know if
> that's already packaged in Debian, but it might make the FTP-masters
> unhappy, especially since it's not mentioned in debian/copyright. So the
> latter should be fixed, at the very least, and we might consider
> packaging that library separately...
> 
> ... that said, it looks like many other packages do ship a copy of that
> library, maybe it's the way it's designed to be shipped?
> 
> https://codesearch.debian.net/search?q=nanosvg=1
> 
> wxwidgets just vendors it, but does mention it in the debian/copyright,
> however:
> 
> https://sources.debian.org/src/wxwidgets3.2/3.2.1%2Bdfsg-1/debian/copyright/#L28
> 
> So there's that: at least add that to the debian/copyright.

Thanks for your patch! I posted a note regarding nanosvg:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982140#12

> Also, I've had trouble reproducing the upstream tarball. I tried to
> build the package with git-buildpackage:
> 
> gbp buildpackage --git-debian-branch=main --git-upstream-tag=1.8.2
> 
> ... but that gives me a different tarball than
> upstream. git-buildpackage generates a tarball with foot-1.8.2/ as a
> top directory, while upstream has foot/. I'm not sure how to resolve
> this, but you should at least provide the upstream tarball ... somewhere
> so that it can be uploaded safely.
> 
> You might want to configure git-buildpackage or some other git-building
> tool in the package as well, since it seems that (git) is what you rely
> on to build this.

I checked UPSTREAM TARBALL CREATION OPTIONS in gbp-buildpackage(1) for
an option to set the prefix that could be used in gbp.conf, but could
not find anything. The default might have been chosen to match GitHub.

I use debuild with lintian in buildah to build Debian packages:

https://www.debian.org/doc/manuals/maint-guide/build.en.html#debuild
https://tauware.blogspot.com/2020/04/building-packages-with-buildah-in-debian.html

> I can probably just live with the upstream tarball for now, but that
> might be something you want to consider documenting in
> debian/README.source or something.

I have documented to obtain the tarball with origtargz:

https://salsa.debian.org/swaywm-team/fuzzel/-/commit/777f02bbb38f229016bb41fc90ebfc923da46e98

# sha256sum ../fuzzel_1.8.2.orig.tar.gz
2e7debba9d56a989921e0ce518a026152d9fbea33abafe384a4aad074db89de8  
../fuzzel_1.8.2.orig.tar.gz

> Otherwise this is almost ready to go, as far as I'm concerned, and I'll
> be happy to sponsor this once it has a proper debian/copyright. Try
> running decopy on the source to see what comes up...

Thanks for your review! This is latest commit of the package:

https://salsa.debian.org/swaywm-team/fuzzel/-/commit/ccc1a63f6289c33560f0ff85a5143e0e47daa529

Regards,
Peter



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-18 Thread Antoine Beaupré
On 2022-11-12 18:17:23, Peter Colberg wrote:
> Dear Debian mentors,
>
> I have updated the fuzzel package to version 1.8.2-1 [1]. I will
> push a signed tag once the package has been accepted into unstable.

Hi!

So a quick review of the package...

It looks like it ships a third-party library, nanosvg. I don't know if
that's already packaged in Debian, but it might make the FTP-masters
unhappy, especially since it's not mentioned in debian/copyright. So the
latter should be fixed, at the very least, and we might consider
packaging that library separately...

... that said, it looks like many other packages do ship a copy of that
library, maybe it's the way it's designed to be shipped?

https://codesearch.debian.net/search?q=nanosvg=1

wxwidgets just vendors it, but does mention it in the debian/copyright,
however:

https://sources.debian.org/src/wxwidgets3.2/3.2.1%2Bdfsg-1/debian/copyright/#L28

So there's that: at least add that to the debian/copyright.

Also, I've had trouble reproducing the upstream tarball. I tried to
build the package with git-buildpackage:

gbp buildpackage --git-debian-branch=main --git-upstream-tag=1.8.2

... but that gives me a different tarball than
upstream. git-buildpackage generates a tarball with foot-1.8.2/ as a
top directory, while upstream has foot/. I'm not sure how to resolve
this, but you should at least provide the upstream tarball ... somewhere
so that it can be uploaded safely.

You might want to configure git-buildpackage or some other git-building
tool in the package as well, since it seems that (git) is what you rely
on to build this.

I can probably just live with the upstream tarball for now, but that
might be something you want to consider documenting in
debian/README.source or something.

Otherwise this is almost ready to go, as far as I'm concerned, and I'll
be happy to sponsor this once it has a proper debian/copyright. Try
running decopy on the source to see what comes up...

a.
-- 
There is no cloud, it's just someone else's computer.
   - Chris Watterson


signature.asc
Description: PGP signature


Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-18 Thread Peter Colberg
Hi Antoine,

On Fri, Nov 18, 2022 at 12:06:19PM -0500, Antoine Beaupré wrote:
> On 2022-11-12 18:17:23, Peter Colberg wrote:
> > I have updated the fuzzel package to version 1.8.2-1 [1]. I will
> > push a signed tag once the package has been accepted into unstable.
> >
> > [1] 
> > https://salsa.debian.org/swaywm-team/fuzzel/-/commit/8ae19155129c7e7bf20246a105702c74a148ff03
> 
> Are you still looking for a sponsor for this?

Yes, thank you, that would be great!

Peter



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-18 Thread Birger Schacht

Hi,

On 11/18/22 18:06, Antoine Beaupré wrote:

On 2022-11-12 18:17:23, Peter Colberg wrote:

Dear Debian mentors,

I have updated the fuzzel package to version 1.8.2-1 [1]. I will
push a signed tag once the package has been accepted into unstable.

[1] 
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/8ae19155129c7e7bf20246a105702c74a148ff03


Are you still looking for a sponsor for this?

@sway team: is there any reason why another DD should hold off on
reviewing and uploading this to NEW?

No! Please go ahead! I think there is just no time for sponsoring 
packages in the swaywm team, but that should not prevent anyone else 
from sponsoring!


cheers,
Birger


OpenPGP_0xCB06EA7B78DBE151_and_old_rev.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-18 Thread Antoine Beaupré
And for what it's worth, I tested the latest package from salsa, as per:

commit 8ae19155129c7e7bf20246a105702c74a148ff03 (HEAD -> main, origin/main, 
origin/HEAD)
Author: Peter Colberg 
Date:   Sat Nov 12 17:53:29 2022 -0500

Update changelog

... and it works well. I have only reviewed the debian/ directory, not
upstream's code, but I can confirm the code in the sals repo matches the
upstream, as far as git is concerned.

That thing is fast and beautiful. :)

a.
-- 
Freedom is being able to make decisions that affect mainly you. Power
is being able to make decisions that affect others more than you. If
we confuse power with freedom, we will fail to uphold real freedom.
- Richard Stallman



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-18 Thread Antoine Beaupré
On 2022-11-12 18:17:23, Peter Colberg wrote:
> Dear Debian mentors,
>
> I have updated the fuzzel package to version 1.8.2-1 [1]. I will
> push a signed tag once the package has been accepted into unstable.
>
> [1] 
> https://salsa.debian.org/swaywm-team/fuzzel/-/commit/8ae19155129c7e7bf20246a105702c74a148ff03

Are you still looking for a sponsor for this?

@sway team: is there any reason why another DD should hold off on
reviewing and uploading this to NEW?

-- 
Either you're with us or you're with the terrorist state.



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-12 Thread Peter Colberg
Dear Debian mentors,

I have updated the fuzzel package to version 1.8.2-1 [1]. I will
push a signed tag once the package has been accepted into unstable.

[1] 
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/8ae19155129c7e7bf20246a105702c74a148ff03

Thanks,
Peter



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-11-09 Thread Peter Colberg
Dear Debian mentors,

Apologies for the confusion: This package is still in need of
sponsorship since I have not heard back from the Sway team.

Thanks,
Peter

On Sat, Sep 17, 2022 at 08:11:35PM -0400, Peter Colberg wrote:
> Dear Sway team,
> 
> Would anyone be willing to sponsor the initial upload of fuzzel? I am
> a Debian Maintainer and would maintain the package myself thereafter.
> 
> On Sun, Oct 31, 2021 at 09:35:06PM +0100, Bastian Germann wrote:
> > On Sat, 6 Feb 2021 15:10:26 -0500 Peter Colberg wrote:
> > > It builds these binary packages:
> > > 
> > >   fuzzel - Application launcher for wlroots based Wayland compositors
> > > 
> > > Fuzzel fills a gap in the Debian swaywm ecosystem as a Wayland
> > > equivalent for rofi in terms of ease of use, robustness, and simplicity.
> 
> > You should contact the team to sponsor this if you have not done this 
> > already.
> > 
> > The d/watch file does not work. The web interface might have changed.
> > You can also use uscan's git mode.
> 
> The download likely failed due to pagination of older releases.
> I have updated debian/watch to query the API instead [1].
> 
> > When you have fixed the d/watch file untag moreinfo.
> 
> Thanks for your review! I have pushed version 1.7.0-1 [2].
> 
> [1] 
> https://salsa.debian.org/swaywm-team/fuzzel/-/commit/2cfcd218545134ba7b1c5ab479b76f29a48e46e6
> [2] 
> https://salsa.debian.org/swaywm-team/fuzzel/-/commit/e3f6004d4c6a1de1e6c1b599d00b5c7fb4f35408
> 
> Thanks,
> Peter



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2022-09-17 Thread Peter Colberg
Dear Sway team,

Would anyone be willing to sponsor the initial upload of fuzzel? I am
a Debian Maintainer and would maintain the package myself thereafter.

On Sun, Oct 31, 2021 at 09:35:06PM +0100, Bastian Germann wrote:
> On Sat, 6 Feb 2021 15:10:26 -0500 Peter Colberg wrote:
> > It builds these binary packages:
> > 
> >   fuzzel - Application launcher for wlroots based Wayland compositors
> > 
> > Fuzzel fills a gap in the Debian swaywm ecosystem as a Wayland
> > equivalent for rofi in terms of ease of use, robustness, and simplicity.

> You should contact the team to sponsor this if you have not done this already.
> 
> The d/watch file does not work. The web interface might have changed.
> You can also use uscan's git mode.

The download likely failed due to pagination of older releases.
I have updated debian/watch to query the API instead [1].

> When you have fixed the d/watch file untag moreinfo.

Thanks for your review! I have pushed version 1.7.0-1 [2].

[1] 
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/2cfcd218545134ba7b1c5ab479b76f29a48e46e6
[2] 
https://salsa.debian.org/swaywm-team/fuzzel/-/commit/e3f6004d4c6a1de1e6c1b599d00b5c7fb4f35408

Thanks,
Peter



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2021-10-31 Thread Bastian Germann

Control: tags -1 moreinfo

On Sat, 6 Feb 2021 15:10:26 -0500 Peter Colberg wrote:

It builds these binary packages:

  fuzzel - Application launcher for wlroots based Wayland compositors

Fuzzel fills a gap in the Debian swaywm ecosystem as a Wayland
equivalent for rofi in terms of ease of use, robustness, and simplicity.
The upstream author, Daniel Eklöf focuses on technical excellence and a
welcoming community around their software, and I am grateful for their
work. Daniel maintains the foot terminal emulator which is in Debian.

Regards,
Peter


You should contact the team to sponsor this if you have not done this already.

The d/watch file does not work. The web interface might have changed.
You can also use uscan's git mode.

When you have fixed the d/watch file untag moreinfo.



Bug#982145: RFS: fuzzel/1.5.1-1 [ITP] -- Application launcher for wlroots based Wayland compositors

2021-02-06 Thread Peter Colberg
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for an initial sponsor for the package "fuzzel". I am
currently a Debian Maintainer and would also like to seek upload
sponsorship so I may maintain the package myself once accepted.

 * Package name: fuzzel
   Version : 1.5.1-1
   Upstream Author : Daniel Eklöf 
 * URL : https://codeberg.org/dnkl/fuzzel
 * License : Expat
 * Vcs : https://salsa.debian.org/swaywm-team/fuzzel
   Section : x11

Fuzzel is a Wayland-native application launcher, similar to rofi's
drun mode.

[ITP] https://bugs.debian.org/982140

It builds these binary packages:

  fuzzel - Application launcher for wlroots based Wayland compositors

Fuzzel fills a gap in the Debian swaywm ecosystem as a Wayland
equivalent for rofi in terms of ease of use, robustness, and simplicity.
The upstream author, Daniel Eklöf focuses on technical excellence and a
welcoming community around their software, and I am grateful for their
work. Daniel maintains the foot terminal emulator which is in Debian.

Regards,
Peter