Bug#982640: [d-i] finish-install: improve understandability of reboot screen

2021-02-12 Thread Holger Wansing
Hi,

John Paul Adrian Glaubitz  wrote (Fri, 12 Feb 
2021 21:08:14 +0100):
> On 2/12/21 9:00 PM, Holger Wansing wrote:
> > I have prepared a small patch, to improve the understandability of the 
> > screen.
> 
> "+ Then, choose  to reboot."
> 
> I think that sentence sounds a bit weird.
> 
> It's probably better to write just "Please choose  to reboot."

Yes, maybe.
Thanks


Holger



-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076



Bug#982640: [d-i] finish-install: improve understandability of reboot screen

2021-02-12 Thread Holger Wansing
Package: finish-install
Severity: wishlist
Tags: patch


Hi,

Jeffrey Walton  wrote (Tue, 9 Feb 2021 04:27:46 -0500):
> Hi Everyone,
> 
> I was trying to follow John Paul Adrian Glaubitz instructions for
> installing Debian 10 on a PowerMac G5. The instructions are at
> https://lists.debian.org/debian-powerpc/2021/02/msg00011.html. The
> instructions say to forgo the reboot after installation and perform
> some extra steps.
> 
> At the end of the installation, the last screen told me a reboot was
> needed. The last screen gave me two choices -  or .
> I selected  because I had the extra steps to perform. I
> planned on reboot after performing the extra steps.
> 
>  unexpectedly rebooted the machine and I lost the chance to
> perform the extra steps. (Now I'm stuck at an OpenFirmware prompt that
> results in a kernel load failure/corrupt image error message for every
> command I enter. Sigh...)
> 
> >From a UX perspective, the last screen has a lot of opportunity for
> improvement. There's no indication what  does or where it
> "goes back" to. It is also not clear that "going back" does not undo
> the most recent steps performed by the installer. Finally, there's no
> indication  will immediately reboot the machine.
> 
> I believe the last screen should say something like:
> 
> Installation is complete. A reboot is required.
> If you select  then a reboot will happen now.
> If you select  then you will have to manually
> reboot later.
> 
> Would you like to Reboot now?
> 
> 
> 
> Changing the text on the last screen will dramatically improve the UX
> experience. It tells the user what is going to happen. It also offers
> the user a chance to avoid the reboot .

I have prepared a small patch, to improve the understandability of the screen.

And turning this into a bugreport against finish-install.


Holger




-- 
Holger Wansing 
PGP-Fingerprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076
diff --git a/debian/changelog b/debian/changelog
index 6db2eef..0f83c47 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+finish-install (2.104) UNRELEASED; urgency=medium
+
+  * Improve understandability of reboot screen.
+
+ -- Holger Wansing   Fri, 12 Feb 2021 20:53:45 +0100
+
 finish-install (2.103) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/finish-install.templates b/debian/finish-install.templates
index 40f25d2..57e5de6 100644
--- a/debian/finish-install.templates
+++ b/debian/finish-install.templates
@@ -37,11 +37,13 @@ _Description: Rebooting into your new system...
 
 Template: finish-install/reboot_in_progress
 Type: note
+# Translators: translate  identical to the translation of the button!
 # :sl1:
 _Description: Installation complete
  Installation is complete, so it is time to boot into your new system.
  Make sure to remove the installation media, so that
  you boot into the new system rather than restarting the installation.
+ Then, choose  to reboot.
 
 Template: finish-install/keep-consoles
 Type: boolean


Bug#982640: [d-i] finish-install: improve understandability of reboot screen

2021-02-12 Thread Brian Potkin
On Fri 12 Feb 2021 at 21:26:50 +0100, Holger Wansing wrote:

> John Paul Adrian Glaubitz  wrote (Fri, 12 Feb 
> 2021 21:08:14 +0100):
> > On 2/12/21 9:00 PM, Holger Wansing wrote:
> > > I have prepared a small patch, to improve the understandability of the 
> > > screen.
> > 
> > "+ Then, choose  to reboot.".
> >
> > I think that sentence sounds a bit weird.

The comma isn't needed

> > It's probably better to write just "Please choose  to reboot."

Yes, but why change anything?   
  

  
  ...Installation is complete, so it is time to boot into your  
  
  new system.   
  

  
Isn't that clear enough? The only other choice is .

> Yes, maybe.

The link the OP quoted also has 
  

  
  Switch to another console...  
  

  
I find that very clear too.

-- 
Brian.