Bug#983178: Created a merge request fixing this issue
pt., 5 mar 2021 o 10:44 Marcin Owsiany napisał(a): > Let me change the code to avoid sending it if the output is empty. > Done, PTAL. https://salsa.debian.org/webmaster-team/cron/-/merge_requests/6 Marcin
Bug#983178: Created a merge request fixing this issue
HI Laura, czw., 4 mar 2021 o 22:52 Laura Arjona Reina napisał(a): > Hello Marcin > thank you very much for working on this! > My pleasure ;-) > I have had a look at the merge request in salsa, but couldn't test the > script myself (yet). > > For what I understood (please correct me if I am wrong), the output is > filtered when composing the mail, so for languages having only the same > validation issues than English, translators would get a mail anyway, just > with almost empty content. > Ouch, you're completely right, and that was *not* my intention. > I wonder if it's maybe better to filter and rewrite the log files, so the > languages having derived from English issues don't receive mail (at least > until English is fixed), or better to just add a sentence like "you may > have additional validation issues that need to be fixed in the > corresponding English file(s), too." to the mail. The whole reason for me filing this bug and writing this code was to avoid receiving the email. And an empty one would be even more annoying than the current state :-D Let me change the code to avoid sending it if the output is empty. However I think it's better to keep the log files intact, in case one wants to see the full picture via https://www-master.debian.org/build-logs/validate Marcin
Bug#983178: Created a merge request fixing this issue
Hello Marcin thank you very much for working on this! I have had a look at the merge request in salsa, but couldn't test the script myself (yet). For what I understood (please correct me if I am wrong), the output is filtered when composing the mail, so for languages having only the same validation issues than English, translators would get a mail anyway, just with almost empty content. I wonder if it's maybe better to filter and rewrite the log files, so the languages having derived from English issues don't receive mail (at least until English is fixed), or better to just add a sentence like "you may have additional validation issues that need to be fixed in the corresponding English file(s), too." to the mail. Kind regards, El 4 de marzo de 2021 22:24:11 CET, Marcin Owsiany escribió: >I created https://salsa.debian.org/webmaster-team/cron/-/merge_requests/6 >which fixes this issue. >It would be great if someone could review and/or merge. > >Marcin -- Laura Arjona Reina https://wiki.debian.org/LauraArjona Sent with K-9 mail
Bug#983178: Created a merge request fixing this issue
I created https://salsa.debian.org/webmaster-team/cron/-/merge_requests/6 which fixes this issue. It would be great if someone could review and/or merge. Marcin
