Bug#983854: ubuntu-dev-tools: Making SourcePackage abstract class botched backportpackage

2021-04-08 Thread Dan Streetman
On Thu, Apr 8, 2021 at 12:36 PM Mattia Rizzolo  wrote:
>
> On Tue, Mar 02, 2021 at 10:21:47AM +0100, Ondřej Surý wrote:
> > commit ee9b8756d9e81003ad199f24a15f69201009bbe7 in upstream package
> > (included in 0.179) botched the ability to run backportpackage on the
> > dsc files:
>
> ahem.
>
> > $ /usr/bin/backportpackage -b -w tmp php-grpc_1.35.0+1.33.1-2.dsc # 
> > just a random package
> > Traceback (most recent call last):
> >   File "/usr/bin/backportpackage", line 424, in 
> >   sys.exit(main(sys.argv))
> >   File "/usr/bin/backportpackage", line 394, in main
> >   pkg = find_package(opts.mirror,
> >   File "/usr/bin/backportpackage", line 204, in find_package
> >   return SourcePackage(version=version, dscfile=package,
> > TypeError: Can't instantiate abstract class SourcePackage with abstract 
> > method distribution

I'm surprised that *ever* worked, as it was clearly ignoring the
warning (from 2010) in the SourcePackage() comment, "Use
DebianSourcePackage or UbuntuSourcePackage instead of using this".

I never use backportpackage myself, but just changing it to use
UbuntuSourcePackage instead should work.
https://code.launchpad.net/~ddstreet/ubuntu-dev-tools/+git/ubuntu-dev-tools/+merge/400848

>
> Dan: ↑
>
> --
> regards,
> Mattia Rizzolo
>
> GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
> More about me:  https://mapreri.org : :'  :
> Launchpad user: https://launchpad.net/~mapreri  `. `'`
> Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-



Bug#983854: ubuntu-dev-tools: Making SourcePackage abstract class botched backportpackage

2021-04-08 Thread Mattia Rizzolo
On Tue, Mar 02, 2021 at 10:21:47AM +0100, Ondřej Surý wrote:
> commit ee9b8756d9e81003ad199f24a15f69201009bbe7 in upstream package
> (included in 0.179) botched the ability to run backportpackage on the
> dsc files:

ahem.

> $ /usr/bin/backportpackage -b -w tmp php-grpc_1.35.0+1.33.1-2.dsc # just 
> a random package
> Traceback (most recent call last):
>   File "/usr/bin/backportpackage", line 424, in 
>   sys.exit(main(sys.argv))
>   File "/usr/bin/backportpackage", line 394, in main
>   pkg = find_package(opts.mirror,
>   File "/usr/bin/backportpackage", line 204, in find_package
>   return SourcePackage(version=version, dscfile=package,
> TypeError: Can't instantiate abstract class SourcePackage with abstract 
> method distribution

Dan: ↑

-- 
regards,
Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540  .''`.
More about me:  https://mapreri.org : :'  :
Launchpad user: https://launchpad.net/~mapreri  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-


signature.asc
Description: PGP signature


Bug#983854: ubuntu-dev-tools: Making SourcePackage abstract class botched backportpackage

2021-03-02 Thread Ondřej Surý
Package: ubuntu-dev-tools
Version: 0.180
Severity: important
Tags: upstream

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Dear Maintainer,

commit ee9b8756d9e81003ad199f24a15f69201009bbe7 in upstream package
(included in 0.179) botched the ability to run backportpackage on the
dsc files:

$ /usr/bin/backportpackage -b -w tmp php-grpc_1.35.0+1.33.1-2.dsc # just a 
random package
Traceback (most recent call last):
  File "/usr/bin/backportpackage", line 424, in 
sys.exit(main(sys.argv))
  File "/usr/bin/backportpackage", line 394, in main
pkg = find_package(opts.mirror,
  File "/usr/bin/backportpackage", line 204, in find_package
return SourcePackage(version=version, dscfile=package,
TypeError: Can't instantiate abstract class SourcePackage with abstract 
method distribution

I think this is actually a RC bug because it makes backportpackage
pretty much unusable, but I am letting you decided that.

Cheers,
Ondrej

- -- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-3-amd64 (SMP w/24 CPU threads)
Locale: LANG=en_IE.UTF-8, LC_CTYPE=en_IE.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_IE:en
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages ubuntu-dev-tools depends on:
ii  binutils2.36-2
ii  dctrl-tools 2.24-3+b1
ii  devscripts  2.21.1
ii  diffstat1.64-1
ii  distro-info 1.0
ii  dpkg-dev1.20.7.1
ii  dput-ng [dput]  1.32
ii  lsb-release 11.1.0
ii  perl5.32.1-2
ii  python3 3.9.1-1
ii  python3-apt 2.1.7
ii  python3-debian  0.1.39
ii  python3-debianbts   3.1.0
ii  python3-distro-info 1.0
ii  python3-httplib20.18.1-3
ii  python3-launchpadlib1.10.13-1
ii  python3-lazr.restfulclient  0.14.2-2
ii  python3-ubuntutools 0.180
ii  sensible-utils  0.0.14
ii  sudo1.9.5p2-2
ii  tzdata  2021a-1

Versions of packages ubuntu-dev-tools recommends:
pn  arch-test
pn  bzr | brz
pn  bzr-builddeb | brz-debian
ii  ca-certificates  20210119
ii  cowbuilder   0.89
ii  debian-archive-keyring   2019.1
ii  debian-keyring   2020.12.24
ii  debootstrap  1.0.123
pn  genisoimage  
ii  lintian  2.104.0
ii  patch2.7.6-7
ii  pbuilder 0.231
pn  python3-dns  
ii  quilt0.66-2.1
ii  reportbug7.10.2
ii  sbuild   0.81.2
ii  ubuntu-keyring [ubuntu-archive-keyring]  2018.09.18.1-5

Versions of packages ubuntu-dev-tools suggests:
ii  qemu-user-static  1:5.2+dfsg-6

- -- no debconf information

-BEGIN PGP SIGNATURE-

iQKTBAEBCgB9FiEEw2Gx4wKVQ+vGJel9g3Kkd++uWcIFAmA+A6tfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEMz
NjFCMUUzMDI5NTQzRUJDNjI1RTk3RDgzNzJBNDc3RUZBRTU5QzIACgkQg3Kkd++u
WcI5FRAAhgermZ2PciOMzJhp3Q+CYFGo2RQe7sJgyrEr6AsBFRH+Fu5xjvud6Y4c
KWLzYepu52JCjRPFKC9NTo6cMoAbjOHeX+gTepgoHHbfkMfbU66RKZYjp6OAABF5
wGWdQVDSA8myCxTADgu92QgkO+FP81bZbDlOZqQ4s2iLsqlYE4JAYlXBgoHHggmh
3XTvDWdxG6x2OhkEJaOyg7FGtXX87ijdGrjCRtzI2eHkdQKcBBKgOQDsQn/8GX/Y
j/wNvu38d2iE+R+ykTgCAfxqAGti3vvOTbKbPbwljVooXuYwggKy+Dpcztz4Z6x/
DLYrbmyT5LJTHSBeWc4J7IbETZqBGttU4SK2hwVOGD3WNt7ZKttbz2A4OfNcImEy
dwxgFaZMFAabb+Cyyw0lOIjCa192HI5brpS7gDl0tV38cnYyxaAsOpcf50ql/aVf
xBhlcNjhdyarJ/dApbwfZxw6R4D/fRLWmhJcGLzl0cbDdVNyXYuvIZQUkMQculgm
q9gGtA2hEFLoHThVfxTP9xQW+ficbvVJiAurchKozzL9UzCVg8GmEwaGIWtOuCtm
hV0VkHsZZBG3ypSQznkKedu7zQ8ZLVhx2rMr4h66yUHOeaJ966DWi6+nHL3ESvNM
Nmz13wLyV58bGhzowRA9gtigEoPA/STEEmTBHvoRjCDt0QTtEBU=
=sJI+
-END PGP SIGNATURE-