Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2
Hi Aron, On 30-03-2021 10:01, Aron Xu wrote: > I have reverted 3, and attached is the new debdiff. This looks wrong, no? +# only automatically trim the nvme-only pools. +POOLS=$(zpool list -H | awk '{print $1}') +for pool in ${ZPOOLS[@]}; do Variable is named POOLS, not ZPOOLS. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2
Hi, On Tue, Mar 30, 2021 at 4:17 AM Paul Gevers wrote: > [...] > > > 3. Add new debconf questions, for the cron jobs of pool scrub and trim, with > >translation updates from debian-i18n people. > > But here, I think there's a serious issue. You seem to be querying the > debconf database during cron jobs, but debconf is not a registry. This > is not acceptable. Lintian warns about this too: > https://lintian.debian.org/tags/debconf-is-not-a-registry.html > > I suggest you prepare an upload with 1 and 2. I don't feel comfortable > with 3, even if you fix the debconf-is-not-a-registry issue. > I have reverted 3, and attached is the new debdiff. Thanks for the comments! Cheers, Aron zfs-linux_2.0.3-2.debdiff.gz Description: application/gzip
Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2
Control: tags -1 moreinfo Hi Aron On 20-03-2021 15:04, Aron Xu wrote: > Please pre-approve unblock package zfs-linux/2.0.3-2. > > This revision is mainly consisted of the following enhancements: > > 1. Cherry-pick of upstream changes after 2.0.3, which is a subset of 2.0.4 > with >irrelevant linux 5.12 compat and other stuff removed, making it a pure bug >fix update; This looks OK. > 2. Fixed update failure from buster-bpo (#983401); This too. > 3. Add new debconf questions, for the cron jobs of pool scrub and trim, with >translation updates from debian-i18n people. But here, I think there's a serious issue. You seem to be querying the debconf database during cron jobs, but debconf is not a registry. This is not acceptable. Lintian warns about this too: https://lintian.debian.org/tags/debconf-is-not-a-registry.html I suggest you prepare an upload with 1 and 2. I don't feel comfortable with 3, even if you fix the debconf-is-not-a-registry issue. Paul OpenPGP_signature Description: OpenPGP digital signature
Bug#985590: (pre-approval) unblock: zfs-linux/2.0.3-2
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Dear release team, Please pre-approve unblock package zfs-linux/2.0.3-2. This revision is mainly consisted of the following enhancements: 1. Cherry-pick of upstream changes after 2.0.3, which is a subset of 2.0.4 with irrelevant linux 5.12 compat and other stuff removed, making it a pure bug fix update; 2. Fixed update failure from buster-bpo (#983401); 3. Add new debconf questions, for the cron jobs of pool scrub and trim, with translation updates from debian-i18n people. Regards, Aron Xu zfs-linux_2.0.3-2.debdiff.gz Description: application/gzip signature.asc Description: PGP signature