Bug#986908: unblock: snort 2.9.15.1-5

[Jan Wagner]

Control: tags -1 - moreinfo

Hi there,

Am 22.04.21 um 11:03 schrieb Javier Fernandez-Sanguino:


On Mon, 19 Apr 2021 at 23:24, Chris Hofstaedtler > wrote:


 > $ debdiff snort_2.9.15.1-4_i386.deb snort_2.9.15.1-5_i386.deb
[..]

The debdiff does not seem to show any actual packaging changes. Are
you sure you diffed the correct files?


Apologies, I sent a debdiff of the binary packages. I will send a 
debdiff of the source packages soon.


here is the debdiff between 2.9.15.1-4 and 2.9.15.1-5.

Cheers, Jan.
--
Never write mail to , you have been warned!
-BEGIN GEEK CODE BLOCK-
Version: 3.12
GIT d-- s+: a C+++ UL P+ L+++ E--- W+++ N+++ o++ K++ w--- O M+ V- PS 
PE Y++

PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h r+++ y
--END GEEK CODE BLOCK--
diff -Nru snort-2.9.15.1/debian/changelog snort-2.9.15.1/debian/changelog
--- snort-2.9.15.1/debian/changelog 2020-12-06 17:23:14.0 +0100
+++ snort-2.9.15.1/debian/changelog 2021-04-10 22:55:04.0 +0200
@@ -1,3 +1,30 @@
+snort (2.9.15.1-5) unstable; urgency=medium
+
+  * debian/snort-common.{preinst,postinst,postrm}:
+- Handle using dpkg-maintscript-helper mv_conffile the relocation
+  of the cronjob /etc/cron.daily/5snort to /etc/cron.daily/snort-common
+  instead of moving it manually to prevent dpkg from prompting the
+  user upon upgrades from older snort version. Thank you
+  Chris Hofstaedtler for the tip (Closes: #984614)
+  * debian/control: Add  Pre-Depends: dpkg (>= 1.17.14) as we
+are now using dpkg-maintscript-helper
+  * debian/snort-common.{postrm,preinst},
+debian/snort.{postinst,postrm,preinst,prerm}:
+Add DEBIAN_SCRIPT_DEBUG to all maintainer scripts
+  * debian/snort.logrotate: Correct name of the alert files (snort.alert
+and not 'alert') this error prevented files from being properly
+logrotated
+  * configure.in: Added patch to check if rpc/rpc.h is required and is 
+provided by libtirpc-dev to warn Ubuntu users that libtirpc-dev is 
+required. 
+Note: not added libtirpc-dev to Build-Depends as Debian's glibc6-dev
+includes the RPC headers (LP: #1906572)
+  * debian/patches/decoding_do_not_assume_ipv4: Add patch provided by Hugh
+Davenport to not assume that all raw packets are IPv4 packets.
+(Closes: 633066)
+
+ -- Javier Fernández-Sanguino Peña   Sat, 10 Apr 2021 
22:55:04 +0200
+
 snort (2.9.15.1-4) unstable; urgency=high
 
   * debian/snort.docs, debian/snort-doc.docs debian/rules: Add README.csv and
@@ -21,6 +48,9 @@
   * debian/rules, debian/snort-common-libraries.dirs, debian/patches/config:
   Do not use multi-arch directories for the Snort libraries, instead, locate 
all
   of the compiled under libraries /usr/lib/snort  (Closes: #962275)
+  This fixes the error "FATAL ERROR: /etc/snort/snort.conf(271) Could not stat
+  dynamic module path "/usr/lib/i386-linux-gnu/snort_dynamicpreprocessor/": No
+  such file or directory" (LP: #1901466, #1902405, #1905164)
   * debian/rules: Drop configure options which are not anymore relevant
   * debian/po: 
 - Update Dutch translation, thanks to Frans Spiesschaert (Closes: #961214)
@@ -101,7 +131,8 @@
 (LP: #1570517, #1484733, #1398969, #1310182, #1273021, #1231833)
 (LP: #1222754, #1215408, #1207981, #1207237, #1181514, #1175892)
 (LP: #1175264, #1161358, #1158169, #1116013, #1065121, #1064478)
-(LP: #1061459, #1031917)
+(LP: #1061459, #1031917, #1905137, #1897344, #1896849, #1882601)
+(LP: #1881141, #1877638)
   - Add also debugging messages as, based on the number of reports in
 Ubuntu, there seems to be many cases where the users install the
 package (with high debconf priority) and the proper network interface
diff -Nru snort-2.9.15.1/debian/control snort-2.9.15.1/debian/control
--- snort-2.9.15.1/debian/control   2020-12-06 17:23:14.0 +0100
+++ snort-2.9.15.1/debian/control   2021-04-10 22:55:04.0 +0200
@@ -65,7 +65,7 @@
 
 Package: snort-common
 Architecture: all
-Pre-Depends: adduser (>= 3.11), ${misc:Pre-Depends}
+Pre-Depends: adduser (>= 3.11), dpkg (>= 1.17.14), ${misc:Pre-Depends}
 Depends: 
 perl, 
 debconf (>= 0.2.80) | debconf-2.0,
diff -Nru snort-2.9.15.1/debian/patches/decoding_do_not_assume_ipv4 
snort-2.9.15.1/debian/patches/decoding_do_not_assume_ipv4
--- snort-2.9.15.1/debian/patches/decoding_do_not_assume_ipv4   1970-01-01 
01:00:00.0 +0100
+++ snort-2.9.15.1/debian/patches/decoding_do_not_assume_ipv4   2021-04-10 
22:55:04.0 +0200
@@ -0,0 +1,48 @@
+Description: Do not assume IPv4 packets when decoding
+ When using Snort on a interface without a link level layer, for example a
+ AIYIA tunnel for IPv6 through SixXs, then snort assumes that the packets will
+ be IPv4. I have a patch that adds a check on the IP version number in the
+ header, and if it is not an IPv4 packet, try decoding as IPv6.
+.
+ Without this 

Bug#986908: unblock: snort 2.9.15.1-5

[Javier Fernandez-Sanguino]

On Mon, 19 Apr 2021 at 23:24, Chris Hofstaedtler  wrote:

> > $ debdiff snort_2.9.15.1-4_i386.deb snort_2.9.15.1-5_i386.deb
> [..]
>
> The debdiff does not seem to show any actual packaging changes. Are
> you sure you diffed the correct files?
>

Apologies, I sent a debdiff of the binary packages. I will send a debdiff
of the source packages soon.

Best regards

Javier

Bug#986908: unblock: snort 2.9.15.1-5

[Graham Inggs]

Control: tags -1 + moreinfo

Hi Javier

On Mon, 19 Apr 2021 at 23:27, Chris Hofstaedtler  wrote:
>
> > $ debdiff snort_2.9.15.1-4_i386.deb snort_2.9.15.1-5_i386.deb
> [..]
>
> The debdiff does not seem to show any actual packaging changes. Are
> you sure you diffed the correct files?

This looks like a binary debdiff, not a source debdiff.

Regards
Graham

Bug#986908: unblock: snort 2.9.15.1-5

[Chris Hofstaedtler]

> $ debdiff snort_2.9.15.1-4_i386.deb snort_2.9.15.1-5_i386.deb
[..]

The debdiff does not seem to show any actual packaging changes. Are
you sure you diffed the correct files?

Chris

Bug#986908: unblock: snort 2.9.15.1-5

[Javier Fernández-Sanguino Peña]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Could it be possible to unblock snort 2.9.15.1-5? 

[Reason]

This version fixes a RC bug (#984614) that generated a dpkg prompt when users
where upgrading from older versions. It also fixes three additional bugs:

- a bug that prevents Snort log files from being rotated properly (discovered
  during testing, not reported in BTS)
- a bug fixing issues when building the package (LP: #1906572)
- a bug fixing parsing of network packets (633066)

[ Impact ] 

There is minimal impact by the above changes.

[ Tests ]

Package upgrades/downgrades have been tested in several chroots and the 
bugs are confirmed as fixed.

[ Risks ]

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


[ Other info ]

Hopefully this request can be accepted! 

unblock snort/2.9.15.1-5


Best regards

Javier

$ debdiff snort_2.9.15.1-4_i386.deb snort_2.9.15.1-5_i386.deb
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Depends: snort-common-libraries (>= [-2.9.15.1-4),-] {+2.9.15.1-5),+} 
snort-rules-default (>= [-2.9.15.1-4),-] {+2.9.15.1-5),+} snort-common (>= 
[-2.9.15.1-4),-] {+2.9.15.1-5),+} debconf (>= 0.5) | debconf-2.0, rsyslog | 
system-log-daemon, logrotate, net-tools, lsb-base, libc6 (>= 2.30), libdaq2 (>= 
2.0.7), libdumbnet1 (>= 1.8), liblzma5 (>= 5.1.1alpha+20120614), 
libnetfilter-queue1, libnghttp2-14 (>= 1.5.0), libpcap0.8 (>= 1.0.0), libpcre3, 
libssl1.1 (>= 1.1.0), zlib1g (>= 1:1.1.4)
Version: [-2.9.15.1-4-] {+2.9.15.1-5+}

$ debdiff snort-common_2.9.15.1-4_all.deb snort-common_2.9.15.1-5_all.deb 
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Conflicts: snort (<< [-2.9.15.1-4)-] {+2.9.15.1-5)+}
Installed-Size: [-519-] {+522+}
Pre-Depends: adduser (>= [-3.11)-] {+3.11), dpkg (>= 1.17.14)+}
Version: [-2.9.15.1-4-] {+2.9.15.1-5+}

$ debdiff snort-rules-default_2.9.15.1-4_all.deb 
snort-rules-default_2.9.15.1-5_all.deb 
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Version: [-2.9.15.1-4-] {+2.9.15.1-5+}

$ debdiff snort-doc_2.9.15.1-4_all.deb snort-doc_2.9.15.1-5_all.deb
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Version: [-2.9.15.1-4-] {+2.9.15.1-5+}

$ debdiff snort-common-libraries_2.9.15.1-4_i386.deb  
snort-common-libraries_2.9.15.1-5_i386.deb 
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/39/3558c32ca8d48f3de5673db0496869cb112938.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/40/e94d0baaefe540c618da94eb888f032c5a1f79.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/c6/49b10979e88a857a4e42b1f78b5c9352a094a3.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/c6/61fc7794c21ed0211a17cf762d1e62f9ff618f.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/cf/523d1c167cb54f099cce54ecd8ddc37ca53e09.debug

Files in first .deb but not in second
-
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/34/c8e8ca361a44fdaa05ca46235585f7342d8999.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/78/5f93750fd367fa5b29b45a8a31347224722498.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/d4/e19c810ddefba362805ecb2f24bfbd064c2367.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/ea/2ad91c60e90e48f59ed33e31b2be14b26f425e.debug
-rw-r--r--  root/root   
/usr/lib/debug/.build-id/ff/24c75759a1335e9247f00279ded2ea0fd03c8f.debug

Control files: lines which differ (wdiff format)

Build-Ids: [-34c8e8ca361a44fdaa05ca46235585f7342d8999 
785f93750fd367fa5b29b45a8a31347224722498 
d4e19c810ddefba362805ecb2f24bfbd064c2367 
ea2ad91c60e90e48f59ed33e31b2be14b26f425e 
ff24c75759a1335e9247f00279ded2ea0fd03c8f-] 
{+393558c32ca8d48f3de5673db0496869cb112938 
40e94d0baaefe540c618da94eb888f032c5a1f79 
c649b10979e88a857a4e42b1f78b5c9352a094a3 
c661fc7794c21ed0211a17cf762d1e62f9ff618f 
cf523d1c167cb54f099cce54ecd8ddc37ca53e09+}
Depends: snort (= [-2.9.15.1-4)-] {+2.9.15.1-5)+}
Installed-Size: [-2309-] {+2308+}
Version: [-2.9.15.1-4-] {+2.9.15.1-5+}

$ debdiff snort-common-libraries_2.9.15.1-4_i386.deb  
snort-common-libraries_2.9.15.1-5_i386.deb 
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)

Installed-Size: [-4832-] {+5027+}