Bug#988204: [pkg-apparmor] Bug#988204: Improved patch

2022-07-06 Thread intrigeri
Hi,

intrigeri (2022-02-13):
> Alistair J R Young (2022-02-12):
>>> So yeah, Alistair, please submit your last patch a merge request upstream, 
>>> as
>>> Christian suggested :)
>>
>> I've done this now and it has been merged:
>>
>> https://gitlab.com/apparmor/apparmor/-/merge_requests/812
>
> Awesome, thanks!

FTR I've submitted a tiny follow-up MR:

  https://gitlab.com/apparmor/apparmor/-/merge_requests/896

Since you authored the code I'm modifying, your review and test would
be welcome :)



Bug#988204: [pkg-apparmor] Bug#988204: Improved patch

2022-02-12 Thread intrigeri
Hi Christian,

Christian Boltz (2021-11-08):
> Your patch looks like something that should (also?) be fixed upstream.

My understanding is that the problem here is caused by a Debian patch:

https://salsa.debian.org/apparmor-team/apparmor/-/blob/debian/master/debian/patches/debian/Make-the-systemd-unit-a-no-op-in-containers-with-no-inter.patch

I could trace the history of that patch back to 2012 (2.7.102-0ubuntu3):

* debian/apparmor.init: do nothing in a container.  This can be
  removed once stacked profiles are supported and used by lxc.
  (LP: #978297)

So I believe upstream is not affected, because it'll try to load the
AppArmor policy even inside the kind of containers where it will fail
(that is, most kinds).

I'm going to drop this patch in Debian, which should fix the problem
this bug report is about, because:

 - As we can see here, this patch causes trouble in some environments.

 - Most container technologies I'm aware of are closer to application
   containers than system containers, and are not going to start the
   whole pile of systemd units, so the patch does not matter there.
   LXC is the only exception I'm aware of.

 - The fact other distros did not need to apply such a patch suggests
   it's not necessary for most use cases.

 - I don't have any time/energy/motivation anymore to maintain or
   upstream myself patches that were initially created as part of the
   Ubuntu delta to meet Canonical's strategic goals & deadlines, and
   never pushed upstream. I'm still immensely grateful by the work
   done upstream by Canonical employees, though!

If removing the patch causes trouble for some sort of LXC containers
(there are multiple ways they can or cannot handle AppArmor, depending
on versions, system configuration, per-container configuration, I lost
track), I'll report this upstream and hopefully a LXC-friendly
solution will be implemented there by those of us who particularly
care about LXC :)

Cheers!



Bug#988204: [pkg-apparmor] Bug#988204: Improved patch

2021-11-08 Thread Christian Boltz
Hello,

Am Montag, 8. November 2021, 20:53:01 CET schrieb Alistair J R Young:
> An improved patch for this issue follows, in accordance with the above
> thread:
> 
> --- rc.apparmor.functions   2021-11-08 13:27:06.461249682 -0600
> +++ rc.apparmor.functions   2021-11-08 13:30:05.766141212 -0600

Your patch looks like something that should (also?) be fixed upstream.

May I ask you to submit a MR at https://gitlab.com/apparmor/apparmor/ ?
(If you don't want to do the upstreaming for whatever reason, I can 
forward your patch - but usually it's better to avoid a "relay" ;-)


Regards,

Christian Boltz
-- 
Hmmm I think I hear steve yelling something about a unit test,
but he is on vacation so I'll just ignore him for now ;)
[John Johansen in apparmor]


signature.asc
Description: This is a digitally signed message part.