Bug#988968: unblock: e17/0.24.2-6
Control: tags -1 - moreinfo
On Tue, May 25, 2021 at 09:12:37AM +0200, Sebastian Ramacher wrote:
> Control: tags -1 moreinfo
>
> On 2021-05-22 08:39:18 -0700, Ross Vandegrift wrote:
> > Control: tags -1 - moreinfo
> >
> > Hello,
> >
> > On Sat, May 22, 2021 at 09:53:26AM +0200, Sebastian Ramacher wrote:
> > > Control: tags -1 moreinfo
> > >
> > > On 2021-05-21 22:23:20 -0700, Ross Vandegrift wrote:
> > > > Package: release.debian.org
> > > > Severity: normal
> > > > User: release.debian@packages.debian.org
> > > > Usertags: unblock
> > > > X-Debbugs-Cc: rvandegr...@debian.org
> > > >
> > > > Please unblock package e17
> > > >
> > > > [ Reason ]
> > > >
> > > > 0.24.2-6 recommends libddcutil2, which has been replaced by
> > > > libddcutil3.
> > > >
> > > > [ Impact ]
> > > >
> > > > A non-existant package will be recommended. Backlight controls for
> > > > external monitors won't work unless the user tries libddcutil3.
> > > >
> > > > [ Tests ]
> > > >
> > > > There are no automated tests. I have used libddcutil3 without
> > > > regression
> > > > since uploading the change.
> > >
> > > Are you sure?
> > >
> > > /tmp/e17-0.24.2%% rgrep ddcutil\.so
> > > src/bin/system/e_system_ddc.c: ddc_lib = dlopen("libddcutil.so.2",
> > > RTLD_NOW | RTLD_LOCAL);
> > >
> > > I don't see libddcutil.so.3 used anywhere.
> >
> > No, I'm not sure anymore - I must've messed up. Apologies!
> >
> > Upstream git after 0.24.2 has a patch to support libddcutil3. There may
> > not be
> > time for testing + migration before release. But if there were, would the
> > below patch be acceptable during freeze?
>
> Yes. Please remove the moreinfo tag once the version with that patch is
> available in unstable.
Thanks - I confirmed the fix works and 0.24.2-8 has been uploaded to unstable.
Thanks,
Ross
signature.asc
Description: PGP signature
Bug#988968: unblock: e17/0.24.2-6
Control: tags -1 moreinfo
On 2021-05-22 08:39:18 -0700, Ross Vandegrift wrote:
> Control: tags -1 - moreinfo
>
> Hello,
>
> On Sat, May 22, 2021 at 09:53:26AM +0200, Sebastian Ramacher wrote:
> > Control: tags -1 moreinfo
> >
> > On 2021-05-21 22:23:20 -0700, Ross Vandegrift wrote:
> > > Package: release.debian.org
> > > Severity: normal
> > > User: release.debian@packages.debian.org
> > > Usertags: unblock
> > > X-Debbugs-Cc: rvandegr...@debian.org
> > >
> > > Please unblock package e17
> > >
> > > [ Reason ]
> > >
> > > 0.24.2-6 recommends libddcutil2, which has been replaced by libddcutil3.
> > >
> > > [ Impact ]
> > >
> > > A non-existant package will be recommended. Backlight controls for
> > > external monitors won't work unless the user tries libddcutil3.
> > >
> > > [ Tests ]
> > >
> > > There are no automated tests. I have used libddcutil3 without regression
> > > since uploading the change.
> >
> > Are you sure?
> >
> > /tmp/e17-0.24.2%% rgrep ddcutil\.so
> > src/bin/system/e_system_ddc.c: ddc_lib = dlopen("libddcutil.so.2",
> > RTLD_NOW | RTLD_LOCAL);
> >
> > I don't see libddcutil.so.3 used anywhere.
>
> No, I'm not sure anymore - I must've messed up. Apologies!
>
> Upstream git after 0.24.2 has a patch to support libddcutil3. There may not
> be
> time for testing + migration before release. But if there were, would the
> below patch be acceptable during freeze?
Yes. Please remove the moreinfo tag once the version with that patch is
available in unstable.
Cheers
>
> Thanks,
> Ross
>
>
> commit ead43c40c36bb4f74426a8b1ca4418952e338ac1
> Author: Carsten Haitzler
> Date: Tue Aug 18 12:06:43 2020 +0100
>
> ddc - add libddcutil.so.3 as supported as it is compatible for our uses
>
> diff --git a/src/bin/system/e_system_ddc.c b/src/bin/system/e_system_ddc.c
> index 2d57b3bac..74d48dd56 100644
> --- a/src/bin/system/e_system_ddc.c
> +++ b/src/bin/system/e_system_ddc.c
> @@ -302,7 +302,11 @@ err:
> static Eina_Bool
> _ddc_init(void)
> {
> - ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW | RTLD_LOCAL);
> + // .so.3 is ABI compatible twith .so.2 for out uses - see
> + // https://www.ddcutil.com/c_api_99/ for changes between them
> + ddc_lib = dlopen("libddcutil.so.3", RTLD_NOW | RTLD_LOCAL);
> + if (!ddc_lib)
> + ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW | RTLD_LOCAL);
> if (!ddc_lib) return EINA_FALSE;
> #define SYM(_x) \
> do { \
--
Sebastian Ramacher
signature.asc
Description: PGP signature
Bug#988968: unblock: e17/0.24.2-6
Control: tags -1 - moreinfo
Hello,
On Sat, May 22, 2021 at 09:53:26AM +0200, Sebastian Ramacher wrote:
> Control: tags -1 moreinfo
>
> On 2021-05-21 22:23:20 -0700, Ross Vandegrift wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian@packages.debian.org
> > Usertags: unblock
> > X-Debbugs-Cc: rvandegr...@debian.org
> >
> > Please unblock package e17
> >
> > [ Reason ]
> >
> > 0.24.2-6 recommends libddcutil2, which has been replaced by libddcutil3.
> >
> > [ Impact ]
> >
> > A non-existant package will be recommended. Backlight controls for
> > external monitors won't work unless the user tries libddcutil3.
> >
> > [ Tests ]
> >
> > There are no automated tests. I have used libddcutil3 without regression
> > since uploading the change.
>
> Are you sure?
>
> /tmp/e17-0.24.2%% rgrep ddcutil\.so
> src/bin/system/e_system_ddc.c: ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW
> | RTLD_LOCAL);
>
> I don't see libddcutil.so.3 used anywhere.
No, I'm not sure anymore - I must've messed up. Apologies!
Upstream git after 0.24.2 has a patch to support libddcutil3. There may not be
time for testing + migration before release. But if there were, would the
below patch be acceptable during freeze?
Thanks,
Ross
commit ead43c40c36bb4f74426a8b1ca4418952e338ac1
Author: Carsten Haitzler
Date: Tue Aug 18 12:06:43 2020 +0100
ddc - add libddcutil.so.3 as supported as it is compatible for our uses
diff --git a/src/bin/system/e_system_ddc.c b/src/bin/system/e_system_ddc.c
index 2d57b3bac..74d48dd56 100644
--- a/src/bin/system/e_system_ddc.c
+++ b/src/bin/system/e_system_ddc.c
@@ -302,7 +302,11 @@ err:
static Eina_Bool
_ddc_init(void)
{
- ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW | RTLD_LOCAL);
+ // .so.3 is ABI compatible twith .so.2 for out uses - see
+ // https://www.ddcutil.com/c_api_99/ for changes between them
+ ddc_lib = dlopen("libddcutil.so.3", RTLD_NOW | RTLD_LOCAL);
+ if (!ddc_lib)
+ ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW | RTLD_LOCAL);
if (!ddc_lib) return EINA_FALSE;
#define SYM(_x) \
do { \
signature.asc
Description: PGP signature
Bug#988968: unblock: e17/0.24.2-6
Control: tags -1 moreinfo
On 2021-05-21 22:23:20 -0700, Ross Vandegrift wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: rvandegr...@debian.org
>
> Please unblock package e17
>
> [ Reason ]
>
> 0.24.2-6 recommends libddcutil2, which has been replaced by libddcutil3.
>
> [ Impact ]
>
> A non-existant package will be recommended. Backlight controls for external
> monitors won't work unless the user tries libddcutil3.
>
> [ Tests ]
>
> There are no automated tests. I have used libddcutil3 without regression
> since uploading the change.
Are you sure?
/tmp/e17-0.24.2%% rgrep ddcutil\.so
src/bin/system/e_system_ddc.c: ddc_lib = dlopen("libddcutil.so.2", RTLD_NOW |
RTLD_LOCAL);
I don't see libddcutil.so.3 used anywhere.
Cheers
>
> [ Risks ]
>
> Low risk - e17 only builds leaf packages and the change is trivial.
>
> [ Checklist ]
> [x] all changes are documented in the d/changelog
> [x] I reviewed all changes and I approve them
> [x] attach debdiff against the package in testing
>
> [ Other info ]
>
> unblock e17/0.24.2-7
> diff -Nru e17-0.24.2/debian/changelog e17-0.24.2/debian/changelog
> --- e17-0.24.2/debian/changelog 2021-01-01 14:29:49.0 -0800
> +++ e17-0.24.2/debian/changelog 2021-05-02 22:02:56.0 -0700
> @@ -1,3 +1,10 @@
> +e17 (0.24.2-7) unstable; urgency=medium
> +
> + * d/control: Recommend libddcutil3 instead of libddcutil2 which isn't in
> +bullseye
> +
> + -- Ross Vandegrift Sun, 02 May 2021 22:02:56 -0700
> +
> e17 (0.24.2-6) unstable; urgency=medium
>
>* Recommend libddcutil2 and update NEWS with backlight control info
> diff -Nru e17-0.24.2/debian/control e17-0.24.2/debian/control
> --- e17-0.24.2/debian/control 2021-01-01 14:07:17.0 -0800
> +++ e17-0.24.2/debian/control 2021-05-02 21:57:47.0 -0700
> @@ -51,7 +51,7 @@
> acpid,
> bc,
> bluez,
> - libddcutil2,
> + libddcutil3,
> libevas-loaders,
> packagekit,
> terminology | x-terminal-emulator,
--
Sebastian Ramacher
signature.asc
Description: PGP signature
Bug#988968: unblock: e17/0.24.2-6
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock X-Debbugs-Cc: rvandegr...@debian.org Please unblock package e17 [ Reason ] 0.24.2-6 recommends libddcutil2, which has been replaced by libddcutil3. [ Impact ] A non-existant package will be recommended. Backlight controls for external monitors won't work unless the user tries libddcutil3. [ Tests ] There are no automated tests. I have used libddcutil3 without regression since uploading the change. [ Risks ] Low risk - e17 only builds leaf packages and the change is trivial. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] unblock e17/0.24.2-7 diff -Nru e17-0.24.2/debian/changelog e17-0.24.2/debian/changelog --- e17-0.24.2/debian/changelog 2021-01-01 14:29:49.0 -0800 +++ e17-0.24.2/debian/changelog 2021-05-02 22:02:56.0 -0700 @@ -1,3 +1,10 @@ +e17 (0.24.2-7) unstable; urgency=medium + + * d/control: Recommend libddcutil3 instead of libddcutil2 which isn't in +bullseye + + -- Ross Vandegrift Sun, 02 May 2021 22:02:56 -0700 + e17 (0.24.2-6) unstable; urgency=medium * Recommend libddcutil2 and update NEWS with backlight control info diff -Nru e17-0.24.2/debian/control e17-0.24.2/debian/control --- e17-0.24.2/debian/control 2021-01-01 14:07:17.0 -0800 +++ e17-0.24.2/debian/control 2021-05-02 21:57:47.0 -0700 @@ -51,7 +51,7 @@ acpid, bc, bluez, - libddcutil2, + libddcutil3, libevas-loaders, packagekit, terminology | x-terminal-emulator,
