Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hello Leo, > Just pushed to the main repo. Please take a look and let me know if it works! It works nicely! I have committed a few more changes, pushed it and uploaded the package. I noticed you didn't add yourself to the Uploaders field and I didn't do it because I didn't know if you wanted that. But please feel free to do so if that's your intention. Thank you! -- Samuel Henrique
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
On Tue, Sep 28, 2021 at 12:27 AM Samuel Henrique wrote: > I gave you permission to that repo (best I can do on my side), and I > set an expiration date of the end of this year, until then you will > end up in the salsa group and inherit permissions so it should be > good. Perfect, thanks! > Awesome, I can do that. Alternatively, I can also push your changes > myself, if you push them to your own repo and give me a go ahead. Just pushed to the main repo. Please take a look and let me know if it works! Cheers
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hello Leo, > On Fri, Sep 24, 2021 at 10:07 PM Samuel Henrique wrote: > > Leo, from my side you're free to push your changes whenever you want. > > I will as soon as someone gives me access to the repo ;) > Just requested access to the Gnome group, but that may take a while. I gave you permission to that repo (best I can do on my side), and I set an expiration date of the end of this year, until then you will end up in the salsa group and inherit permissions so it should be good. > > Let's try to coordinate things, feel free to perform changes to the > > packaging, I will wait until I get your ack to go ahead (if there's > > any work left to be done). > > I'm not a gnome-extension expert, so I'll push my changes so that the > package is at least gpb-buildable, and you can then maybe check that > the build makes sense and upload it yourself if you want. Awesome, I can do that. Alternatively, I can also push your changes myself, if you push them to your own repo and give me a go ahead. Thank you! -- Samuel Henrique
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
On Fri, Sep 24, 2021 at 10:07 PM Samuel Henrique wrote: > Leo, from my side you're free to push your changes whenever you want. I will as soon as someone gives me access to the repo ;) Just requested access to the Gnome group, but that may take a while. > Let's try to coordinate things, feel free to perform changes to the > packaging, I will wait until I get your ack to go ahead (if there's > any work left to be done). I'm not a gnome-extension expert, so I'll push my changes so that the package is at least gpb-buildable, and you can then maybe check that the build makes sense and upload it yourself if you want. Cheers Leo
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hello all, > Both upstream and pristine-tar branches look clean (do not branch from > master) and we can keep the repo's history. > > Jonathan, Samual, does that seem ok to you? > Unfortunately the branch-creation involved in the process can't really > be proposed via MR, so if this seems ok, one of us would have to "just > do it" ;) It's looking good to me. Since the previous commits are still kept, I believe we can go ahead with this approach before Jonathan's ack, he's probably busy and I think it's safe to assume he will be fine with it (especially since the history gets preserved). Leo, from my side you're free to push your changes whenever you want. Let's try to coordinate things, feel free to perform changes to the packaging, I will wait until I get your ack to go ahead (if there's any work left to be done). Thank you! -- Samuel Henrique
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
On Tue, 21 Sep 2021 19:57:39 +0100 Samuel Henrique wrote: > Awesome, I was trying to add the upstream and pristine-tar branches to > the repo but it's not looking good so far. I think I managed to convert it to a gbp project successfully. Take a look here: https://salsa.debian.org/costela/gnome-shell-extension-system-monitor Basic steps (in a freshly cloned salsa repo): git checkout --orphan upstream git rm -rf . git commit --allow-empty -m 'initial upstream commit' git checkout -f master gbp import-orig ../ gbp dch Both upstream and pristine-tar branches look clean (do not branch from master) and we can keep the repo's history. Jonathan, Samual, does that seem ok to you? Unfortunately the branch-creation involved in the process can't really be proposed via MR, so if this seems ok, one of us would have to "just do it" ;) Cheers, Leo
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hello Jonathan, > Yes please go ahead, you're very welcome, feel free to add yourself as > an uploader too if you'd like. Awesome, I was trying to add the upstream and pristine-tar branches to the repo but it's not looking good so far. Would you be ok with me resetting the git repo with "gbp import-dscs --debsnap gnome-shell-extension-system-monitor" and working on top of that? We would lose the previous commits but I believe it will make contributions easier in the long run. Thank you! -- Samuel Henrique
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hi Samuel On 2021/09/19 20:47, Samuel Henrique wrote: I'd like to update this package to the latest upstream version in order to support Gnome 40 over the next few days. I'm also planning to push the pristine-tar and upstream branches[0], as well as adding the upstream code to the master branch, and adding myself as an Uploader (so that gbp can build it without extra steps). Please let me know if you'd prefer to keep things the way they are or would like me to only do some of those things. Yes please go ahead, you're very welcome, feel free to add yourself as an uploader too if you'd like. -Jonathan
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Hello Jonathan, I'd like to update this package to the latest upstream version in order to support Gnome 40 over the next few days. I'm also planning to push the pristine-tar and upstream branches[0], as well as adding the upstream code to the master branch, and adding myself as an Uploader (so that gbp can build it without extra steps). Please let me know if you'd prefer to keep things the way they are or would like me to only do some of those things. Thank you! [0] Though I will probably push only the latest release to these branches. -- Samuel Henrique
Bug#993198: gnome-shell-extension-system-monitor: does not declare compatibility with GNOME Shell 40
Package: gnome-shell-extension-system-monitor Version: 38+git20200414-32cc79e-1 Severity: important Tags: fixed-upstream The metadata.json for this extension doesn't declare compatibility with GNOME 40. This seems to have been fixed in upstream git, along with preferences UI changes to make it work in GNOME 40. In many versions of GNOME Shell this didn't matter much, because validation of extensions' metadata against the installed Shell version was disabled by default, but in GNOME 40 the default has changed back to enabling the version check by default, in an effort to avoid issues caused by outdated extensions remaining enabled. When we do the GNOME 40 transition, hopefully soon, we will have to either update this extension or remove it from testing. It would be useful to get a fixed version into experimental. Would you mind adding the GNOME team to Uploaders so we can "officially" do team-uploads? I think that'd be useful for future transitions. Thanks, smcv
