Bug#993958: apt: Unnecessarily provide empty dir /lib/systemd/

2021-10-15 Thread Boyuan Yang
Control: close 993958

It seems that debhelper/13.5.2 has reverted related changes. Closing this bug
report until a real merged-user solution is implemented.

Thanks,
Boyuan Yang

On Wed, 08 Sep 2021 12:10:34 -0400 Boyuan Yang  wrote:
> Package: apt
> Severity: normal
> Version: 2.3.9
> X-Debbugs-CC: j...@debian.org
> 
> Dear Debian APT Maintainers,
> 
> % dpkg -c ./apt_2.3.9_amd64.deb | grep systemd    
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./lib/systemd/
> -rwxr-xr-x root/root 16029 2021-09-07 11:25
> ./usr/lib/apt/apt.systemd.daily
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/system/
> -rw-r--r-- root/root   389 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily-upgrade.service
> -rw-r--r-- root/root   184 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily-upgrade.timer
> -rw-r--r-- root/root   326 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily.service
> -rw-r--r-- root/root   156 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily.timer
> 
> 
> Since systemd system services are now installed under /usr/lib/systemd,
> obviously we do not need to provide the empty directory /lib/systemd/
anymore.
> The systemd binary package always provides it instead. Please consider
> revising the build system and do not generate /lib/systemd/ directory in the
> .deb file.


signature.asc
Description: This is a digitally signed message part


Bug#993958: apt: Unnecessarily provide empty dir /lib/systemd/

2021-09-08 Thread Niels Thykier
Control: reassign -1 debhelper
Control: affects -1 apt


Hi,

This looks more like a bug in debhelper than anything else.  Reassigning.

On Wed, 08 Sep 2021 12:10:34 -0400 Boyuan Yang  wrote:
> Package: apt
> Severity: normal
> Version: 2.3.9
> X-Debbugs-CC: j...@debian.org
> 
> Dear Debian APT Maintainers,
> 
> % dpkg -c ./apt_2.3.9_amd64.deb | grep systemd
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./lib/systemd/
> -rwxr-xr-x root/root 16029 2021-09-07 11:25
> ./usr/lib/apt/apt.systemd.daily
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/system/
> -rw-r--r-- root/root   389 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
> daily-upgrade.service
> -rw-r--r-- root/root   184 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
> daily-upgrade.timer
> -rw-r--r-- root/root   326 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
> daily.service
> -rw-r--r-- root/root   156 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
> daily.timer
> 
> 
> Since systemd system services are now installed under /usr/lib/systemd,
> obviously we do not need to provide the empty directory /lib/systemd/ anymore.
> The systemd binary package always provides it instead. Please consider
> revising the build system and do not generate /lib/systemd/ directory in the
> .deb file.
> 
> Thanks,
> Boyuan Yang



Bug#993958: apt: Unnecessarily provide empty dir /lib/systemd/

2021-09-08 Thread Boyuan Yang
Control: tags -1 +patch

I am providing a patch at
https://salsa.debian.org/apt-team/apt/-/merge_requests/186 .

A plain-text version is also provided below.

Thanks,
Boyuan Yang


From 5e7657f8fe77bb9aa247e390d430005d6c87ae98 Mon Sep 17 00:00:00 2001
From: Boyuan Yang 
Date: Wed, 8 Sep 2021 16:25:25 -0400
Subject: [PATCH] Install systemd files into /usr/lib/systemd/ (#993958)

---
 debian/apt.install | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian/apt.install b/debian/apt.install
index 3658bf5e6..6afc8c2e7 100644
--- a/debian/apt.install
+++ b/debian/apt.install
@@ -1,5 +1,5 @@
-debian/*.service /lib/systemd/system/
-debian/*.timer /lib/systemd/system/
+debian/*.service usr/lib/systemd/system/
+debian/*.timer usr/lib/systemd/system/
 debian/apt.systemd.daily usr/lib/apt
 etc/apt/
 usr/bin/apt
-- 
GitLab



On Wed, 08 Sep 2021 12:10:34 -0400 Boyuan Yang  wrote:
> Package: apt
> Severity: normal
> Version: 2.3.9
> X-Debbugs-CC: j...@debian.org
> 
> Dear Debian APT Maintainers,
> 
> % dpkg -c ./apt_2.3.9_amd64.deb | grep systemd    
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./lib/systemd/
> -rwxr-xr-x root/root 16029 2021-09-07 11:25
> ./usr/lib/apt/apt.systemd.daily
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/
> drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/system/
> -rw-r--r-- root/root   389 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily-upgrade.service
> -rw-r--r-- root/root   184 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily-upgrade.timer
> -rw-r--r-- root/root   326 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily.service
> -rw-r--r-- root/root   156 2021-09-07 11:25
./usr/lib/systemd/system/apt-
> daily.timer
> 
> 
> Since systemd system services are now installed under /usr/lib/systemd,
> obviously we do not need to provide the empty directory /lib/systemd/
anymore.
> The systemd binary package always provides it instead. Please consider
> revising the build system and do not generate /lib/systemd/ directory in the
> .deb file.
> 
> Thanks,
> Boyuan Yang



signature.asc
Description: This is a digitally signed message part


Bug#993958: apt: Unnecessarily provide empty dir /lib/systemd/

2021-09-08 Thread Boyuan Yang
Package: apt
Severity: normal
Version: 2.3.9
X-Debbugs-CC: j...@debian.org

Dear Debian APT Maintainers,

% dpkg -c ./apt_2.3.9_amd64.deb | grep systemd
drwxr-xr-x root/root 0 2021-09-07 11:25 ./lib/systemd/
-rwxr-xr-x root/root 16029 2021-09-07 11:25
./usr/lib/apt/apt.systemd.daily
drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/
drwxr-xr-x root/root 0 2021-09-07 11:25 ./usr/lib/systemd/system/
-rw-r--r-- root/root   389 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
daily-upgrade.service
-rw-r--r-- root/root   184 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
daily-upgrade.timer
-rw-r--r-- root/root   326 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
daily.service
-rw-r--r-- root/root   156 2021-09-07 11:25 ./usr/lib/systemd/system/apt-
daily.timer


Since systemd system services are now installed under /usr/lib/systemd,
obviously we do not need to provide the empty directory /lib/systemd/ anymore.
The systemd binary package always provides it instead. Please consider
revising the build system and do not generate /lib/systemd/ directory in the
.deb file.

Thanks,
Boyuan Yang


signature.asc
Description: This is a digitally signed message part