Bug#994454: golang-github-containers-common: should include debci test suite

2024-09-10 Thread Reinhard Tartler
reassign 994454 libpod
close 5.2.0+ds1-5
affects 994454 golang-github-containers-common
thanks


"Bastien Roucariès"  writes:

> Package: golang-github-containers-common
> Severity: important
>
> Dear Maintainer,
>
> This package [golang-github-containers-common] is used in conjunction
> of podman to run container, and the secomp list could break due to
> kernel change on some arch or even lib change.
>
> It will be nice to exercice this package using podman to run a basic debian
> container running some classical package (systemd, at with a timer in 60s 
> etc).
>
> It will allow to catch bug like #994451 using debci early and moreover run 
> this
> test also at build time in order to catch regression during the rebuild phase
> of release on non debci arch.

I've been looking into autopkgtests more, and have come to the
conclusion that adding an autopkgtest to the
golang-github-containers-common package would not have caught #994451,
because it would require a rebuild of podman. Running autopkgtest of
this package would run podman compiled against the old code in sid, and
a change would therefore not be tested.

Instead, libpod since version 5.2.0+ds1-5 now comes with autopkgtests,
that are triggered by debci upon changes from
golang-github-containers-common. This in turn would have likely detected
this issue.

I'm therefore reassinging and closing this bug accordingly.

Thanks for reporting this issue!

-rt



Bug#994454: golang-github-containers-common: should include debci test suite

2021-09-26 Thread Reinhard Tartler
Control: tag -1 help

Hi Bastien,

On Thu, Sep 16, 2021 at 4:36 AM Bastien Roucariès <
roucaries.bast...@gmail.com> wrote:

> Package: golang-github-containers-common
> Severity: important
>
> Dear Maintainer,
>
> This package is used in conjunction of podman to run container, and the
> secomp
> list could break due to kernel change on some arch or even lib change.
>
> It will be nice to exercice this package using podman to run a basic debian
> container running some classical package (systemd, at with a timer in 60s
> etc).
>
> It will allow to catch bug like #994451 using debci early and moreover run
> this
> test also at build time in order to catch regression during the rebuild
> phase
> of release on non debci arch.
>

I like that idea a lot. In this case, however, we would need to recompile
podman against the fixed containers/common. Shouldn't that debci test
therefore rather be in the src:libpod package?

Also, do you have experience how to write those tests? I'd be happy to
review/accept a patch doing so.

-- 
regards,
Reinhard


Bug#994454: golang-github-containers-common: should include debci test suite

2021-09-16 Thread Bastien Roucariès
Package: golang-github-containers-common
Severity: important

Dear Maintainer,

This package is used in conjunction of podman to run container, and the secomp
list could break due to kernel change on some arch or even lib change.

It will be nice to exercice this package using podman to run a basic debian
container running some classical package (systemd, at with a timer in 60s etc).

It will allow to catch bug like #994451 using debci early and moreover run this
test also at build time in order to catch regression during the rebuild phase
of release on non debci arch.

Thanks

Bastien