Bug#995850: lintian: more context is not always a good thing
Hi Hugh, On Mon, Oct 11, 2021 at 5:48 PM Hugh McMaster wrote: > > To avoid specifying the tag override four times, I tried "line 35 41 > 57 132" but that didn't work at all. I am not opposed to the idea (or to making overrides easier to use in other ways) but isn't the array as susceptible to new upstream versions as four separate lines? BTW, Lintian's test suite has an automatic hint adjuster. (No editor required.) Would that be helpful to the public for use on their overrides? Kind regards Felix Lechner
Bug#995850: lintian: more context is not always a good thing
Hi Hugh, On Sun, Oct 10, 2021 at 9:54 PM Hugh McMaster wrote: > > Is it possible to make the line number component an optional array? line > [1,3,5] Do you mean overriding some line numbers, but leaving others? Thanks! Kind regards Felix Lechner
Bug#995850: lintian: more context is not always a good thing
Hi, On Sun, Oct 10, 2021 at 3:33 PM Thorsten Glaser wrote: > > I’ve not yet tested ... > whether the asterisk indeed allows anything to come after, > i.e. “line * ot to” isn’t equivalent to “line *”… I am not sure it's a good feature, but it should work. [1][2] Kind regards Felix Lechner [1] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Processable/Overrides.pm#L278 [2] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Group.pm#L374
Bug#995850: lintian: more context is not always a good thing
Felix Lechner dixit: >By the way, you should also be able to use the wildcards * and ? in >lieu of the line numbers right now. Please let me know if that works. So indeed: -mksh source: debian-watch-uses-insecure-uri http://www.mirbsd.org/MirOS/dist/mir/mksh/ +mksh source: debian-watch-uses-insecure-uri http://www.mirbsd.org/MirOS/dist/mir/mksh/ (line *) -mksh: typo-in-manual-page usr/share/man/man1/mksh.1.gz ot to +mksh: typo-in-manual-page usr/share/man/man1/mksh.1.gz line * ot to These changes correctly override the issues. I’ve not yet tested (e.g. by inserting an actual misspelling into the manpage) whether the asterisk indeed allows anything to come after, i.e. “line * ot to” isn’t equivalent to “line *”… bye, //mirabilos -- [16:04:33] bkix: "veni vidi violini" [16:04:45] bkix: "ich kam, sah und vergeigte"...
Bug#995850: lintian: more context is not always a good thing
Hi, On Wed, Oct 6, 2021 at 6:21 PM Thorsten Glaser wrote: > > Can I use a wildcard then? By the way, you should also be able to use the wildcards * and ? in lieu of the line numbers right now. Please let me know if that works. Thanks! Kind regards Felix Lechner
Bug#995850: lintian: more context is not always a good thing
Hi, On Wed, Oct 6, 2021 at 6:21 PM Thorsten Glaser wrote: > > mksh: typo-in-manual-page usr/share/man/man1/mksh.1.gz ot to * Yes, that should work. I rewrote the override handling, but some parts are not fully specified. (I can't remember which.) Is 'mksh' the package giving you trouble? If so, I'll have a look. Thanks! Kind regards Felix Lechner
Bug#995850: lintian: more context is not always a good thing
Felix Lechner dixit: >At first glance, the line numbers seemed like a customer-friendly way >to distinguish hints, but I see your point. (Many more hints are fixed >than overridden.) Indeed, but it makes overriding them in the case where that’s truly the correct action (at no fault of lintian) harder. >Would it help for your override issue to relegate >the line numbers to the end of the context? Thanks! Can I use a wildcard then? Something like mksh: typo-in-manual-page usr/share/man/man1/mksh.1.gz ot to * I remember wildcards not always working right, but then, I’ve been first using lintian in tandem with linda so I don’t know which century that might have been not working well… bye, //mirabilos -- den AGP stecker anfeilen, damit er in den slot aufm 440BX board passt… oder netzteile, an die man auch den monitor angeschlossen hat und die dann für ein elektrisch aufgeladenes gehäuse gesorgt haben […] für lacher gut auf jeder LAN party │ damals, als der pizzateig noch auf dem monior "gegangen" ist
Bug#995850: lintian: more context is not always a good thing
Hi, On Wed, Oct 6, 2021 at 5:48 PM Thorsten Glaser wrote: > > less context may actually > be enough to identify the issue in question, as is here, where the line > number, which is a more fragile identifier, is not needed. We may be able to offer a command line option to turn off the line numbers, but the line numbers are needed when parsing text to prevent the issuance of duplicate hints, which now cause Lintian to croak. At first glance, the line numbers seemed like a customer-friendly way to distinguish hints, but I see your point. (Many more hints are fixed than overridden.) Would it help for your override issue to relegate the line numbers to the end of the context? Thanks! Kind regards Felix Lechner
Bug#995850: lintian: more context is not always a good thing
Package: lintian Version: 2.107.0 Please reconsider changing and extending the context of various tags. More specifically: • debian-watch-uses-insecure-uri old context: the URI new context: the URI plus " (line 2)" • typo-in-manual-page old context: file, space, old word, space, new word new context: file, space, "line ", line number, space, old word, space, new word In both cases the old context made it perfectly usable to override the specific instance as it was fully sufficient to find it. (I would not, for example, want to override typo-in-manual-page for the entire file, but the “ot” here is correct (“test file1 -ot file2”), and it moves lines with releases and my time is better spent elsewhere than on needless lintian override churn.) So, please revert this change for these two tags at least, and consider reviewing the other tags, specifically whether less context may actually be enough to identify the issue in question, as is here, where the line number, which is a more fragile identifier, is not needed. bye, //mirabilos -- Yes, I hate users and I want them to suffer. -- Marco d'Itri on gmane.linux.debian.devel.general
