Bug#997224: btag: FTBFS: InteractiveTagger.cpp:201:34: error: ‘bool TagLib::String::isNull() const’ is deprecated [-Werror=deprecated-declarations]

[Eric Long]

tag -1 patch thanks

Also, it seemed that zlib is missing from building dependencies in my 
sbuild chroot:


```
[ 46%] Linking CXX executable btag
/usr/bin/cmake -E cmake_link_script CMakeFiles/btag.dir/link.txt 
--verbose=1
/usr/bin/c++ -g -O2 -ffile-prefix-map=/<>=. 
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time 
-D_FORTIFY_SOURCE=2 -Wall -Werror -Wl,-z,relro -Wl,-z,now -rdynamic 
CMakeFiles/btag.dir/src/BasicStringFilter.cpp.o 
CMakeFiles/btag.dir/src/ConfirmationHandler.cpp.o 
CMakeFiles/btag.dir/src/EnglishTitleLocalizationHandler.cpp.o 
CMakeFiles/btag.dir/src/InteractiveTagger.cpp.o 
CMakeFiles/btag.dir/src/main.cpp.o 
CMakeFiles/btag.dir/src/RenamingFilter.cpp.o 
CMakeFiles/btag.dir/src/SimpleCapitalizationFilter.cpp.o 
CMakeFiles/btag.dir/src/SpanishTitleLocalizationHandler.cpp.o 
CMakeFiles/btag.dir/src/StandardConsole.cpp.o 
CMakeFiles/btag.dir/src/TitleCapitalizationFilter.cpp.o 
CMakeFiles/btag.dir/src/TitleLocalizationHandler.cpp.o -o btag 
/usr/lib/riscv64-linux-gnu/libboost_filesystem.so.1.74.0 
/usr/lib/riscv64-linux-gnu/libboost_system.so.1.74.0 -ltag -lz

/usr/bin/ld: cannot find -lz: No such file or directory
collect2: error: ld returned 1 exit status
make[3]: *** [CMakeFiles/btag.dir/build.make:262: btag] Error 1
```

By adding `zlib1g-dev` to Build-Depends in d/control, this is fixed.

Cheers,
Eric

Bug#997224: btag: FTBFS: InteractiveTagger.cpp:201:34: error: ‘bool TagLib::String::isNull() const’ is deprecated [-Werror=deprecated-declarations]

[Eric Long]

Source: btag
Version: 1.1.3-1
Followup-For: Bug #997224
X-Debbugs-Cc: i...@hack3r.moe

tag -1 patch thanks

Hello,

Attached is a patch that replaces deprecated methods and variables according to
TagLib official docs [1]. It fixes FTBFS and it should work well too.

If more help is needed, please let me know.

Cheers,
Eric

[1]: https://taglib.org/api/classTagLib_1_1String.html
--- a/src/InteractiveTagger.cpp
+++ b/src/InteractiveTagger.cpp
@@ -198,7 +198,7 @@
 
 // Ask for the artist
 artist_confirmation.reset();
-if (!f.tag()->artist().isNull())
+if (!f.tag()->artist().isEmpty())
 
artist_confirmation.set_local_default(m_input_filter->filter(f.tag()->artist().toWString()));
 artist_confirmation.ask(L"Artist:");
 while (!artist_confirmation.complies())
@@ -207,7 +207,7 @@
 
 // Ask for the album
 album_confirmation.reset();
-if (!f.tag()->album().isNull())
+if (!f.tag()->album().isEmpty())
 
album_confirmation.set_local_default(m_input_filter->filter(f.tag()->album().toWString()));
 album_confirmation.ask(L"Album:");
 while (!album_confirmation.complies())
@@ -236,7 +236,7 @@
 // Ask for the song title
 ConfirmationHandler title_confirmation(*m_terminal, m_input_filter, 
m_output_filter);
 title_confirmation.reset();
-if (!f.tag()->title().isNull())
+if (!f.tag()->title().isEmpty())
 
title_confirmation.set_local_default(m_input_filter->filter(f.tag()->title().toWString()));
 title_confirmation.ask(L"Title:");
 while (!title_confirmation.complies())
@@ -244,8 +244,8 @@
 f.tag()->setTitle(title_confirmation.answer());
 
 // Reset the comment and genre fields
-f.tag()->setComment(TagLib::String::null);
-f.tag()->setGenre(TagLib::String::null);
+f.tag()->setComment(TagLib::String());
+f.tag()->setGenre(TagLib::String());
 
 // Add it to the list of unsaved files
 m_unsaved_files.push_back(f);

Bug#997224: btag: FTBFS: InteractiveTagger.cpp:201:34: error: ‘bool TagLib::String::isNull() const’ is deprecated [-Werror=deprecated-declarations]

[Lucas Nussbaum]

Source: btag
Version: 1.1.3-1
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK 
> -DBOOST_SYSTEM_DYN_LINK -I/usr/include/taglib -g -O2 
> -ffile-prefix-map=/<>=. -fstack-protector-strong -Wformat 
> -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -MD -MT 
> CMakeFiles/btag.dir/src/InteractiveTagger.cpp.o -MF 
> CMakeFiles/btag.dir/src/InteractiveTagger.cpp.o.d -o 
> CMakeFiles/btag.dir/src/InteractiveTagger.cpp.o -c 
> /<>/src/InteractiveTagger.cpp
> /<>/src/InteractiveTagger.cpp: In member function ‘void 
> InteractiveTagger::tag_file(const boost::filesystem::path&, 
> ConfirmationHandler&, ConfirmationHandler&, int*, int)’:
> /<>/src/InteractiveTagger.cpp:201:34: error: ‘bool 
> TagLib::String::isNull() const’ is deprecated 
> [-Werror=deprecated-declarations]
>   201 | if (!f.tag()->artist().isNull())
>   |  ^~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:343:28: note: declared here
>   343 | TAGLIB_DEPRECATED bool isNull() const;
>   |^~
> /<>/src/InteractiveTagger.cpp:210:33: error: ‘bool 
> TagLib::String::isNull() const’ is deprecated 
> [-Werror=deprecated-declarations]
>   210 | if (!f.tag()->album().isNull())
>   |  ~~~^~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:343:28: note: declared here
>   343 | TAGLIB_DEPRECATED bool isNull() const;
>   |^~
> /<>/src/InteractiveTagger.cpp:239:33: error: ‘bool 
> TagLib::String::isNull() const’ is deprecated 
> [-Werror=deprecated-declarations]
>   239 | if (!f.tag()->title().isNull())
>   |  ~~~^~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:343:28: note: declared here
>   343 | TAGLIB_DEPRECATED bool isNull() const;
>   |^~
> /<>/src/InteractiveTagger.cpp:247:41: error: 
> ‘TagLib::String::null’ is deprecated [-Werror=deprecated-declarations]
>   247 | f.tag()->setComment(TagLib::String::null);
>   | ^~~~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:528:37: note: declared here
>   528 | TAGLIB_DEPRECATED static String null;
>   | ^~~~
> /<>/src/InteractiveTagger.cpp:247:41: error: 
> ‘TagLib::String::null’ is deprecated [-Werror=deprecated-declarations]
>   247 | f.tag()->setComment(TagLib::String::null);
>   | ^~~~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:528:37: note: declared here
>   528 | TAGLIB_DEPRECATED static String null;
>   | ^~~~
> /<>/src/InteractiveTagger.cpp:248:39: error: 
> ‘TagLib::String::null’ is deprecated [-Werror=deprecated-declarations]
>   248 | f.tag()->setGenre(TagLib::String::null);
>   |   ^~~~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from /<>/src/InteractiveTagger.cpp:14:
> /usr/include/taglib/tstring.h:528:37: note: declared here
>   528 | TAGLIB_DEPRECATED static String null;
>   | ^~~~
> /<>/src/InteractiveTagger.cpp:248:39: error: 
> ‘TagLib::String::null’ is deprecated [-Werror=deprecated-declarations]
>   248 | f.tag()->setGenre(TagLib::String::null);
>   |   ^~~~
> In file included from /usr/include/taglib/tag.h:30,
>  from /usr/include/taglib/tfile.h:31,
>  from /usr/include/taglib/fileref.h:29,
>  from