Bug#997932: Does not include a .symbols

2021-10-27 Thread Sebastien Bacher 

Updated patch with the correct content and the bug reference
diff -Nru opensc-0.22.0/debian/changelog opensc-0.22.0/debian/changelog
--- opensc-0.22.0/debian/changelog	2021-08-17 06:48:15.0 +0200
+++ opensc-0.22.0/debian/changelog	2021-10-27 12:36:10.0 +0200
@@ -1,3 +1,11 @@
+opensc (0.22.0-2) UNRELEASED; urgency=medium
+
+  * debian/opensc-pkcs11.symbols:
+- create a .symbols to ensure the API isn't accidentally changing
+  (Closes: #997932)
+
+ -- Sebastien Bacher   Wed, 27 Oct 2021 12:36:10 +0200
+
 opensc (0.22.0-1) unstable; urgency=medium
 
   * New upstream release (Closes: 979726)
diff -Nru opensc-0.22.0/debian/opensc-pkcs11.symbols opensc-0.22.0/debian/opensc-pkcs11.symbols
--- opensc-0.22.0/debian/opensc-pkcs11.symbols	1970-01-01 01:00:00.0 +0100
+++ opensc-0.22.0/debian/opensc-pkcs11.symbols	2021-10-27 12:35:49.0 +0200
@@ -0,0 +1,767 @@
+libopensc.so.8 opensc-pkcs11 #MINVER#
+ _sc_asn1_decode@Base 0.22.0
+ _sc_asn1_encode@Base 0.22.0
+ _sc_card_add_ec_alg@Base 0.22.0
+ _sc_card_add_rsa_alg@Base 0.22.0
+ _sc_debug@Base 0.22.0
+ _sc_debug_hex@Base 0.22.0
+ _sc_delete_reader@Base 0.22.0
+ _sc_log@Base 0.22.0
+ _sc_match_atr@Base 0.22.0
+ _sc_match_atr_block@Base 0.22.0
+ eac_default_flags@Base 0.22.0
+ eac_pace_get_tries_left@Base 0.22.0
+ eac_secret_name@Base 0.22.0
+ escape_buf_to_pace_capabilities@Base 0.22.0
+ escape_buf_to_pace_input@Base 0.22.0
+ escape_buf_to_pace_output@Base 0.22.0
+ escape_pace_capabilities_to_buf@Base 0.22.0
+ escape_pace_input_to_buf@Base 0.22.0
+ escape_pace_output_to_buf@Base 0.22.0
+ get_pace_capabilities@Base 0.22.0
+ iasecc_sdo_encode_update_field@Base 0.22.0
+ iasecc_sm_create_file@Base 0.22.0
+ iasecc_sm_delete_file@Base 0.22.0
+ iasecc_sm_external_authentication@Base 0.22.0
+ iasecc_sm_pin_reset@Base 0.22.0
+ iasecc_sm_pin_verify@Base 0.22.0
+ iasecc_sm_read_binary@Base 0.22.0
+ iasecc_sm_rsa_generate@Base 0.22.0
+ iasecc_sm_rsa_update@Base 0.22.0
+ iasecc_sm_sdo_update@Base 0.22.0
+ iasecc_sm_update_binary@Base 0.22.0
+ iso7816_read_binary_sfid@Base 0.22.0
+ iso7816_update_binary_sfid@Base 0.22.0
+ iso7816_write_binary_sfid@Base 0.22.0
+ npa_reset_retry_counter@Base 0.22.0
+ perform_chip_authentication@Base 0.22.0
+ perform_pace@Base 0.22.0
+ perform_terminal_authentication@Base 0.22.0
+ sc_append_file_id@Base 0.22.0
+ sc_append_path@Base 0.22.0
+ sc_append_path_id@Base 0.22.0
+ sc_append_record@Base 0.22.0
+ sc_asn1_clear_algorithm_id@Base 0.22.0
+ sc_asn1_decode@Base 0.22.0
+ sc_asn1_decode_algorithm_id@Base 0.22.0
+ sc_asn1_decode_bit_string@Base 0.22.0
+ sc_asn1_decode_bit_string_ni@Base 0.22.0
+ sc_asn1_decode_choice@Base 0.22.0
+ sc_asn1_decode_integer@Base 0.22.0
+ sc_asn1_decode_object_id@Base 0.22.0
+ sc_asn1_encode@Base 0.22.0
+ sc_asn1_encode_algorithm_id@Base 0.22.0
+ sc_asn1_encode_object_id@Base 0.22.0
+ sc_asn1_find_tag@Base 0.22.0
+ sc_asn1_print_tags@Base 0.22.0
+ sc_asn1_put_tag@Base 0.22.0
+ sc_asn1_read_tag@Base 0.22.0
+ sc_asn1_sig_value_rs_to_sequence@Base 0.22.0
+ sc_asn1_sig_value_sequence_to_rs@Base 0.22.0
+ sc_asn1_skip_tag@Base 0.22.0
+ sc_asn1_verify_tag@Base 0.22.0
+ sc_asn1_write_element@Base 0.22.0
+ sc_aux_data_allocate@Base 0.22.0
+ sc_aux_data_free@Base 0.22.0
+ sc_aux_data_get_md_guid@Base 0.22.0
+ sc_aux_data_set_md_flags@Base 0.22.0
+ sc_aux_data_set_md_guid@Base 0.22.0
+ sc_base64_decode@Base 0.22.0
+ sc_base64_encode@Base 0.22.0
+ sc_bin_to_hex@Base 0.22.0
+ sc_build_pin@Base 0.22.0
+ sc_bytes2apdu@Base 0.22.0
+ sc_cancel@Base 0.22.0
+ sc_card_ctl@Base 0.22.0
+ sc_card_find_ec_alg@Base 0.22.0
+ sc_card_find_rsa_alg@Base 0.22.0
+ sc_change_reference_data@Base 0.22.0
+ sc_check_apdu@Base 0.22.0
+ sc_check_sw@Base 0.22.0
+ sc_color_fprintf@Base 0.22.0
+ sc_compare_oid@Base 0.22.0
+ sc_compare_path@Base 0.22.0
+ sc_compare_path_prefix@Base 0.22.0
+ sc_compute_signature@Base 0.22.0
+ sc_concatenate_path@Base 0.22.0
+ sc_connect_card@Base 0.22.0
+ sc_context_create@Base 0.22.0
+ sc_copy_asn1_entry@Base 0.22.0
+ sc_crc32@Base 0.22.0
+ sc_create_file@Base 0.22.0
+ sc_ctx_detect_readers@Base 0.22.0
+ sc_ctx_get_reader@Base 0.22.0
+ sc_ctx_get_reader_by_id@Base 0.22.0
+ sc_ctx_get_reader_by_name@Base 0.22.0
+ sc_ctx_get_reader_count@Base 0.22.0
+ sc_ctx_log_to_file@Base 0.22.0
+ sc_ctx_use_reader@Base 0.22.0
+ sc_ctx_win32_get_config_value@Base 0.22.0
+ sc_decipher@Base 0.22.0
+ sc_delete_file@Base 0.22.0
+ sc_delete_record@Base 0.22.0
+ sc_der_copy@Base 0.22.0
+ sc_detect_card_presence@Base 0.22.0
+ sc_disconnect_card@Base 0.22.0
+ sc_do_log@Base 0.22.0
+ sc_do_log_color@Base 0.22.0
+ sc_do_log_noframe@Base 0.22.0
+ sc_dump_hex@Base 0.22.0
+ sc_encode_oid@Base 0.22.0
+ sc_enum_apps@Base 0.22.0
+ sc_erase_binary@Base 0.22.0
+ sc_establish_context@Base 0.22.0
+ sc_file_add_acl_entry@Base 0.22.0
+ sc_file_clear_acl_entries@Base 0.22.0
+ sc_file_dup@Base 0.22.0
+ sc_file_free@Base 0.22.0
+ sc_file_get_acl_entry@Base 0.22.0
+ sc_file_new@Base 0.22.0
+ sc_file_set_content@Base 0.22.0
+

Bug#997932: Does not include a .symbols

2021-10-27 Thread Sebastien Bacher 

Package: opensc
Version: 0.22.0-1
Severity: minor
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu impish ubuntu-patch

Dear maintainers,

Current opensc doesn't include a .symbols, having one would help in 
ensuring updates don't include incompatible changes. The issue was 
raised by the Ubuntu MIR team on https://launchpad.net/bugs/1892559 and 
is a condition for us to promote the package but it would also be useful 
in Debian.


Ludovic who participated in the discussion that the .so is dlopened but 
respecting the defined PKCS11 standard, which probably means it make 
sense to ensure the files stay compatible with defined API.


The attached patch enable symbols tracking


Thanks for considering,
Sebastien Bacher



 changelog |8 
 opensc-pkcs11.symbols |  767 ++
 2 files changed, 775 insertions(+)