Package: impressive
Version: 0.13.0~beta1a-1
Severity: grave
Justification: renders package unusable
Dear Maintainer,
impressive crashes with the following output for me, when used with any PDF:
###
Welcome to Impressive version 0.13.0-beta1a (SVN r285)
pygame 1.9.6
Hello from the pygame community. https://www.pygame.org/contribute.html
Detected screen size: 1920x1080 pixels
PDF renderer: Xpdf/Poppler
OpenGL renderer: Radeon RX 580 Series (POLARIS10, DRM 3.36.0, 5.6.0-2-amd64,
LLVM 10.0.0)
===
OOPS! Impressive crashed!
This shouldn't happen. Please report this incident to the author, including the
full output of the program, particularly the following lines. If possible,
please also send the input files you used.
Impressive version: 0.13.0-beta1a (SVN r285)
Python version: 3.8.3 (default, May 14 2020, 11:03:12)
[GCC 9.3.0]
PyGame version: 1.9.6
PIL version: Pillow 7.0.0
PDF renderer: Xpdf/Poppler
OpenGL vendor: X.Org
OpenGL renderer: Radeon RX 580 Series (POLARIS10, DRM 3.36.0, 5.6.0-2-amd64,
LLVM 10.0.0)
OpenGL version: 4.6 (Compatibility Profile) Mesa 20.0.7
Operating system: Linux 5.6.0-2-amd64 (x86_64)
Linux distribution: Debian GNU/Linux bullseye/sid
Command line: /usr/bin/impressive GiT.pdf
Traceback (most recent call last):
File "/usr/bin/impressive", line 6451, in run_main
main()
File "/usr/bin/impressive", line 6368, in main
RenderPage(Pcurrent, Tcurrent)
File "/usr/bin/impressive", line 3679, in RenderPage
gl.TexImage2D(gl.TEXTURE_2D, 0, gl.RGB, TexWidth, TexHeight, 0, gl.RGB,
gl.UNSIGNED_BYTE, PageImage(page))
File "/usr/bin/impressive", line 3599, in PageImage
img = RenderPDF(page, not(ZoomMode), ZoomMode)
File "/usr/bin/impressive", line 3399, in RenderPDF
img = PDFRenderer.render(SourceFile, RealPage, useres, use_aa)
File "/usr/bin/impressive", line 3282, in render
try_digits.sort(key=lambda n: abs(n - digits))
AttributeError: 'range' object has no attribute 'sort'
This is a general python3 incompatibility and is already fixed upstream in SVN,
though not released yet AFAICS
The following is the change, that fixes the issue:
--- /a/impressive 2020-05-28 10:01:59.841029102 +0200
+++ /b/impressive 2020-05-28 10:02:10.217064169 +0200
@@ -3278,7 +3278,7 @@
TempFileName
])
digits = GetFileProp(filename, 'digits', 6)
-try_digits = range(6, 0, -1)
+try_digits = list(range(6, 0, -1))
try_digits.sort(key=lambda n: abs(n - digits))
try_digits = [(n, TempFileName + ("-%%0%dd.ppm" % n) % page) for n in
try_digits]
for digits, imgfile in try_digits:
I don't know how this would be handled, since there is no new release yet, but
the bug is effectively fixed upstream.
Would the patch be carried by debian until a new release is done?
-- System Information:
Debian Release: bullseye/sid
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 5.6.0-2-amd64 (SMP w/12 CPU cores)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages impressive depends on:
ii poppler-utils 0.71.0-6
ii python3 3.8.2-3
ii python3-pil 7.0.0-4+b1
ii python3-pygame 1.9.6+dfsg-2+b1
Versions of packages impressive recommends:
ii ffmpeg 7:4.2.2-1+b1
ii mplayer2:1.3.0-8+b6
ii perl 5.30.2-1
ii xdg-utils 1.1.3-2
Versions of packages impressive suggests:
ii ghostscript 9.52~dfsg-1
pn latex-beamer
ii pdftk 2.02-5+b1
ii pdftk-java [pdftk] 3.1.1-1
-- no debconf information
-- debsums errors found:
debsums: changed file /usr/share/impressive/impressive.py (from impressive
package)
