Bug#938027: python-pip: Python2 removal in sid/bullseye

2020-03-13 Thread Barry Warsaw
Hi Sandro.

Honestly, I have not contributed to Debian in a couple of years, and I don’t 
see that changing any time soon.  Best to contact Matthias, the Python Team, or 
just do whatever you think is best.

Cheers,
-Barry

> On Mar 13, 2020, at 12:32, Sandro Tosi  wrote:
> 
> On Fri, 30 Aug 2019 07:44:13 + Matthias Klose  wrote:
>> Package: src:python-pip
>> Version: 18.1-5
>> Severity: normal
>> Tags: sid bullseye
>> User: debian-pyt...@lists.debian.org
>> Usertags: py2removal
> 
> the only rdeps of `bin:python-pip` have been removed from testing, so
> it's probably time we drop this package too!
> 
> Carl, Barry: do you see anything wrong with this? what should we do
> about the -whl package? is it still required for something or can we
> drop it along with bin:python-pip? is it needed for anything
> py3k-related?
> 
> I would like to proceed quickly, ideally within a week.
> 
> thanks,
> Sandro



signature.asc
Description: Message signed with OpenPGP


Bug#890621: forwarded python3.6 issue (bpo-32305 causing regressions)

2018-02-19 Thread Barry Warsaw
On Feb 19, 2018, at 04:08, Matthias Klose  wrote:
> 
> This is https://bugs.python.org/issue32305, apparently intentional and will be
> in 3.7.  So better fix the packages itself. Not sure if that really should be
> backported.

Thanks for the forward.  The fix is for third party packages to use 
`getattr(module, ‘__file__’, None)` instead of `hasattr(module, ‘__file__’)`.  
I think gunicorn has already fixed this in their upstream.



signature.asc
Description: Message signed with OpenPGP


Bug#859421: python-tz orphaning

2017-04-07 Thread Barry Warsaw
On Apr 07, 2017, at 02:47 AM, Matthias Klose wrote:

>I think it's safe to go forward with this. Maybe keep the zope team (or the
>individual uploaders) as an uploader for a while, but I think the zope team
>is a little bit dead at this point ...

I really think we should pull the zope library packages into DPMT.



Bug#812768: [Python-modules-team] Bug#812768: python-whoosh: diff for NMU version 2.7.0-1.1

2017-01-30 Thread Barry Warsaw
On Jan 30, 2017, at 08:21 AM, Simon McVittie wrote:

>Thanks for letting me know, I'll mark it as unmaintained. Would you like
>your other packages to be marked as unmaintained too?
>
>Sorry, I am not intending to adopt python-whoosh: I'm only fixing it
>because removing it from testing would be disruptive for other packages
>in Debian.

I'd be willing to help maintain whoosh, but only with DPMT as Maintainer and
myself as Uploader.

Given the ongoing discussion over in debian-python@ it might not be worth
git-dpm'ifying it, but instead just moving the vcs branch over to the team
repo.  If this is acceptable, let me know.



Bug#851649: (no subject)

2017-01-17 Thread Barry Warsaw
I have no objections, but I don't have time right now to do it.  Piotr did the
1.7.0-1 upload so please verify with him.



Bug#844943: python-bleach: FTBFS: Tests failures

2017-01-13 Thread Barry Warsaw
On Jan 13, 2017, at 09:16 PM, Pirate Praveen wrote:

>I would prefer this approach as I prefer to avoid maintaining two
>versions if possible. I cloned html5lib.git repo, but found recent tags
>missing there. Can you push them?

Apologies.  Tags pushed.  Let me know when you have a repo or branch for me to
test and I will do QA on pip and friends.


pgpGosToLnO15.pgp
Description: OpenPGP digital signature


Bug#844943: python-bleach: FTBFS: Tests failures

2017-01-10 Thread Barry Warsaw
Here's another thought.

What if we upload a new html5lib source package containing seven-9's?  I know
we're in freeze, but this may make the most sense.  Then, packages which need
the old version like bleach can depend on the seven-9's version and that won't
affect packages which require the newer version like pip.

Eventually bleach will fix their package to work with the newer html5lib, or
even html5lib 1.0 when that gets released.  Then we can remove the seven-9's
package.  It's something of a mini-transition, and I'm not happy about having
to do that, but it seems to be the least painful suggestion for now, with the
least possibility of regressions or breakages.

Cheers,
-Barry



pgpUVcrH1sMSk.pgp
Description: OpenPGP digital signature


Bug#844943: python-bleach: FTBFS: Tests failures

2017-01-10 Thread Barry Warsaw
On Jan 10, 2017, at 09:37 AM, Pirate Praveen wrote:

>bleach and other projects using html5lib seems to have locked the version of
>html5lib to the one with 7 nines. Can we also go back to the older version
>which works?

I had a conversation with the upstream pip maintainer.  In theory it may be
possible.  In practice it's often a nightmare to go backwards.  I'm willing to
help try to make that happen if others are also willing to help.

>It is not sustainable to expect maintainers to reverse dependencies to fix
>breakage with out giving them advance notice. Since python-bleach has
>autopkgtests defined, it would have been easy to find out if an update of
>python-html5lib would break it or not using a tool like build-and-upload
>script from pkg-ruby-extras team [1]

I'm not sure why you think I'd know anything about an obscure Ruby tool.  I
still contend that Debian ought to have automatic promotion gating on reverse
dependency building and testing.

All that aside, if someone wants to help put together a git branch that
properly reverts html5lib to seven-9's, I will gladly review and test it with
pip, and upload it if it looks okay.

Cheers,
-Barry


pgpvrc2qv10Fk.pgp
Description: OpenPGP digital signature


Bug#835437: (no subject)

2016-12-15 Thread Barry Warsaw
I can't reproduce the build failures reported here even with dpkg-buildpackage
-A.  However, I am going to add the discard-port proxies to d/rules that
pybuild normally adds by default (this package doesn't use pybuild).  That at
least will prevent the tests from *actually* hitting the internet.  I'll close
#830281 against that change.

Yes, this makes the test suite fail during package build.  I have reported
this upstream at https://github.com/pycurl/pycurl/issues/424

However note that d/rules currently discards test suite errors, so they don't
prevent the build from succeeding.  This makes running the tests semi-useless
but I think until upstream fixes their test suite, it's the best we can do.
Therefore I'm going to tag this bug as unreproducible and reduce the
severity.

I also can't reproduce the C locale problem, but I'm going to consider that a
separate bug so please file a new one on that issue.



Bug#835437: pycurl: FTBFS too much often (failing tests)

2016-11-04 Thread Barry Warsaw
On Nov 03, 2016, at 08:32 PM, Santiago Vila wrote:

>My recommendation: Please find the way to disable any tests which
>perform network access, I have the strong feeling that the build would
>never hang if those tests are disabled.

+1 - unfortunately I just don't have any spare cycles right now.  If someone
wants to work on this, I will gladly review, sponsor, or otherwise help get
your contribution landed.


pgp2IDe_orI1A.pgp
Description: OpenPGP digital signature


Bug#835437: pycurl: FTBFS too much often (failing tests)

2016-11-03 Thread Barry Warsaw
On Nov 03, 2016, at 02:03 PM, Sandro Tosi wrote:

>Hey Barry, did you have a chance to look at this? might be also just
>forward it upstream and see how that goes. Thanks!

I'm sorry, I haven't. :(


pgpI4eitBenxl.pgp
Description: OpenPGP digital signature


Bug#840847: (no subject)

2016-10-24 Thread Barry Warsaw
Any chance this fix can get uploaded soon-ish?  gtimelog build depends on it
so it's marked for autoremoval because of this bug.  Thanks!



Bug#838531: nose2: FTBFS in testing (failing tests)

2016-09-26 Thread Barry Warsaw
On Sep 24, 2016, at 03:47 PM, Chris Lamb wrote:

>> nose2: FTBFS in testing (failing tests)
>
>This is somewhat mind-bending to debug:
>
>   AssertionError: Regex didn't match:
>  'FAILED \\(failures=5, errors=1, skipped=1\\)' not found in
>  […] FAILED (failures=1, errors=1, skipped=1)\n'
>
>ie. the wrong tests in a set of tests for a testcase in a testing utility
>are passing when they should be failing, and it's not even clear which of
>them should be failing.

Hi, I can't seem to reproduce this on unstable.  Both dpkg-buildpackage -A and
sbuild work just fine, as does autopkgtest in an unstable chroot.

However, the reproducible build problem is a real issue; I'm about to upload
0.6.5-2 which will fix this.  Once that's pushed to git or uploaded, could you
please try again?



Bug#828883: (no subject)

2016-07-13 Thread Barry Warsaw
This actually turns out to be a bug in pybuild (dh-python).

In zope.interface's d/control file we have:

Build-Depends: debhelper (>= 9),
   dh-python,
   dpkg-dev (>= 1.16.1~),
   libpython-all-dbg,
   libpython-all-dev,
   libpython3-all-dbg,
   libpython3-all-dev,
   python-all-dbg:any,
   python-all-dev:any,
   python-setuptools,
   python-zope.event,
   python3-all-dbg:any,
   python3-all-dev:any,
   python3-setuptools,
   python3-zope.event

Note the ':any' specifier on the interpreter packages.  pybuild didn't
recognize these.

I reported this to Piotr who fixed it in dh-python git, which I tested and
verified fixes the problem, so I reassigned this bug to that package.



Bug#830712: marked as pending

2016-07-13 Thread Barry Warsaw
tag 830712 pending
thanks

Hello,

Bug #830712 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/enum34.git;a=commitdiff;h=f290d36

---
commit f290d362a8d9767fb18687442d21f25980877481
Author: Barry Warsaw <ba...@python.org>
Date:   Wed Jul 13 10:11:03 2016 -0400

New upstream release.

* New upstream release.
* d/control: Add `Breaks: python-enum` to ensure that package (since
  removed from the archive) gets uninstalled when python-enum34 is
  installed. (Closes: #830712)

diff --git a/debian/changelog b/debian/changelog
index c5febc4..3b2e820 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+enum34 (1.1.6-1) UNRELEASED; urgency=medium
+
+  * New upstream release.
+  * d/control: Add `Breaks: python-enum` to ensure that package (since
+removed from the archive) gets uninstalled when python-enum34 is
+installed. (Closes: #830712)
+
+ -- Barry Warsaw <ba...@debian.org>  Wed, 13 Jul 2016 09:56:45 -0400
+
 enum34 (1.1.5-1) unstable; urgency=medium
 
   [ Ondřej Nový ]



Bug#828094: python3-coverage: Missing JavaScript dependency: jquery.debounce.min.js

2016-07-05 Thread Barry Warsaw
On Jul 03, 2016, at 09:04 PM, Ben Finney wrote:

>I can work to package the library dependency; would you be interested
>in sponsoring it into the archive?

Yes, for sure!


pgpYTQQt9NOGZ.pgp
Description: OpenPGP digital signature


Bug#828094: python3-coverage: Missing JavaScript dependency: jquery.debounce.min.js

2016-06-24 Thread Barry Warsaw
Package: python3-coverage
Version: 4.1+dfsg.1-2
Severity: grave
Justification: renders package unusable

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Dear Maintainer,

Apparently python-coverage has gained a dependency on
jquery.debounce.min.js but this isn't available in the archive afaict.
The closest thing apt-file tells me is

% apt-file search jquery.debounce
phpmyadmin: /usr/share/phpmyadmin/js/jquery/jquery.debounce-1.0.5.js

See the reference in coverage/html.py.

This missing js file breaks html reporting.  E.g. in a tox
environment using system site packages:

coverage runtests: commands[1] | python -m coverage combine
- --rcfile=/home/barry/projects/ubuntu/allsnappy/ubuntu-image/coverage.ini
coverage runtests: commands[2] | python -m coverage html
- --rcfile=/home/barry/projects/ubuntu/allsnappy/ubuntu-image/coverage.ini
Couldn't find static file 'jquery.debounce.min.js' from
'/home/barry/projects/ubuntu/allsnappy/ubuntu-image', tried:
['/usr/share/javascript/jquery.debounce.min.js',
'/usr/share/javascript/jquery-debounce/jquery.debounce.min.js',
'/usr/lib/python3/dist-packages/coverage/htmlfiles/jquery.debounce.min.js',
'/usr/lib/python3/dist-packages/coverage/htmlfiles/jquery-debounce/jquery.debounce.min.js']
ERROR: InvocationError:
'/home/barry/projects/ubuntu/allsnappy/ubuntu-image/.tox/coverage/bin/python
- -m coverage html
- --rcfile=/home/barry/projects/ubuntu/allsnappy/ubuntu-image/coverage.ini'


- -- System Information:
Debian Release: stretch/sid
  APT prefers yakkety
  APT policy: (500, 'yakkety')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.4.0-25-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages python3-coverage depends on:
ii  libc6  2.23-0ubuntu3
ii  python33.5.1-4
ii  python3-pkg-resources  20.10.1-1

Versions of packages python3-coverage recommends:
ii  libjs-jquery  1.12.3-1
ii  libjs-jquery-hotkeys  0~20130707+git2d51e3a9+dfsg-2ubuntu1
ii  libjs-jquery-isonscreen   1.2.0-1
ii  libjs-jquery-tablesorter  10-2ubuntu2

python3-coverage suggests no packages.

- -- no debconf information

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBCAAGBQJXbbpCAAoJEBJutWOnSwa/L4IQAJa1TXw6WmfwoT6aX82Qv6x8
0+Jk0aNE3aHP5DSaJTBhVP4i1WciKt6mvrubM/+uARpsGFFR9Rz61YDtkk59NwGL
gcU7wpmhN/d9yhn7l3XcUTpx3aiqq6l86/HQg45dLNL7LK23Ntsq+fNTrbtw+6qp
0FCFC0ZT6qN9LtV+dpV7MbW3rTuYFrqo98G7xSlOZrWkA2V8gO5mTbDUkq+y1e/O
kk3mft9XUu5j8JI87i1SgjdXrcLJGchKW2Z2MkqhuFPOCbg2PY/FlJZNLnQEqwhd
JDsDYV+4Qh7n3QwDmotpkR98GEZecHkI6kVRcP2j3/UDxojmeMfr2Zw3k5PJnhMf
ETqy7a9w8medl9qPNCR+EIf/f+akuk0m5IEJJT9MjagifEg0bZtUomame619r63d
aQY5beJnpIldg+N0x4q7R1tXx5tTrnGipBjRQrZPRC2m5acHMQZzm58uQ3ASAeXE
JTl4o4P00q4t7nEX7mjWiUI1AFjwITGKDoGrzBOPTzikH3tVakNM/o2yG4DkUUtD
U0M9nhycdiEw/5pBs2MhJ70ZJ40v7sG2RQ8Jxv7eQcwTuyXlSNAe7cIOVHPrB/kz
jtRc3fniGaWX0yVHtuMIDa1BvrhvagDuihGNmveVNBVS4OPCoxvRyGgjSqm9Sbx7
wccdJBWySpvfr/BYs7m3
=QNgz
-END PGP SIGNATURE-



Bug#824566: (no subject)

2016-05-17 Thread Barry Warsaw
I don't know how to use targetcli.  I tried the simple command you gave in
your bug report, but that failed for other reasons (some kind of input file is
missing).

In any case, I just uploaded pyparsing 2.1.4+dfsg1-1 which has a number of bug
fixes.  Please try that.  If it works for you, great!  Please close this bug.

If it still doesn't work for you, please provide a reproducible test case.



Bug#817936: roger-router: Please add libpeas-1.0-0-python2loader to Depends

2016-05-13 Thread Barry Warsaw
On May 13, 2016, at 08:51 AM, Rolf Leggewie wrote:

>Ubuntu is still unchanged both in Xenial and Yakkety.

I'm currently in the process of resyncing the libpeas stack in Debian back to
Yakkety.  It's slow going because the python2/3 loader issue isn't the only
delta from Debian in these packages.

I'm not currently planning on SRUing all of this back into Xenial, and I'm not
even sure such SRUs would be acceptable.  Let's try to DTRT in Yakkety and
figure out the minimal amount of work needed to fix whatever's broken in
Xenial.  But let's do the latter in response to actual bug reports from users.

Since roger-router doesn't ship any Python code itself, I don't think it
should Depends on libpeas-1.0-python2loader.  Given that your follow up to
Jan-Michael asks about the existence of Python 2 plugins for roger, it seems
premature to add that Suggests to roger, and I totally agree about encouraging
the port of any such third party plugins to Python 3.

Note that any plugins which exist in the archive should themselves Depend on
libpeas-1.0-python2loader if they are Python 2.  (For Xenial, they'd have to
add a Depends on libpeas-1.0-python3loader if they were Python 3, but for
Debian and Yakkety, they would just Depends on libpeas since they get the
Python 3 loader for free now.)  Any third-party plugins not in the archive
will have to apt install the Python 2 loader itself.

Does that sound right and good to you?


pgpxwxtZWhIZz.pgp
Description: OpenPGP digital signature


Bug#820312: marked as pending

2016-05-11 Thread Barry Warsaw
tag 820312 pending
thanks

Hello,

Bug #820312 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/enum34.git;a=commitdiff;h=d0dc602

---
commit d0dc602f58cb2e04a0b559e79285e646d4bc2f26
Author: Barry Warsaw <ba...@python.org>
Date:   Wed May 11 14:39:40 2016 -0400

New upstream release.

* New upstream release.
  - Closes: #793506
  - Closes: #820312

diff --git a/debian/changelog b/debian/changelog
index db49fb4..f84459b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,7 +4,9 @@ enum34 (1.1.5-1) UNRELEASED; urgency=medium
   * Fixed VCS URL (https)
 
   [ Barry Warsaw ]
-  * New upstream release. (Closes: #793506)
+  * New upstream release.
+- Closes: #793506
+- Closes: #820312
   * d/control:
 - Bump Standards-Version to 3.9.8 with no other changes needed.
 - Swap Maintainer and Uploaders.



Bug#821223: [Python-modules-team] Bug#821223: Unable to create a virtualenv: invalid requirement: '_markerlib'

2016-04-18 Thread Barry Warsaw
I'll have a fix uploaded momentarily.



Bug#821223: (no subject)

2016-04-18 Thread Barry Warsaw
Can you please report the output of `dpkg-query -W python-pip-whl`, both if
virtualenv works and doesn't work for you?



Bug#820195: (no subject)

2016-04-13 Thread Barry Warsaw
FWIW, attached is the patch in Ubuntu which fixes the FTBFS.  This comes from
0.6-1ubuntu1.
Description: Adapt tests to changes in NumPy 1.10 Default casting rule
Origin: Upstream (commit 9b91b1789c8dc81e84c0a8691febbd1e242a81d1)

---
 pint/testsuite/helpers.py | 8 +++-
 pint/testsuite/test_issues.py | 2 +-
 pint/testsuite/test_numpy.py  | 1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

--- a/pint/testsuite/helpers.py
+++ b/pint/testsuite/helpers.py
@@ -2,11 +2,17 @@
 
 from __future__ import division, unicode_literals, print_function, absolute_import
 
+from distutils.version import StrictVersion
+
 from pint.compat import unittest, HAS_NUMPY, HAS_UNCERTAINTIES, NUMPY_VER, PYTHON3
 
 
 def requires_numpy18():
-return unittest.skipUnless(NUMPY_VER >= '1.8', 'Requires NumPy >= 1.8')
+return unittest.skipUnless(StrictVersion(NUMPY_VER) >= StrictVersion('1.8'), 'Requires NumPy >= 1.8')
+
+
+def requires_numpy_previous_than(version):
+return unittest.skipUnless(StrictVersion(NUMPY_VER) < StrictVersion(version), 'Requires NumPy < %s' % version)
 
 
 def requires_numpy():
--- a/pint/testsuite/test_issues.py
+++ b/pint/testsuite/test_issues.py
@@ -404,7 +404,7 @@
 self.assertQuantityAlmostEqual(x + y, 5.1 * ureg.meter)
 self.assertQuantityAlmostEqual(z, 5.1 * ureg.meter)
 
-
+@helpers.requires_numpy_previous_than('1.10')
 def test_issue94(self):
 ureg = UnitRegistry()
 v1 = np.array([5, 5]) * ureg.meter
--- a/pint/testsuite/test_numpy.py
+++ b/pint/testsuite/test_numpy.py
@@ -165,6 +165,7 @@
 self.assertRaises(ValueError, self.q.cumprod)
 self.assertQuantityEqual((self.q / self.ureg.m).cumprod(), [1, 2, 6, 24])
 
+@helpers.requires_numpy_previous_than('1.10')
 def test_integer_div(self):
 a = [1] * self.ureg.m
 b = [2] * self.ureg.m


Bug#815294: marked as pending

2016-04-11 Thread Barry Warsaw
tag 815294 pending
thanks

Hello,

Bug #815294 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-scripttest.git;a=commitdiff;h=d861abd

---
commit d861abd6921e13b2d07f6b482fdb2a7e2bad8909
Author: Barry Warsaw <ba...@python.org>
Date:   Mon Apr 11 16:42:14 2016 -0400

Fix FTBFS, bump Standards-Version, add DEP-8 tests.

* d/rules: override_dh_auto_test: Don't run the test suite at build time
  since upstream's tests/ directory isn't included in the tarball.
  (Closes: #815294)
* d/control: Bump Standards-Version to 3.9.7 with no other changes needed.
* d/tests/: Added simple import-based DEP-8 tests.

diff --git a/debian/changelog b/debian/changelog
index f531106..daefc40 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,16 @@
 python-scripttest (1.3-2) UNRELEASED; urgency=medium
 
+  [ Ondřej Nový ]
   * Fixed VCS URL (https)
 
- -- Ondřej Nový <n...@ondrej.org>  Tue, 29 Mar 2016 22:22:37 +0200
+  [ Barry Warsaw ]
+  * d/rules: override_dh_auto_test: Don't run the test suite at build time
+since upstream's tests/ directory isn't included in the tarball.
+(Closes: #815294)
+  * d/control: Bump Standards-Version to 3.9.7 with no other changes needed.
+  * d/tests/: Added simple import-based DEP-8 tests.
+
+ -- Barry Warsaw <ba...@debian.org>  Mon, 11 Apr 2016 16:31:42 -0400
 
 python-scripttest (1.3-1) unstable; urgency=medium
 



Bug#804582: (no subject)

2016-04-08 Thread Barry Warsaw
Okay, so I think the locale changes are enough to fix the FTBFS.  I retried
building in an Ubuntu PPA and the build succeeded.

The timeout failure must just have been a problem with my local sbuild.



Bug#804582: (no subject)

2016-04-08 Thread Barry Warsaw
It's a locale problem.  This fixes most of the problems:

diff --git a/debian/rules b/debian/rules
index 9c04662..6130dc4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,8 @@
 #!/usr/bin/make -f
 
 export PYBUILD_NAME=paramiko
+export PYBUILD_VERBOSE=1
+export DH_VERBOSE=1
 
 %:
dh $@ --with python2,python3 --buildsystem=pybuild
@@ -11,3 +13,12 @@ ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
 endif
dh_installdocs
 
+override_dh_auto_test:
+   mkdir -p $(CURDIR)/tmp-locales
+   localedef -i /usr/share/i18n/locales/en_US -c -f UTF-8 \
+ -A /usr/share/locale/locale.alias \
+ $(CURDIR)/tmp-locales/en_US.UTF-8
+   LOCPATH=$(CURDIR)/tmp-locales LC_ALL=en_US.UTF-8 \
+   dh_auto_test -- \
+   --system=custom \
+   --test-args='{interpreter} $(CURDIR)/test.py --verbose'


Unfortunately, I still have one last test I'm tracking down in python3.5
(python2.7 passes now):

==
FAIL: test_L_handshake_timeout (tests.test_transport.TransportTest)
--
Traceback (most recent call last):
  File "/<>/tests/test_transport.py", line 811, in 
test_L_handshake_timeout
password='pygmalion')
AssertionError: EOFError not raised by connect



Bug#804582: (no subject)

2016-04-08 Thread Barry Warsaw
I haven't quite fixed it yet, but it's almost certainly related to FOLDER in
test_sftp.py.  When the tests, such as test_K_utf8() fail, it's because the
folder isn't empty so the os.rmdir() fails.

Quickly I tried to add a TEST_FOLDER=`mktemp -d` to the test command but that
didn't quite work.  I think that's still probably on the right track, but I
don't have some detail right yet.



Bug#804582: (no subject)

2016-04-08 Thread Barry Warsaw
On Apr 08, 2016, at 10:59 AM, Jeremy T. Bouse wrote:

>Yes, I'd taken a slightly different approach but got to the same results
>that you are currently getting. I have included your approach as it is
>much cleaner than what I'd hacked together.
>
>Still trying to get to the bottom of those remaining failures causing
>the test to fail and the build to cease.

Awesome, thanks.  I'm also trying to investigate those last few failures.  I
applied the following patch to get a bit more debugging, but other than seeing
the errno is 4 (EINTR) I don't have any more information.

I also looked at updating the package to the latest upstream but that didn't
seem to help the failures, and upstream's latest tarball isn't compatible with
the current quilt patch.  I also tried 1.15.4 but that didn't help either.

I'll also note that `tox -e py27,py35` of upstream's git (master, v1.15.3, and
v1.15.4) passes all its tests so there's something weird about the build
environment that's breaking the build.  FWIW, I'm using sbuild with a sid
chroot.

--- a/paramiko/sftp_client.py
+++ b/paramiko/sftp_client.py
@@ -803,7 +803,7 @@
 elif code == SFTP_PERMISSION_DENIED:
 raise IOError(errno.EACCES, text)
 else:
-raise IOError(text)
+raise IOError(code, text)
 
 def _adjust_cwd(self, path):
 """


pgpuW7HIy20DY.pgp
Description: OpenPGP digital signature


Bug#804582: (no subject)

2016-04-07 Thread Barry Warsaw
I'm running across this too now.  I think part of the problem is that pybuild
invokes unittest discover by default, but this isn't how paramiko's test suite
is actually run, at least if you go by what's in the tox.ini file.

This gets me closer:

diff --git a/debian/rules b/debian/rules
index 9c04662..8d5d25b 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,6 +1,7 @@
 #!/usr/bin/make -f
 
 export PYBUILD_NAME=paramiko
+export PYBUILD_TEST_ARGS={interpreter} $(CURDIR)/test.py
 
 %:
dh $@ --with python2,python3 --buildsystem=pybuild
@@ -11,3 +12,5 @@ ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
 endif
dh_installdocs
 
+override_dh_auto_test:
+   PYBUILD_SYSTEM=custom dh_auto_test


But I'm still seeing two failures and two errors:

==
ERROR: test_K_utf8 (tests.test_sftp.SFTPTest)
--
Traceback (most recent call last):
  File "/<>/tests/test_sftp.py", line 171, in tearDown
sftp.rmdir(FOLDER)
  File "/<>/paramiko/sftp_client.py", line 390, in rmdir
self._request(CMD_RMDIR, path)
  File "/<>/paramiko/sftp_client.py", line 729, in _request
return self._read_response(num)
  File "/<>/paramiko/sftp_client.py", line 776, in _read_response
self._convert_status(msg)
  File "/<>/paramiko/sftp_client.py", line 806, in _convert_status
raise IOError(text)
IOError: Failure

==
ERROR: test_L_utf8_chdir (tests.test_sftp.SFTPTest)
--
Traceback (most recent call last):
  File "/<>/tests/test_sftp.py", line 679, in test_L_utf8_chdir
sftp.mkdir(FOLDER + '/' + unicode_folder)
  File "/<>/paramiko/sftp_client.py", line 380, in mkdir
self._request(CMD_MKDIR, path, attr)
  File "/<>/paramiko/sftp_client.py", line 729, in _request
return self._read_response(num)
  File "/<>/paramiko/sftp_client.py", line 776, in _read_response
self._convert_status(msg)
  File "/<>/paramiko/sftp_client.py", line 806, in _convert_status
raise IOError(text)
IOError: Failure

==
FAIL: test_K_utf8 (tests.test_sftp.SFTPTest)
--
Traceback (most recent call last):
  File "/<>/tests/test_sftp.py", line 675, in test_K_utf8
self.fail('exception ' + str(e))
AssertionError: exception Failure

==
FAIL: test_O_getcwd (tests.test_sftp.SFTPTest)
--
Traceback (most recent call last):
  File "/<>/tests/test_sftp.py", line 734, in test_O_getcwd
self.assertEqual(None, sftp.getcwd())
AssertionError: None != u'/'

--
Ran 148 tests in 34.596s

FAILED (failures=2, errors=2)



Bug#807351: (no subject)

2016-04-04 Thread Barry Warsaw
I just ran across this bug too, but not until I worked out a different
patch. ;)

I'd be fine with Neil's patch, or deleting the test entirely.  In the
attached, I only assert that the SystemError is raised, but not what the
exception message is.

The other change is to close a small (possibly only theoretical) hole which
could leak the temporary file.  Ideally, this should probably use a
with-statement and tempfile.NamedTemporaryFile.
diff --git a/tests/test_deb822.py b/tests/test_deb822.py
index 698366b..33c569d 100755
--- a/tests/test_deb822.py
+++ b/tests/test_deb822.py
@@ -911,16 +911,17 @@ Description: python modules to work with Debian-related data formats
 
 See also https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750247#35
 """
-fd, filename = tempfile.mkstemp()
-fp = os.fdopen(fd, 'wb')
-fp.write(UNPARSED_PARAGRAPHS_WITH_COMMENTS.encode('utf-8'))
-fp.close()
-
 try:
+fd, filename = tempfile.mkstemp()
+fp = os.fdopen(fd, 'wb')
+fp.write(UNPARSED_PARAGRAPHS_WITH_COMMENTS.encode('utf-8'))
+fp.close()
+
 with open_utf8(filename) as fh:
-paragraphs = list(deb822.Deb822.iter_paragraphs(
-fh, use_apt_pkg=True))
-self.assertEqual(paragraphs[0]['Build-Depends'], 'debhelper,')
+self.assertRaises(SystemError,
+  list,
+  deb822.Deb822.iter_paragraphs(
+  fh, use_apt_pkg=True))
 finally:
 os.remove(filename)
 


Bug#815864: (no subject)

2016-03-09 Thread Barry Warsaw
Patch updated, hopefully for the last time!

diff --git a/debian/changelog b/debian/changelog
index 824ce2a..819e79e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+python3.5 (3.5.1-8) UNRELEASED; urgency=medium
+
+  * d/patches/ensurepip-disabled.diff: Provide more debugging when the
+ensurepip command fails.
+  * d/patches/ensurepip-wheels.diff: Update for compatibility with latest
+python-pip packages.
+  * d/control.in: Update python-pip-whl dependency version.
+
+ -- Barry Warsaw <ba...@debian.org>  Wed, 09 Mar 2016 16:23:54 -0500
+
 python3.5 (3.5.1-7) unstable; urgency=medium
 
   * Update to 20160224 from the 3.5 branch.
diff --git a/debian/control.in b/debian/control.in
index 3999830..984111e 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -38,7 +38,7 @@ Architecture: any
 Multi-Arch: allowed
 Priority: @PRIO@
 Depends: @PVER@ (= ${binary:Version}),
- python-pip-whl (>= 8.0.2-7), ${shlibs:Depends}, ${misc:Depends}
+ python-pip-whl (>= 8.1.0-2), ${shlibs:Depends}, ${misc:Depends},
 Breaks: python3-pip (<< 1.5.6-4)
 Description: Interactive high-level object-oriented language (pyvenv binary, version @VER@)
  Python is a high-level, interactive, object-oriented language. Its @VER@ version
diff --git a/debian/patches/ensurepip-disabled.diff b/debian/patches/ensurepip-disabled.diff
index 7fbc575..1226e2e 100644
--- a/debian/patches/ensurepip-disabled.diff
+++ b/debian/patches/ensurepip-disabled.diff
@@ -1,10 +1,8 @@
 # DP: Disable ensurepip for the system installation, only enable it for virtual environments.
 
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
-@@ -8,6 +8,34 @@ import tempfile
+@@ -8,6 +8,34 @@
  
  __all__ = ["version", "bootstrap"]
  
@@ -39,7 +37,7 @@ Index: b/Lib/ensurepip/__init__.py
  
  # pip currently requires ssl support, so we try to provide a nicer
  # error message when that is missing (http://bugs.python.org/issue19744)
-@@ -68,6 +96,11 @@ def bootstrap(*, root=None, upgrade=Fals
+@@ -68,6 +96,11 @@
  
  Note that calling this function will alter both sys.path and os.environ.
  """
@@ -51,11 +49,9 @@ Index: b/Lib/ensurepip/__init__.py
  if altinstall and default_pip:
  raise ValueError("Cannot use altinstall and default_pip together")
  
-Index: b/Lib/venv/__init__.py
-===
 --- a/Lib/venv/__init__.py
 +++ b/Lib/venv/__init__.py
-@@ -254,7 +254,24 @@ class EnvBuilder:
+@@ -252,7 +252,28 @@
  # intended for the global Python environment
  cmd = [context.env_exe, '-Im', 'ensurepip', '--upgrade',
  '--default-pip']
@@ -65,7 +61,9 @@ Index: b/Lib/venv/__init__.py
 +# following command will produce an unhelpful error.  Let's make it
 +# more user friendly.
 +try:
-+subprocess.check_output(cmd, stderr=subprocess.STDOUT)
++subprocess.check_output(
++cmd, stderr=subprocess.STDOUT,
++universal_newlines=True)
 +except subprocess.CalledProcessError:
 +print("""\
 +The virtual environment was not created successfully because ensurepip is not
@@ -76,7 +74,9 @@ Index: b/Lib/venv/__init__.py
 +
 +You may need to use sudo with that command.  After installing the python3-venv
 +package, recreate your virtual environment.
-+""")
++
++Failing command: {}
++""".format(cmd))
 +sys.exit(1)
  
  def setup_scripts(self, context):
diff --git a/debian/patches/ensurepip-wheels.diff b/debian/patches/ensurepip-wheels.diff
index 930e013..45044f8 100644
--- a/debian/patches/ensurepip-wheels.diff
+++ b/debian/patches/ensurepip-wheels.diff
@@ -1,5 +1,3 @@
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
 @@ -1,3 +1,4 @@
@@ -7,7 +5,7 @@ Index: b/Lib/ensurepip/__init__.py
  import os
  import os.path
  import pkgutil
-@@ -8,13 +9,9 @@ import tempfile
+@@ -8,13 +9,9 @@
  __all__ = ["version", "bootstrap"]
  
  
@@ -22,7 +20,7 @@ Index: b/Lib/ensurepip/__init__.py
  try:
  import ssl
  except ImportError:
-@@ -26,8 +23,8 @@ else:
+@@ -26,8 +23,9 @@
  pass
  
  _PROJECTS = [
@@ -30,10 +28,11 @@ Index: b/Lib/ensurepip/__init__.py
 -("pip", _PIP_VERSION),
 +"setuptools",
 +"pip",
++"pkg_resources",
  ]
  
  
-@@ -45,7 +42,10 @@ def version():
+@@ -45,7 +43,10 @@
  """
  Returns a string specifying the bundled version of pip.
  """
@@ -45,7 +44,7 @@ Index: b/Lib/ensurepip/__init__.py
  
  def _disable_pip_configuration_settings():

Bug#813571: (no subject)

2016-03-08 Thread Barry Warsaw
I think this should now all be sorted out with python-virtualenv 15.0.0+ds-1
and python-pip 8.1.0-1.  I'm going to close this bug but if you're still
having a problem with those new versions, please reopen it.



Bug#815864: (no subject)

2016-03-03 Thread Barry Warsaw
Ignore the last patch.  This one is better because it no longer forces
python3.5-venv to Depends on virtualenv.  With 8.0.3-3, python-pip-whl
contains all the necessary wheels.
diff --git a/debian/changelog b/debian/changelog
index 469d204..7e3dcaf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+python3.5 (3.5.1-6ubuntu3~test0) UNRELEASED; urgency=medium
+
+  * d/patches/ensurepip-disabled.diff: Provide more debugging when the
+ensurepip command fails.
+  * d/patches/ensurepip-wheels.diff: Update for compatibility with latest
+python-pip packages.
+  * d/control.in: Update python-pip-whl version dependency.
+
+ -- Barry Warsaw <ba...@ubuntu.com>  Mon, 29 Feb 2016 16:45:06 -0500
+
 python3.5 (3.5.1-6ubuntu2) xenial; urgency=medium
 
   * python3.5-venv: Drop the dependency on python-pip-whl, depend on
diff --git a/debian/control.in b/debian/control.in
index 3999830..e63ee59 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -38,7 +38,7 @@ Architecture: any
 Multi-Arch: allowed
 Priority: @PRIO@
 Depends: @PVER@ (= ${binary:Version}),
- python-pip-whl (>= 8.0.2-7), ${shlibs:Depends}, ${misc:Depends}
+ python-pip-whl (>= 8.0.3-3), ${shlibs:Depends}, ${misc:Depends}
 Breaks: python3-pip (<< 1.5.6-4)
 Description: Interactive high-level object-oriented language (pyvenv binary, version @VER@)
  Python is a high-level, interactive, object-oriented language. Its @VER@ version
diff --git a/debian/patches/ensurepip-disabled.diff b/debian/patches/ensurepip-disabled.diff
index 7fbc575..1226e2e 100644
--- a/debian/patches/ensurepip-disabled.diff
+++ b/debian/patches/ensurepip-disabled.diff
@@ -1,10 +1,8 @@
 # DP: Disable ensurepip for the system installation, only enable it for virtual environments.
 
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
-@@ -8,6 +8,34 @@ import tempfile
+@@ -8,6 +8,34 @@
  
  __all__ = ["version", "bootstrap"]
  
@@ -39,7 +37,7 @@ Index: b/Lib/ensurepip/__init__.py
  
  # pip currently requires ssl support, so we try to provide a nicer
  # error message when that is missing (http://bugs.python.org/issue19744)
-@@ -68,6 +96,11 @@ def bootstrap(*, root=None, upgrade=Fals
+@@ -68,6 +96,11 @@
  
  Note that calling this function will alter both sys.path and os.environ.
  """
@@ -51,11 +49,9 @@ Index: b/Lib/ensurepip/__init__.py
  if altinstall and default_pip:
  raise ValueError("Cannot use altinstall and default_pip together")
  
-Index: b/Lib/venv/__init__.py
-===
 --- a/Lib/venv/__init__.py
 +++ b/Lib/venv/__init__.py
-@@ -254,7 +254,24 @@ class EnvBuilder:
+@@ -252,7 +252,28 @@
  # intended for the global Python environment
  cmd = [context.env_exe, '-Im', 'ensurepip', '--upgrade',
  '--default-pip']
@@ -65,7 +61,9 @@ Index: b/Lib/venv/__init__.py
 +# following command will produce an unhelpful error.  Let's make it
 +# more user friendly.
 +try:
-+subprocess.check_output(cmd, stderr=subprocess.STDOUT)
++subprocess.check_output(
++cmd, stderr=subprocess.STDOUT,
++universal_newlines=True)
 +except subprocess.CalledProcessError:
 +print("""\
 +The virtual environment was not created successfully because ensurepip is not
@@ -76,7 +74,9 @@ Index: b/Lib/venv/__init__.py
 +
 +You may need to use sudo with that command.  After installing the python3-venv
 +package, recreate your virtual environment.
-+""")
++
++Failing command: {}
++""".format(cmd))
 +sys.exit(1)
  
  def setup_scripts(self, context):
diff --git a/debian/patches/ensurepip-wheels.diff b/debian/patches/ensurepip-wheels.diff
index 930e013..aae0dac 100644
--- a/debian/patches/ensurepip-wheels.diff
+++ b/debian/patches/ensurepip-wheels.diff
@@ -1,5 +1,3 @@
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
 @@ -1,3 +1,4 @@
@@ -7,7 +5,7 @@ Index: b/Lib/ensurepip/__init__.py
  import os
  import os.path
  import pkgutil
-@@ -8,13 +9,9 @@ import tempfile
+@@ -8,13 +9,9 @@
  __all__ = ["version", "bootstrap"]
  
  
@@ -22,7 +20,7 @@ Index: b/Lib/ensurepip/__init__.py
  try:
  import ssl
  except ImportError:
-@@ -26,8 +23,8 @@ else:
+@@ -26,8 +23,9 @@
  pass
  
  _PROJECTS = [
@@ -30,10 +28,11 @@ Index: b/Lib/ensurepip/__init__.py
 -("pip", _PIP_VERSION),
 +"setuptools",
 +"pip",
++"pkg_resources",
  ]
  
  
-@@ -45,7 +42,10 @@ def version():
+@@ -45,7 +43,10 @@
  """
  Returns a stri

Bug#815864: (no subject)

2016-03-02 Thread Barry Warsaw
Attached is the patch that fixes this problem; it has already been forwarded
to Matthias.  The potentially controversial bit is the new dependency on
virtualenv, which is required to pick up the pip wheel.  Alternatively, we
could split python-virtualenv into a separate -support binary package, but
that of course would have to go through NEW.
diff --git a/debian/changelog b/debian/changelog
index 469d204..27eead3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,13 @@
+python3.5 (3.5.1-6ubuntu3~test0) UNRELEASED; urgency=medium
+
+  * d/patches/ensurepip-disabled.diff: Provide more debugging when the
+ensurepip command fails.
+  * d/patches/ensurepip-wheels.diff: Update for compatibility with latest
+python-pip packages.
+  * d/control.in: Add virtualenv to Depends of pythonX.Y-venv.
+
+ -- Barry Warsaw <ba...@ubuntu.com>  Mon, 29 Feb 2016 16:45:06 -0500
+
 python3.5 (3.5.1-6ubuntu2) xenial; urgency=medium
 
   * python3.5-venv: Drop the dependency on python-pip-whl, depend on
diff --git a/debian/control.in b/debian/control.in
index 3999830..bb5ac65 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -38,7 +38,7 @@ Architecture: any
 Multi-Arch: allowed
 Priority: @PRIO@
 Depends: @PVER@ (= ${binary:Version}),
- python-pip-whl (>= 8.0.2-7), ${shlibs:Depends}, ${misc:Depends}
+ python-pip-whl (>= 8.0.2-7), virtualenv, ${shlibs:Depends}, ${misc:Depends}
 Breaks: python3-pip (<< 1.5.6-4)
 Description: Interactive high-level object-oriented language (pyvenv binary, version @VER@)
  Python is a high-level, interactive, object-oriented language. Its @VER@ version
diff --git a/debian/patches/ensurepip-disabled.diff b/debian/patches/ensurepip-disabled.diff
index 7fbc575..1226e2e 100644
--- a/debian/patches/ensurepip-disabled.diff
+++ b/debian/patches/ensurepip-disabled.diff
@@ -1,10 +1,8 @@
 # DP: Disable ensurepip for the system installation, only enable it for virtual environments.
 
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
-@@ -8,6 +8,34 @@ import tempfile
+@@ -8,6 +8,34 @@
  
  __all__ = ["version", "bootstrap"]
  
@@ -39,7 +37,7 @@ Index: b/Lib/ensurepip/__init__.py
  
  # pip currently requires ssl support, so we try to provide a nicer
  # error message when that is missing (http://bugs.python.org/issue19744)
-@@ -68,6 +96,11 @@ def bootstrap(*, root=None, upgrade=Fals
+@@ -68,6 +96,11 @@
  
  Note that calling this function will alter both sys.path and os.environ.
  """
@@ -51,11 +49,9 @@ Index: b/Lib/ensurepip/__init__.py
  if altinstall and default_pip:
  raise ValueError("Cannot use altinstall and default_pip together")
  
-Index: b/Lib/venv/__init__.py
-===
 --- a/Lib/venv/__init__.py
 +++ b/Lib/venv/__init__.py
-@@ -254,7 +254,24 @@ class EnvBuilder:
+@@ -252,7 +252,28 @@
  # intended for the global Python environment
  cmd = [context.env_exe, '-Im', 'ensurepip', '--upgrade',
  '--default-pip']
@@ -65,7 +61,9 @@ Index: b/Lib/venv/__init__.py
 +# following command will produce an unhelpful error.  Let's make it
 +# more user friendly.
 +try:
-+subprocess.check_output(cmd, stderr=subprocess.STDOUT)
++subprocess.check_output(
++cmd, stderr=subprocess.STDOUT,
++universal_newlines=True)
 +except subprocess.CalledProcessError:
 +print("""\
 +The virtual environment was not created successfully because ensurepip is not
@@ -76,7 +74,9 @@ Index: b/Lib/venv/__init__.py
 +
 +You may need to use sudo with that command.  After installing the python3-venv
 +package, recreate your virtual environment.
-+""")
++
++Failing command: {}
++""".format(cmd))
 +sys.exit(1)
  
  def setup_scripts(self, context):
diff --git a/debian/patches/ensurepip-wheels.diff b/debian/patches/ensurepip-wheels.diff
index 930e013..aae0dac 100644
--- a/debian/patches/ensurepip-wheels.diff
+++ b/debian/patches/ensurepip-wheels.diff
@@ -1,5 +1,3 @@
-Index: b/Lib/ensurepip/__init__.py
-===
 --- a/Lib/ensurepip/__init__.py
 +++ b/Lib/ensurepip/__init__.py
 @@ -1,3 +1,4 @@
@@ -7,7 +5,7 @@ Index: b/Lib/ensurepip/__init__.py
  import os
  import os.path
  import pkgutil
-@@ -8,13 +9,9 @@ import tempfile
+@@ -8,13 +9,9 @@
  __all__ = ["version", "bootstrap"]
  
  
@@ -22,7 +20,7 @@ Index: b/Lib/ensurepip/__init__.py
  try:
  import ssl
  except ImportError:
-@@ -26,8 +23,8 @@ else:
+@@ -26,8 +23,9 @@
  pass
  
  _PROJECTS = [
@@ -30,10 +28,11 @@ Index: b/Lib/ensurepip/__init__.py
 -("pip", _PIP_VERSION),
 +

Bug#814622: [Python-modules-team] Bug#814622: (no subject)

2016-02-15 Thread Barry Warsaw
On Feb 15, 2016, at 08:06 PM, Sebastian Ramacher wrote:

>This is just not true. python3.m5 -m pytest works just fine. If not, please
>file a proper bug report.

The fix you uploaded introduces a regression, albeit in Ubuntu only right now,
but it will show up in Debian once Python 3.4 is dropped.  Uploading a change
that fixes one thing but regresses another is not a proper fix.  Thus, this
bug is not resolved.


pgpagjM8zszRm.pgp
Description: OpenPGP digital signature


Bug#814622: (no subject)

2016-02-15 Thread Barry Warsaw
The reversion of 2.8.7-2 is not correct.  It breaks the DEP-8 tests in Ubuntu
where there is only Python 3.5 (and will break Debian as soon as Python 3.4 is
dropped).

By reverting this, you find that there is no Python 3 module in python3-pytest
and `python3.5 -m pytest` fails.  Please restore the change from 2.8.7-2 and
find another way to fix the problem.

Personally, I don't think we should have any Python version specific /usr/bin
scripts, but I suppose we need /usr/bin/py.test and /usr/bin/py.test-3 for
backward compatibility.  Better that people get in the habit of invoking such
tools via -m.



Bug#814571: marked as pending

2016-02-15 Thread Barry Warsaw
tag 814571 pending
thanks

Hello,

Bug #814571 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-pip.git;a=commitdiff;h=e33082b

---
commit e33082b7e0da3202e43005e71e323c699b589086
Author: Barry Warsaw <ba...@python.org>
Date:   Mon Feb 15 13:12:00 2016 -0500

d/control: Update the python-setuptools-whl Breaks/Replaces versions. 
(Closes: #814571)

diff --git a/debian/changelog b/debian/changelog
index e64086c..5c534f9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-pip (8.0.2-7) UNRELEASED; urgency=medium
+
+  * d/control: Update the python-setuptools-whl Breaks/Replaces versions.
+(Closes: #814571)
+
+ -- Barry Warsaw <ba...@debian.org>  Mon, 15 Feb 2016 13:05:40 -0500
+
 python-pip (8.0.2-6) unstable; urgency=medium
 
   * d/control: Fix Breaks/Replaces version on python-six-whl.  



Bug#814571: [Python-modules-team] Bug#814571: python-setuptools-whl and python-pip-whl: error when trying to install together

2016-02-15 Thread Barry Warsaw
On Feb 15, 2016, at 11:37 AM, Matthias Klose wrote:

>No, in the first place it's a bug to not declare a proper Breaks/Replaces.

Well, in the meantime, you uploaded a new version of python-setuptools, so the
Breaks/Replaces that already exists in python-pip is now out of date.  But if
you agree to remove python-setuptools-whl in 20.0-3, I will update the B/R in
python-pip to match it.

>And yes, you asked me to remove the whl package, but without giving a reason
>for it in your forward.

Okay, but it was discussed fairly extensively in debian-python@ already, both
in terms of the technology and the changes in Debian Python Policy, which are
already committed to its vcs.  But to re-iterate:

Through the use of dirtbike, packages which require -whls will build them at
their own build-time, but this is limited to pip and virtualenv.  Because the
dependencies of upstream pip change, this is the only viable option for
sustainability.  Thus the previous -whl packages sprinkled throughout the
archive should now be removed.

I've included the patch here.  I'm not going to play whack-a-mole with this
bug, but it will be fixed when python-setuptools-whl is removed.
diff --git a/debian/control b/debian/control
index 164dc1c..d969756 100644
--- a/debian/control
+++ b/debian/control
@@ -9,7 +9,6 @@ Build-Depends:
  python-all,
  python3-all,
  python3-sphinx,
- python3-wheel
 Build-Conflicts: python-setuptools, python3-setuptools
 Standards-Version: 3.9.6
 Homepage: https://pypi.python.org/pypi/setuptools
@@ -91,11 +90,3 @@ Depends:
 Suggests: python-setuptools-doc
 Description: PyPy Distutils Enhancements
  Extensions to the python-distutils for large or complex distributions.
-
-Package: python-setuptools-whl
-Architecture: all
-Depends: ${misc:Depends}
-Description: Python Distutils Enhancements (wheel package)
- Extensions to the python-distutils for large or complex distributions.
- .
- This package provides setuptools in PEP 427 wheel format.
diff --git a/debian/rules b/debian/rules
index d71db5a..564b847 100755
--- a/debian/rules
+++ b/debian/rules
@@ -17,10 +17,6 @@ override_dh_auto_install:
 
 	$(MAKE) -C docs html
 
-	mkdir -p debian/python-setuptools-whl/usr/share/python-wheels
-	python3 setup.py bdist_wheel --universal \
-	-d debian/python-setuptools-whl/usr/share/python-wheels
-
 	# dh_pypy from dh-python < 1.20150705-1 falls over requires.txt
 	# and our requires.txt aren't useful
 	find debian/tmp -name requires.txt -delete


pgpSewR1SQdJx.pgp
Description: OpenPGP digital signature


Bug#814571: [Python-modules-team] Bug#814571: python-setuptools-whl and python-pip-whl: error when trying to install together

2016-02-13 Thread Barry Warsaw
On Feb 13, 2016, at 07:27 AM, Ralf Treinen wrote:

>Here is a list of files that are known to be shared by both packages
>(according to the Contents file for sid/amd64, which may be
>slightly out of sync):
>
>  /usr/share/python-wheels/setuptools-20.0-py2.py3-none-any.whl
>
>This bug has been filed against both packages. If you, the maintainers of
>the two packages in question, have agreed on which of the packages will
>resolve the problem please reassign the bug to that package. You may then
>also register in the BTS that the other package is affected by the bug.

It is a bug in setuptools and I forwarded a patch to the maintainer.  I'm
happy to NMU it if preferred.



Bug#813399: [Python-modules-team] Bug#813399: python-pip-whl: fails to upgrade from 'testing' - trying to overwrite /usr/share/python-wheels/six-1.10.0-py2.py3-none-any.whl

2016-02-12 Thread Barry Warsaw
On Feb 12, 2016, at 01:11 PM, Andreas Beckmann wrote:

>the Breaks+Replaces against python-six-whl are insufficiently versioned,
>that package was removed in six 1.10.0-3, it is still present in -2.

I'm not sure I can make piuparts cooperate for me locally, but it's obvious
the Replaces/Breaks for python-six-whl should be bumped to 1.10.0-2, so I am
going to upload python-pip 8.0.2-6 that fixes this.



Bug#813399: marked as pending

2016-02-12 Thread Barry Warsaw
tag 813399 pending
thanks

Hello,

Bug #813399 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-pip.git;a=commitdiff;h=7994a76

---
commit 7994a7639100ece279608917e1fb1867cb103d83
Author: Barry Warsaw <ba...@python.org>
Date:   Fri Feb 12 14:24:07 2016 -0500

d/control: Fix Breaks/Replaces version on python-six-whl.   (Closes: 
#813399)

diff --git a/debian/changelog b/debian/changelog
index 423a15c..e64086c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-pip (8.0.2-6) unstable; urgency=medium
+
+  * d/control: Fix Breaks/Replaces version on python-six-whl.  
+(Closes: #813399)
+
+ -- Barry Warsaw <ba...@debian.org>  Fri, 12 Feb 2016 14:23:58 -0500
+
 python-pip (8.0.2-5) unstable; urgency=medium
 
   * d/control: Fix Built-Using package names.



Bug#814069: python-six-whl and python-pip-whl: error when trying to install together

2016-02-08 Thread Barry Warsaw
On Feb 08, 2016, at 10:51 AM, Colin Watson wrote:

>Looks like https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=813399, but
>more of the same.  Barry, shouldn't you be doing something like
>"python-six-whl (<< 1.10.0+)", rather than these sketchy <= dependencies
>on specific packaging revisions that are going to break when we do
>something innocuous in six?
>
>The whole way this devendoring is handled seems very very sketchy
>anyway.  I take it that you're trying to ensure that pip has
>exactly-versioned wheels available even when (e.g.) six moves on to a
>newer upstream version?  In that case, I suggest finding a way to ship
>the necessary wheels in a directory private to pip instead of in
>/usr/share/python-wheels/.  We really shouldn't be deliberately shipping
>the same file in two different packages for more than just temporary
>transitional purposes.
>
>> Here is a list of files that are known to be shared by both packages
>> (according to the Contents file for sid/amd64, which may be
>> slightly out of sync):
>> 
>>   /usr/share/python-wheels/six-1.10.0-py2.py3-none-any.whl
>> 
>> This bug has been filed against both packages. If you, the maintainers of
>> the two packages in question, have agreed on which of the packages will
>> resolve the problem please reassign the bug to that package. You may then
>> also register in the BTS that the other package is affected by the bug.  
>
>I would be inclined to argue that this path clearly belongs to the
>python-six-whl package.  Barry, do you agree with me reassigning this
>bug to python-pip-whl?

-whl packages really only exist for pip and virtualenv.  As per Debian Python
policy, they shouldn't be used for anything else in the archive.  It used to
be that the only way we could provide those .whl files was to build them when
we built the dependent packages, thus we had to add python-six-whl and others.

But now we have dirtbike, which is a tool to turn .deb provided packages back
into wheels, so pip and virtualenv build whatever they need using dirtbike in
their own d/rules files, and have Built-Using headers to at least document
this; or at least *did* - it looks like some things got lost or mis-merged
from an earlier branch :(

So where we ultimately want to end up is that python-six-whl and the others go
away.  Instead, we'll have only python-pip-whl and another -whl package in
virtualenv to provide a few additional requirements.  I haven't uploaded or
file bugs for the appropriate changes in the dependent packages yet.  I
thought I had everything working locally and ready to go, but I've run into a
few snafus which I'm still working out.

Anyway, that's the plan.  As you mention, this really is a transitional period
and I thought it would go more smoothly.  /usr/share/python-wheels will not
have two paths owned by two different packages once this is done.  Debian
Python Policy has been updated in bzr but not yet pushed out (there are other
unrelated changes pending).

You're right Colin, that this bug really belongs in pip and I think it should
be duped to #813399; which I closed over the weekend, but maybe not
correctly.  You might be right about the << dependencies, in which case, let's
keep this bug (#814069) as a separate bug, but move it to python-pip.

Hopefully that makes sense.  Apologies for all the brokenness I've introduced.
I had some work priorities that unfortunately interrupted this transition, but
I'll be working only on this transition now until it's all fixed.


pgpf0J7Mx91l1.pgp
Description: OpenPGP digital signature


Bug#813399: [Python-modules-team] Bug#813399: python-pip-whl: fails to upgrade from 'testing' - trying to overwrite /usr/share/python-wheels/six-1.10.0-py2.py3-none-any.whl

2016-02-01 Thread Barry Warsaw
On Feb 01, 2016, at 04:24 PM, Andreas Beckmann wrote:

>during a test with piuparts I noticed your package fails to upgrade from
>'testing'.
>It installed fine in 'testing', then the upgrade to 'sid' fails
>because it tries to overwrite other packages files without declaring a
>Breaks+Replaces relation.
>
>See policy 7.6 at
>https://www.debian.org/doc/debian-policy/ch-relationships.html#s-replaces
>
>>From the attached log (scroll to the bottom...):  
>
>  Selecting previously unselected package python-pip-whl.
>  Preparing to unpack .../python-pip-whl_8.0.2-2_all.deb ...
>  Unpacking python-pip-whl (8.0.2-2) ...
>  dpkg: error processing archive 
> /var/cache/apt/archives/python-pip-whl_8.0.2-2_all.deb (--unpack):
>   trying to overwrite 
> '/usr/share/python-wheels/six-1.10.0-py2.py3-none-any.whl', which is also in 
> package python-six-whl 1.10.0-1
>  dpkg-deb: error: subprocess paste was killed by signal (Broken pipe)
>  Errors were encountered while processing:
>   /var/cache/apt/archives/python-pip-whl_8.0.2-2_all.deb

python-pip-whl has Breaks/Replaces, but it looks like I got the version
specifications wrong.



Bug#813399: marked as pending

2016-02-01 Thread Barry Warsaw
tag 813399 pending
thanks

Hello,

Bug #813399 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-pip.git;a=commitdiff;h=af4faa1

---
commit af4faa13f52f7c14b5a06c77a5ff2aad20164fce
Author: Barry Warsaw <ba...@python.org>
Date:   Mon Feb 1 13:09:38 2016 -0500

d/control: Fix Breaks/Depends for python-pip-whl.  (Closes: #813399)

diff --git a/debian/changelog b/debian/changelog
index 686617a..6c49120 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,7 @@
 python-pip (8.0.2-3) UNRELEASED; urgency=medium
 
   * Fix python-pip Recommends of python-all-dev.  (Closes: #799559)
+  * d/control: Fix Breaks/Depends for python-pip-whl.  (Closes: #813399)
 
  -- Barry Warsaw <ba...@debian.org>  Sat, 30 Jan 2016 17:07:08 -0500
 



Bug#813162: [Python-modules-team] Bug#813162: python3-pip: missing dependencies

2016-01-29 Thread Barry Warsaw
Hi Sebastian,

On Jan 30, 2016, at 01:34 AM, Sebastian Ramacher wrote:

>This was an upgrade and python-pip-whl version 1.5.6-7 is installed.

You definitely need python-pip-whl 8.0.2-1

Did that not install when you upgraded?


pgpxoVou06iwX.pgp
Description: OpenPGP digital signature


Bug#813162: [Python-modules-team] Bug#813162: python3-pip: missing dependencies

2016-01-29 Thread Barry Warsaw
On Jan 30, 2016, at 01:07 AM, Sebastian Ramacher wrote:

>After installing python3-cachecontrol, python3-lockfile, python3-packaging,
>python3-progress and python3-retrying, pip3 no longer fails with ImportErrors.

Those shouldn't be necessary.  Was this an upgrade or a fresh install of these
packages?  Do you have python-pip-whl installed?


pgpaYzZvDmUKs.pgp
Description: OpenPGP digital signature


Bug#813162: marked as pending

2016-01-29 Thread Barry Warsaw
tag 813162 pending
thanks

Hello,

Bug #813162 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-pip.git;a=commitdiff;h=b17ccb1

---
commit b17ccb1c0f4bed16364605f7f9945854c3fd5877
Author: Barry Warsaw <ba...@python.org>
Date:   Fri Jan 29 21:44:08 2016 -0500

d/control: Add binary version dependency. (Closes: #813162)

diff --git a/debian/changelog b/debian/changelog
index 90d8104..2744c8c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+python-pip (8.0.2-2) UNRELEASED; urgency=medium
+
+  * d/control: Add binary version dependency. (Closes: #813162)
+
+ -- Barry Warsaw <ba...@ubuntu.com>  Fri, 29 Jan 2016 21:39:41 -0500
+
 python-pip (8.0.2-1) unstable; urgency=medium
 
   * New upstream release.



Bug#810139: (no subject)

2016-01-15 Thread Barry Warsaw
Ultimately, this is a bug in Cython, which upstream is aware of and should fix
by Python 3.6.  I reverted the change in upstream Python 3.5 (and 2.7) since
it's technically a regression.  Matthias has cherry picked the fix for
Ubuntu's Python 3.5; I assume but am not sure if he's also done the same for
Debian.



Bug#808843: marked as pending

2016-01-04 Thread Barry Warsaw
tag 808843 pending
thanks

Hello,

Bug #808843 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-pyramid.git;a=commitdiff;h=52a8f94

---
commit 52a8f944af07a44758c6f5b8f815856d77787b59
Author: Barry Warsaw <ba...@ubuntu.com>
Date:   Mon Jan 4 13:42:53 2016 -0500

New upstream release.

* Team upload.
* New upstream release.  (Closes: #808843)
* d/watch: Adjust filenamemangle to account for seemingly recent uscan
  behavior change where it doesn't strip everything before the last slash.

diff --git a/debian/changelog b/debian/changelog
index 6c4088e..c57226b 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+python-pyramid (1.6+dfsg-1) UNRELEASED; urgency=medium
+
+  * Team upload.
+  * New upstream release.  (Closes: #808843)
+  * d/watch: Adjust filenamemangle to account for seemingly recent uscan
+behavior change where it doesn't strip everything before the last slash.
+
+ -- Barry Warsaw <ba...@debian.org>  Mon, 04 Jan 2016 13:39:41 -0500
+
 python-pyramid (1.5.7+dfsg-1) unstable; urgency=medium
 
   * Team upload.



Bug#804558: [Python-modules-team] Bug#804558: tweepy: FTBFS: ImportError: No module named {unittest2, vcr}

2016-01-04 Thread Barry Warsaw
On Jan 04, 2016, at 10:43 AM, Carl Chenet wrote:

>We have a RC bug for Tweepy in Debian because the unittest2 and/or vcr
>Python modules are not packaged for Debian

Not correct.  Both packages are in Debian for both Python 2 and 3.

We have unittest2 1.1.0-6 and vcr 1.7.3-1

There must be some other build problem going on.

>Tell me if I'm wrong but unittests executions are not mandatory by
>Debian policy while building a Debian package.

Probably not mandatory, but good practice.  Sometimes it's not possible to run
a package's test suite at build time for various reasons.  In those cases, I
think it's good practice to write a DEP-8 autopkgtest to at least test the
installed package.

Cheers,
-Barry



Bug#808763: [Python-modules-team] Bug#808763: Running pytest

2015-12-23 Thread Barry Warsaw
On Dec 23, 2015, at 07:20 PM, Tristan Seligmann wrote:

>If you want to run pytest with a particular version of python, then
>"pythonX.Y -m pytest" is a much better way than relying on the py.test-X.Y
>scripts.

Sorry, I've had no time to respond in detail, but in general I agree with
this.  It's true of any version-specific script (e.g. pip) even if it is a
less user-friendly ui.



Bug#795216: marked as pending

2015-11-20 Thread Barry Warsaw
tag 795216 pending
thanks

Hello,

Bug #795216 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/tox.git;a=commitdiff;h=319ab86

---
commit 319ab86dbeef788318c674e4e862019d50e99e6f
Author: Barry Warsaw <ba...@python.org>
Date:   Fri Nov 20 17:03:35 2015 -0500

d/copyright: Added missing licenses.  (Closes: #795216)

diff --git a/debian/changelog b/debian/changelog
index 55fb182..3ebc010 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ tox (2.2.1-1) unstable; urgency=medium
   * New upstream release.
   * d/patches/fix-sphinx-build.patch: Fix documentation build locations.
   * d/rules: Update override_dh_installdocs locations.
+  * d/copyright: Added missing licenses.  (Closes: #795216)
 
  -- Barry Warsaw <ba...@debian.org>  Fri, 20 Nov 2015 16:48:04 -0500
 



Bug#802141: (no subject)

2015-10-29 Thread Barry Warsaw
A better way to skip trying to run the nonexistent upstream test suite is to
add this to d/rules:

export PYBUILD_DISABLE=test



Bug#802145: marked as pending

2015-10-27 Thread Barry Warsaw
tag 802145 pending
thanks

Hello,

Bug #802145 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:


http://git.debian.org/?p=python-modules/packages/python-cachecontrol.git;a=commitdiff;h=8b1eec6

---
commit 8b1eec6402bfe18f0c92f5d094a1ea467917c205
Author: Barry Warsaw <ba...@python.org>
Date:   Tue Oct 27 16:20:02 2015 -0400

* Non-maintainer upload.
* Add python-requests to Build-Depends. (Closes: #802145)
* Removed some underscores from long description. (Closes: #799531)

diff --git a/debian/changelog b/debian/changelog
index 992ae56..59819cf 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+python-cachecontrol (0.11.5-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add python-requests to Build-Depends. (Closes: #802145)
+  * Removed some underscores from long description. (Closes: #799531)
+
+ -- Andreas Tille <ti...@debian.org>  Mon, 26 Oct 2015 10:51:48 +0100
+
 python-cachecontrol (0.11.5-1) unstable; urgency=medium
 
   * New upstream release.



Bug#802145: Attached debdiff for NMU - please commit to packaging Git

2015-10-27 Thread Barry Warsaw
On Oct 26, 2015, at 11:04 AM, Andreas Tille wrote:

>I took the freedom to fix the minor bug in addition to the serious
>one.  Please add the debdiff to your packaging git.

Done, and thanks!



Bug#802130: (no subject)

2015-10-27 Thread Barry Warsaw
https://github.com/malthe/chameleon/issues/206


pgpqR6mDavIMd.pgp
Description: OpenPGP digital signature


Bug#789670: (no subject)

2015-09-18 Thread Barry Warsaw
I think the best we can do is add a Conflicts between the two packages.  The
contents of the conflicting directories are different.  Personally, I think
it's a bug that the two upstreams install these into the top-level namespace,
but given the nature of the packages, I can see why they did it this way.

I'll upload a Conflicts for future and will begin the NMU for python-pies.


pgpuUCgg8OHqp.pgp
Description: OpenPGP digital signature


Bug#795594: (no subject)

2015-09-10 Thread Barry Warsaw
I'm attaching a diff against current svn which fixes the d/copyright issue.
It also makes some other changes which fixes the d/watch file and updates the
package to Babel 2.0 and cldr 27.  I'm not applying it because the package
doesn't build - the test fail.  I don't think upstream supports v27 yet.
OTOH, I don't want to lose these changes.  Apologies for attaching them to
this bug instead of opening a new bug.
Index: debian/changelog
===
--- debian/changelog	(revision 34223)
+++ debian/changelog	(working copy)
@@ -1,3 +1,20 @@
+python-babel (2.0+dfsg.1-1) UNRELEASED; urgency=medium
+
+  * Team upload.
+  * New upstream release.
+  * debian/copyright: Fill out the `Files: common/*` section to include
+the Unicode license agreement.  (Closes: #795594)
+  * debian/control: Update Standards-Version to 3.9.6 with no other
+changes necessary.
+  * debian/patches:
+- 0001-Fixup-get_currency_name-test.patch: Removed, applied upstream.
+- adds-support-for-python-3.2.patch: Removed, no longer necessary.
+- fix-sphinx-conf.py-to-avoid-intersphinx.patch: Refreshed.
+  * debian/repack: Update Unicode core.zip location.
+  * debian/watch: Use the pypi.debian.net redirector.
+
+ -- Barry Warsaw <ba...@debian.org>  Thu, 10 Sep 2015 15:25:31 -0400
+
 python-babel (1.3+dfsg.1-5) unstable; urgency=medium
 
   * Team upload.
Index: debian/control
===
--- debian/control	(revision 34223)
+++ debian/control	(working copy)
@@ -15,7 +15,7 @@
python3-setuptools,
python3-six,
python3-tz
-Standards-Version: 3.9.4
+Standards-Version: 3.9.6
 Homepage: http://babel.pocoo.org/
 Vcs-Svn: svn://anonscm.debian.org/python-modules/packages/python-babel/trunk/
 Vcs-Browser: http://svn.debian.org/viewsvn/python-modules/packages/python-babel/trunk/
Index: debian/copyright
===
--- debian/copyright	(revision 34223)
+++ debian/copyright	(working copy)
@@ -12,7 +12,58 @@
 License: GPL-2
 
 Files: common/*
-Copyright:
+Copyright: © 1991-2013 Unicode, Inc.
+License: Unicode
+ UNICODE, INC. LICENSE AGREEMENT - DATA FILES AND SOFTWARE
+ .
+ Unicode Data Files include all data files under the directories
+ http://www.unicode.org/Public/, http://www.unicode.org/reports/, and
+ http://www.unicode.org/cldr/data/. Unicode Data Files do not include PDF
+ online code charts under the directory http://www.unicode.org/Public/.
+ Software includes any source code published in the Unicode Standard or under
+ the directories http://www.unicode.org/Public/,
+ http://www.unicode.org/reports/, and http://www.unicode.org/cldr/data/.
+ .
+ NOTICE TO USER: Carefully read the following legal agreement. BY DOWNLOADING,
+ INSTALLING, COPYING OR OTHERWISE USING UNICODE INC.'S DATA FILES ("DATA
+ FILES"), AND/OR SOFTWARE ("SOFTWARE"), YOU UNEQUIVOCALLY ACCEPT, AND AGREE TO
+ BE BOUND BY, ALL OF THE TERMS AND CONDITIONS OF THIS AGREEMENT. IF YOU DO NOT
+ AGREE, DO NOT DOWNLOAD, INSTALL, COPY, DISTRIBUTE OR USE THE DATA FILES OR
+ SOFTWARE.
+ .
+ COPYRIGHT AND PERMISSION NOTICE
+ .
+ Copyright © 1991-2013 Unicode, Inc. All rights reserved. Distributed under
+ the Terms of Use in http://www.unicode.org/copyright.html.
+ .
+ Permission is hereby granted, free of charge, to any person obtaining a
+ copy of the Unicode data files and any associated documentation (the "Data
+ Files") or Unicode software and any associated documentation (the "Software")
+ to deal in the Data Files or Software without restriction, including without
+ limitation the rights to use, copy, modify, merge, publish, distribute, and/or
+ sell copies of the Data Files or Software, and to permit persons to whom the
+ Data Files or Software are furnished to do so, provided that (a) the above
+ copyright notice(s) and this permission notice appear with all copies of the
+ Data Files or Software, (b) both the above copyright notice(s) and this
+ permission notice appear in associated documentation, and (c) there is clear
+ notice in each modified Data File or in the Software as well as in the
+ documentation associated with the Data File(s) or Software that the data or
+ software has been modified.
+ .
+ THE DATA FILES AND SOFTWARE ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
+ KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD
+ PARTY RIGHTS. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR HOLDERS INCLUDED IN
+ THIS NOTICE BE LIABLE FOR ANY CLAIM, OR ANY SPECIAL INDIRECT OR CONSEQUENTIAL
+ DAMAGES, OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR
+ PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS
+ ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR P

Bug#796898: python-pykmip: Remove Depends and Build-Depends on python3-enum34

2015-08-25 Thread Barry Warsaw
Source: python-pykmip
Severity: serious

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Dear Maintainer,

python-pykmip currently includes Depends and Build-Depends on
python3-enum34.  This package is incompatible with Python 3.5 and
unnecessary for Python 3.4 since the stdlib already contains the
package 'enum' which is the importable name in both cases.
python3-enum34 has been removed from the archive for Stretch.

Please remove these dependencies.


- -- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.1.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBCAAGBQJV3IcfAAoJEBJutWOnSwa/410QAKa0jrDH00Ai6zy8cZxTDBuh
qwj8uitaWj0TbksidBin17O7Fbu+5rVyCVNZSCc4gutv+WlOMZRoXWWyUuOeonZX
HmQsMGTkBFCdVvWehiENjtlTcR1olTZZtDBL6EHFr54r5r+qNqPBaLx6cgf6c+xP
8C0jSegRT/PHbC5qNfghJ/7B2DoknQLG0A9MBp9NYS8RMjUXQ2ChomGw0TigQgt1
RV+AdNnviAilJZ+9rOlUn9LyUjctl1mqaYluOkD/21KOGlK/861H1fiaNoAZWnGx
ICkYwLARAj4MWPUWOdIMnKr/3cJzsfiqrd481JI3pmNGI8ubHAndJoBzFA2M4j9D
s7AkgHE4nSaTW/rRvaI5v2L3mPcPq3xbAuB6rcpUqLr3HxX/aKKV9GOKH5+tem18
qQYhx7LtiF7OuWfq5GlpoWhI6FIygGI8nLG3gO1QauxLJpVNaLiHS41AilXY1SRz
uBcCj/+DI+dFEn5UVwn4F4meGR+BduFknNidXh9TcZQ7VpHwef4N7JqsWIQBZar6
yolb/ZQbYZw0rB+ixhdH9HY+2l88aY+S91aNkPbsv56ANydiTwSog+xppdrzKxvC
9IYyGQcRM2CB4MgGScDxQtnKYlXhgdEonxcQ6R9/hLj/BEgxl96N5dlgr8SyRqco
dW/lHbxPQvY0IlyR7sEH
=FdaX
-END PGP SIGNATURE-



Bug#796909: python3-pies: Don't Depend on python3-enum34

2015-08-25 Thread Barry Warsaw
Package: python3-pies
Severity: serious

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Dear Maintainer,

python3-enum34 binary package has been removed from the archive,
because all supported versions of Python 3 already include the stdlib
enum package, and enum34 is no longer compatible with Python 3.5.
python3-pies Depends on it though.  Please remove the dependency (it's
fine for python-pies to Depend on python-enum34).

% apt-cache show python3-pies | grep Depends
Depends: python3-enum34, python3:any (= 3.3.2-2~)


- -- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.1.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQIcBAEBCAAGBQJV3LL1AAoJEBJutWOnSwa/UxwP+gKAE+oyMFqB/0gRmQAibUP1
GXyEtqhO9yDAeM4Hy9uSgdLIhw/tUWEsdhFcOsKjUFPoNkc4nQlgKr6MYT6MsuFD
11yuvNIFJKnaarGUViIotRgWzli4OvcZ9W2TKrff+zCLpnZUo+Q5UxZFWU5HRstr
7xEbjXzRNCMrrHQgU42KALZSM8V7Gyt7XVSzzTnQufKzTgGtICs4trXV7otmitJN
ZHrp44W+LQRO2y7rnOglxHq/lrJBLLGushiCWy8p58I0fsLQIA0nlufEOqPZgOFc
/IQ3it/ERvLAk4hO0NHxZSMOyOWAOhU5MQm0uQ09uEQAeb6LMLkVx5jZfHyQ69/Q
crY22dfJTEuIW/mu35Pr0iMkzCJxAtDPsAr0cXI0pV6rFAKs2jxereXbvFiayg7/
eUfxz2kEyhUZuu8o7y1FvCzaO1YKQNH/Js/Y9e8GkdTZs3MGjC2kPYJ9w0XWTyRP
KEffvm6/Fll0ddvv9IcCuePDmACJswGcRoONK4jb/xjLjOENciKj/OuGQwBSZboK
sDH5dJvAD2UK/VoVq+TRcRaAhiCoC5NheUTnxsoAdnAMjUObmu0sdRGvqU0JzWns
nfJAJ1mLyL++3qVXIfkn3gAjzUQR0xoaYG5//kvduDTDw99FjGQABdZ5wceJQEcP
F6MGP6bapA57NIgTkl/w
=tao4
-END PGP SIGNATURE-



Bug#744145: (no subject)

2015-02-27 Thread Barry Warsaw
ScottK and I discussed this and we agreed that the change is necessary, and
that the severity of this bug should be bumped to serious.  We also need to
make a change to Debian Python Policy to more accurately reflect the
restriction on wheel files.  I will handle both of these changes.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#774213: (no subject)

2015-01-12 Thread Barry Warsaw
Something else must still be going on.  I have the following zope packages
installed:

% aptitude search zope | grep ^i
i   python-zope.component   - Zope Component Architecture   
i   python-zope.configuration   - Zope Configuration Markup Language (ZCML) 
i   python-zope.deprecation - Zope Deprecation Infrastructure   
i   python-zope.event   - Very basic event publishing system
i   python-zope.exceptions  - Zope exceptions for Python
i   python-zope.i18nmessageid   - Message Identifiers for internationalizati
i A python-zope.interface   - Interfaces for Python 
i   python-zope.location- Tools for working with object locations   
i   python-zope.proxy   - Generic transparent proxies for Python
i   python-zope.schema  - zope.interface extension for defining data
i   python-zope.security- Zope Security Framework   
i   python-zope.testing - Zope testing helpers  
i   python-zope.testrunner  - Flexible test runner with layer support fo
i   python3-zope.component  - Zope Component Architecture   
i   python3-zope.configuration  - Zope Configuration Markup Language (ZCML) 
i   python3-zope.deprecation- Zope Deprecation Infrastructure   
i   python3-zope.event  - Very basic event publishing system
i   python3-zope.exceptions - Zope exceptions for Python 3  
i   python3-zope.i18nmessageid  - Message Identifiers for internationalizati
i   python3-zope.interface  - Interfaces for Python3
i   python3-zope.location   - Tools for working with object locations   
i   python3-zope.proxy  - Generic transparent proxies for Python
i   python3-zope.schema - zope.interface extension for defining data
i   python3-zope.testing- Zope testing helpers for Python 3 
i   python3-zope.testrunner - Flexible test runner with layer support fo
i A zope-common - common settings and scripts for Zope insta
i   zope2.13- Open Source Web Application Server

so definitely python-zope.security, python-zope.proxy, and zope2.13.

and yet...

% /usr/lib/zope2.13/bin/python 

 import zope.security._proxy
 zope.security._proxy.__file__
'/usr/lib/python2.7/dist-packages/zope/security/_proxy.x86_64-linux-gnu.so'


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#774213: zope2.13: import zope.security._proxy - SystemError: dynamic module not initialized properly

2015-01-07 Thread Barry Warsaw
On Dec 30, 2014, at 02:32 PM, Kirill Smelkov wrote:

Package: zope2.13
Version: 2.13.22-1
Severity: grave
Justification: renders package unusable

With zope2.13 I've tried to create a (user) instance and start it, but a
`SystemError: dynamic module not initialized properly` is raised while
zopectl tries to import zope.security._proxy .

I've tried both recipes on two different sid machines and I am unable to
reproduce the problem.  Importing zope.security._proxy succeeds for me, as
does the dzhandle [...] start command.

Perhaps it's a local problem?  Try re-installing zope.security?

Cheers,
-Barry


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#768286: marked as done (python{, 3}-zope.interface-dbg: unhandled symlink to directory conversion: /usr/share/doc/PACKAGE)

2015-01-06 Thread Barry Warsaw
On Dec 28, 2014, at 11:48 PM, Ivo De Decker wrote:

On Sun, Dec 28, 2014 at 05:31:59PM -0500, Barry Warsaw wrote:
 Would you please attach a debdiff against 4.1.1-3 so it's easier for me to
 make sure that a future release from alioth vcs doesn't regress?

Sure. Attached.

Thanks, applied.


pgpyu2aew8pc8.pgp
Description: OpenPGP digital signature


Bug#767554: python-persistent and python-zodb: error when trying to install together

2014-12-08 Thread Barry Warsaw
On Dec 08, 2014, at 01:47 PM, Arnaud Fontaine wrote:

 Arnaud Fontaine wrote (26 Nov 2014 09:03:09 GMT) :
 Really sorry about  that. FTR, I have not uploaded  anything yet because
 the release  team would prefer  to avoid  the Conflicts if  possible and
 make python-zodb depends upon  python-persistent instead. AFAIK, it does
 not seem to be an issue but I have just sent an email to upstream author
 to confirm it's not going to be an issue...

 Any answer from them?

Yes, sorry about  the lag. The upstream said there  should be no problem
for  python-zodb  to  Depends  on  python-persistent  (and  thus  remove
persistent module from python-zodb). Barry:  if that's ok, I will upload
python-persistent  with  the   Breaks/Replaces  and  upload  python-zodb
without persistent module?

+1, and thanks!


pgpHG7cQgM4P0.pgp
Description: OpenPGP digital signature


Bug#771794: pip silently removes/updates system provided python packages

2014-12-03 Thread Barry Warsaw
On Dec 02, 2014, at 10:38 PM, Scott Kitterman wrote:

Speaking only for myself, I think that sounds reasonable.

It's well established I believe in Debian Python usage that if a user
installs packages in /usr/local and break their system, they are on their
own, so I'm not particularly worried about the edge cases for having the same
python package installed in /usr/lib and /usr/local, it's on whoever
installed stuff in /usr/local.

Work's been busy for me lately, but I'll just chime in with a +1


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#771794: [Python-modules-team] Bug#771794: pip silently removes/updates system provided python packages

2014-12-03 Thread Barry Warsaw
On Dec 03, 2014, at 03:20 PM, Piotr Ożarowski wrote:

IMO we should patch pip to *not* touch (install, upgrade, uninstall,
etc.) anything in /usr directory (or /) except /usr/local. Our Python
interpreter already installs to /usr/local and so should pip.

+1

This way:
 * pip doesn't need to figure out which file can be touched,
 * we can detect cause of problems just by looking at traceback
   (right now the very first thing I do once someone sends me a
   traceback is to look for .egg files in there (thank you ez_install!);
   with pip installing/overwriting files in /usr instead of /usr/local
   it's not that easy, not to mention that it will be a lot harder to
   fix it after such install)
 * we'll be able to easily prove to our users that we're not insane
   and we did test our stuff (please rename
   /usr/local/pythonX.Y/dist-packages to something else for few minutes
   and try again)

Don't forget that `$python -S` disables `import site` which has the side
effect of not including /usr/local on sys.path.  E.g.

% python3 -c import sys; print(sys.path)
['', '/home/barry/env/python', '/usr/lib/python3.4', 
'/usr/lib/python3.4/plat-x86_64-linux-gnu', '/usr/lib/python3.4/lib-dynload', 
'/home/barry/.local/lib/python3.4/site-packages', 
'/usr/local/lib/python3.4/dist-packages', '/usr/lib/python3/dist-packages']
% python3 -S -c import sys; print(sys.path)
['', '/home/barry/env/python', '/usr/lib/python3.4/', 
'/usr/lib/python3.4/plat-x86_64-linux-gnu', '/usr/lib/python3.4/lib-dynload']

Unfortunately, as you can see, this also disables
/usr/lib/python3/dist-packages so it it's a perfect way of telling people
let's disable any non-apt managed packages.

I would support adding a special Debian -X switch which removes /usr/local
paths from sys.path.  Then, if you suspect some local outside-apt
customization is causing them problems you can ask them to run:

$ python3 -X ignore-debian-usr-local-customizations

(spelling TBD)


--
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#771794: (no subject)

2014-12-02 Thread Barry Warsaw
For reference:

https://github.com/pypa/pip/issues/1668


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#767554: python-persistent and python-zodb: error when trying to install together

2014-11-12 Thread Barry Warsaw
On Nov 12, 2014, at 05:50 PM, Arnaud Fontaine wrote:

From upstream point  of view, ZODB3 (aka python-zodb in  Debian) used to
include persistent, BTrees,  ZODB and ZEO modules.  However, since ZODB3
3.11.0a1, upstream  has split it  up into  4 distinct packages  (one for
each module),  bump the version  to 4.0  and made ZODB3  a metapackage
depending on all of them.

It looks like Debian still has zodb 3.9.7, right?

As of  fixing this RC  bug for Jessie:  Among the four,  only persistent
package is currently available in Debian, so  there is no way to get rid
of  ZODB3 (at  least for  Jessie). Barry:  If persistent  = 4.0  Debian
package is useful on  its own to anyone (and thus  should not be removed
From testing),  then can I  add a Conflict  on both packages  and upload
them to fix this bug?

IIRC, I needed to update python-persistent for the Python 3 zope.component
transition, as it's a build-dep.  There are no other reverse dependencies that
I know of.

I think a Conflicts is the right way to handle this for now, given where we
are in the Jessie release cycle.  Arnaud, thanks for handling this!


signature.asc
Description: PGP signature


Bug#752078: (no subject)

2014-06-19 Thread Barry Warsaw
I think it's better to prune the files in that directory from the orig
tarball, using a Files-Excluded header in d/copyright.  The reason for this is
that, even though the package does not currently contain the documentation, if
it ever does, it's better to rebuild the docs from scratch using
`--with sphinxdocs` than using the pre-build html.

I'm not sure my 4.1.1-2 upload with this change will be accepted or not.  It
doesn't look like 4.1.1-1 made it to the NEW queue, so I'm guessing it got
rejected although I did not see a notification.  If that's true, then the
un-repacked 4.1.1 orig tarball isn't in the archive, and this new one can get
uploaded.  If it did, then it'll probably be rejected, in which case the next
new upstream should get the proper tarball.

In the meantime, I'm crossing my fingers and giving it a go.  4.1.1-2 will
close this bug.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#751804: (no subject)

2014-06-17 Thread Barry Warsaw
Are you reporting a packaging bug or an upstream bug?  I ask because 1.7.1-1
doesn't explicitly set $HOME any more.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#719767: (no subject)

2014-05-15 Thread Barry Warsaw
Note that in Python 3.4, we have the stdlib ensurepip module which exposes the
exact same probably there.  See bug #732703 for details.  I am in the process
of uploading a Debian policy compliant solution, even though it's rather
complex.  The same solution could be shared by the standalone
python-virtualenv package.  Once #732703 is fixed, I'll look into porting that
code into python-virtualenv.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#731299: (no subject)

2013-12-12 Thread Barry Warsaw
I just updated svn for pytest 2.5.0, which depends on python-py 1.4.19.  I
updated the d/control version dependency as per this bug.

python-py's maintainer has just uploaded 1.4.19 so we should wait on uploading
pytest 2.5.0 until that's landed.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#707086: (no subject)

2013-05-24 Thread Barry Warsaw
This is caused by the ancient version of zope.interface in sid/jessie.  We
need to get z.i 4.0.5 (the latest upstream release) and then this bug will fix
itself wink.


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#572072: (no subject)

2012-10-10 Thread Barry Warsaw
For all intents and purposes, computer-janitor is abandonware.

https://bugs.launchpad.net/ubuntu/+source/computer-janitor/+bug/1050071


signature.asc
Description: PGP signature


Bug#661441: (no subject)

2012-10-02 Thread Barry Warsaw
I added a merge proposal on the Ubuntu bug which fixes the FTBFS (and adds the
`set -x` flag in d/rules).  I'm not sure upstream would approve of the patch,
since it's not clear to me whether the bogus SCRIPT tag should be entirely
stripped or not.  But in the absence of upstream response to their bug, this
does fix the FTBFS.

Here's the Ubuntu bug:

https://bugs.launchpad.net/ubuntu/quantal/+source/genshi/+bug/935516

and the merge proposal with the diff:

https://code.launchpad.net/~barry/ubuntu/quantal/genshi/lp935516/+merge/127596


signature.asc
Description: PGP signature


Bug#679968: in ipython shell -- inserts history substitution before the prompt line -- renders python-mode interactive use with ipython unusable

2012-07-03 Thread Barry Warsaw
On Jul 02, 2012, at 04:45 PM, Yaroslav Halchenko wrote:

 if python-mode.el is affected, please open a ticket also at
 https://bugs.launchpad.net/python-mode

isn't python-mode.el belonging to python-mode package the one
responsible for setting up ipython shell comint mode??? (sorry, I just
do not know those details)

I don't either since I'm not an ipython user.

Barry, I thought you had some handy way to forward bugs to LP or have
misunderstood?

We can easily link bugs in Launchpad to the related bug in Debian, but that's
about it.

N.B. Ideally, I am as a user report bugs in Debian using reportbug, and then
the mighty Maintainer either fixes them himself or forwards upstream
(i.e. LP).  Who am I to steal the pleasure of maintainership duties away from
him ? ;) and as you kindly pointed out -- it might not be a bug of
python-mode.el?...

+1

** busy fixing a bug in numpy and forwarding it upstream ATM.

Yay!



signature.asc
Description: PGP signature


Bug#646464: (no subject)

2012-02-23 Thread Barry Warsaw
Here's the patch I applied to Ubuntu to get this package to build from smc git
head.

=== modified file 'debian/changelog'
--- debian/changelog2011-09-18 22:03:34 +
+++ debian/changelog2012-02-23 14:59:43 +
@@ -1,3 +1,19 @@
+smc (1.9+git20120222-0ubuntu1) precise; urgency=low
+
+  * New upstream snapshot.  Fixes FTBFS. (LP: #903126)
+- debian/control: Add libboost-thread-dev to B-D
+- debian/patches/01_configure.ac.patch: Search for boost_filesystem-mt
+  instead of boost_filesystem (as required by patch in previous Debian
+  version of the package).  Also search for boost_system so that this
+  library gets added to the linker line.
+- debian/patches: Remove as unnecessary 01_configure.patch,
+  02_binutils-gold.patch, 03_smc_boost1.46.patch
+- debian/rules: Add get-orig-source rule to check out smc from git.
+  Add post-patches rule to run autogen.sh after applying the
+  configure.ac patches.
+
+ -- Barry Warsaw ba...@ubuntu.com  Wed, 22 Feb 2012 17:14:50 -0500
+
 smc (1.9-4ubuntu1) oneiric; urgency=low
 
   * Update 02_binutils-gold.patch to properly use LDADD. Fixes FTBFS.

=== modified file 'debian/control'
--- debian/control  2011-09-18 22:03:34 +
+++ debian/control  2012-02-22 23:01:11 +
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Ubuntu Developers ubuntu-devel-disc...@lists.ubuntu.com
 XSBC-Original-Maintainer: Muammar El Khatib muam...@debian.org
-Build-Depends: cdbs, debhelper (= 6), autotools-dev, libcegui-mk2-dev (= 
0.6.2), libboost-filesystem-dev, libsdl1.2-dev, libsdl-image1.2-dev, 
libsdl-mixer1.2-dev, libsdl-ttf2.0-dev, pkg-config, quilt (= 0.40), ttf-dejavu
+Build-Depends: cdbs, debhelper (= 6), autotools-dev, libcegui-mk2-dev (= 
0.6.2), libboost-filesystem-dev, libboost-thread-dev, libsdl1.2-dev, 
libsdl-image1.2-dev, libsdl-mixer1.2-dev, libsdl-ttf2.0-dev, pkg-config, quilt 
(= 0.40), ttf-dejavu
 Standards-Version: 3.9.1
 Homepage: http://www.secretmaryo.org
 

=== added file 'debian/patches/01_configure.ac.patch'
--- debian/patches/01_configure.ac.patch1970-01-01 00:00:00 +
+++ debian/patches/01_configure.ac.patch2012-02-23 14:43:19 +
@@ -0,0 +1,23 @@
+Author: Barry Warsaw ba...@ubuntu.com
+Description: A patch to change configure.ac file to recognize libboost.
+--- a/configure.ac
 b/configure.ac
+@@ -19,13 +19,17 @@
+ ### Check for libraries ###
+ 
+ # Check for the Boost Filesystem library
+-AC_CHECK_LIB([boost_filesystem], [main], ,
++AC_CHECK_LIB([boost_filesystem-mt], [main], ,
+   [AC_MSG_ERROR([Unable to find Boost Filesystem library])])
+ 
+ # Check for the Boost Thread library
+ AC_CHECK_LIB([boost_thread], [main], ,
+   [AC_MSG_ERROR([Unable to find Boost Thread library])])
+ 
++# Check for the Boost System library
++AC_CHECK_LIB([boost_system], [main], ,
++  [AC_MSG_ERROR([Unable to find Boost System library])])
++
+ # Check for the OpenGL and GLU library
+ case ${host} in
+ *darwin*|*macosx*)

=== removed file 'debian/patches/01_configure.patch'
--- debian/patches/01_configure.patch   2011-08-20 20:18:07 +
+++ debian/patches/01_configure.patch   1970-01-01 00:00:00 +
@@ -1,30 +0,0 @@
-Author: Joao Pinto joao.pi...@getdeb.net
-Description: A patch to change configure file to make recognize libboost.
 smc-1.9.orig/configure
-+++ smc-1.9/configure
-@@ -3377,13 +3377,13 @@
- # Check for the Boost Filesystem library
- 
- 
--{ $as_echo $as_me:$LINENO: checking for main in -lboost_filesystem 5
--$as_echo_n checking for main in -lboost_filesystem...  6; }
-+{ $as_echo $as_me:$LINENO: checking for main in -lboost_filesystem-mt 5
-+$as_echo_n checking for main in -lboost_filesystem-mt...  6; }
- if test ${ac_cv_lib_boost_filesystem_main+set} = set; then
-   $as_echo_n (cached)  6
- else
-   ac_check_lib_save_LIBS=$LIBS
--LIBS=-lboost_filesystem  $LIBS
-+LIBS=-lboost_filesystem-mt  $LIBS
- cat conftest.$ac_ext _ACEOF
- /* confdefs.h.  */
- _ACEOF
-@@ -3441,7 +3441,7 @@
- #define HAVE_LIBBOOST_FILESYSTEM 1
- _ACEOF
- 
--  LIBS=-lboost_filesystem $LIBS
-+  LIBS=-lboost_filesystem-mt $LIBS
- 
- else
-   { { $as_echo $as_me:$LINENO: error: Unable to find Boost Filesystem 
library 5

=== removed file 'debian/patches/02_binutils-gold.patch'
--- debian/patches/02_binutils-gold.patch   2011-09-18 22:03:34 +
+++ debian/patches/02_binutils-gold.patch   1970-01-01 00:00:00 +
@@ -1,13 +0,0 @@
-Index: smc-1.9/src/Makefile.in
-===
 smc-1.9.orig/src/Makefile.in   2011-09-18 22:02:04.0 -0400
-+++ smc-1.9/src/Makefile.in2011-09-18 22:03:01.0 -0400
-@@ -78,7 +78,7 @@
-   font.$(OBJEXT) gl_surface.$(OBJEXT) img_manager.$(OBJEXT) \
-   img_settings.$(OBJEXT) renderer.$(OBJEXT) video.$(OBJEXT)
- smc_OBJECTS = $(am_smc_OBJECTS)
--smc_LDADD = $(LDADD)
-+smc_LDADD = $(LDADD) -lX11 -lboost_system
- DEFAULT_INCLUDES = -I.@am__isrc@ -I$(top_builddir)
- depcomp

Bug#642660: (no subject)

2012-02-15 Thread Barry Warsaw
Attached is the fix I applied on Ubuntu, which builds fgfs-atlas from CVS.

Cheers.
=== modified file 'debian/control'
--- debian/control	2009-10-17 02:27:02 +
+++ debian/control	2012-02-14 21:45:12 +
@@ -1,14 +1,17 @@
 Source: fgfs-atlas
 Section: games
 Priority: extra
-Maintainer: Ove Kaaven o...@arcticnet.no
+Maintainer: Ubuntu Developers ubuntu-devel-disc...@lists.ubuntu.com
+XSBC-Original-Maintainer: Ove Kaaven o...@arcticnet.no
 Build-Depends: debhelper ( 5),
  libx11-dev, libxext-dev, libxi-dev, libice-dev, libsm-dev, libxt-dev, libxmu-dev,
  libgl1-mesa-dev | xlibmesa-gl-dev | libgl-dev,
  libglu1-mesa-dev | libglu1-xorg-dev | xlibmesa-glu-dev | libglu-dev,
  freeglut3-dev | libglut3-dev, zlib1g-dev, libjpeg62-dev | libjpeg-dev,
  libpng12-dev, libplib-dev (= 1.8.4) | plib1.8.4-dev,
- libcurl4-gnutls-dev, libopenal-dev, libalut-dev, autotools-dev, simgear-dev (= 1.0.0-3)
+ libcurl4-gnutls-dev, libopenal-dev, libalut-dev, autotools-dev, automake,
+ libglew-dev,
+ simgear-dev (= 1.0.0-3)
 Standards-Version: 3.7.3
 Homepage: http://atlas.sourceforge.net/
 

=== removed file 'debian/install'
--- debian/install	2008-04-21 11:38:18 +
+++ debian/install	1970-01-01 00:00:00 +
@@ -1,1 +0,0 @@
-src/AtlasPalette usr/share/games/FlightGear

=== modified file 'debian/rules'
--- debian/rules	2008-04-21 11:38:18 +
+++ debian/rules	2012-02-14 23:02:01 +
@@ -3,7 +3,7 @@
 # GNU copyright 1997 to 1999 by Joey Hess.
 
 # Uncomment this to turn on verbose mode.
-#export DH_VERBOSE=1
+export DH_VERBOSE=1
 
 ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
 CFLAGS=-O0 -g
@@ -11,8 +11,19 @@
 CFLAGS=-O2 -g
 endif
 
+DEB_DEBIAN_DIR=$(dir $(firstword $(MAKEFILE_LIST)))
+CVSROOT=':pserver:anonym...@atlas.cvs.sourceforge.net:/cvsroot/atlas'
+# The MMDD part of the changelog version number, used to get a dated CVS
+# checkout from upstream.
+REV=$(shell dpkg-parsechangelog \
+  | sed -rne 's,^Version: .*[+~]cvs([0-9]+).*,\1,p')
+# The full changelog version number, used for the orig.tar.gz
+VER=$(shell dpkg-parsechangelog \
+  | sed -rne 's,^Version: (.*[+~]cvs[0-9]+).*,\1,p')
+
 configure: configure-stamp
 configure-stamp:
+	./autogen.sh
 	dh_testdir
 	./configure --prefix=/usr --mandir=\$${prefix}/share/man --infodir=\$${prefix}/share/info \
 		--bindir=\$${prefix}/games --datadir=\$${prefix}/share/games \
@@ -39,7 +50,7 @@
 	dh_clean
 
 	# update from autotools-dev
-	cp -f /usr/share/misc/config.guess /usr/share/misc/config.sub .
+	#cp -f /usr/share/misc/config.guess /usr/share/misc/config.sub .
 
 install: build
 	dh_testdir
@@ -48,7 +59,7 @@
 	dh_installdirs
 
 	$(MAKE) install prefix=$(CURDIR)/debian/fgfs-atlas/usr
-	mv debian/fgfs-atlas/usr/games/buildmaps.sh debian/fgfs-atlas/usr/share/doc/fgfs-atlas
+	#mv debian/fgfs-atlas/usr/games/buildmaps.sh debian/fgfs-atlas/usr/share/doc/fgfs-atlas
 
 # Build architecture-independent files here.
 binary-indep: build install
@@ -74,5 +85,16 @@
 	dh_md5sums
 	dh_builddeb
 
+get-orig-source:
+	rm -rf atlas-$(VER).orig
+	cvs -z3 -d$(CVSROOT) co -D $(REV) -d atlas-$(REV).orig -P Atlas
+	find atlas-$(REV).orig -name CVS | xargs rm -rf
+	rm -rf atlas-$(REV).orig/projects
+	rm -f atlas-$(REV).orig/.cvsignore
+	GZIP=--best tar -cz --owner root --group root --mode a+rX \
+			-f fgfs-atlas_$(VER).orig.tar.gz \
+			atlas-$(REV).orig
+	rm -rf atlas-$(REV).orig
+
 binary: binary-indep binary-arch
 .PHONY: build clean binary-indep binary-arch binary install configure

=== added directory 'debian/source'
=== added file 'debian/source/format'
--- debian/source/format	1970-01-01 00:00:00 +
+++ debian/source/format	2012-02-14 19:47:34 +
@@ -0,0 +1,1 @@
+3.0 (quilt)



signature.asc
Description: PGP signature


Bug#658787: (no subject)

2012-02-13 Thread Barry Warsaw
I noticed this same failure when I tried to build the package for Ubuntu.
However, what was weird was that it succeeded for amd64 but failed for i386.

https://launchpad.net/ubuntu/+source/cssutils/0.9.8-1build1

Same results in my PPA:

https://launchpad.net/~barry/+archive/python/+packages

I *think* the external access is mocked in the test suite, so in theory it
shouldn't cause a failure.  For some reason this doesn't work correctly for
i386, but does for amd64 (where the tests all pass in the buildds).

It would be interesting to know whether Debian sees the same behavior, and
whether a better fix than just disabling all the tests exists.  It might also
be worth looking at cssutils 0.9.9 (which is available on PyPI at the time of
this writing).


signature.asc
Description: PGP signature


Bug#658787: (no subject)

2012-02-13 Thread Barry Warsaw
Duh.  arch: all so nevermind.


signature.asc
Description: PGP signature


Bug#651996: (no subject)

2012-01-03 Thread Barry Warsaw
We already fixed this in Ubuntu, using an upstream unreleased patch.  I just
tested this out with the Debian version of the package and it fixes the
failure there too.  Here's the diff.

-Barry

=== modified file 'debian/changelog'
--- debian/changelog2011-09-20 10:35:03 +
+++ debian/changelog2012-01-03 18:08:38 +
@@ -1,3 +1,11 @@
+cython (0.15.1-2) UNRELEASED; urgency=low
+
+  * debian/patches/python27-testsuite-fix.patch:
+Fix test suite for Python 2.7 change.  Patch comes from Cython
+upstream, post 0.15.1 release.  (Closes: #651996)
+
+ -- Barry Warsaw ba...@python.org  Tue, 03 Jan 2012 13:07:26 -0500
+
 cython (0.15.1-1) unstable; urgency=low
 
   [ Nikolaus Rath ]

=== added file 'debian/patches/python27-testsuite-fix.patch'
--- debian/patches/python27-testsuite-fix.patch 1970-01-01 00:00:00 +
+++ debian/patches/python27-testsuite-fix.patch 2012-01-03 18:06:57 +
@@ -0,0 +1,43 @@
+Description: Upstream fix (post 0.15.1 release) to work around changes
+ in Python 2.7's indexing error message.
+Origin: 
https://github.com/cython/cython/commit/b623fb856a82d2ece1e2f04fb32309384ab0cb7e.diff
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cython/+bug/901840/+index
+Forwarded: not-needed
+
+diff --git a/tests/run/dict_getitem.pyx b/tests/run/dict_getitem.pyx
+index 845ac7f..40e05e8 100644
+--- a/tests/run/dict_getitem.pyx
 b/tests/run/dict_getitem.pyx
+@@ -21,7 +21,7 @@ def test(dict d, index):
+ 
+  test(None, 1) # doctest: +ELLIPSIS
+ Traceback (most recent call last):
+-TypeError: ...subscriptable...
++TypeError: ...object...
+ 
+ return d[index]
+ 
+diff --git a/tests/run/index.pyx b/tests/run/index.pyx
+index 22cec2b..74eec6e 100644
+--- a/tests/run/index.pyx
 b/tests/run/index.pyx
+@@ -1,15 +1,13 @@
+ __doc__ = u
+- index_object(100, 100)
++ index_object(100, 100)   # doctest: +ELLIPSIS
+ Traceback (most recent call last):
+ ...
+-TypeError: 'int' object is unsubscriptable
++TypeError: 'int' object ...
+ 
+ 
+ import sys
+-if sys.version_info = (2,7):
+-__doc__ = __doc__.replace(u'is unsubscriptable', u'is not subscriptable')
+-elif sys.version_info  (2,5):
+-__doc__ = __doc__.replace(u'int' object is unsubscriptable, 
u'unsubscriptable object')
++if sys.version_info  (2,5):
++__doc__ = __doc__.replace(u'int' object ..., u'unsubscriptable object')
+ 
+ import cython
+ 

=== modified file 'debian/patches/series'
--- debian/patches/series   2011-09-20 10:35:03 +
+++ debian/patches/series   2012-01-03 18:06:57 +
@@ -1,1 +1,2 @@
 deb_tempdisable_numpy_doctests
+python27-testsuite-fix.patch




signature.asc
Description: PGP signature


Bug#642601: (no subject)

2011-09-27 Thread Barry Warsaw
Yep, we fixed this in Ubuntu back in November.  Here's the merge proposal at
the time:

https://code.launchpad.net/~barry/update-manager/673297-py27/+merge/40510

And the patch we applied (omitting debian/changelog):

=== modified file 'UpdateManager/Core/utils.py'
--- UpdateManager/Core/utils.py 2010-08-12 09:54:02 +
+++ UpdateManager/Core/utils.py 2010-11-10 10:04:04 +
@@ -349,10 +349,10 @@
 return _(1 KB)
 elif bytes  1024 * 1024:
 # TRANSLATORS: download size of small updates, e.g. 250 KB
-return locale.format(_(%.0f KB), bytes/1024)
+return locale.format_string(_(%.0f KB), bytes/1024)
 else:
 # TRANSLATORS: download size of updates, e.g. 2.3 MB
-return locale.format(_(%.1f MB), bytes / 1024 / 1024)
+return locale.format_string(_(%.1f MB), bytes / 1024 / 1024)
 
 if __name__ == __main__:
   #print mirror_from_sources_list()


Looks like the code's different now, but it confirms your patch is the right
way to go.  This was applied in:

update-manager (1:0.145.1) natty; urgency=low


signature.asc
Description: PGP signature


Bug#638953: (no subject)

2011-09-22 Thread Barry Warsaw
I'm testing this patch in Ubuntu (which has the same ftbfs):

https://github.com/nipy/nipype/commit/33db6f6bff3d0b554037e0169d17a14b7ff66f89


signature.asc
Description: PGP signature


Bug#638953: (no subject)

2011-09-22 Thread Barry Warsaw
This is the patch I applied to the Ubuntu package:

=== added file 'debian/patches/import_design_matrix.patch'
--- debian/patches/import_design_matrix.patch   1970-01-01 00:00:00 +
+++ debian/patches/import_design_matrix.patch   2011-09-22 18:15:26 +
@@ -0,0 +1,19 @@
+Description: nipype ftbfs due to ImportError.  This patch contains the
+ upstream git pull request fixing the import.
+Origin:
+ https://github.com/nipy/nipype/commit/33db6f6bff3d0b554037e0169d17a14b7ff66f89
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/nipype/+bug/835008
+Forwarded: not-needed
+Author: Barry Warsaw ba...@ubuntu.com
+
+--- a/nipype/interfaces/nipy/model.py
 b/nipype/interfaces/nipy/model.py
+@@ -6,7 +6,7 @@
+ 
+ from nipype.utils.misc import package_check
+ package_check('nipy')
+-import nipy.labs.utils.design_matrix as dm
++import nipy.modalities.fmri.design_matrix as dm
+ import nipy.labs.glm as GLM
+ 
+ from nipype.interfaces.base import (BaseInterface, TraitedSpec, traits, File,

=== modified file 'debian/patches/series'
--- debian/patches/series   2011-07-16 17:43:23 +
+++ debian/patches/series   2011-09-22 18:15:26 +
@@ -1,1 +1,2 @@
 deb_tollerate_exceptions_while_docbuilding
+import_design_matrix.patch



signature.asc
Description: PGP signature


Bug#638953: (no subject)

2011-09-22 Thread Barry Warsaw
On Sep 22, 2011, at 02:26 PM, Yaroslav Halchenko wrote:

eh -- we crossed in hyperspace -- I called mine up_recent_nipy_reference
and didn't include all the nice headers... do you have a helper script
for this DEP-3-friendliness?

Nope, just quick Emacs fingers.  But I always have to lookup DEP-3 to get it
right.  I guess that means it's time for a script. :)

No worries.  We can just sync the Debian version when it's available (or early
in the Ubuntu P-series) and throw away my patch.


signature.asc
Description: PGP signature


Bug#632225: Cod review

2011-09-20 Thread Barry Warsaw
Hi Jelmer,

On Sep 19, 2011, at 11:22 PM, Jelmer Vernooij wrote:

 client.c:318 client_set_notify_funct() where notify_baton2 has
 inconsistent
 refcounting between the if-clause and else-clause. When you go through the
 if-clause, notify_baton2 steals a reference to Py_None, which is going
 to get
 decref'd in client_dealloc(). The Py_XDECREF there does not protect
 you from
 the extra decref of Py_None! You can see that if you go through the
 else-clause, func will get incref'd, but if you go through the
 if-clause, you
 actually leak func! Suggestion: incref notify_baton2 instead of func.
I don't follow - further down in that function we Py_INCREF func, so we always 
increment the reference count of func if we assign it to notify_baton2.

Oh, I see it now.  Right, Py_None will get incref'd by virtue of it being
stored in func.  It's a little confusing the way it's written, but agreed that
it's safe.

 * client.c:256: py_cancel_check should be incref'd?

It's a C function, I don't see why it could go away.

Right (hence the question mark).  Probably, technically more correct to hold
an explicit reference to it, but agreed that it's likely safe.

 * client.c, multiple locations: PyArg_Parse* does not incref 'O'
 arguments, so
 be careful about calling back into Python with any such parsed object. You
 need to ensure your library increfs such objects before a potential call
 back into Python, and then decrefs it when you're done with the Python
 call. I haven't audited all the places this happens, so this could be a
 false alarm (i.e. you don't call back into Python).
I'm not aware of any places where we do that in client.c.

Cool.

Thanks for closing bug 632225.  One more Python 2.7 blocker down!  But of
course, I couldn't stop now, so here are a few other minor things that jumped
out at me.

(Aside: FWIW, I've always said that the Python C API is the *perfect* use case
for goto.  You'll see it all over Python's own C code. :).

editor.c, py_txdelta_window_handler(): when PyList_New() fails, and opts is
NULL, you'll return without releasing the GIL.  You should probably also check
the return value for the Py_BuildValue() and PyList_SetItem() calls in this
function.  These are all probably unlikely to fail, so I'm just being paranoid
(IME, not a bad trait to have when it comes to Python's C API. :).

wc.c, py_status(): when Pool(NULL) returns NULL, you'll leak ret.
Technically, this will also happen when dup_status is NULL, but the
PyErr_NoMemory will probably kill you anyway.

The above also happens in adm_init().

adm_entries_read(): check return from PyDict_SetItemString().

adm_get_prop_diffs(): py_propchanges can leak if the Py_BuildValue() returns
NULL, or if py_orig_props ends up NULL.  Also, check the PyList_SetItem()
return value.

repos.c, repos_init(): ret gets leaked if Pool(NULL) returns NULL.

fs_root_paths_changed(): Check return value from PyDict_SetItemString().

util.c, PyOS_tmpfile(): I think tmpfile_fn gets leaked, since
PyObject_GetAttrString() returns a new reference, which you throw away after
the PyObject_CallObject().

prop_hash_to_dict() check return value from PyDict_SetItemString().  Similarly
in pyify_changed_paths() and pyify_changed_paths2().  Also in
pyify_changed_paths2(), when pyval is NULL, py_changed_paths is leaked.

More return value checks missing in py_svn_log_wrapper() and py_dirent().
(Yeah, I know I'm being a PITA :).

stream_init(): ret is leaked when Pool(NULL) returns NULL.  (Is this basically
an svn OOM error?).

py_file_rev_handler() and py_ra_file_rev_handler(): I think ret is leaked if
you don't enter the if-clause.

_ra.c: Similarly, I think it's possible to leak ret from py_open_tmp_file().
E.g You get into the PyFile_Check() else-if-clause, but *fp is not NULL.  ret
doesn't get decref'd.  (OTOH, I don't know the logic of apr_file_from_object()
so it might be an impossible situation.)

get_commit_editor(): commit_callback gets leaked if you take one of the early
exits.

ra_get_dir(): Check return code from PyDict_SetItemString().  py_dirents can
leak if py_props == NULL.

ra_get_locks(): ret can leak if pyval == NULL.  Also, check return value from
PyDict_SetItemString().  (similarly for ra_get_locations,
merge_rangelist_to_list, mergeinfo_to_dict, ra_mergeinfo)

get_username_prompt_provider(): auth can leak if Pool(NULL) returns NULL.

py_simple_prompt(): ret can leak in the early exit error conditions.
Same for:
 * py_ssl_client_cert_pw_prompt()
 * py_ssl_client_cert_prompt()
 * get_ssl_client_cert_pw_prompt_provider()
 * get_ssl_client_cert_prompt_provider()
 * get_username_provider()
 * get_ssl_server_trust_file_provider()
 * get_ssl_client_cert_file_provider()
 * get_ssl_client_cert_pw_file_provider()
 * get_windows_simple_provider()
 * get_windows_ssl_server_trust_provider()
 * get_keychain_simple_provider()

get_ssl_server_trust_prompt_provider(): auth leaked when Pool(NULL) returns
NULL.

py_cb_get_simple_provider_prompt(): ret leaks from the 

Bug#632225: Cod review

2011-09-19 Thread Barry Warsaw
I did a very quick review of the C code here (branched from debianlp:subvertpy
on Launchpad, so should be the sid package), and found a number of
questionable things.  I don't know the library code or the svn API very well,
so it's entirely possible that some or all of these are false alarms.  It's
also possible I missed some things.  I list them here because they made me go
hmm and I think they're worth a second look.

Most issues I think are not that serious, e.g. leaking a refcount in a rare
error condition, either by not decref'ing an object in a short-circuit exit,
or not checking return values for Python API calls.  I'll list these farther
down.  The most serious issue appears to be in util.c in
config_hash_from_object().

Potentially serious:

Notice how when config is a dictionary, you set `dict = config` but when it's
not, you PyObject_GetAttrString() the config's __dict__.  This sets up a
situation where outside this conditional, you are inconsistent with dict's
refcount.  The if-clause has one lower reference than the else-clause because
PyObject_GetAttrString returns a new reference.  Thus it's possible that
PyDict_Check and PyDict_Next are operating on an object for which the client
doesn't hold sufficient references.  You're also leaking dict when you've gone
through the else-clause.  Suggestion: incref dict in the if-clause and add a
decref of dict before the return at the end of the function.

client.c:318 client_set_notify_funct() where notify_baton2 has inconsistent
refcounting between the if-clause and else-clause.  When you go through the
if-clause, notify_baton2 steals a reference to Py_None, which is going to get
decref'd in client_dealloc().  The Py_XDECREF there does not protect you from
the extra decref of Py_None!  You can see that if you go through the
else-clause, func will get incref'd, but if you go through the if-clause, you
actually leak func!  Suggestion: incref notify_baton2 instead of func.

client_proplist, inside the props-nelts loop, the PyList_Append return value
is not checked.  Not likely to fail, but more seriously, `value` is leaked.
Py_BuildValue returns a new reference, but PyList_Append does not steal its
reference.  Thus you leak every `value`.

editor.c:58, new_editor_object: you (probably, haven't checked the call-sites)
need to incref commit_callback, since it gets decref'd in py_editor_dealloc.
Looks like the refcounts are unmatched.

Other problems:

* wrap_py_commit_items(): leaks ret when the PyList_SetItem returns on line
  118.
* client.c:145: PyList_Append return value unchecked, probably harmless though
  a (void) should be added.
* client.c:167: similar for PyDict_SetItemString
* client.c:256: py_cancel_check should be incref'd?
* client.c, multiple locations: PyArg_Parse* does not incref 'O' arguments, so
  be careful about calling back into Python with any such parsed object.  You
  need to ensure your library increfs such objects before a potential call
  back into Python, and then decrefs it when you're done with the Python
  call.  I haven't audited all the places this happens, so this could be a
  false alarm (i.e. you don't call back into Python).
* client.c:925: prop_list leaks in the error condition return
* client.c:1037: leaks ret when PyList_SetItem returns non-zero.
* client.c:1086: leaks entry_dict in the error return path
* client.c:1251: PyList_SetItem return value not checked
* client.c:1279: PyDict_SetItemString return value not checked
* client.c:1473: leaks `data` when data-pool is NULL.

I'm still reviewing the code, so if I find anything else I'll send a follow up.

Cheers,
-Barry



signature.asc
Description: PGP signature


Bug#634107: (no subject)

2011-08-22 Thread Barry Warsaw
I had a problem with pbuilder on wheezy.  This Launchpad bug might be related:

https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/805886

I tested this fix in the Debian package for util-linux:

https://code.launchpad.net/~pr0gg3d/ubuntu/oneiric/util-linux/bug-805886/+merge/70680

and it fixed the problem perfectly for Wheezy.


signature.asc
Description: PGP signature


Bug#634860: (no subject)

2011-07-28 Thread Barry Warsaw
Updated svn in r17925, including Breaks.  ScottK is going to review and upload.


signature.asc
Description: PGP signature


Bug#623165: FTBFS w/ Python 2.7 enabled

2011-04-22 Thread Barry Warsaw
Here is the bug report for graphviz failure against Python 2.7 in Ubuntu
Natty:

https://bugs.launchpad.net/ubuntu/+source/graphviz/+bug/683182/+index

Here's the debdiff I applied to our package to get it to build:

https://bugs.launchpad.net/ubuntu/+source/graphviz/+bug/683182/+attachment/1755021/+files/683182.debdiff


signature.asc
Description: PGP signature


Bug#568674: (no subject)

2010-03-04 Thread Barry Warsaw
This is on our (upstream's) radar:

http://bugs.python.org/issue7755


signature.asc
Description: PGP signature