Bug#1066115: mpg123: FTBFS: error: implicit declaration of function ‘mpg321_alsa_get_volume’ [-Werror=implicit-function-declaration]

[Joachim Reichel]

Hi Andreas,

usually I would have implemented your suggestion (and I don't mind anyone 
implementing it), but I'm not really keen on investing in a dependency that 
hasn't seen a single upstream release in 12 years and where the last upload was 
an NMU four years ago from myself dealing with a similar problem. I hope that 
explains why I took the route of this suboptimal shortcut.


Best regards,
  Joachim

Bug#1066115: mpg123: FTBFS: error: implicit declaration of function ‘mpg321_alsa_get_volume’ [-Werror=implicit-function-declaration]

[Joachim Reichel]

tag 1066115 + patch
thanks

Hi,

attached is the debdiff for the NMU, uploaded to delayed/10. Similar to the 
previous NMU it adds -Wno-error=implicit-function-declaration to downgrade these 
errors back into warnings again.


Best regards,
  Joachimdiff -Nru mpg321-0.3.2/debian/changelog mpg321-0.3.2/debian/changelog
--- mpg321-0.3.2/debian/changelog   2020-07-23 17:22:42.0 +0200
+++ mpg321-0.3.2/debian/changelog   2024-03-21 21:39:07.0 +0100
@@ -1,3 +1,11 @@
+mpg321 (0.3.2-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add -Wno-error=implicit-function-declaration to CFLAGS to disable
+new defaults from dpkg-buildflags (Closes: #1066115).
+
+ -- Joachim Reichel   Thu, 21 Mar 2024 20:39:07 +
+
 mpg321 (0.3.2-3.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru mpg321-0.3.2/debian/rules mpg321-0.3.2/debian/rules
--- mpg321-0.3.2/debian/rules   2020-07-23 17:22:42.0 +0200
+++ mpg321-0.3.2/debian/rules   2024-03-21 21:37:50.0 +0100
@@ -4,7 +4,7 @@
 #export DH_VERBOSE=1
 
 
-export CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused 
-Wno-error=format-security -Wno-error=implicit-function-declaration -fcommon 
+export CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused 
-Wno-error=format-security -Wno-error=implicit-function-declaration -fcommon
 
 MPG321_ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
 

Bug#1023303: jhead 1:3.06.0.1-3 deletes EXIF data

[Joachim Reichel]

Hi Stefan,

thanks for the image. I just uploaded -4 which fixes the problem.

Best regards,
  Joachim

Bug#1023303: jhead 1:3.06.0.1-3 deletes EXIF data

[Joachim Reichel]

Hi Stefan,

it would have been helpful if you had attached an image that shows this 
behavior. I have an idea what the problem might be, but having access to your 
test case for verification would be good. Feel free to send it directly to my 
email address if you prefer.


Best regards,
  Joachim

Bug#1022028: jhead: CVE-2022-41751

[Joachim Reichel]

found 1022028 1:3.00-8
thanks

The bugs exist probably since the features were added a long time ago. Let's use 
the current oldstable version for tracking purposes.

Bug#1005696: cgal: -latomic not added on mipsel

[Joachim Reichel]

Hi,

On 2/14/22 09:54, Sebastiaan Couwenberg wrote:
Just adding -latomic to LDFLAGS was not sufficient, to workaround this issue 
-Wl,--no-as-needed also needed to be added to CXXFLAGS.


Do you really mean CXXFLAGS? Or should that read LDFLAGS?

Best regards,
  Joachim

Bug#1000146: cppcheck: incorrect dependencies: libc6 should be >= 2.32

[Joachim Reichel]

Hi Ian,

On 28.11.21 19:21, Ian Jackson wrote:

Joachim Reichel (cppcheck maintainer):

I'll upload a new version cppcheck with a workaround shortly


Would you mind both prioritising this fix ?  FTAOD it's not just
cppcheck that is scheduled for autoremoval.  Any package which
transitively [build-]depends on any package whose .debs are affected
will be scheduled for autoremoval (assuming some bug has been filed).


I'm aware of that. And "shortly" definitely means "before the autoremoval" 
(which is currently scheduled for 2022-01-01). Is there a particular reason for 
the urgency that I'm missing? Note that cppcheck is not a library, i.e., this 
wrong dependency should not spread out by delaying the upload a bit.


(Fixing dpkg-shlibdeps and binNMUs is a different topic and is probably better 
discussed in #100421.)


Best regards,
  Joachim

Bug#1000146: cppcheck: incorrect dependencies: libc6 should be >= 2.32

[Joachim Reichel]

The root case of the problem has now been identified (see bug #100421). I'll 
upload a new version cppcheck with a workaround shortly (and before the 
autoremoval kicks in) -- just wanting to wait a bit more for a potential new 
upstream release.


Best regards,
  Joachim

Bug#1000421: dpkg-shlibdeps: Wrong minimum version requirement on libc6

[Joachim Reichel]

Package: dpkg-dev
Version: 1.20.9
Severity: serious
Control: affects -1 cppcheck

Hi,

dpkg-shlibdeps calculates too low minimum version requirements for cppcheck on 
libc6 (see bug 1000146).

To reproduce, build cppcheck 2.6-1 in unstable chroot without cleaning up, 
e.g., "dpkg-buildpackage -rfakeroot -us -uc".

$ grep Depends debian/cppcheck/DEBIAN/control
Depends: libc6 (>= 2.29), [...]

But running the binary with libc6 2.31 fails with

cppcheck: ./libc.so.6: version `GLIBC_2.32' not found (required by cppcheck)
cppcheck: ./libc.so.6: version `GLIBC_2.32' not found (required by 
/usr/lib/x86_64-linux-gnu/libstdc++.so.6)
cppcheck: ./libc.so.6: version `GLIBC_2.32' not found (required by 
/lib/x86_64-linux-gnu/libpthread.so.0)

I believe that is the case because a certain symbol in the .bss section is 
ignored (this is the only symbol with 2.32 suffix):

$ objdump -w -T ./debian/cppcheck/usr/bin/cppcheck | grep __libc_single_threaded
004670e0 gDO .bss   0001  GLIBC_2.32  
__libc_single_threaded

$ nm -D ./debian/cppcheck/usr/bin/cppcheck | grep __libc_single_threaded
004670e0 B __libc_single_threaded@@GLIBC_2.32

$ dpkg-shlibdeps ./debian/cppcheck/usr/bin/cppcheck; cat debian/substvars
shlibs:Depends=libc6 (>= 2.29), [...]

After hacking /usr/share/perl5/Dpkg/Shlibs/Objdump.pm:462 to read
"defined => ($sect ne '*UND*') && ($sect ne '.bss')"
(maybe not the right solution, just for demonstration):

$ dpkg-shlibdeps ./debian/cppcheck/usr/bin/cppcheck; cat debian/substvars
shlibs:Depends=libc6 (>= 2.32), [...]

(Not really sure about the severity. I believe the resulting bugs in packagage 
using dpkg-shlipdeps are "serious".)

Best regards,
  Joachim

-- Package-specific info:
System tainted due to merged-usr-via-aliased-dirs.

-- System Information:
Debian Release: 11.1
  APT prefers stable-debug
  APT policy: (800, 'stable-debug'), (800, 'stable'), (500, 'stable-security')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.10.0-9-amd64 (SMP w/16 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dpkg-dev depends on:
ii  binutils  2.35.2-2
ii  bzip2 1.0.8-4
ii  libdpkg-perl  1.20.9
ii  make  4.3-4.1
ii  patch 2.7.6-7
ii  perl  5.32.1-4+deb11u2
ii  tar   1.34+dfsg-1
ii  xz-utils  5.2.5-2

Versions of packages dpkg-dev recommends:
ii  build-essential  12.9
ii  clang-11 [c-compiler]1:11.0.1-2
ii  fakeroot 1.25.3-1.1
ii  gcc [c-compiler] 4:10.2.1-1
ii  gcc-10 [c-compiler]  10.2.1-6
ii  gnupg2.2.27-2
ii  gpgv 2.2.27-2
ii  libalgorithm-merge-perl  0.08-3

Versions of packages dpkg-dev suggests:
ii  debian-keyring  2021.07.26

-- no debconf information

Bug#1000146: cppcheck: incorrect dependencies: libc6 should be >= 2.32

[Joachim Reichel]

severity 1000146 serious
thanks


Hi Alejandro,

I was able to reproduce the problem. It's unclear to me why "${shlibs:Depends}" 
does not produce a ">= 2.32" constraint and I've asked on the debian-mentors 
list for comments. Obviously, I could add that constraint manually, but I would 
first like to get some insights why the automatic mechanism did not work out.


I'm downgrading the severity, as the package can be easily made fully functional 
by upgrading libc6 manually.


Best regards,
   Joachim

Bug#988986: ABI change in tinyxml2 8.1.0+dfsg-1

[Joachim Reichel]

For the missing major version/SONAME change I've created an issue in the upstream github project: 
https://github.com/leethomason/tinyxml2/issues/867


Best regards,
  Joachim

Bug#985671: CVE-2020-35636 CVE-2020-35628 CVE-2020-28636 CVE-2020-28601

[Joachim Reichel]

tags 985671 + pending
thanks

Bug#957563: mpg321: ftbfs with GCC-10

[Joachim Reichel]

NMU uploaded to delayed/10.

Basically mpg321_common.diff plus an additional fix for another FTBFS related
to circular build dependencies. Updated diff attached.

Best regards,
  Joachim
diff -Nru mpg321-0.3.2/debian/changelog mpg321-0.3.2/debian/changelog
--- mpg321-0.3.2/debian/changelog	2019-03-13 15:59:02.0 +0100
+++ mpg321-0.3.2/debian/changelog	2020-07-23 17:22:42.0 +0200
@@ -1,3 +1,15 @@
+mpg321 (0.3.2-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Export CFLAGS to make them take effect.
+  * Add -Wno-error=format-security to CFLAGS to disable the default from
+dpkg-buildflags as workaround for some build error.
+  * Add -fcommon to CFLAGS (Closes: #957563).
+  * Remove circular build dependencies around build-stamp which make the
+package FTBFS in clean environments.
+
+ -- Joachim Reichel   Thu, 23 Jul 2020 17:22:42 +0200
+
 mpg321 (0.3.2-3) unstable; urgency=medium
 
   * Fix compilation error
diff -Nru mpg321-0.3.2/debian/rules mpg321-0.3.2/debian/rules
--- mpg321-0.3.2/debian/rules	2012-05-01 08:53:43.0 +0200
+++ mpg321-0.3.2/debian/rules	2020-07-23 17:22:42.0 +0200
@@ -4,7 +4,7 @@
 #export DH_VERBOSE=1
 
 
-CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused
+export CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused -Wno-error=format-security -fcommon 
 
 MPG321_ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
 
@@ -24,15 +24,14 @@
 endif
 	touch configure-stamp
 
-build: configure-stamp build-arch build-indep
-build-arch: build-stamp
-build-indep: build-stamp
-build-stamp: build install
+build: build-arch build-indep
+build-arch: configure-stamp
+build-indep: configure-stamp
 
 clean:
 	dh_testdir
 	dh_testroot
-	rm -f build-stamp configure-stamp
+	rm -f configure-stamp
 
 	# Add here commands to clean up after the build process.
 	[ ! -f Makefile ] || $(MAKE) distclean

Bug#957563: mpg321: ftbfs with GCC-10

[Joachim Reichel]

tag 957563 + patch
thanks

Attached is the patch mpg321_common.diff that adds -fcommon to CFLAGS (see
http://gcc.gnu.org/gcc-10/porting_to.html), plus adding "export" to make them
take effect, and demoting one error to warning again.

I've also attached the patch mpg321_extern.diff which fixes the actual cause
for the problem (builds fine, but didn't really test the resulting binary).
You might want to forward it to upstream.

Best regards,
  Joachim
diff -Nru mpg321-0.3.2/debian/changelog mpg321-0.3.2/debian/changelog
--- mpg321-0.3.2/debian/changelog	2019-03-13 15:59:02.0 +0100
+++ mpg321-0.3.2/debian/changelog	2020-07-23 17:22:42.0 +0200
@@ -1,3 +1,13 @@
+mpg321 (0.3.2-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Export CFLAGS to make them take effect.
+  * Add -Wno-error=format-security to CFLAGS to disable the default from
+dpkg-buildflags as workaround for some build error.
+  * Add -fcommon to CFLAGS (Closes: #957563).
+
+ -- Joachim Reichel   Thu, 23 Jul 2020 17:22:42 +0200
+
 mpg321 (0.3.2-3) unstable; urgency=medium
 
   * Fix compilation error
diff -Nru mpg321-0.3.2/debian/rules mpg321-0.3.2/debian/rules
--- mpg321-0.3.2/debian/rules	2012-05-01 08:53:43.0 +0200
+++ mpg321-0.3.2/debian/rules	2020-07-23 17:22:42.0 +0200
@@ -4,7 +4,7 @@
 #export DH_VERBOSE=1
 
 
-CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused
+export CFLAGS = $(shell dpkg-buildflags --get CFLAGS) -Wall -Wunused -Wno-error=format-security -fcommon 
 
 MPG321_ARCH = $(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
 
Description: 
 TODO: Put a short summary on the line above and replace this paragraph
 with a longer explanation of this change. Complete the meta-information
 with other relevant fields (see below for details).

---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:

Origin: , 
Bug: 
Bug-Debian: https://bugs.debian.org/
Bug-Ubuntu: https://launchpad.net/bugs/
Forwarded: 
Reviewed-By: 
Last-Update: 2020-07-23

--- mpg321-0.3.2.orig/mpg321.h
+++ mpg321-0.3.2/mpg321.h
@@ -116,7 +116,7 @@ extern char *playlist_file;
 extern int quit_now;
 extern char remote_input_buf[PATH_MAX + 5];
 extern int file_change;
-int loop_remaining;
+extern int loop_remaining;
 
 extern int status;
 extern int scrobbler_time;
@@ -233,8 +233,8 @@ RETSIGTYPE handle_sigchld(int sig);
 #define FFT_BUFFER_SIZE_LOG 9
 #define FFT_BUFFER_SIZE (1 << FFT_BUFFER_SIZE_LOG) /* 512 */
 /*Temporary data stores to perform FFT in */
-double real[FFT_BUFFER_SIZE];
-double imag[FFT_BUFFER_SIZE];
+extern double real[FFT_BUFFER_SIZE];
+extern double imag[FFT_BUFFER_SIZE];
 
 typedef struct {
 	double real[FFT_BUFFER_SIZE];
@@ -258,10 +258,10 @@ fft_state *fft_init(void);
 /* Output buffer process */
 void frame_buffer_p();
 /* Semaphore array */
-int semarray;
+extern int semarray;
 /* Input/Output buffer position */
-int mad_decoder_position;
-int output_buffer_position;
+extern int mad_decoder_position;
+extern int output_buffer_position;
 /* Output Frame including needed information */
 typedef struct {
 	unsigned char data[4*1152];
@@ -285,10 +285,10 @@ typedef struct {
 } decoded_frames;
 
 /* Output frame queue pointer */
-output_frame *Output_Queue;
+extern output_frame *Output_Queue;
 
 /* Shared total decoded frames */
-decoded_frames *Decoded_Frames;
+extern decoded_frames *Decoded_Frames;
 
 #if defined(__GNU_LIBRARY__) && !defined(_SEM_SEMUN_UNDEFINED)
 /* */
--- mpg321-0.3.2.orig/mpg321.c
+++ mpg321-0.3.2/mpg321.c
@@ -90,6 +90,7 @@ mad_timer_t current_time;
 mpg321_options options = { 0, NULL, NULL, 0 , 0, 0};
 int status = MPG321_STOPPED;
 int file_change = 0;
+int loop_remaining = 0;
 int remote_restart = 0;
 int muted = 0;
 char *id3_get_tag (struct id3_tag const *tag, char const *what, unsigned int maxlen);
@@ -104,6 +105,15 @@ extern http_file_length;
 /* ALSA Volume Range */
 extern long volume_min,volume_max;
 #endif
+
+double real[FFT_BUFFER_SIZE];
+double imag[FFT_BUFFER_SIZE];
+int semarray;
+int mad_decoder_position;
+int output_buffer_position;
+output_frame *Output_Queue;
+decoded_frames *Decoded_Frames;
+
 /* Get the next frame in the round buffer */
 int getnext_place(int position)
 {

Bug#946234: [NMU] FTFBS with CGAL 5.0 (if cmake is absent)

[Joachim Reichel]

> Upstream 0.5.0 now builds against CGAL 5, so we only need an upload here.

What do you mean with "only"? Is there already a package for the new upstream
ready to be uploaded?

NMU uploaded to DELAYED/5-day.

Bug#946264: openems: FTBFS (affects CGAL transition)

[Joachim Reichel]

Source: openems
Version: 0.0.35+git20190103.6a75e98+dfsg.1-1
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417). A binNMU would have been
sufficient, but your package FTBFS for unrelated reasons. See
https://buildd.debian.org/status/package.php?p=openems .

This might be the same problem as in bug #944144, but I'm not sure.

Best regards,
  Joachim

Bug#946114: FTFBS with CGAL 5.0 (NMU)

[Joachim Reichel]

Uploaded to DELAYED/5-day.

Bug#946234: [NMU] FTFBS with CGAL 5.0 (if cmake is absent)

[Joachim Reichel]

Source: pygalmesh
Version: 0.4.0-1
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS (if
cmake is not present, see the other bug I just filed). I intend to NMU the
package with the attached diff to DELAYED/5-day.

Best regards,
  Joachim
diff -Nru pygalmesh-0.4.0/debian/changelog pygalmesh-0.4.0/debian/changelog
--- pygalmesh-0.4.0/debian/changelog2019-08-18 18:42:35.0 +0200
+++ pygalmesh-0.4.0/debian/changelog2019-12-05 23:07:13.0 +0100
@@ -1,3 +1,11 @@
+pygalmesh (0.4.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch to fix FTBFS with CGAL >= 5.0 (Closes: #xx).
+  * Add Build-Depends: libcgal-dev (>= 5.0~).
+
+ -- Joachim Reichel   Thu, 05 Dec 2019 23:07:13 +0100
+
 pygalmesh (0.4.0-1) unstable; urgency=medium
 
   * set debian/watch to track upstream git tags,
diff -Nru pygalmesh-0.4.0/debian/control pygalmesh-0.4.0/debian/control
--- pygalmesh-0.4.0/debian/control  2019-08-18 18:42:35.0 +0200
+++ pygalmesh-0.4.0/debian/control  2019-12-05 23:07:13.0 +0100
@@ -5,7 +5,7 @@
 Uploaders: Drew Parsons 
 Build-Depends: debhelper-compat (= 12),
  dh-python, python3-all-dev, python3-setuptools,
- libcgal-dev,
+ libcgal-dev (>= 5.0~),
  libeigen3-dev,
  pandoc,
  python3-meshio,
diff -Nru pygalmesh-0.4.0/debian/patches/series 
pygalmesh-0.4.0/debian/patches/series
--- pygalmesh-0.4.0/debian/patches/series   1970-01-01 01:00:00.0 
+0100
+++ pygalmesh-0.4.0/debian/patches/series   2019-12-05 23:06:31.0 
+0100
@@ -0,0 +1 @@
+use-cgal-in-header-only-mode.patch
diff -Nru pygalmesh-0.4.0/debian/patches/use-cgal-in-header-only-mode.patch 
pygalmesh-0.4.0/debian/patches/use-cgal-in-header-only-mode.patch
--- pygalmesh-0.4.0/debian/patches/use-cgal-in-header-only-mode.patch   
1970-01-01 01:00:00.0 +0100
+++ pygalmesh-0.4.0/debian/patches/use-cgal-in-header-only-mode.patch   
2019-12-05 23:07:13.0 +0100
@@ -0,0 +1,14 @@
+Index: pygalmesh-0.4.0/setup.py
+===
+--- pygalmesh-0.4.0.orig/setup.py
 pygalmesh-0.4.0/setup.py
+@@ -48,8 +48,7 @@ ext_modules = [
+ get_pybind_include(),
+ get_pybind_include(user=True),
+ ],
+-# CGAL_ImageIO for generate_from_inr
+-libraries=["CGAL", "CGAL_ImageIO", "gmp", "mpfr"],
++libraries=["stdc++", "gmp", "mpfr"],
+ )
+ ]
+ 

Bug#946229: [NMU] FTFBS with CGAL 5.0

[Joachim Reichel]

Source: sfcgal
Version: 1.3.7-2
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS. I
intend to NMU the package with the attached diff to DELAYED/5-day.

Best regards,
  Joachim
diff -Nru sfcgal-1.3.7/debian/changelog sfcgal-1.3.7/debian/changelog
--- sfcgal-1.3.7/debian/changelog   2019-08-18 07:57:14.0 +0200
+++ sfcgal-1.3.7/debian/changelog   2019-12-05 21:34:40.0 +0100
@@ -1,3 +1,11 @@
+sfcgal (1.3.7-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch to fix FTBFS with CGAL >= 5.0 (Closes: #xx).
+  * Add Build-Depends: libcgal-dev (>= 5.0~).
+
+ -- Joachim Reichel   Thu, 05 Dec 2019 21:34:40 +0100
+
 sfcgal (1.3.7-2) unstable; urgency=medium
 
   * Bump Standards-Version to 4.4.0, no changes.
diff -Nru sfcgal-1.3.7/debian/control sfcgal-1.3.7/debian/control
--- sfcgal-1.3.7/debian/control 2019-08-18 07:55:35.0 +0200
+++ sfcgal-1.3.7/debian/control 2019-12-05 21:34:40.0 +0100
@@ -6,7 +6,7 @@
 Priority: optional
 Build-Depends: debhelper (>= 9.20160114),
cmake,
-   libcgal-dev (>= 4.10.1),
+   libcgal-dev (>= 5.0~),
libboost-all-dev,
libmpfr-dev,
libgmp-dev,
diff -Nru sfcgal-1.3.7/debian/patches/fix-ftbfs-with-cgal-5.x.patch 
sfcgal-1.3.7/debian/patches/fix-ftbfs-with-cgal-5.x.patch
--- sfcgal-1.3.7/debian/patches/fix-ftbfs-with-cgal-5.x.patch   1970-01-01 
01:00:00.0 +0100
+++ sfcgal-1.3.7/debian/patches/fix-ftbfs-with-cgal-5.x.patch   2019-12-05 
21:34:40.0 +0100
@@ -0,0 +1,44 @@
+Description: Require C++14 and CGAL >= 5.0
+Author: Joachim Reichel 
+Bug: https://github.com/Oslandia/SFCGAL/issues/198
+
+Index: sfcgal-1.3.7/CMakeLists.txt
+===
+--- sfcgal-1.3.7.orig/CMakeLists.txt
 sfcgal-1.3.7/CMakeLists.txt
+@@ -1,6 +1,8 @@
+ cmake_minimum_required( VERSION 2.8 )
+ project( SFCGAL )
+ 
++set(CMAKE_CXX_STANDARD 14)
++
+ set( CMAKE_DEBUG_POSTFIX "d" )
+ 
+ #
+@@ -51,19 +53,19 @@ endif()
+ 
+ # 4.3 minimal
+ # 4.13 recommended
+-find_package( CGAL 4.3 COMPONENTS Core REQUIRED )
++find_package( CGAL COMPONENTS Core REQUIRED )
+ message( STATUS "CGAL ${CGAL_VERSION} found" )
+ 
+ include_directories( ${CMAKE_BINARY_DIR}/include )
+ 
+ # For CGAL versions < 4.3, we add a local directory that contains some 
tweaked include files from unreleased versions
+ # They will overwrite files from the CGAL installation
+-if( "${CGAL_VERSION}" VERSION_LESS "4.3" )
+-  include_directories( patches/CGAL-4.2 )
+-elseif( "${CGAL_VERSION}" VERSION_LESS "4.10")
+-  include_directories( patches/CGAL-4.3 )
+-  add_definitions( "-DCGAL_INTERSECTION_VERSION=1" )
+-endif()
++# if( "${CGAL_VERSION}" VERSION_LESS "4.3" )
++#   include_directories( patches/CGAL-4.2 )
++# elseif( "${CGAL_VERSION}" VERSION_LESS "4.10")
++#   include_directories( patches/CGAL-4.3 )
++#   add_definitions( "-DCGAL_INTERSECTION_VERSION=1" )
++# endif()
+ 
+ #-- BOOST --
+ option( Boost_USE_AUTO_LINK "boost use autolink" OFF )
diff -Nru sfcgal-1.3.7/debian/patches/fix-linker-error.patch 
sfcgal-1.3.7/debian/patches/fix-linker-error.patch
--- sfcgal-1.3.7/debian/patches/fix-linker-error.patch  1970-01-01 
01:00:00.0 +0100
+++ sfcgal-1.3.7/debian/patches/fix-linker-error.patch  2019-12-05 
21:34:40.00000 +0100
@@ -0,0 +1,82 @@
+Description: Force GMPXX as workaround for a linker error (used to be the
+  default for CGAL 4.x packages)
+Author: Joachim Reichel 
+Bug: https://github.com/Oslandia/SFCGAL/issues/198
+
+Index: sfcgal-1.3.7/CMakeLists.txt
+===
+--- sfcgal-1.3.7.orig/CMakeLists.txt
 sfcgal-1.3.7/CMakeLists.txt
+@@ -55,6 +55,7 @@ endif()
+ # 4.13 recommended
+ find_package( CGAL COMPONENTS Core REQUIRED )
+ message( STATUS "CGAL ${CGAL_VERSION} found" )
++add_definitions( "-DCGAL_USE_GMPXX=1" )
+ 
+ include_directories( ${CMAKE_BINARY_DIR}/include )
+ 
+Index: sfcgal-1.3.7/test/garden/CMakeLists.txt
+===
+--- sfcgal-1.3.7.orig/test/garden/CMakeLists.txt
 sfcgal-1.3.7/test/garden/CMakeLists.txt
+@@ -7,7 +7,7 @@ set( REGRESS_NAME garden-test-SFCGAL )
+ add_executable( ${REGRESS_NAME} ${SFCGAL_REGRESS_GARDEN_TEST_SOURCES} )
+ 
+ target_link_libraries( ${REGRESS_NAME} SFCGAL)
+-target_link_libraries( ${REGRESS_NAME} ${CGAL_3RD_PARTY_LIBRARIES} 
${Boost_LIBRARIES})
++target_link_libraries( ${REGRESS_NAME} gmpxx ${CGAL_3RD_PARTY_LIBRARIES} 
${Boost_LIBRARIES})
+ 
+ set_target_p

Bug#945840: /usr/bin/ledger: error while loading shared libraries: libboost_python27.so.1.67.0: cannot open shared object file: No such file or directory

[Joachim Reichel]

Hi,

it seems to me that other packages are also affected:

- k3d FTBFS (bug #946225)
- yade FTBFS (apparently fixed in experimental, see bug #938859)

Even though these packages needs to be fixed, it might be a good idea not to
break them right way and make e.g. the cgal_5.0 transition more difficult than
necessary.

  Joachim

Bug#946228: FTBFS with CGAL 5.0

[Joachim Reichel]

Source: k3d
Version: 0.8.0.6-8
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS.

Attached are two patches that fix the problem. In addition, one needs to add
"Build-Depends: libcgal-dev (>= 5.0~).

But just applying these two patches is not enough to unblock the transition due
to bug #946225.

Best regards,
  Joachim
Index: k3d-0.8.0.6/CMakeLists.txt
===
--- k3d-0.8.0.6.orig/CMakeLists.txt
+++ k3d-0.8.0.6/CMakeLists.txt
@@ -7,7 +7,7 @@ IF(${CMAKE_MAJOR_VERSION} GREATER 3 OR $
   CMAKE_POLICY(SET CMP0026 OLD)
 ENDIF()
 
-set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_STANDARD 14)
 
 
 SET(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")
Index: k3d-0.8.0.6/cmake/modules/K3DFindCGAL.cmake
===
--- k3d-0.8.0.6.orig/cmake/modules/K3DFindCGAL.cmake
+++ k3d-0.8.0.6/cmake/modules/K3DFindCGAL.cmake
@@ -7,11 +7,6 @@ FIND_PATH(K3D_CGAL_INCLUDE_DIR CGAL
)
 MARK_AS_ADVANCED(K3D_CGAL_INCLUDE_DIR)
 
-FIND_LIBRARY(K3D_CGAL_LIBRARY CGAL
-   DOC "The CGAL library"
-   )
-MARK_AS_ADVANCED(K3D_CGAL_LIBRARY)
-
 FIND_LIBRARY(K3D_MPFR_LIBRARY mpfr
DOC "The mpfr library"
)
@@ -22,7 +17,7 @@ FIND_LIBRARY(K3D_GMP_LIBRARY gmp
)
 MARK_AS_ADVANCED(K3D_GMP_LIBRARY)
 
-IF(K3D_CGAL_INCLUDE_DIR AND K3D_CGAL_LIBRARY AND K3D_MPFR_LIBRARY AND 
K3D_GMP_LIBRARY)
+IF(K3D_CGAL_INCLUDE_DIR AND K3D_MPFR_LIBRARY AND K3D_GMP_LIBRARY)
SET(K3D_CGAL_FOUND 1)
-ENDIF(K3D_CGAL_INCLUDE_DIR AND K3D_CGAL_LIBRARY AND K3D_MPFR_LIBRARY AND 
K3D_GMP_LIBRARY)
+ENDIF(K3D_CGAL_INCLUDE_DIR AND K3D_MPFR_LIBRARY AND K3D_GMP_LIBRARY)
 
Index: k3d-0.8.0.6/modules/cgal/CMakeLists.txt
===
--- k3d-0.8.0.6.orig/modules/cgal/CMakeLists.txt
+++ k3d-0.8.0.6/modules/cgal/CMakeLists.txt
@@ -6,7 +6,6 @@ K3D_BUILD_MODULE(k3d-cgal)
 K3D_CREATE_MODULE_PROXY(k3d-cgal)
 
 TARGET_LINK_LIBRARIES(k3d-cgal
-   ${K3D_CGAL_LIBRARY}
${K3D_MPFR_LIBRARY}
${K3D_GMP_LIBRARY}
${Boost_THREAD_LIBRARY}

Bug#946225: FTBFS related to Boost.Python

[Joachim Reichel]

Source: k3d
Version: 0.8.0.6-8
Severity: serious
Tags: ftbfs

Hi,

your package FTBFS:

CMake Error at 
/usr/share/cmake-3.15/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find Boost (missing: python) (found suitable version "1.67.0",
  minimum required is "1.42")
Call Stack (most recent call first):
  /usr/share/cmake-3.15/Modules/FindPackageHandleStandardArgs.cmake:378 
(_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.15/Modules/FindBoost.cmake:2161 
(find_package_handle_standard_args)
  cmake/modules/K3DFindBoost.cmake:9 (FIND_PACKAGE)
  CMakeLists.txt:254 (INCLUDE)

This might have been caused by bug 945840.

Best regards,
  Joachim

-- System Information:
Debian Release: 10.2
  APT prefers stable-debug
  APT policy: (800, 'stable-debug'), (800, 'stable'), (700, 'testing-debug'), 
(700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#946223: [NMU] FTFBS with CGAL 5.0

[Joachim Reichel]

Source: yade
Version: 2019.01a-3
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS.
Attached are two patches that fix the problem. In addition, one needs to add
"Build-Depends: libcgal-dev (>= 5.0~).

Just applying these two patches is not enough due to bug #938859. What is your
planned timeline for an upload to unstable?

Best regards,
  Joachim

-- System Information:
Debian Release: 10.2
  APT prefers stable-debug
  APT policy: (800, 'stable-debug'), (800, 'stable'), (700, 'testing-debug'), 
(700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-6-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Index: yade-2019.01a/CMakeLists.txt
===
--- yade-2019.01a.orig/CMakeLists.txt
+++ yade-2019.01a/CMakeLists.txt
@@ -299,7 +299,7 @@ IF(ENABLE_CGAL)
 
 FILE(GLOB CGAL_SRC_LIB "lib/triangulation/*.cpp")
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CGAL_DEFINITIONS} -DYADE_CGAL")
-SET(LINKLIBS  
"${LINKLIBS};${CGAL_LIBRARIES};${GMP_LIBRARIES};${GMPXX_LIBRARIES};")
+SET(LINKLIBS  "${LINKLIBS};${GMP_LIBRARIES};${GMPXX_LIBRARIES};")
 MESSAGE(STATUS "Found CGAL")
 SET(CONFIGURED_FEATS "${CONFIGURED_FEATS} CGAL")
 
Index: yade-2019.01a/cMake/FindCGAL.cmake
===
--- yade-2019.01a.orig/cMake/FindCGAL.cmake
+++ yade-2019.01a/cMake/FindCGAL.cmake
@@ -7,38 +7,26 @@
 # This module defines
 #  CGAL_DEFINITIONS: compiler flags for compiling with CGAL
 #  CGAL_INCLUDE_DIR: where to find CGAL.h
-#  CGAL_LIBRARIES: the libraries needed to use CGAL
 #  CGAL_FOUND: if false, do not try to use CGAL
 
-IF(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+IF(CGAL_INCLUDE_DIR)
 SET(CGAL_FOUND TRUE)
-ELSE(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+ELSE(CGAL_INCLUDE_DIR)
FIND_PATH(CGAL_INCLUDE_DIR CGAL/basic.h
 /usr/include/
 /usr/local/include/
 $ENV{ProgramFiles}/CGAL/*/include/
 $ENV{SystemDrive}/CGAL/*/include/
 )
-FIND_LIBRARY(CGAL_LIBRARIES NAMES CGAL libCGAL
-PATHS
-/usr/lib
-/usr/local/lib
-/usr/lib/CGAL
-/usr/lib64
-/usr/local/lib64
-/usr/lib64/CGAL
-$ENV{ProgramFiles}/CGAL/*/lib/ms
-$ENV{SystemDrive}/CGAL/*/lib/ms
-)
 
-IF(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+IF(CGAL_INCLUDE_DIR)
 SET(CGAL_FOUND TRUE)
-MESSAGE(STATUS "Found CGAL: ${CGAL_INCLUDE_DIR}, ${CGAL_LIBRARIES}")
+MESSAGE(STATUS "Found CGAL: ${CGAL_INCLUDE_DIR}")
INCLUDE_DIRECTORIES(${CGAL_INCLUDE_DIR})
-ELSE(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+ELSE(CGAL_INCLUDE_DIR)
 SET(CGAL_FOUND FALSE)
 MESSAGE(STATUS "CGAL not found.")
-ENDIF(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+ENDIF(CGAL_INCLUDE_DIR)
 
-MARK_AS_ADVANCED(CGAL_INCLUDE_DIR CGAL_LIBRARIES)
-ENDIF(CGAL_INCLUDE_DIR AND CGAL_LIBRARIES)
+MARK_AS_ADVANCED(CGAL_INCLUDE_DIR)
+ENDIF(CGAL_INCLUDE_DIR)
Index: yade-2019.01a/CMakeLists.txt
===
--- yade-2019.01a.orig/CMakeLists.txt
+++ yade-2019.01a/CMakeLists.txt
@@ -32,6 +32,8 @@
 project(Yade C CXX)
 cmake_minimum_required(VERSION 2.8.11)
 
+set(CMAKE_CXX_STANDARD 14)
+
 set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cMake")
 
 INCLUDE(FindPythonInterp)
@@ -83,7 +85,7 @@ ELSE()
   ENDIF()
 ENDIF()
 
-SET(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -fPIC -O2 --param=ssp-buffer-size=4 
-Wformat -Wformat-security -Werror=format-security -Wall -std=c++11")
+SET(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -fPIC -O2 --param=ssp-buffer-size=4 
-Wformat -Wformat-security -Werror=format-security -Wall -std=c++14")
 
 IF (DEBUG)
   SET(CMAKE_VERBOSE_MAKEFILE 1)

Bug#946116: FTBFS with CGAL 5.0

[Joachim Reichel]

Source: rheolef
Version: 7.0-3
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS.
Attached are two patches to fix the problem, however, the build fails at a
later stage due to bug #944197.

Best regards,
  Joachim
Index: rheolef-7.0/configure.ac
===
--- rheolef-7.0.orig/configure.ac
+++ rheolef-7.0/configure.ac
@@ -600,29 +600,10 @@ dnl is it a well-known C++ compiler ?
 dnl-
 RHEO_RECOGNIZE_CXX
 if test x"${rheo_cxx}" = x"gnu"; then
-RHEO_GXX2011
-if test x"${rheo_gxx2011}" = x"yes"; then
-  if test x"${rheo_have_float128}" = x"yes"; then
-CXXFLAGS="${CXXFLAGS} -std=gnu++11"
-  else
-CXXFLAGS="${CXXFLAGS} -std=c++11"
-  fi
-else
-  RHEO_GXX2011_PRE
-  if test x"${rheo_gxx2011_pre}" = x"yes"; then
-if test x"${rheo_have_float128}" = x"yes"; then
-  CXXFLAGS="${CXXFLAGS} -std=gnu++0x"
-else
-  CXXFLAGS="${CXXFLAGS} -std=c++0x"
-fi
-  else
-CXXFLAGS="${CXXFLAGS} -ansi"
-  fi
-fi
-CXXFLAGS="${CXXFLAGS} -Wall ${permissive_opts} -Wno-unused 
-Wno-strict-aliasing -Wno-literal-suffix -Wno-deprecated-declarations"
+CXXFLAGS="${CXXFLAGS} -Wall ${permissive_opts} -Wno-unused 
-Wno-strict-aliasing -Wno-literal-suffix -Wno-deprecated-declarations 
-std=c++14"
 LDFLAGS="${LDFLAGS} -Wl,--as-needed"
 elif test x"${rheo_cxx}" = x"clang"; then
-CXXFLAGS="${CXXFLAGS} -Wall ${permissive_opts} -Wno-unused 
-Wno-strict-aliasing -Wno-deprecated-declarations -Wno-deprecated-register 
-std=c++11"
+CXXFLAGS="${CXXFLAGS} -Wall ${permissive_opts} -Wno-unused 
-Wno-strict-aliasing -Wno-deprecated-declarations -Wno-deprecated-register 
-std=c++14"
 LDFLAGS="${LDFLAGS} -Wl,--as-needed"
 fi
 #echo "CXXFLAGS ${CXXFLAGS}"
Index: rheolef-7.0/configure.ac
===
--- rheolef-7.0.orig/configure.ac
+++ rheolef-7.0/configure.ac
@@ -1726,7 +1726,7 @@ with_cgal="yes"
 rheo_incdir_cgal=""
 rheo_libdir_cgal=""
 #rheo_libs_cgal="-lCGAL_Core -lCGAL -lboost_thread"
-rheo_libs_cgal="-lCGAL -lgmp"
+rheo_libs_cgal="-lgmp"
 AC_ARG_WITH(cgal-incdir,
 [  --with-cgal-incdir[[=DIR]]  the cgal computational geometry 
includes directory (default=autodetect) ],
 [  case "${withval}" in
@@ -1752,7 +1752,7 @@ AC_ARG_WITH(cgal-libdir,
 [  rheo_libdir_cgal="" ]
 )
 AC_ARG_WITH(cgal-libs,
-[  --with-cgal-libs[[=LIBS]]   the cgal computational geometry library 
linker flags (default=-lCGAL) ],
+[  --with-cgal-libs[[=LIBS]]   the cgal computational geometry library 
linker flags (default=-lgmp) ],
 [  case "${withval}" in
   yes|no)  with_cgal=${withval};;
   *)   rheo_libs_cgal=${withval}

Bug#946114: FTFBS with CGAL 5.0 (NMU)

[Joachim Reichel]

Source: crrcsim
Version: 0.9.13-3.1
Severity: serious
Tags: ftbfs
Control: block 944417 by -1

Hi,

the transition to CGAL 5.0 started (see bug #944417) and your package FTBFS. I
intend to NMU the package with the attached diff to DELAYED/5-day.

Best regards,
  Joachim
diff -Nru crrcsim-0.9.13/debian/changelog crrcsim-0.9.13/debian/changelog
--- crrcsim-0.9.13/debian/changelog 2018-12-22 00:02:57.0 +0100
+++ crrcsim-0.9.13/debian/changelog 2019-12-03 22:22:43.0 +0100
@@ -1,3 +1,11 @@
+crrcsim (0.9.13-3.2) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Add patch to fix FTBFS with CGAL >= 5.0 (Closes: #xx).
+  * Add Build-Depends: libcgal-dev (>= 5.0~).
+
+ -- Joachim Reichel   Tue, 03 Dec 2019 22:22:43 +0100
+
 crrcsim (0.9.13-3.1) unstable; urgency=medium
 
   * Non-maintainer upload.
diff -Nru crrcsim-0.9.13/debian/control crrcsim-0.9.13/debian/control
--- crrcsim-0.9.13/debian/control   2018-12-22 00:02:43.0 +0100
+++ crrcsim-0.9.13/debian/control   2019-12-03 22:22:43.0 +0100
@@ -9,7 +9,7 @@
  libsdl1.2-dev,
  libboost-thread-dev,
  libplib-dev,
- libcgal-dev,
+ libcgal-dev (>= 5.0~),
  libjpeg-dev,
  portaudio19-dev,
 Standards-Version: 4.1.4
diff -Nru crrcsim-0.9.13/debian/patches/10-cgal-use-header-only-mode.patch 
crrcsim-0.9.13/debian/patches/10-cgal-use-header-only-mode.patch
--- crrcsim-0.9.13/debian/patches/10-cgal-use-header-only-mode.patch
1970-01-01 01:00:00.0 +0100
+++ crrcsim-0.9.13/debian/patches/10-cgal-use-header-only-mode.patch
2019-12-03 22:22:43.0 +0100
@@ -0,0 +1,13 @@
+Index: crrcsim-0.9.13/configure.ac
+===
+--- crrcsim-0.9.13.orig/configure.ac
 crrcsim-0.9.13/configure.ac
+@@ -232,7 +232,7 @@ if  (test "x$ac_cv_header_CGAL_Exact_pre
+   has_CGAL="yes  (found CGAL v3)"
+ fi   
+ CGAL_CFLAGS=-frounding-math
+-CGAL_LIBS=-lCGAL
++CGAL_LIBS=
+ AC_DEFINE([WINDDATA3D], [1], [Import code for wind data, needs CGAL, 0 to 
disable])
+ else
+ has_CGAL="no   (CGAL not found)"
diff -Nru crrcsim-0.9.13/debian/patches/series 
crrcsim-0.9.13/debian/patches/series
--- crrcsim-0.9.13/debian/patches/series2018-12-01 16:49:34.0 
+0100
+++ crrcsim-0.9.13/debian/patches/series2019-12-03 22:22:43.0 
+0100
@@ -7,3 +7,4 @@
 07-add-libgmp.patch
 08-boost_thread-mt-change.patch
 09-remove-extra-std-err.patch
+10-cgal-use-header-only-mode.patch

Bug#925782: Patch for bug 925782

[Joachim Reichel]

tag 925782 + patch
thanks

Hi,

attached is a patch that fixes the FTBFS with g++-9.

Best regards,
  Joachim
Index: mp3check-0.8.7/texception.h
===
--- mp3check-0.8.7.orig/texception.h
+++ mp3check-0.8.7/texception.h
@@ -38,10 +38,10 @@ extern "C" {

 #define TExceptionN(n) public: virtual const char *name()  const { return #n; }
 #define TExceptionM(m) public: virtual const char *message() const { return m; }
-#define TExceptionM1(m,a) public: virtual const char *message() const { char *buf; asprintf(, m, a); return buf; }
-#define TExceptionM2(m,a,b) public: virtual const char *message() const { char *buf; asprintf(, m, a,b); return buf; }
-#define TExceptionM3(m,a,b,c) public: virtual const char *message() const { char *buf; asprintf(, m, a,b,c); return buf; }
-#define TExceptionM4(m,a,b,c,d) public: virtual const char *message() const { char *buf; asprintf(, m, a,b,c,d); return buf; }
+#define TExceptionM1(m,a) public: virtual const char *message() const { char *buf; int result = asprintf(, m, a); return result != -1 ? buf : "asprintf failure"; }
+#define TExceptionM2(m,a,b) public: virtual const char *message() const { char *buf; int result = asprintf(, m, a,b); return result != -1 ? buf : "asprintf failure"; }
+#define TExceptionM3(m,a,b,c) public: virtual const char *message() const { char *buf; int result = asprintf(, m, a,b,c); return result != -1 ? buf : "asprintf failure"; }
+#define TExceptionM4(m,a,b,c,d) public: virtual const char *message() const { char *buf; int result = asprintf(, m, a,b,c,d); return result != -1 ? buf : "asprintf failure"; }

 // base class of all exceptions
 class TException {
Index: mp3check-0.8.7/tstring.cc
===
--- mp3check-0.8.7.orig/tstring.cc
+++ mp3check-0.8.7/tstring.cc
@@ -111,7 +111,7 @@ tstring::Rep *tstring::Rep::clone(size_t
 tstring::Rep *tstring::Rep::create(size_t tmem) {
size_t m = sizeof(Rep) << 1;
while((m - 1 - sizeof(Rep)) < tmem) m <<= 1;
-   Rep *p = new (m - 1 - sizeof(Rep)) Rep;
+   Rep *p = new (/*tag*/ true, m - 1 - sizeof(Rep)) Rep;
p->mem = m - 1 - sizeof(Rep); p->ref = 1; p->vulnerable = false;
return p;
 }
Index: mp3check-0.8.7/tstring.h
===
--- mp3check-0.8.7.orig/tstring.h
+++ mp3check-0.8.7/tstring.h
@@ -71,9 +71,12 @@ class tstring {

   // static methods
   // operator new for this class
-  static void * operator new (size_t size, size_t tmem) {
+  // add a tag parameter to ensure that the signature of the delete operator does not collide with the (void*,size_t) overload
+  static void * operator new (size_t size, bool /*tag*/, size_t tmem) {
 	 return ::operator new (size + tmem + 1);}
-  static void operator delete (void *p, size_t) {
+  static void operator delete (void *p, bool /*tag*/, size_t) {
+	 ::operator delete (p); }
+  static void operator delete (void *p) {
 	 ::operator delete (p); }

   // create a new representation

Bug#933848: FTBFS if cmake is installed or if built twice in a row

[Joachim Reichel]

It seems to be that the cmake-related FTBFS was not addressed?

Bug#933848: FTBFS if cmake is installed or if built twice in a row

[Joachim Reichel]

Source: pygalmesh
Version: 0.3.6-1
Severity: serious

1) pygalmesh FTBFS if cmake is installed. Actually the build succeeds, but the
resulting binary package is almost empty.

With cmake installed:

 fakeroot debian/rules clean
dh clean --with python3 --buildsystem=pybuild
   dh_auto_clean -O--buildsystem=pybuild
I: pybuild base:217: dh_auto_clean --buildsystem=cmake
   dh_autoreconf_clean -O--buildsystem=pybuild
   dh_clean -O--buildsystem=pybuild
[...]
 fakeroot debian/rules binary
dh binary --with python3 --buildsystem=pybuild
   dh_testroot -O--buildsystem=pybuild
   dh_prep -O--buildsystem=pybuild
   dh_auto_install -O--buildsystem=pybuild
I: pybuild base:217: dh_auto_install --buildsystem=cmake 
--builddirectory="/mnt/debian/packages/pygalmesh/pygalmesh-0.3.6/.pybuild/cpython3_3.7_pygalmesh/build"
 
--destdir="/mnt/debian/packages/pygalmesh/pygalmesh-0.3.6/debian/python3-pygalmesh"
 -- 
   dh_installdocs -O--buildsystem=pybuild

Without cmake installed:

 fakeroot debian/rules clean
dh clean --with python3 --buildsystem=pybuild
   dh_auto_clean -O--buildsystem=pybuild
I: pybuild base:217: python3.7 setup.py clean 
running clean
removing '/build/pygalmesh-0.3.6/.pybuild/cpython3_3.7_pygalmesh/build' (and 
everything under it)
'build/bdist.linux-amd64' does not exist -- can't clean it
'build/scripts-3.7' does not exist -- can't clean it
[...]
 fakeroot debian/rules binary
dh binary --with python3 --buildsystem=pybuild
   dh_testroot -O--buildsystem=pybuild
   dh_prep -O--buildsystem=pybuild
   dh_auto_install -O--buildsystem=pybuild
I: pybuild base:217: /usr/bin/python3 setup.py install --root 
/build/pygalmesh-0.3.6/debian/python3-pygalmesh 
running install
[... many more lines following ...]
   dh_installdocs -O--buildsystem=pybuild

I don't understand why the bare existence of cmake causes the build process to
behave differently. At least, the package should declare a Build-Conflicts: on
cmake.


2) pygalmesh FTBFS when built twice in a row. This can be fixed by putting

pygalmesh-from-inr.1
pygalmesh-volume-from-surface.1

in debian/clean.


Best regards,
  Joachim


-- System Information:
Debian Release: 10.0
  APT prefers stable-debug
  APT policy: (800, 'stable-debug'), (800, 'stable'), (700, 'testing-debug'), 
(700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#870406: Removal from testing

[Joachim Reichel]

Due to bugs 870406 and 887057 the following packages are scheduled for removal
from testing on 2019-03-11:

gjay, mp3cd, mp3roaster, mpg321, normalize-audio, ripit, terminatorx

Is anyone working on these bugs?

  Joachim

Bug#905577: cppcheck: FTBFS on arm*, ppc64el and s390x (plus various ports) - test failure

[Joachim Reichel]

Hi Adrian,

thanks for looking into it! Actually I'm testing right now a similar patch where
the declaration of v2 a few lines below is adjusted in a similar way. Upload
should happen shortly.

  Joachim

Bug#898535: closed by Chow Loong Jin (Bug#898535: fixed in tinyxml2 6.2.0+dfsg-2)

[Joachim Reichel]

On 03.08.2018 06:03, Debian Bug Tracking System wrote:
> Changes:
>  tinyxml2 (6.2.0+dfsg-2) unstable; urgency=medium
>  .
>* [7fdca1f] Rename package for abi break (Closes: #898535)

How do you plan to deal with the breakage that results from the renaming? Did
you already ask for binNMUs? I do not see a bug report that requests a
transition slot, nor any discussion on debian-release.

  Joachim

Bug#883986: Bug 886670 fixed

[Joachim Reichel]

Bug 886670 has now been fixed, so you could use find_package(CGAL ...) instead
of accessing internal variables like CGAL_CXX_FLAGS_INIT. find_package() will no
longer inject internal flags that were used to build CGAL itself.

For a simple example run cgal_create_cmake_script on a trivial foo.cpp file
containing a main() function.

If you decide not to use find_package(), you can run make on the generated
Makefile to see the default flags.

  Joachim

Bug#897127: psensor FTBFS on i386/armhf: FAIL: test-cppcheck.sh

[Joachim Reichel]

See bug 898327.

  Joachim

Bug#898327: cppcheck: *** stack smashing detected ***: terminated

[Joachim Reichel]

Hi Jakub,

I confirm that the crash goes away if libtinyxml2-6 is downgraded to
6.0.0+dfsg-1. Thanks for finding the real cause!

I've filed bug 898535 against tinyxml2. I've added a versioned Build-Depends to
cppcheck as workaround.

  Joachim

Bug#898535: Incompatible ABI change without SONAME bump

[Joachim Reichel]

Source: tinyxml2
Version: 6.2.0+dfsg-1
Severity: grave
Tags: upstream

Hi,

the layout of tinyxml::XMLDocument has been changed between version 6.0.0 and
6.2.0 (addition of _parsingDepth member). Unfortunately, the SONAME has not
been bumped. This can cause applications built against version 6.0.0 to crash
when running with version 6.2.0. See bug 898327 for an example.

Please discuss this with upstream. Maybe they could release 6.2.1 with bumped
SONAME?

Please inform the reverse dependencies of tinyxml2 about the problem.

  Joachim

-- System Information:
Debian Release: 9.4
  APT prefers stable-debug
  APT policy: (800, 'stable-debug'), (800, 'stable'), (700, 'testing-debug'), 
(700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-6-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#898327: cppcheck: *** stack smashing detected ***: terminated

[Joachim Reichel]

Hi Jakub,

I can reproduce this on i386 with the binary package from the archive (but not
on amd64). I'm not able to reproduce the problem if I build the package myself
in an up-to-date sid chroot.

It also does not happen if I use g++ 7.3.0-15 which was used on the autobuilder,
but there are of course more variables like other build dependencies.

The problem also shows up with 1.82-1 in the snapshot archive, but not with
1.76.1-1 in stable.

Debugging this problem is difficult since I can't reproduce it in a local build.
I'm leaning towards a binNMU to see whether it was a temporary problem on the
build machine. What do you think?

  Joachim

Bug#886670: libcgal-dev: CGAL_CXX_FLAGS_INIT contains flags that shouldn't be there

[Joachim Reichel]

severity 886670 normal
unblock 883986 by 886670
tag 886670 upstream
forwarded 886670 https://github.com/CGAL/cgal/issues/2734
thanks

On 08.01.2018 20:35, Adrian Bunk wrote:
> While looking into fixing #883986 I ran into the following problem
> due to openscad using CGAL_CXX_FLAGS_INIT:
> 
> /usr/lib/x86_64-linux-gnu/cmake/CGAL/CGALConfig.cmake:
> set(CGAL_CXX_FLAGS_INIT   "-g -O2 
> -fdebug-prefix-map=/build/cgal-d6DBFP/cgal-4.11=. -fstack-protector-strong 
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 
> -frounding-math" )
> 
> The only flag that might be correct in this place is -frounding-math,
> in case that is required for using CGAL.
> 
> Exposing flags like -fdebug-prefix-map is simply wrong.
> 
> (For #883986 the problem is the -g, that is also wrong here.)

I agree and I have forwarded this as
https://github.com/CGAL/cgal/issues/2734

> The severity might seem inflated, but this should be fixed
> for fixing the RC #883986 FTBFS in openscad.

However, I disagree about the severity. Since there is a simple workaround I've
reset the severity to normal and removed the block relation.

  Joachim

Bug#883986: Don't drop -frounding-math

[Joachim Reichel]

You shouldn't drop ${CGAL_CXX_FLAGS_INIT} completely. If you want to avoid the
troublesome flags, you should at least include -frounding-math, which is
strictly needed for CGAL.

  Joachim

Bug#871811: Bug#876521: FTBFS with CGAL 4.11

[Joachim Reichel]

Hi Sebastiaan,

any news here? SFCGAL is now the only remaining reverse dependency that affects
the upload of CGAL 4.11.

Unless you have information that changes the picture in the near-term future I
would like to go on and request a transition slot for CGAL 4.11.

Kind regards,
  Joachim

Bug#876524: FTBFS with CGAL 4.11

[Joachim Reichel]

Source: yade
Severity: serious
Tags: upstream

Hi,

I would like to upgrade CGAL from 4.9 to 4.11 but if I do so your package
FTBFS. Therefore (and because of the SONAME transition), CGAL 4.11 has been
uploaded to experimental for now instead of sid.

Attached is an excerpt from the build log with the errors.

  Joachim

-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (800, 'stable'), (700, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (200, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
/usr/include/eigen3/Eigen/src/Core/PlainObjectBase.h:537:19:   required from 
‘Eigen::PlainObjectBase::PlainObjectBase(const 
Eigen::DenseBase&) [with OtherDerived = 
Eigen::CwiseBinaryOp, const 
Eigen::CwiseNullaryOp >, const 
Eigen::CwiseBinaryOp, 
const Eigen::CwiseNullaryOp >, const Eigen::Inverse 
> > >; Derived = Eigen::Matrix]’
/usr/include/eigen3/Eigen/src/Core/Matrix.h:379:29:   required from 
‘Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, 
_MaxCols>::Matrix(const Eigen::EigenBase&) [with OtherDerived = 
Eigen::CwiseBinaryOp, const 
Eigen::CwiseNullaryOp >, const 
Eigen::CwiseBinaryOp, 
const Eigen::CwiseNullaryOp >, const Eigen::Inverse 
> > >; _Scalar = double; int _Rows = 3; int _Cols = 3; int _Options = 0; int 
_MaxRows = 3; int _MaxCols = 3]’
/tmp/cgal/yade-2017.01a/core/Cell.hpp:138:102:   required from here
/usr/include/eigen3/Eigen/src/Core/AssignEvaluator.h:86:63: warning: enum 
constant in boolean context [-Wint-in-bool-context]
 MayLinearVectorize = bool(MightVectorize) && MayLinearize && 
DstHasDirectAccess
  
~^
/usr/include/eigen3/Eigen/src/Core/AssignEvaluator.h:90:49: warning: enum 
constant in boolean context [-Wint-in-bool-context]
 MaySliceVectorize  = bool(MightVectorize) && bool(DstHasDirectAccess)
 ^~~~
CMakeFiles/yade.dir/build.make:977: recipe for target 
'CMakeFiles/yade.dir/pkg/common/PersistentTriangulationCollider.cpp.o' failed
make[3]: *** 
[CMakeFiles/yade.dir/pkg/common/PersistentTriangulationCollider.cpp.o] Error 1
--
/usr/include/eigen3/Eigen/src/Core/PlainObjectBase.h:537:19:   required from 
‘Eigen::PlainObjectBase::PlainObjectBase(const 
Eigen::DenseBase&) [with OtherDerived = 
Eigen::CwiseBinaryOp, const 
Eigen::CwiseNullaryOp >, const 
Eigen::CwiseBinaryOp, 
const Eigen::CwiseNullaryOp >, const Eigen::Inverse 
> > >; Derived = Eigen::Matrix]’
/usr/include/eigen3/Eigen/src/Core/Matrix.h:379:29:   required from 
‘Eigen::Matrix<_Scalar, _Rows, _Cols, _Options, _MaxRows, 
_MaxCols>::Matrix(const Eigen::EigenBase&) [with OtherDerived = 
Eigen::CwiseBinaryOp, const 
Eigen::CwiseNullaryOp >, const 
Eigen::CwiseBinaryOp, 
const Eigen::CwiseNullaryOp >, const Eigen::Inverse 
> > >; _Scalar = double; int _Rows = 3; int _Cols = 3; int _Options = 0; int 
_MaxRows = 3; int _MaxCols = 3]’
/tmp/cgal/yade-2017.01a/core/Cell.hpp:138:102:   required from here
/usr/include/eigen3/Eigen/src/Core/AssignEvaluator.h:86:63: warning: enum 
constant in boolean context [-Wint-in-bool-context]
 MayLinearVectorize = bool(MightVectorize) && MayLinearize && 
DstHasDirectAccess
  
~^
/usr/include/eigen3/Eigen/src/Core/AssignEvaluator.h:90:49: warning: enum 
constant in boolean context [-Wint-in-bool-context]
 MaySliceVectorize  = bool(MightVectorize) && bool(DstHasDirectAccess)
 ^~~~

Bug#876521: FTBFS with CGAL 4.11

[Joachim Reichel]

Source: sfcgal
Severity: serious
Tags: upstream

Hi,

I would like to upgrade CGAL from 4.9 to 4.11 but if I do so your package
FTBFS. Therefore (and because of the SONAME transition), CGAL 4.11 has been
uploaded to experimental for now instead of sid.

Attached is an excerpt from the build log with the errors.

  Joachim

-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (800, 'stable'), (700, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (200, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
 from /tmp/cgal/sfcgal-1.3.1/src/Coordinate.cpp:21:
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/numeric.h:50:15: 
note: candidate: double SFCGAL::round(const double&)
 inline double round( const double& v )
   ^
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/numeric.h:50:15: 
note:   no known conversion for argument 1 from ‘__gmp_expr<__mpq_struct [1], 
__gmp_binary_expr<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, long int, 
__gmp_binary_multiplies> >’ to ‘const double&’
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/numeric.h:72:23: 
note: candidate: CGAL::Gmpz SFCGAL::round(const CGAL::Gmpq&)
 SFCGAL_API CGAL::Gmpz round( const CGAL::Gmpq& v ) ;
   ^
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/numeric.h:72:23: 
note:   no known conversion for argument 1 from ‘__gmp_expr<__mpq_struct [1], 
__gmp_binary_expr<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, long int, 
__gmp_binary_multiplies> >’ to ‘const CGAL::Gmpq&’
src/CMakeFiles/SFCGAL.dir/build.make:65: recipe for target 
'src/CMakeFiles/SFCGAL.dir/Coordinate.cpp.o' failed
make[3]: *** [src/CMakeFiles/SFCGAL.dir/Coordinate.cpp.o] Error 1
--
 from /usr/include/boost/config/no_tr1/memory.hpp:21,
 from /usr/include/boost/smart_ptr/shared_ptr.hpp:23,
 from /usr/include/boost/shared_ptr.hpp:17,
 from 
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/Geometry.h:26,
 from 
/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include/SFCGAL/algorithm/collect.h:26,
 from /tmp/cgal/sfcgal-1.3.1/src/algorithm/collect.cpp:21:
/usr/include/c++/7/bits/unique_ptr.h:51:28: note: declared here
   template class auto_ptr;
^~~~
src/CMakeFiles/SFCGAL.dir/build.make:617: recipe for target 
'src/CMakeFiles/SFCGAL.dir/algorithm/Intersection3D.cpp.o' failed
make[3]: *** [src/CMakeFiles/SFCGAL.dir/algorithm/Intersection3D.cpp.o] Error 1
--
/usr/include/boost/archive/detail/iserializer.hpp:369:31:   required from 
‘boost::archive::detail::pointer_iserializer::pointer_iserializer() 
[with Archive = boost::archive::binary_iarchive; T = SFCGAL::Point]’
/usr/include/boost/serialization/singleton.hpp:100:7:   required from ‘static 
T& boost::serialization::singleton::get_instance() [with T = 
boost::archive::detail::pointer_iserializer]’
/usr/include/boost/serialization/singleton.hpp:135:28:   required from ‘static 
const T& boost::serialization::singleton::get_const_instance() [with T = 
boost::archive::detail::pointer_iserializer]’
/usr/include/boost/archive/detail/interface_iarchive.hpp:55:34:   required from 
‘const boost::archive::detail::basic_pointer_iserializer* 
boost::archive::detail::interface_iarchive::register_type(T*) [with T 
= SFCGAL::Point; Archive = boost::archive::binary_iarchive]’
/tmp/cgal/sfcgal-1.3.1/src/detail/io/Serialization.cpp:59:28:   required from 
here
/usr/include/boost/serialization/access.hpp:116:11: error: ‘class 
__gmp_expr<__mpq_struct [1], __mpq_struct [1]>’ has no member named 
‘serialize’; did you mean ‘canonicalize’?
 t.serialize(ar, file_version);
 ~~^
 canonicalize
src/CMakeFiles/SFCGAL.dir/build.make:1601: recipe for target 
'src/CMakeFiles/SFCGAL.dir/detail/io/Serialization.cpp.o' failed
make[3]: *** [src/CMakeFiles/SFCGAL.dir/detail/io/Serialization.cpp.o] Error 1
[ 39%] Building CXX object 
src/CMakeFiles/SFCGAL.dir/detail/polygonSetToMultiPolygon.cpp.o
cd /tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/src && /usr/bin/c++  
-DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DCGAL_INTERSECTION_VERSION=1 
-DSFCGAL_BUILD_SHARED -DSFCGAL_EXPORTS 
-I/tmp/cgal/sfcgal-1.3.1/obj-x86_64-linux-gnu/include 
-I/tmp/cgal/sfcgal-1.3.1/patches/CGAL-4.3 -isystem 
/usr/include/x86_64-linux-gnu  -g -O2 
-fdebug-prefix-map=/tmp/cgal/sfcgal-1.3.1=. -fstack-protector-strong -Wformat 
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra 
-Wno-long-long -pedantic -Wpointer-arith 

Bug#838516: FTBFS: conflicts between build dependencies

[Joachim Reichel]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Removing libglew-dev from Build-Depends seems to work (in the sense that I did
not spot any related build errors), but I have no idea whether this is the
correct solution.

However, the build does not complete because of

/tmp/k3d-0.8.0.5/k3dsdk/ngui/utility.cpp: In function ‘void
k3d::ngui::non_blocking_sleep(double)’:
/tmp/k3d-0.8.0.5/k3dsdk/ngui/utility.cpp:63:2: error: ‘signal_timeout’ is not
a member of ‘Glib’
  Glib::signal_timeout().connect(

which can be fixed by adding "#include ".

Joachim

-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJX5BuPAAoJELj6/xxDiGdxB/wP/0U2C73NtPyJFViMXQPRwm0h
0c+p18stcTnNlQk1vuZocPADKPHHTaSdD+7xTxMRIqK3BsIhrGehPdA7WzJ/DcAj
zHsSDTaPOM+L+4tBp7M5tLZTWGEBXL+4jk3flU70XW4R0+W4ivj+bkf1kZs4f9WX
w+bEpOWfp/8qNRy7SXzys5lFVJ4yRget2JnlXHukOAh8Y4wW525XB2pnZZ8Wr48F
ynQZuuLTarZH67dVEoT9nRXHG/cJUS5Y7/4gdh8Jc+K9KorFG11ugRMy6hFHpXZh
wfGvqXkHhFAjF+7VwYcS2oS7neSaDIJ57RBeKnIXeqsaESe+7VzmQga7woGOYGIb
OW16Ua43vOFb3a8BysH7+dg4FFcBu6wR6I+AgJyOG1zw95QcyH7Her4x1pQJ4YPd
VvmotJW+x4Z6p5ORdF1NyzELTGrm7Xxnea+zfZR+PxxQgRkJpSiu5sVx8fYtYTn5
+3ySHKhr+VqDjgWtac8HJV4SbU8uBPoUiqNQJS16ick7w3T0QLKSmWgTkr0HPz/I
hlLmPl3+2fQ1ZdgmMSZcOytICVfkl98rt7aDPBAK/INerLs7WdbOIwQSunxQ0Pri
M33KLPnT37oYthsu7U3vOYTAJdrYmAmenWUada/bTp/+R9bB48vJntdx3I3h399G
wTG+QmLQNPbqv0APynxb
=DPXf
-END PGP SIGNATURE-

Bug#838516: FTBFS: conflicts between build dependencies

[Joachim Reichel]

Source: k3d
Version: 0.8.0.5-4
Severity: serious

Hi,
   
k3d 0.8.0.5-4 has
 
Build-Depends: [...] libglew-dev, libglewmx-dev, [...]
  
but libglewmx-dev 1.13.0-3 has
  
Conflicts: libglew-dev
  
(I want to rebuild k3d against the new cgal package which changed SONAMEs.)
   
Regards,
  Joachim

-- System Information:
Debian Release: 8.6
  APT prefers stable-updates
  APT policy: (810, 'stable-updates'), (800, 'stable'), (700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#835427: s/XML_NO_ERROR/XML_SUCCESS/

[Joachim Reichel]

Older versions of tinyxml defined both XML_NO_ERROR and XML_SUCCESS to 0. Never
versions define only XML_SUCCESS.

Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Joachim Reichel]

user release.debian@packages.debian.org
usertag 790996 + transition
block 790996 by 790756
reassign 790996 release.debian.org
thanks

Attached is the diff for 4.6.1-2. Several build depends have not yet made the
transition:

level 3: gmp (791053)
level 5: qtbase-opensource-src (794518)
level 6: libqglviewer, boost

Joachim

diff -Nru cgal-4.6.1/debian/changelog cgal-4.6.1/debian/changelog
--- cgal-4.6.1/debian/changelog	2015-06-26 18:58:01.0 +0200
+++ cgal-4.6.1/debian/changelog	2015-08-15 10:57:45.0 +0200
@@ -1,3 +1,9 @@
+cgal (4.6.1-2) unstable; urgency=medium
+
+  * Rename library packages for g++5 ABI transition (Closes: #790996).
+
+ -- Joachim Reichel reic...@debian.org  Sat, 15 Aug 2015 10:57:06 +0200
+
 cgal (4.6.1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru cgal-4.6.1/debian/control cgal-4.6.1/debian/control
--- cgal-4.6.1/debian/control	2015-04-10 20:19:57.0 +0200
+++ cgal-4.6.1/debian/control	2015-08-15 10:58:58.0 +0200
@@ -10,7 +10,9 @@
 Homepage: http://www.cgal.org/
 XS-Autobuild: yes
 
-Package: libcgal11
+Package: libcgal11v5
+Conflicts: libcgal11
+Replaces: libcgal11
 Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
@@ -35,13 +37,15 @@
  This package contains the main library libCGAL.so as well as two support
  libraries libCGAL_Core.so (from the CORE project) and libCGAL_ImageIO.so
  (image I/O). The library libCGAL_Qt4.so used for visualization in demos
- can be found in the package libcgal-qt4-11.
+ can be found in the package libcgal-qt4-11v5.
 
-Package: libcgal-qt4-11
+Package: libcgal-qt4-11v5
+Conflicts: libcgal-qt4-11
+Replaces: libcgal-qt4-11
 Architecture: any
 Multi-Arch: same
 Pre-Depends: ${misc:Pre-Depends}
-Depends: libcgal11 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
+Depends: libcgal11v5 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
 Description: C++ library for computational geometry (support for Qt4)
  CGAL (Computational Geometry Algorithms Library) makes the most important
  of the solutions and methods developed in computational geometry available
@@ -65,7 +69,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcgal11 (= ${binary:Version}), libboost-dev, libboost-thread-dev,
+Depends: libcgal11v5 (= ${binary:Version}), libboost-dev, libboost-thread-dev,
  libboost-system-dev, libboost-program-options-dev, libgmp10-dev, libmpfr-dev,
  zlib1g-dev, ${misc:Depends}
 Suggests: libmpfi-dev, libntl-dev, libtbb-dev
@@ -83,7 +87,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libcgal11 (= ${binary:Version}), libcgal-qt4-11 (= ${binary:Version}),
+Depends: libcgal11v5 (= ${binary:Version}), libcgal-qt4-11v5 (= ${binary:Version}),
  libcgal-dev, libqt4-dev, ${misc:Depends}
 Replaces: libcgal-dev ( 4.1-1)
 Breaks: libcgal-dev ( 4.1-1)
@@ -100,9 +104,9 @@
 Section: devel
 Architecture: all
 Multi-Arch: foreign
-Depends: libcgal-dev (= ${binary:Version}), libcgal11 (= ${binary:Version}),
+Depends: libcgal-dev (= ${binary:Version}), libcgal11v5 (= ${binary:Version}),
  ${misc:Depends}
-Recommends: libcgal-qt4-dev (= ${binary:Version}), libcgal-qt4-11 (= ${binary:Version})
+Recommends: libcgal-qt4-dev (= ${binary:Version}), libcgal-qt4-11v5 (= ${binary:Version})
 Suggests: liblapack-dev, libatlas-base-dev, gfortran,  geomview,
  libqglviewer-dev, libipe-dev (= 7), libglew1.5-dev | libglew-dev,
  libmagick++-dev, qt4-dev-tools, libqt4-opengl-dev, libeigen3-dev (= 3.1.0~beta1-1),
@@ -118,7 +122,7 @@
 Package: libcgal-ipelets
 Section: graphics
 Architecture: any
-Depends: libcgal11 (= ${binary:Version}), ipe (= ${Ipe-Version}), ipe ( ${Ipe-Version}+),
+Depends: libcgal11v5 (= ${binary:Version}), ipe (= ${Ipe-Version}), ipe ( ${Ipe-Version}+),
  ${shlibs:Depends}, ${misc:Depends}
 Conflicts: libcgal5-ipelets
 Replaces: libcgal5-ipelets
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11.install cgal-4.6.1/debian/libcgal-qt4-11.install
--- cgal-4.6.1/debian/libcgal-qt4-11.install	2014-10-24 21:24:42.0 +0200
+++ cgal-4.6.1/debian/libcgal-qt4-11.install	1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-usr/lib/*/libCGAL_Qt4.so.*
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11.shlibs cgal-4.6.1/debian/libcgal-qt4-11.shlibs
--- cgal-4.6.1/debian/libcgal-qt4-11.shlibs	2015-04-10 20:43:58.0 +0200
+++ cgal-4.6.1/debian/libcgal-qt4-11.shlibs	1970-01-01 01:00:00.0 +0100
@@ -1 +0,0 @@
-libCGAL_Qt4 11 libcgal-qt4-11
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11v5.install cgal-4.6.1/debian/libcgal-qt4-11v5.install
--- cgal-4.6.1/debian/libcgal-qt4-11v5.install	1970-01-01 01:00:00.0 +0100
+++ cgal-4.6.1/debian/libcgal-qt4-11v5.install	2014-10-24 21:24:42.0 +0200
@@ -0,0 +1 @@
+usr/lib/*/libCGAL_Qt4.so.*
diff -Nru cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides
--- cgal-4.6.1/debian/libcgal-qt4-11v5.lintian-overrides	1970-01-01 01:00:00.0 +0100
+++ cgal-4.6.1

Bug#790996: cgal: library transition may be needed when GCC 5 is the default

[Joachim Reichel]

On 08/10/2015 04:16 PM, Helmut Grohne wrote:
 Control: severity -1 serious
 
 libcgal11 broke ABI in 4.6.1-1+b1.
 
 Example symbol diff:
 
 -CGAL::swallow(std::istream, std::string const)
 +CGAL::swallow(std::istream, std::__cxx11::basic_stringchar, 
 std::char_traitschar, std::allocatorchar  const)

Thanks, I'm aware of that and working on it. Some of the build-depends haven't
made the transition yet: gmp, ntl, qtbase-opensource-src, ipe, geomview,
libqglviewer.

(Additionally, a small part of the patch depends on the names of their binary
packages.)

Joachim


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#780359: Options w.r.t. libcgal11 transition

[Joachim Reichel]

Hi,

dolfin is now the only reverse dependency holding up the libcgal11 transition.

What are the options?
(1) Fix dolfin without causing another transition
(2) Remove dolfin from testing
(3) Upload 1.5.0-1 from experimental to unstable
(4) ...?

(1) I don't know the details but it seems to me that this is not easy.

(3) This causes another transition, but the only reverse dependencies of the
binary packages of dolfin are python-viper (plus the meta packages fenics,
science-mathematics and science-mathematics-dev). Rebuilding python-viper
against dolfin 1.5.0-1 worked without problems. Maybe this additional transition
isn't that bad (apart from the delay)?

BTW does anyone understand why dolfin does not appear in the list of
autoremovals? The bug is release-critical and not fixed in unstable/testing,
only experimental.

Joachim


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#733302: FTBFS: missing texinfo dependency and syntax erorr in texinfo file

[Joachim Reichel]

Package: cgdb
Version: 0.6.7-1
Severity: serious
Tags: patch

Hi,

your package fails to build in a pbuilder sid environment because makeinfo is
missing if there is no Build-Depends on texinfo. Furthermore, there is a syntax
erorr in doc/cgdb.texinfo which causes a build error with newer texinfo
versions. Just replace itemx by item in line 699 and 765.

BTW is the change of debian/patches/manpage.diff between 0.6.6-2 and 0.6.7-1
intentional? The man page title changes from curses based frontend to GDB to
sanua based frontend to GDB ...

Joachim

-- System Information:
Debian Release: 7.3
  APT prefers stable-updates
  APT policy: (810, 'stable-updates'), (800, 'stable'), (700, 'testing'), (200, 
'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.7-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cgdb depends on:
ii  dpkg  1.16.12
ii  gdb   7.4.1+dfsg-0.1
ii  install-info  4.13a.dfsg.1-10
ii  libc6 2.17-92+b1
ii  libncurses5   5.9-10
ii  libreadline6  6.2+dfsg-0.1
ii  libtinfo5 5.9-10

cgdb recommends no packages.

cgdb suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#701347: rheolef: ftbfs with GCC-4.8

[Joachim Reichel]

Package: rheolef
Followup-For: Bug #701347

I am not able to reproduce this bug with g++ 4.8.1-5.

Joachim

-- System Information:
Debian Release: 7.1
  APT prefers stable-updates
  APT policy: (810, 'stable-updates'), (800, 'stable'), (700, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.7-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#713069: k3d: FTBFS on armel and ia64 (terminate called after throwing an instance of 'CGAL::Assertion_exception')

[Joachim Reichel]

ia64:
The problem has been fixed in cgal 4.2-4. A new build attempt should fix this
problem (but see #703068).

armel:
CGAL does not work on armel. The CGAL plugin for k3D should be disabled on
armel. (Note: due to a mistake on my side there used to exist CGAL binary
packages on armel for a few version -- all of them non-functional.)

Joachim


-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#643278: install target in generated Makefile for ipelets missing

[Joachim Reichel]

retitle 643278 install target in generated Makefile for ipelets missing
severity 643278 normal
tag 643278 +help
thanks

The problem is that the Makfile generated for shared/demo/CGAL_ipelets
lacks most install related targets.

It still works in squeeze (using cmake 2.8.2) and fails in current sid
(using cmake 2.8.5), but worked in sid on August ~7th. First I thought
the problem was related to the newer cmake version, but that's wrong.
Installing cmake 2.8.5 (from backports) in Debian squeeze works fine.

Maybe the problem is related to the introduction of multiarch.

The new upstream version 3.9-1 has a workaround for the problem (custom
cp rule instead of make install), hence, downgrading the severity.

Joachim



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#633578: FTBFS with g++ 4.6

[Joachim Reichel]

Package: core++
Version: 1.7-11
Severity: grave
Tags: upstream, help

See https://bugs.launchpad.net/ubuntu/+source/core++/+bug/771054 for
details.

I'm not very motivated to fix this problem myself (see the RFA bug #550777),
but I'll happily upload a patch.

If the problem is not solved by the time of the freeze for wheezy I'll ask
for removal of the package.

-- System Information:
Debian Release: 6.0.2
  APT prefers stable
  APT policy: (800, 'stable'), (750, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#590382: patch and NMU notice

[Joachim Reichel]

tag 590382 + patch
thanks

Attached is a patch to fix the problem. Hereby I announce my intention to NMU 
the
package. If there are objections, let me know.

Joachim
diff -u gelemental-1.2.0/debian/changelog gelemental-1.2.0/debian/changelog
--- gelemental-1.2.0/debian/changelog
+++ gelemental-1.2.0/debian/changelog
@@ -1,3 +1,12 @@
+gelemental (1.2.0-4.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * debian/patches/ftbfs_doxygen_changes.dpatch: Added.
+- do not try to install *.gif and *.dot files which do no longer exist
+  * debian/patches/00list: Adjusted.
+
+ -- Joachim Reichel reic...@debian.org  Fri, 27 Aug 2010 18:38:31 +0200
+
 gelemental (1.2.0-4) unstable; urgency=low
 
   * debian/control (Standards-Version): Bumped to 3.8.3.
diff -u gelemental-1.2.0/debian/patches/00list gelemental-1.2.0/debian/patches/00list
--- gelemental-1.2.0/debian/patches/00list
+++ gelemental-1.2.0/debian/patches/00list
@@ -5,0 +6 @@
+ftbfs_doxygen_changes
only in patch2:
unchanged:
--- gelemental-1.2.0.orig/debian/patches/ftbfs_doxygen_changes.dpatch
+++ gelemental-1.2.0/debian/patches/ftbfs_doxygen_changes.dpatch
@@ -0,0 +1,49 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## ftbfs_doxygen_changes.dpatch by Joachim Reichel reic...@debian.org
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Fix an FTBFS because doxygen no longer generates *.gif and *.dot files.
+
+...@dpatch@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gelemental-1.2.0~/docs/api/Makefile.am gelemental-1.2.0/docs/api/Makefile.am
+--- gelemental-1.2.0~/docs/api/Makefile.am	2007-02-14 10:47:51.0 +0100
 gelemental-1.2.0/docs/api/Makefile.am	2010-08-27 18:36:05.0 +0200
+@@ -12,7 +12,7 @@
+ install-api: $(srcdir)/html/index.html
+ 	@$(NORMAL_INSTALL)
+ 	$(mkinstalldirs) $(DESTDIR)/$(apidir)
+-	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png $$dir/*.gif $$dir/*.dot ; do \
++	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png ; do \
+ 		f=`echo $$p | sed -e 's|^.*/||'`; \
+ 		echo  $(INSTALL_DATA) $$p $(DESTDIR)$(apidir)/$$f; \
+ 		$(INSTALL_DATA) $$p $(DESTDIR)$(apidir)/$$f; \
+@@ -20,7 +20,7 @@
+ 
+ uninstall-api: $(srcdir)/html/index.html
+ 	@$(NORMAL_UNINSTALL)
+-	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png $$dir/*.gif $$dir/*.dot ; do \
++	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png ; do \
+ 		f=`echo $$p | sed -e 's|^.*/||'`; \
+ 		echo  rm -f $(DESTDIR)$(apidir)/$$f; \
+ 		rm -f $(DESTDIR)$(apidir)/$$f; \
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' gelemental-1.2.0~/docs/api/Makefile.in gelemental-1.2.0/docs/api/Makefile.in
+--- gelemental-1.2.0~/docs/api/Makefile.in	2007-09-25 06:46:27.0 +0200
 gelemental-1.2.0/docs/api/Makefile.in	2010-08-27 18:36:16.0 +0200
+@@ -393,7 +393,7 @@
+ install-api: $(srcdir)/html/index.html
+ 	@$(NORMAL_INSTALL)
+ 	$(mkinstalldirs) $(DESTDIR)/$(apidir)
+-	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png $$dir/*.gif $$dir/*.dot ; do \
++	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png ; do \
+ 		f=`echo $$p | sed -e 's|^.*/||'`; \
+ 		echo  $(INSTALL_DATA) $$p $(DESTDIR)$(apidir)/$$f; \
+ 		$(INSTALL_DATA) $$p $(DESTDIR)$(apidir)/$$f; \
+@@ -401,7 +401,7 @@
+ 
+ uninstall-api: $(srcdir)/html/index.html
+ 	@$(NORMAL_UNINSTALL)
+-	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png $$dir/*.gif $$dir/*.dot ; do \
++	@dir='$(D)'; for p in $$dir/*.html $$dir/*.css $$dir/*.png ; do \
+ 		f=`echo $$p | sed -e 's|^.*/||'`; \
+ 		echo  rm -f $(DESTDIR)$(apidir)/$$f; \
+ 		rm -f $(DESTDIR)$(apidir)/$$f; \

Bug#558399: buffer overflow in normalize-audio

[Joachim Reichel]

Hi Stefan,

thanks for the bug report and the patch. I'll upload a fixed version soon.

Joachim



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#552961: zimpl: FTBFS: tests failed

[Joachim Reichel]

Due to a bug in the makefile, the package was accidentally build as
debug version (-DNDEBUG missing). In a debug build errors (incl.
triggered by errors in the input) call abort() instead of exit() to get
a stack trace. Since abort() causes Aborted to be in the output, the
expected output is different.

I still don't understand why the package only failed on same
architectures, on only sometimes on particular architectures (incl. i386
and amd64). It seems that the Aborted string is not always printed, or
the bug in the makefile only shows up under certain conditions.

A fixed package will be uploaded soon.



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#476017: patch

[Joachim Reichel]

An updated package is available at
http://www.joachim-reichel.de/debian/repository/pool/main/z/zimpl/zimpl_2.07.ds1-2.dsc

Since I'm not a DD yet I need a sponsor. If someone sponsors that package please
notify Bruno Barrera C. ([EMAIL PROTECTED]) to avoid double work (he recently 
offered to
sponsor -1 but seems to be busy right now).

Note that 2.07.ds1-1 never was in the archive. Hence you need the -sa option for
dpkg-buildpackage.

Joachim



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#470359: please transition to gfortran

[Joachim Reichel]

An updated package is available at 
http://www.joachim-reichel.de/debian/repository/pool/non-free/c/cgal/cgal_3.3.1-3.dsc


(sorry, I forgot to add this fact to the bug log)

My AM is currently reviewing the package and I asked him whether he would 
sponsor the upload, but I haven't got any reply yet. In case someone wants to 
sponsor the upload, please notify Bruno Barrera ([EMAIL PROTECTED]) to avoid double work.




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#428876: hppa also affected

[Joachim Reichel]

This bug also affects hppa, see
http://experimental.debian.net/fetch.php?pkg=core%2B%2Bver=1.7-9arch=hppastamp=1203264200file=logas=raw

In total, at least four architectures are affected (hppa, ia64, s390 , sparc).

Since there hasn't been any visible action in almost three months, I take the
liberty to add the help tag.

Regards,
  Joachim




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#466310: core++_1.7-9(unstable/ia64/alkman): FTBFS: Tries to copy non-existing pdfs

[Joachim Reichel]

This is a bug in my workaround for #428876 and #435229. Will be fixed in the 
next upload.


Thanks,
  Joachim




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#428876: Testcase for 428876

[Joachim Reichel]

Hi,

I do not have acces to a sparc machine and I can't use the developer
machines since I'm no DD (yet). I build the package in a current sid
chroot on i386 and uploaded history.ps to
http://www.joachim-reichel.de/tmp/history.ps . Can you try if this file
triggers the problem?

Regards,
  Joachim




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#429155: patch

[Joachim Reichel]

tag 429155 + patch
thanks

Hi Oohara,

please find attached a patch to fix this bug. An updated package
including this patch can be found at

http://www.joachim-reichel.de/debian/pool/main/z/zblast/zblast_1.3-2.3.dsc

I also fixed a lintian warning about ignoring the error code of $(MAKE)
clean. Please let me know if you have objections to this NMU.

Regards,
  Joachim
diff -u zblast-1.3/debian/changelog zblast-1.3/debian/changelog
--- zblast-1.3/debian/changelog
+++ zblast-1.3/debian/changelog
@@ -1,3 +1,11 @@
+zblast (1.3-2.3) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Create /var/games/zblast if necessary (Closes: #429155).
+  * Do not ignore error code of $(MAKE) clean.
+
+ -- Joachim Reichel [EMAIL PROTECTED]  Tue,  7 Aug 2007 17:51:05 +0200
+
 zblast (1.3-2.2) unstable; urgency=high
 
   * Non-maintainer upload during BSP.
diff -u zblast-1.3/debian/rules zblast-1.3/debian/rules
--- zblast-1.3/debian/rules
+++ zblast-1.3/debian/rules
@@ -32,7 +32,7 @@
dh_testroot
rm -f build-stamp
 
-   -$(MAKE) clean
+   $(MAKE) clean
 
dh_clean
 
diff -u zblast-1.3/debian/zblast-data.postinst 
zblast-1.3/debian/zblast-data.postinst
--- zblast-1.3/debian/zblast-data.postinst
+++ zblast-1.3/debian/zblast-data.postinst
@@ -19,6 +19,10 @@
 # create the score file if necessary
 if test $1 = configure
 then
+  if test ! -d /var/games/zblast
+  then
+mkdir -p /var/games/zblast
+  fi
   if test ! -e /var/games/zblast/zblast.scores
   then
 touch /var/games/zblast/zblast.scores