Bug#967953: ifupdown2

[Julien Fortin]

Hi Christoph,


On Thu, Aug 6, 2020 at 12:27 PM Christoph Egger  wrote:
>
> Hi
>
> > We are now looking for a new debian sponsor to upload our latest
> > version to the debian repository.
>
> I guess I can help there for now but better don't rely on me for long-term
> sponsoring. What exactly would you want uploaded? Do you have the package
> somewhere? or github HEAD?

It would be awesome if you could help us out with this new release
(https://packages.debian.org/sid/ifupdown2).
We want to upload ifupdown2 3.0: it adds python3 support, new features
and fixes a bunch of bugs

The package is available on github, master branch:
http://github.com/CumulusNetworks/ifupdown2/

git clone https://github.com/CumulusNetworks/ifupdown2.git -b master

git tag 3.0.0-1

ifupdown2 (3.0.0-1) unstable; urgency=medium

   * New: python3 support
   * New: attribute alias support
   * New: bridge-always-up attribute
   * New: set bridge mtu with policy default
   * New: ES bond with "es-sys-mac" attribute
   * New: vxlan attribute: vxlan-mcastgrp-map
   * New: support for "veth-peer-name" attribute
   * New: dhcp policy: dhclient_retry_on_failure
   * New: support for marking interfaces as mgmt interfaces
   * New: bridge-vlan-vni-map attribute (single vxlan device)
   * New: dhcp: skipping dhcp configuration if link-down yes
   * New: vrf-slave: keep vlan down if lower device has "link-down yes"
   * New: vxlan: support for vxlan-svcnodeip6 and vxlan-mcastgrp6 (fixes #43)
   * New: support for add ovs-ports-condone-regex attribute (openvswitch)
   * Fix: dry-run exceptions
   * Fix: bond enslavement ordering
   * Fix: process MTU before addrgen
   * Fix: set bridge MTU after bridge creation
   * Fix: ifquery-running: incorrect displayed data
   * Fix: tunnel configuration compatibility with ifupdown1
   * Fix: start-networking script is back to handle mgmt & hotplug cases
   * Fix: devices matching with ".{0,13}\-v" could get removed by ifreload
   * Fix: mstpctl: check mstpctl-stp and bridge-stp and fix bridge cache update
   * Removing python-argcomplete dependency

 -- Julien Fortin   Tue, 04 Aug 2020 23:42:42 +0200

Let me know if that's all good and can proceed with the upload.

Best regards
Julien

>
> Christoph

Bug#967953: Package not installable in sid due to missing dependencies python-argcomplete and python-ipaddr

[Julien Fortin]

Hi Julian,

Thanks for your submission. We've ported ifupdown2 to python3. Our
release has been ready for a few months now, unfortunately our usual
sponsor is not responding anymore.
We are now looking for a new debian sponsor to upload our latest
version to the debian repository.

Best
Julien

On Wed, Aug 5, 2020 at 7:57 PM Julian Brost  wrote:
>
> Package: ifupdown2
> Version: 1.2.7-1
> Severity: grave
>
> The package ifupdown2 currently cannot be installed on systems running
> sid as the two of its dependencies, python-argcomplete and
> python-ipaddr, are no longer present in sid.
>
> The suggested packages python-gvgen and python-mako also no longer exist.

Bug#917534: ifupdown2 fails to start network configuration

[Julien Fortin]

Hello Joerg,

I've pushed the commit on top of master (git clone && make deb). Feel free
to try it if you have time.
https://github.com/CumulusNetworks/ifupdown2/commit/72ba45697100206304cde79dde820ba1f2cfdd8d

I will send an upload request soon.

Happy holidays!
Cheers,
Julien

On Sun, Dec 30, 2018 at 1:30 AM Joerg Dorchain  wrote:

> On Sat, Dec 29, 2018 at 07:46:27PM +0700, Julien Fortin wrote:
> > Thanks for submitting a bug report.
>
> Thanks you for the quick response.
>
> > I've prepared a patch to fix this issue (soon to be pushed on our
> github).
> >
> > This issue will be automatically closed when the new release is uploaded
> > and validated by the debian system
>
> I will be happy to test.
>
> Bye,
>
> Joerg
>
>

Bug#917534: ifupdown2 fails to start network configuration

[Julien Fortin]

Hey Joerg

Thanks for submitting a bug report.
I've prepared a patch to fix this issue (soon to be pushed on our github).

This issue will be automatically closed when the new release is uploaded
and validated by the debian system

Cheers,
Julien

On Fri, Dec 28, 2018 at 5:15 PM Joerg Dorchain  wrote:

> Package: ifupdown2
> Version: 1.2.2-1
> Severity: serious
> Justification: renders system unusable
>
> Hello,
>
> with this package and this version, my system comes up without any
> networking configured, giving an error message at startup
>
> Fri Dec 28 10:38:52 2018: networking: Configuring network interfaces
> Fri Dec 28 10:38:52 2018: Traceback (most recent call last):
> Fri Dec 28 10:38:52 2018:   File "/sbin/ifup", line 26, in 
> Fri Dec 28 10:38:52 2018: from ifupdown.log import log
> Fri Dec 28 10:38:52 2018:   File "/usr/share/ifupdown2/ifupdown/log.py",
> line 163, in 
> Fri Dec 28 10:38:52 2018: log = Log()
> Fri Dec 28 10:38:52 2018:   File "/usr/share/ifupdown2/ifupdown/log.py",
> line 65, in __init__
> Fri Dec 28 10:38:52 2018: self.syslog_handler =
> logging.handlers.SysLogHandler(address=address, facility=facility)
> Fri Dec 28 10:38:52 2018:   File "/usr/lib/python2.7/logging/handlers.py",
> line 761, in __init__
> Fri Dec 28 10:38:52 2018: self._connect_unixsocket(address)
> Fri Dec 28 10:38:52 2018:   File "/usr/lib/python2.7/logging/handlers.py",
> line 804, in _connect_unixsocket
> Fri Dec 28 10:38:52 2018: self.socket.connect(address)
> Fri Dec 28 10:38:52 2018:   File "/usr/lib/python2.7/socket.py", line 228,
> in meth
> Fri Dec 28 10:38:52 2018: return getattr(self._sock,name)(*args)
> Fri Dec 28 10:38:52 2018: socket.error: [Errno 2] No such file or directory
>
> My system is running on sysvinit.
>
> An acceptable proposal would be to log to stderr until /dev/log has been
> setup
>
> The init script used looks as follows:
>
> ## BEGIN INIT INFO
> # Provides:  networking ifupdown
> # Required-Start:mountkernfs $local_fs urandom $syslog
> # Required-Stop: $local_fs
> # Default-Start: S
> # Default-Stop:  0 6
> # Short-Description: Raise network interfaces.
> # Description:   Prepare /run/network directory, ifstate file and
> raise network interfaces, or take them down.
> ### END INIT INFO
>
> exec /usr/share/ifupdown2/sbin/start-networking "$@"
>
>
> Bye,
>
> Joerg
>

Bug#854325: ifupdown2: missing Conflicts: ifupdown

[Julien Fortin]

Hello Andreas,

Thanks for the reporting this issue.
I will take a look at this early next week.

Best,
Julien Fortin


On Mon, Feb 6, 2017 at 3:59 AM, Andreas Beckmann <a...@debian.org> wrote:

> Package: ifupdown2
> Version: 1.0~git20170114-1
> Severity: serious
> User: debian...@lists.debian.org
> Usertags: piuparts
>
>
> Hi,
>
> despite of all the diversion magic being performed, ifupdown2
> comes with
>   Provides+Replaces: ifupdown
> but without a corresponding Breaks or Conflicts: ifupdown.
> This causes files to disappear after the sequence:
>
>   install ifupdown
>   install ifupdown2
>   remove+purge ifupdown2
>
> and ifupdown is no longer functional (but dpkg still thinks
> it is correctly installed).
>
>
> >From the attached log (scroll to the bottom...):
>
> 0m28.7s ERROR: FAIL: After purging files have disappeared:
>   /etc/default/networkingowned by: ifupdown2
>   /etc/systemd/system/multi-user.target.wants/   not owned
>   /etc/systemd/system/multi-user.target.wants/networking.service ->
> /lib/systemd/system/networking.service   not owned
>   /etc/systemd/system/network-online.target.wants/   not owned
>   /etc/systemd/system/network-online.target.wants/networking.service ->
> /lib/systemd/system/networking.service   not owned
>   /lib/systemd/system/networking.service owned by: ifupdown2
>   /var/lib/systemd/deb-systemd-helper-enabled/multi-user.target.wants/
>  not owned
>   /var/lib/systemd/deb-systemd-helper-enabled/multi-user.
> target.wants/networking.service not owned
>   /var/lib/systemd/deb-systemd-helper-enabled/network-online.target.wants/
>  not owned
>   /var/lib/systemd/deb-systemd-helper-enabled/network-online.
> target.wants/networking.service not owned
>   /var/lib/systemd/deb-systemd-helper-enabled/networking.service.dsh-also
>   not owned
>
> (note that "owned by: ifupdown2" is misleading - the ownership was only
> recorded after ifupdown2 was installed and had taken over these files)
>
> Diversions cannot be used for /etc/default/networking!
>
> To allow switching back from ifupdown2 to ifupdown, ifupdown will
> probably need a matching Provides+Replaces+Conflicts: ifupdown,
> (against the virtual ifupdown package, not against ifupdown2)
> but I haven't tested that.
>
>
> Andreas
>

Bug#843848: ifupdown2: diversion handling broken

[Julien Fortin]

Hi Andreas,

Thanks for reporting this issue.

Sorry again, for the delay. As I was saying I didn't see your email when I
got back from my new year vacations.
I added Roopa to the conversation.

You always want to install the diversion - it's a no-op if it is already
> there.
>

Ack. I thought I just needed to divert existing/installed files. See patch
bellow.

diff --git a/debian/ifupdown2.preinst b/debian/ifupdown2.preinst
index 07fc073..eddf429 100644
--- a/debian/ifupdown2.preinst
+++ b/debian/ifupdown2.preinst
@@ -3,7 +3,7 @@
 MYNAME="${0##*/}"

 report() { echo "${MYNAME}: $*" ; }
-report_err() { report "Error: $*" >&2 ; }
+report_err() { report "Error: $*" >&2 ; exit 1; }

 preinst_divert()
 {
@@ -12,13 +12,7 @@ preinst_divert()
 then
 report_err "existing diversion for $1"
 else
-if [ -e "$1" ] || [ -L "$1" ];
-then
-if [ $(dpkg-query -L ifupdown2 | grep "^$1$" | wc -l) -eq 0 ];
-then
-dpkg-divert --add --package ifupdown2 --rename --divert
"$1.disabled" "$1"
-fi
-fi
+dpkg-divert --add --package ifupdown2 --rename --divert
"$1.disabled" "$1"
 fi
 }

On Mon, Jan 2, 2017 at 5:21 PM, Andreas Beckmann <a...@debian.org> wrote:

> Control: found -1 1.0~git20161221-1
>
> Hi,
>
> most of the issues are fixed, but one is remaining:
>
> On 2016-11-11 21:09, Julien Fortin wrote:
> >> 2. unconditionally install the diversions, installing bash-completion
> >> after ifupdown2 breaks right now with a file overwrite error since the
> >> diversions are not in place (this is how I noticed the problems)
> >>
> >
> > I tried to reinstall bash-completion, didn't see any issue.
> > Then remove + install, didn't see any issues.
> > Can you please provide me the steps you are following?
>
> remove bash-completion
> install ifupdown2
> install bash-completion
>
> (best test this in a fresh minimal chroot)
>
>
> looking at ifupdown.preinst, I marked the wrong (i.e. superfluous) lines
> with #!!:
>
> preinst_divert()
> {
> diversions=$(dpkg-divert --list | grep "$1" | grep -v 'by ifupdown2$'
> | wc -l 2> /dev/null)
> if [ "$diversions" -gt 0 ];
> then
> report_err "existing diversion for $1"
> else
> #!!if [ -e "$1" ] || [ -L "$1" ];
> #!!then
> #!!if [ $(dpkg-query -L ifupdown2 | grep "^$1$" | wc -l) -eq 0
> ];
> #!!then
> dpkg-divert --add --package ifupdown2 --rename --divert
> "$1.disabled" "$1"
> #!!fi
> #!!fi
> #!!fi
> }
>
> You always want to install the diversion - it's a no-op if it is already
> there.
> You don't want to install the diversion only if a conflicting file is
> already present,
> but also to take care for the conflicting file to be installed later.
>
> And I'm pretty sure that you are missing an 'exit 1' in the
> report_err function - there is no point in continuing the
> installation if the system is in a broken state.
>
>
> Andreas
>

Bug#843848: ifupdown2: diversion handling broken

[Julien Fortin]

Hello Andreas,

Sorry, I totally missed this email as I was in vacation.
I will look at this issue today.

Thank you.
Julien

On Fri, Jan 13, 2017 at 1:38 PM, Andreas Beckmann  wrote:

> Ping? ifupdown2 is at the risk of being autoremoved ... and won't be in
> stretch if this bug is not fixed in time.
>
> Andreas
>

Bug#843848: ifupdown2: diversion handling broken

[Julien Fortin]

Hello Andreas,

Thank you for reporting these issues.
My comments are inline:

On Thu, Nov 10, 2016 at 9:20 AM, Andreas Beckmann  wrote:

> Package: ifupdown2
> Version: 1.0~git20161101-1
> Severity: serious
>
> Hi,
>
> ifupdown doesn't use the diversions correctly
>
> 1. diverting conffiles does not work well, so just use Breaks against
> the bash-completion versions shipping the ifup etc. completion in /etc
> Do not forget to clean up the now obsolete diversions in /etc in the
> preinst or postinst!
>

I don't really know how to use breaks and I think we are fine today with
diverting. We are now cleaning up /etc/bash_completion.d/ifup (if
previously
installed by ifupdown2). I used dpkg-maintscript-helper, it seemed to me
the ideal way.


> 2. unconditionally install the diversions, installing bash-completion
> after ifupdown2 breaks right now with a file overwrite error since the
> diversions are not in place (this is how I noticed the problems)
>

I tried to reinstall bash-completion, didn't see any issue.
Then remove + install, didn't see any issues.
Can you please provide me the steps you are following?


> (also upgrading ifupdown2 will suddenly install more diversions since
> it finds more of the files that could be diverted - because the
> installed ifupdown2 version shipped them)
>

fixed


>
> 3. unconditionally install/remove the diversions without checking
> whether they exist, running dpkg-divert multiple times is idempotent
>

I used dpkg-divert --list to check if ifupdown2 owns diversions before
removing diversions.

We just submitted a debian release. It might get uploaded over the weekend
or sometimes next week, I can't give you an exact timeline here.

If you wish to have these patches today, I invite you to get them from our
github repository (branch debian-prep2): https://github.
com/CumulusNetworks/ifupdown2/tree/debian-prep2

git clone https://github.com/CumulusNetworks/ifupdown2.git -b debian-prep2

Thanks again.

Regards,
Julien.