Bug#882080: debian-goodies: checkrestart from debian-goodies 0.77 finds no files to restart

2017-11-18 Thread RjY
Just wanted to add I am also seeing this. Also wanted to note using
checkrestart with -n (I wondered if not using lsof might produce
different results) instead gave a python exception/backtrace.

--

% sudo lsof -n | grep -E 'DEL|deleted' | grep /lib/
mpv2765rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv2765rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
mpv/termi  2765  2769  rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv/termi  2765  2769  rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
mpv/lua2765  2770  rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv/lua2765  2770  rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
mpv/cache  2765  2774  rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv/cache  2765  2774  rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
mpv/demux  2765  2775  rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv/demux  2765  2775  rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
mpv/ao 2765  2778  rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
mpv/ao 2765  2778  rjy  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
inetd  3864   root  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
sshd   3871   root  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
login  4085   root  DEL   REG8,2
 3014687 /lib/x86_64-linux-gnu/security/pam_systemd.so
apt9909rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
systemd   21060rjy  txt   REG8,2  
16657602886230 /lib/systemd/systemd (deleted)
systemd   21060rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
systemd   21060rjy  DEL   REG8,2
 2883762 /lib/systemd/libsystemd-shared-235.so
(sd-pam   21061rjy  txt   REG8,2  
16657602886230 /lib/systemd/systemd (deleted)
(sd-pam   21061rjy  DEL   REG8,2
 3014687 /lib/x86_64-linux-gnu/security/pam_systemd.so
(sd-pam   21061rjy  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
(sd-pam   21061rjy  DEL   REG8,2
 2883762 /lib/systemd/libsystemd-shared-235.so
dbus-daem 29391 messagebus  DEL   REG8,2
 2883608 /lib/x86_64-linux-gnu/libsystemd.so.0.19.1
systemd-l 29392   root  txt   REG8,2   
2192722886245 /lib/systemd/systemd-logind (deleted)
systemd-l 29392   root  DEL   REG8,2
 2883672 /lib/x86_64-linux-gnu/libudev.so.1.6.7
systemd-l 29392   root  DEL   REG8,2
 2883762 /lib/systemd/libsystemd-shared-235.so

% sudo checkrestart
Found 0 processes using old versions of upgraded files

% sudo checkrestart -n
Traceback (most recent call last):
  File "/usr/sbin/checkrestart", line 798, in 
main()
  File "/usr/sbin/checkrestart", line 157, in main
toRestart = procfilescheck(blacklist = blacklist, excludepidlist = 
excludepidlist)
  File "/usr/sbin/checkrestart", line 435, in procfilescheck
data = re.split('\s+', output.strip('\n'), 3)
TypeError: a bytes-like object is required, not 'str'

-- 
https://rjy.org.uk/



Bug#668306: rs: immediate segfault, apparently caused by hardening options (-pie)

2012-04-10 Thread RjY
Package: rs
Version: 20120325-1
Severity: serious

  rjy@vile ~ % seq 1 9 | rs 3 3
  zsh: doneseq 1 9 | 
  zsh: segmentation fault  rs 3 3

This happens regardless of input.

It appears to be caused by -pie in the parameters passed to cc

  rjy@vile /tmp/rs/rs-20120325 % cc -D_FORTIFY_SOURCE=2 -DUSE_LIBBSD -g -O2 
-fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 
-Werror=format-security -Wall -Wextra -Wformat -flto=jobserver -fPIE -pie 
-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o rs rs.c -lbsd  
  In file included from /usr/include/bsd/bsd.h:41:0,
   from rs.c:47:
  /usr/include/bsd/getopt.h:34:2: warning: #warning Deprecated header, use 
bsd/unistd.h or unistd.h with libbsd-overlay.pc instead. [-Wcpp]
  rjy@vile /tmp/rs/rs-20120325 % seq 1 9 | ./rs 3 3
  zsh: doneseq 1 9 | 
  zsh: segmentation fault  ./rs 3 3

After removing -pie (from between the second -fPIE and -Wl,-z,relro)

  rjy@vile /tmp/rs/rs-20120325 % cc -D_FORTIFY_SOURCE=2 -DUSE_LIBBSD -g -O2 
-fPIE -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 
-Werror=format-security -Wall -Wextra -Wformat -flto=jobserver -fPIE 
-Wl,-z,relro -Wl,-z,now -Wl,--as-needed -o rs rs.c -lbsd 
  In file included from /usr/include/bsd/bsd.h:41:0,
   from rs.c:47:
  /usr/include/bsd/getopt.h:34:2: warning: #warning Deprecated header, use 
bsd/unistd.h or unistd.h with libbsd-overlay.pc instead. [-Wcpp]
  rjy@vile /tmp/rs/rs-20120325 % seq 1 9 | ./rs 3 3
  1  2  3  
  4  5  6
  7  8  9

Sorry if this is hard to read, the command lines are so long...

Build command was copied from debuild output, which was

  rjy@vile /tmp/rs/rs-20120325 % debuild -us -uc
   dpkg-buildpackage -rfakeroot -D -us -uc
  dpkg-buildpackage: source package rs
  dpkg-buildpackage: source version 20120325-1
  dpkg-buildpackage: source changed by Thorsten Glaser t...@mirbsd.de
   dpkg-source --before-build rs-20120325
  dpkg-buildpackage: host architecture amd64
   fakeroot debian/rules clean
  dh_testdir
  rm -f rs
  dh_clean
   dpkg-source -b rs-20120325
  dpkg-source: info: using source format `1.0'
  dpkg-source: info: building rs using existing rs_20120325.orig.tar.gz
  dpkg-source: info: building rs in rs_20120325-1.diff.gz
  dpkg-source: info: building rs in rs_20120325-1.dsc
   debian/rules build
  dh_testdir
  rm -f rs
  for opts in '-flto=jobserver' '-fwhole-program --combine' ''; do \
  set -x; \
  cc -D_FORTIFY_SOURCE=2 -DUSE_LIBBSD -g -O2 -fPIE 
-fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security 
-Werror=format-security -Wall -Wextra -Wformat $opts -fPIE -pie -Wl,-z,relro 
-Wl,-z,now -Wl,--as-needed -o rs \
  rs.c -lbsd; \
  test -x rs  exit 0; \
  done; echo 2 Compiling failed.; exit 1
  + cc -D_FORTIFY_SOURCE=2 -DUSE_LIBBSD -g -O2 -fPIE -fstack-protector 
--param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security 
-Wall -Wextra -Wformat -flto=jobserver -fPIE -pie -Wl,-z,relro -Wl,-z,now 
-Wl,--as-needed -o rs rs.c -lbsd
  In file included from /usr/include/bsd/bsd.h:41:0,
   from rs.c:47:
  /usr/include/bsd/getopt.h:34:2: warning: #warning Deprecated header, use 
bsd/unistd.h or unistd.h with libbsd-overlay.pc instead. [-Wcpp]
  + test -x rs
  + exit 0
   fakeroot debian/rules binary
  dh_testdir
  dh_testroot
  if test -x $(which dh_prep); then dh_prep; else dh_clean -k; fi
  dh_installchangelogs
  dh_installdocs
  dh_install
  dh_installman
  dh_link
  dh_strip
  dh_compress
  dh_fixperms
  dh_installdeb
  dh_shlibdeps
  dpkg-shlibdeps: warning: package could avoid a useless dependency if 
debian/rs/usr/bin/rs was not linked against libgcc_s.so.1 (it uses none of the 
library's symbols).
  dh_gencontrol
  dh_md5sums
  dh_builddeb
  dpkg-deb: building package `rs' in `../rs_20120325-1_amd64.deb'.
   dpkg-genchanges  ../rs_20120325-1_amd64.changes
  dpkg-genchanges: including full source code in upload
   dpkg-source --after-build rs-20120325
  dpkg-buildpackage: full upload (original source is included)
  rjy@vile /tmp/rs/rs-20120325 % seq 1 9 | ./rs 3 3
  zsh: doneseq 1 9 | 
  zsh: segmentation fault  ./rs 3 3

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages rs depends on:
ii  libbsd0  0.3.0-2
ii  libc62.13-27
ii  libgcc1  1:4.7.0-3

rs recommends no packages.

rs suggests no packages.

-- no debconf information

-- 
http://rjy.org.uk/



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#617644: pdnsd: fails to start, broken init script

2011-03-10 Thread RjY
Package: pdnsd
Version: 1.2.8-par-1
Severity: grave
Justification: renders package unusable

/etc/init.d/pdnsd has several problems that prevent pdnsd from starting.

Firstly line 28

test -f . /etc/default/rcS || exit 0
  
This just produces an error, '.: unexpected operator'

(I just deleted the line. I don't think /etc/default/rcS is needed at
all, there doesn't appear to be any variable from it referenced, but I
might have missed something.)



Secondly, line ~20

test -f /etc/default/$NAME

/etc/default/pdnsd is tested for, but never actually sourced. So
START_DAEMON is never set to 'yes' so the script thinks the daemon is
disabled, and never runs it.



Fixing these two at least allows the daemon to start. I also noticed
that $AUTO_MODE handling is apparently broken (although I don't use one)

if test -z $AUTO_MODE  test -f /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf

I think the first test should be -n. -z means is a zero-length string,
-n means is _not_ a zero-length string.



-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.37-2-686 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages pdnsd depends on:
ii  adduser   3.112+nmu2 add and remove users and groups
ii  debconf [debconf-2.0] 1.5.38 Debian configuration management sy
ii  libc6 2.11.2-11  Embedded GNU C Library: Shared lib

Versions of packages pdnsd recommends:
pn  resolvconfnone (no description available)

pdnsd suggests no packages.

-- Configuration Files:
/etc/default/pdnsd changed:
START_DAEMON=yes
AUTO_MODE=
START_OPTIONS=

/etc/init.d/pdnsd changed:
NAME=pdnsd
DESC=proxy DNS server
DAEMON=/usr/sbin/pdnsd
PIDFILE=/var/run/pdnsd.pid
CACHE=/var/cache/pdnsd/pdnsd.cache
test -x $DAEMON || exit 0
test -f /etc/default/$NAME || exit 0
. /etc/default/$NAME
if test -n $AUTO_MODE  test -f /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf
then
START_OPTIONS=${START_OPTIONS} -c /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf
fi
. /lib/lsb/init-functions
is_yes() {
case $1 in
[Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|1) return 0;;
*) return 1;
esac
}
log_end_msg2 () {
log_end_msg $@
test $1 -eq 0 || exit 1
}
gen_cache()
{
if ! test -f $CACHE; then
mkdir -p `dirname $CACHE`
dd if=/dev/zero of=$CACHE bs=1 count=4 2 /dev/null
chown -R pdnsd.proxy /var/cache/pdnsd
fi  
}
check_pid()
{
if test -f $PIDFILE; then
log_warning_msg pid file is exist in $PIDFILE, stop $pdnsd it 
or restart $pdnsd
exit 1
fi
}
start_resolvconf()
{
test -x /sbin/resolvconf || return
for f in `seq 1 60`; do
sleep 0.1
if pdnsd-ctl status /dev/null 21; then
break
fi
done
if pdnsd-ctl status | grep -q resolvconf; then
server=$(pdnsd-ctl status|sed -ne '/^Global:$/,/^Server.*:$/s/.*Server 
ip.*: \(.*\)$/\1/p')
case $server in
)  ;;
0.0.0.0) echo nameserver 127.0.0.1 | /sbin/resolvconf -a 
lo.$NAME;;
*)   echo nameserver $server   | /sbin/resolvconf -a 
lo.$NAME;;
esac
fi
}
stop_resolvconf()
{
if [ -x /sbin/resolvconf ] ; then
/sbin/resolvconf -d lo.$NAME
fi
}
pdnsd_start()
{
if is_yes $START_DAEMON; then
check_pid
log_begin_msg Starting $NAME
start-stop-daemon --oknodo --start --quiet --pidfile $PIDFILE \
--exec $DAEMON -- --daemon -p $PIDFILE $START_OPTIONS
log_end_msg2 $?
start_resolvconf
else
log_warning_msg Not starting $NAME (disabled in /etc/default/$NAME)
fi
}
pdnsd_stop()
{
log_begin_msg Stopping $NAME
start-stop-daemon --oknodo --stop --quiet --user pdnsd 
--retry=TERM/3/KILL/3 --pidfile $PIDFILE --name $NAME
start-stop-daemon --oknodo --stop --quiet --user pdnsd --retry=0/3/KILL/3 
--exec $DAEMON  /dev/null
log_end_msg2 $?
rm -f $PIDFILE
stop_resolvconf
}
pdnsd_status()
{
if status_of_proc $DAEMON $NAME; then
/usr/sbin/pdnsd-ctl status
fi
}
case $1 in
start)
gen_cache
pdnsd_start
;;
  stop)
pdnsd_stop
  ;;
  status)
pdnsd_status
;;
  restart|force-reload)
pdnsd_stop
  pdnsd_start
;;
*)
echo Usage: /etc/init.d/$NAME 
{start|stop|restart|force-reload|status} 2
exit 1
;;
esac
exit 0

/etc/pdnsd.conf changed:
// Read the pdnsd.conf(5) manpage for an explanation of the options.
/* Note: this file is overriden by automatic config files when
   /etc/default/pdnsd AUTO_MODE is set and that
   /usr/share/pdnsd/pdnsd-$AUTO_MODE.conf exists
 */
// 2010-08-15: comment out server_ip to listen on all interface,
// uncomment root-servers section to do recursive resolving
global {

Bug#617318: new upstream version 0.17

2011-03-08 Thread RjY
I noticed on the git list that there is a new upstream version out to
fix this problem[1]:

  Here's an updated tig, which fixes an incompatibility with ncurses
  2.8.[2]

[1] http://permalink.gmane.org/gmane.comp.version-control.git/168563

[2] I think he means 5.8 :-) the particular patch is this
http://repo.or.cz/w/tig.git/commitdiff/ddae52065f967db43f4d9aa07340c950cdb2b433

-- 
http://rjy.org.uk/



-- 
To UNSUBSCRIBE, email to debian-bugs-rc-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org