Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Dear Hans-Christoph, Now the main blocker for migrating android-platform-tools from experimental to sid is: - https://qa.debian.org/excuses.php?experimental=1=android-platform-tools And blocker for migrating android-platform-frameworks-base is Bug#1014831 - https://bugs.debian.org/1014831 I still don't have good way to resolve it. One idea is to enable all the embedded *_test.cpp code, and to see whether the tests pass or not. Cheers, Roger On Mon, Feb 13, 2023 at 12:17 AM Hans-Christoph Steiner wrote: > > > Roger, it is great to see your progress on android-platform-tools. Are you > thinking of trying to get it into bookworm? If so, let me know how I can > help. > It would be really valuable to have there, but I don't know how much work > it'll be.
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Roger, it is great to see your progress on android-platform-tools. Are you thinking of trying to get it into bookworm? If so, let me know how I can help. It would be really valuable to have there, but I don't know how much work it'll be.
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Hi Hans, * Hans-Christoph Steiner [2023-02-13 09:17]: Roger, it is great to see your progress on android-platform-tools. Are you thinking of trying to get it into bookworm? If so, let me know how I can help. It would be really valuable to have there, but I don't know how much work it'll be. ähm, soft freeze started yesterday so no new upstream versions, please: https://release.debian.org/testing/freeze_policy.html#soft Cheers Jochen signature.asc Description: PGP signature
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Dear Jochen,
> Oups, sorry. The attached patch against android-platform-tools fixes the
> issue for me.
Very appreciated!
I tried the patch in pbuilder and porterbox, and found the patch need
slight modify.
Enclosed is the patch confirmed working on my side.
BTW. The patch was already incorporated into
android-platform-tools/33.0.3-1~exp8
Thanks again for your kind help!
Cheers,
Roger
Description: Implement const_iterator::operator--
Forwarded: not-needed
Needed for
android-platform-frameworks-base/libs/androidfw/LoadedArsc.cpp
when compiling against libstdc++.
---
--- a/system/incremental_delivery/incfs/util/include/util/map_ptr.h
+++ b/system/incremental_delivery/incfs/util/include/util/map_ptr.h
@@ -180,6 +180,11 @@ public:
return *this;
}
+const const_iterator& operator--() {
+safe_ptr_--;
+return *this;
+}
+
const_iterator& operator+=(int n) {
safe_ptr_ = safe_ptr_ + n;
return *this;
@@ -321,6 +326,14 @@ public:
return temp;
}
+template = 0>
+const map_ptr operator--(int) {
+map_ptr temp = *this;
+LIBINCFS_MAP_PTR_DEBUG_CODE(verified_ = false);
+--ptr_;
+return temp;
+}
+
template = 0>
map_ptr operator+(const S n) const {
return map_ptr(map_, ptr_ + n, verified_block_);
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
* Roger Shimizu [2023-02-09 13:42]:
Please try the version in experimental.
and also refer the version info of this ticket:
Found in versions android-platform-frameworks-base/1:10.0.0+r36-5,
android-platform-frameworks-base/13~beta3-1~exp1
Fixed in version android-platform-frameworks-base/1:10.0.0+r36-6
Oups, sorry. The attached patch against android-platform-tools fixes the
issue for me.
Cheers Jochen
From: Jochen Sprickerhof
Date: Fri, 10 Feb 2023 11:46:23 +0100
Subject: Implement const_iterator::operator--
Needed for
android-platform-frameworks-base/libs/androidfw/LoadedArsc.cpp
when compiling against libstdc++.
---
.../incremental_delivery/incfs/util/include/util/map_ptr.h | 12
1 file changed, 12 insertions(+)
diff --git a/system/incremental_delivery/incfs/util/include/util/map_ptr.h b/system/incremental_delivery/incfs/util/include/util/map_ptr.h
index 304540f..836b320 100644
--- a/system/incremental_delivery/incfs/util/include/util/map_ptr.h
+++ b/system/incremental_delivery/incfs/util/include/util/map_ptr.h
@@ -180,6 +180,11 @@ public:
return *this;
}
+const const_iterator& operator--() {
+safe_ptr_--;
+return *this;
+}
+
const_iterator& operator+=(int n) {
safe_ptr_ = safe_ptr_ + n;
return *this;
@@ -321,6 +326,13 @@ public:
return temp;
}
+template = 0>
+const map_ptr& operator--() {
+LIBINCFS_MAP_PTR_DEBUG_CODE(verified_ = false);
+--ptr_;
+return *this;
+}
+
template = 0>
map_ptr operator+(const S n) const {
return map_ptr(map_, ptr_ + n, verified_block_);
signature.asc
Description: PGP signature
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Dear Jochen, Thanks for your reply, and kindness trying to help! > On Thu, Feb 9, 2023 at 1:30 PM Jochen Sprickerhof wrote: > What exactly did you test? Please try the version in experimental. and also refer the version info of this ticket: Found in versions android-platform-frameworks-base/1:10.0.0+r36-5, android-platform-frameworks-base/13~beta3-1~exp1 Fixed in version android-platform-frameworks-base/1:10.0.0+r36-6 Cheers, Roger
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
Hi Roger, * Roger Shimizu [2023-02-04 10:47]: On Sat, Feb 4, 2023 at 12:09 AM Roger Shimizu wrote: control: reopen -1 Yes, it ftbfs on sid now. And I tried latest upstream 13.0.0_r24, result is the same. Have to fix this issue before we can migrate to sid. Error log is not originally reported, for latest error log please refer to: - https://bugs.debian.org/1012890#17 I guess the issue is caused due to upstream using clang stdc++ lib, but we're using gcc/g++ one. Those two have slight differences. I can't reproduce this. The unstable version (1:10.0.0+r36-10) builds fine in sbuild and also reproducible builds shows no ftbfs: https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/i386/android-platform-frameworks-base.html What exactly did you test? Cheers Jochen signature.asc Description: PGP signature
Bug#1012890: android-platform-frameworks-base: ftbfs with GCC-12
control: tags -1 +help + Hans-Christoph Dear Hans-Christoph, It'd be appreciated if you can help this ticket. I tried a few ways, but it still doesn't work. On Sat, Feb 4, 2023 at 12:09 AM Roger Shimizu wrote: > > control: reopen -1 > > Yes, it ftbfs on sid now. > And I tried latest upstream 13.0.0_r24, result is the same. > Have to fix this issue before we can migrate to sid. Error log is not originally reported, for latest error log please refer to: - https://bugs.debian.org/1012890#17 I guess the issue is caused due to upstream using clang stdc++ lib, but we're using gcc/g++ one. Those two have slight differences. Cheers, Roger
