Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Control: tags 1020108 patch
Martin Quinson wrote...
> Thanks for any help that could be provided.
Greetings from the Karlsruhe BSP.
As mentioned earlier, the build failure is a result of grep's new
warning messages. Digging closer I realized the current quote_bre()
function can no longer used that way: quilt uses the result both for
grep (now triggering the messages) and sed's search and replace (where
quoting the forward slash is crucial).
The patch attached replaces quote_bre() with two new functions
quote_bre_grep() and quote_bre_sed(), and adjusts all invocations
according to the respective need.
Test suite passes now.
Cheers,
Christoph
--- a/quilt/diff.in
+++ b/quilt/diff.in
@@ -260,7 +260,7 @@
# Add all files in the snapshot into the file list (they may all
# have changed).
files=( $(find $QUILT_PC/$snap_subdir -type f \
- | sed -e "s/^$(quote_bre $QUILT_PC/$snap_subdir/)//" \
+ | sed -e "s/^$(quote_bre_sed $QUILT_PC/$snap_subdir/)//" \
| sort) )
printf "%s\n" "${files[@]}" >&4
unset files
--- a/quilt/patches.in
+++ b/quilt/patches.in
@@ -71,7 +71,7 @@
# Quote each file name only once
for file in "${opt_files[@]}"
do
- files_bre[${#files_bre[@]}]=$(quote_bre "$file")
+ files_bre[${#files_bre[@]}]=$(quote_bre_grep "$file")
done
# "Or" all files in a single pattern
--- a/quilt/scripts/patchfns.in
+++ b/quilt/scripts/patchfns.in
@@ -91,7 +91,15 @@
}
# Quote a string for use in a basic regular expression.
-quote_bre()
+# For use with grep.
+quote_bre_grep()
+{
+ echo "$1" | sed -e 's:\([][^$.*\\]\):\\\1:g'
+}
+
+# Quote a string for use in a basic regular expression.
+# For use with sed's search and replace.
+quote_bre_sed()
{
echo "$1" | sed -e 's:\([][^$/.*\\]\):\\\1:g'
}
@@ -227,7 +235,7 @@
if [ -e "$SERIES" ]
then
- grep -q "^$(quote_bre $patch)\([ \t]\|$\)" "$SERIES"
+ grep -q "^$(quote_bre_grep $patch)\([ \t]\|$\)" "$SERIES"
else
return 1
fi
@@ -377,7 +385,7 @@
{
local patch=$1
[ -e $DB ] || return 1
- grep -q "^$(quote_bre $patch)\$" $DB
+ grep -q "^$(quote_bre_grep $patch)\$" $DB
}
applied_patches()
@@ -477,7 +485,7 @@
local tmpfile
if tmpfile=$(gen_tempfile)
then
- grep -v "^$(quote_bre $patch)\$" $DB > $tmpfile
+ grep -v "^$(quote_bre_grep $patch)\$" $DB > $tmpfile
cat $tmpfile > $DB
rm -f $tmpfile
[ -s $DB ] || rm -f $DB
@@ -542,7 +550,7 @@
fi
local patch=${1#$SUBDIR_DOWN$QUILT_PATCHES/}
- local bre=$(quote_bre "$patch")
+ local bre=$(quote_bre_sed "$patch")
set -- $(sed -e "/^$bre\(\|\.patch\|\.diff\?\)\(\|\.gz\|\.bz2\|\.xz\|\.lzma\|\.lz\)\([ "$'\t'"]\|$\)/!d" \
-e 's/[ '$'\t''].*//' "$SERIES")
if [ $# -eq 1 ]
@@ -653,7 +661,7 @@
then
find "$path" -type f \
-a ! -path "$(quote_glob "$path")/.timestamp" |
- sed -e "s/$(quote_bre "$path")\///"
+ sed -e "s/$(quote_bre_sed "$path")\///"
fi
}
--- a/quilt/upgrade.in
+++ b/quilt/upgrade.in
@@ -76,7 +76,7 @@
for patch in $(applied_patches)
do
- proper_name="$(grep "^$(quote_bre $patch)"'\(\|\.patch\|\.diff?\)\(\|\.gz\|\.bz2\)\([ \t]\|$\)' $SERIES)"
+ proper_name="$(grep "^$(quote_bre_grep $patch)"'\(\|\.patch\|\.diff?\)\(\|\.gz\|\.bz2\)\([ \t]\|$\)' $SERIES)"
proper_name=${proper_name#$QUILT_PATCHES/}
proper_name=${proper_name%% *}
if [ -z "$proper_name" ]
@@ -86,7 +86,7 @@
fi
if [ "$patch" != "$proper_name" -a -d $QUILT_PC/$patch ] \
- && grep -q "^$(quote_bre $patch)\$" \
+ && grep -q "^$(quote_bre_grep $patch)\$" \
$QUILT_PC/applied-patches
then
mv $QUILT_PC/$patch $QUILT_PC/$proper_name \
Processed: Re: Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Processing control commands: > tags 1020108 patch Bug #1020108 [src:quilt] quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2 Added tag(s) patch. -- 1020108: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020108 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Hi Martin, The relevant part might be: > > > [44] $ quilt patches -- /dev/null dev/null null --- -- failed > > > grep: warning: stray \ before / != ~ > > > grep: warning: stray \ before / != ~ > > > grep: warning: stray \ before / != ~ > > > [46] $ echo create > create -- ok grep added a warning for 'stray \'. There are ongoing discussions about it in #1019724. The change in grep might be reverted (that is, the warning would be removed for the time being). Lucas On 19/09/22 at 10:17 +0200, Martin Quinson wrote: > Control: tag -1 help > > I seem to remember that this is a transient bug, that does not occure all the > time at all. That being said, I'm not sure I already tested running the tests > in > parallel. Is that really a FTBFS if the failure only happens under this > setting? > > I tend to remove the FTBFS severity on this one, but I'm not sure. > > I'm really short on time these days, so any help is welcome. It's maybe the > occasion to upgrade the package to the new upstream release, but we have a lot > of patches that I'd like to integrate upstream. It takes time because upstream > is picky and only integrate sensible changes. I do not blame them for that (to > the contrary), but I don't often trust myself to discuss our changes with > them. > > The package is uptodate on salsa. > > Thanks for any help that could be provided. > Mt > > Le dimanche 18 septembre 2022 à 08:40 +0200, Lucas Nussbaum a écrit : > > Source: quilt > > Version: 0.66-2.1 > > Severity: serious > > Justification: FTBFS > > Tags: bookworm sid ftbfs > > User: lu...@debian.org > > Usertags: ftbfs-20220917 ftbfs-bookworm > > > > Hi, > > > > During a rebuild of all packages in sid, your package failed to build > > on amd64. > > > > > > Relevant part (hopefully): > > > make[2]: Entering directory '/<>' > > > [add-filename-check.test] > > > 6 commands (6 passed, 0 failed) > > > [altered-series.test] > > > 12 commands (12 passed, 0 failed) > > > [comments.test] > > > 11 commands (11 passed, 0 failed) > > > [applied.test] > > > 15 commands (15 passed, 0 failed) > > > [dir-a-b.test] > > > 11 commands (11 passed, 0 failed) > > > [colon-in-patch-name.test] > > > 23 commands (23 passed, 0 failed) > > > [create-delete.test] > > > [4] $ mkdir patches -- ok > > > [6] $ echo delete > delete -- ok > > > [7] $ quilt new test.diff -- ok > > > [10] $ quilt add create -- ok > > > [13] $ echo create > create -- ok > > > [14] $ quilt refresh -- ok > > > [17] $ quilt add delete -- ok > > > [20] $ rm -f delete -- ok > > > [21] $ quilt refresh -- ok > > > [23] $ quilt header -r -- ok > > > [31] $ quilt patches -v create -- ok > > > [33] $ quilt patches delete -- ok > > > [36] $ quilt pop -q -- ok > > > [40] $ quilt patches create -- ok > > > [42] $ quilt patches -v delete -- ok > > > [44] $ quilt patches -- /dev/null dev/null null --- -- failed > > > grep: warning: stray \ before / != ~ > > > grep: warning: stray \ before / != ~ > > > grep: warning: stray \ before / != ~ > > > [46] $ echo create > create -- ok > > > [47] $ rm -f delete -- ok > > > [48] $ patch -p1 --dry-run < patches/test.diff -- ok > > > 19 commands (18 passed, 1 failed) > > > make[2]: *** [Makefile:411: test/.create-delete.ok] Error 1 > > > make[2]: *** Waiting for unfinished jobs > > > [annotate.test] > > > 31 commands (31 passed, 0 failed) > > > [duplicate-patch-in-series.test] > > > 9 commands (9 passed, 0 failed) > > > [conflicts.test] > > > 39 commands (39 passed, 0 failed) > > > [auto-refresh.test] > > > 14 commands (14 passed, 0 failed) > > > [dotglob.test] > > > 7 commands (7 passed, 0 failed) > > > [delete.test] > > > 34 commands (34 passed, 0 failed) > > > [backup-files.test] > > > 119 commands (119 passed, 0 failed) > > > make[2]: Leaving directory '/<>' > > > dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" > > > VERBOSE=1 > > > returned exit code 2 > > > > > > The full build log is available from: > > http://qa-logs.debian.net/2022/09/17/quilt_0.66-2.1_unstable.log > > > > All bugs filed during this archive rebuild are listed at: > > https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220917;users=lu...@debian.org > > or: > > https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220917&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results > > > > A list of current common problems and possible solutions is available at > > http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! > > > > If you reassign this bug to another package, please marking it as 'affects'- > > ing > > this package. See https://www.debian.org/Bugs/server-control#affects > > > > If you fail to reproduce this, please provide a build log and diff it with > > mine > > so that we can identify if something relevant changed in the meantime. > > -- > Pour une évaluation indépendante, transparente et rigoureuse ! > Je souti
Processed: Re: Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Processing control commands: > tag -1 help Bug #1020108 [src:quilt] quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2 Added tag(s) help. -- 1020108: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020108 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Control: tag -1 help I seem to remember that this is a transient bug, that does not occure all the time at all. That being said, I'm not sure I already tested running the tests in parallel. Is that really a FTBFS if the failure only happens under this setting? I tend to remove the FTBFS severity on this one, but I'm not sure. I'm really short on time these days, so any help is welcome. It's maybe the occasion to upgrade the package to the new upstream release, but we have a lot of patches that I'd like to integrate upstream. It takes time because upstream is picky and only integrate sensible changes. I do not blame them for that (to the contrary), but I don't often trust myself to discuss our changes with them. The package is uptodate on salsa. Thanks for any help that could be provided. Mt Le dimanche 18 septembre 2022 à 08:40 +0200, Lucas Nussbaum a écrit : > Source: quilt > Version: 0.66-2.1 > Severity: serious > Justification: FTBFS > Tags: bookworm sid ftbfs > User: lu...@debian.org > Usertags: ftbfs-20220917 ftbfs-bookworm > > Hi, > > During a rebuild of all packages in sid, your package failed to build > on amd64. > > > Relevant part (hopefully): > > make[2]: Entering directory '/<>' > > [add-filename-check.test] > > 6 commands (6 passed, 0 failed) > > [altered-series.test] > > 12 commands (12 passed, 0 failed) > > [comments.test] > > 11 commands (11 passed, 0 failed) > > [applied.test] > > 15 commands (15 passed, 0 failed) > > [dir-a-b.test] > > 11 commands (11 passed, 0 failed) > > [colon-in-patch-name.test] > > 23 commands (23 passed, 0 failed) > > [create-delete.test] > > [4] $ mkdir patches -- ok > > [6] $ echo delete > delete -- ok > > [7] $ quilt new test.diff -- ok > > [10] $ quilt add create -- ok > > [13] $ echo create > create -- ok > > [14] $ quilt refresh -- ok > > [17] $ quilt add delete -- ok > > [20] $ rm -f delete -- ok > > [21] $ quilt refresh -- ok > > [23] $ quilt header -r -- ok > > [31] $ quilt patches -v create -- ok > > [33] $ quilt patches delete -- ok > > [36] $ quilt pop -q -- ok > > [40] $ quilt patches create -- ok > > [42] $ quilt patches -v delete -- ok > > [44] $ quilt patches -- /dev/null dev/null null --- -- failed > > grep: warning: stray \ before / != ~ > > grep: warning: stray \ before / != ~ > > grep: warning: stray \ before / != ~ > > [46] $ echo create > create -- ok > > [47] $ rm -f delete -- ok > > [48] $ patch -p1 --dry-run < patches/test.diff -- ok > > 19 commands (18 passed, 1 failed) > > make[2]: *** [Makefile:411: test/.create-delete.ok] Error 1 > > make[2]: *** Waiting for unfinished jobs > > [annotate.test] > > 31 commands (31 passed, 0 failed) > > [duplicate-patch-in-series.test] > > 9 commands (9 passed, 0 failed) > > [conflicts.test] > > 39 commands (39 passed, 0 failed) > > [auto-refresh.test] > > 14 commands (14 passed, 0 failed) > > [dotglob.test] > > 7 commands (7 passed, 0 failed) > > [delete.test] > > 34 commands (34 passed, 0 failed) > > [backup-files.test] > > 119 commands (119 passed, 0 failed) > > make[2]: Leaving directory '/<>' > > dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 > > returned exit code 2 > > > The full build log is available from: > http://qa-logs.debian.net/2022/09/17/quilt_0.66-2.1_unstable.log > > All bugs filed during this archive rebuild are listed at: > https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220917;users=lu...@debian.org > or: > https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220917&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results > > A list of current common problems and possible solutions is available at > http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! > > If you reassign this bug to another package, please marking it as 'affects'- > ing > this package. See https://www.debian.org/Bugs/server-control#affects > > If you fail to reproduce this, please provide a build log and diff it with > mine > so that we can identify if something relevant changed in the meantime. -- Pour une évaluation indépendante, transparente et rigoureuse ! Je soutiens la Commission d'Évaluation de l'Inria. signature.asc Description: This is a digitally signed message part
Bug#1020108: quilt: FTBFS: dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 returned exit code 2
Source: quilt Version: 0.66-2.1 Severity: serious Justification: FTBFS Tags: bookworm sid ftbfs User: lu...@debian.org Usertags: ftbfs-20220917 ftbfs-bookworm Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[2]: Entering directory '/<>' > [add-filename-check.test] > 6 commands (6 passed, 0 failed) > [altered-series.test] > 12 commands (12 passed, 0 failed) > [comments.test] > 11 commands (11 passed, 0 failed) > [applied.test] > 15 commands (15 passed, 0 failed) > [dir-a-b.test] > 11 commands (11 passed, 0 failed) > [colon-in-patch-name.test] > 23 commands (23 passed, 0 failed) > [create-delete.test] > [4] $ mkdir patches -- ok > [6] $ echo delete > delete -- ok > [7] $ quilt new test.diff -- ok > [10] $ quilt add create -- ok > [13] $ echo create > create -- ok > [14] $ quilt refresh -- ok > [17] $ quilt add delete -- ok > [20] $ rm -f delete -- ok > [21] $ quilt refresh -- ok > [23] $ quilt header -r -- ok > [31] $ quilt patches -v create -- ok > [33] $ quilt patches delete -- ok > [36] $ quilt pop -q -- ok > [40] $ quilt patches create -- ok > [42] $ quilt patches -v delete -- ok > [44] $ quilt patches -- /dev/null dev/null null --- -- failed > grep: warning: stray \ before / != ~ > grep: warning: stray \ before / != ~ > grep: warning: stray \ before / != ~ > [46] $ echo create > create -- ok > [47] $ rm -f delete -- ok > [48] $ patch -p1 --dry-run < patches/test.diff -- ok > 19 commands (18 passed, 1 failed) > make[2]: *** [Makefile:411: test/.create-delete.ok] Error 1 > make[2]: *** Waiting for unfinished jobs > [annotate.test] > 31 commands (31 passed, 0 failed) > [duplicate-patch-in-series.test] > 9 commands (9 passed, 0 failed) > [conflicts.test] > 39 commands (39 passed, 0 failed) > [auto-refresh.test] > 14 commands (14 passed, 0 failed) > [dotglob.test] > 7 commands (7 passed, 0 failed) > [delete.test] > 34 commands (34 passed, 0 failed) > [backup-files.test] > 119 commands (119 passed, 0 failed) > make[2]: Leaving directory '/<>' > dh_auto_test: error: make -j8 check "TESTSUITEFLAGS=-j8 --verbose" VERBOSE=1 > returned exit code 2 The full build log is available from: http://qa-logs.debian.net/2022/09/17/quilt_0.66-2.1_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20220917;users=lu...@debian.org or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20220917&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! If you reassign this bug to another package, please marking it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.
