Processed: Re: Bug#1026628: pyro4: FTBFS: AssertionError: must fail
Processing control commands: > tags -1 +pending Bug #1026628 [src:pyro4] pyro4: FTBFS: AssertionError: must fail Added tag(s) pending. -- 1026628: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026628 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
Bug#1026628: pyro4: FTBFS: AssertionError: must fail
Control: tags -1 +pending Hi, On Mon, Jan 2, 2023 at 4:15 PM Bo YU wrote: > Although skip failed test cases are not perfect solution to fix such > issues, but upstream has decided to end pyro4's life on python3.10. I > think it is ok to skip these failed test cases on python 3.10. There is > no sense to patch test files if in order to pass these failed cases. If > to fix pyro4's core code, I am not sure if how many work need to be > finished. Just confirmed, your patch fixes this issue. Thanks for your contribution! > PS: I would like to package pyro5 if it makes sense.:) Do you have packaging experience? Can you do it in a day or two? Regards, Laszlo/GCS
Bug#1026628: pyro4: FTBFS: AssertionError: must fail
Source: pyro4
Version: 4.82-1
Followup-For: Bug #1026628
Tags: ftbfs patch
X-Debbugs-Cc: Bo YU
Dear Maintainer,
Although skip failed test cases are not perfect solution to fix such
issues, but upstream has decided to end pyro4's life on python3.10. I
think it is ok to skip these failed test cases on python 3.10. There is
no sense to patch test files if in order to pass these failed cases. If
to fix pyro4's core code, I am not sure if how many work need to be
finished.
I have tested the patch attached.
PS: I would like to package pyro5 if it makes sense.:)
--
Regards,
--
Bo YU
diff -Nru pyro4-4.82/debian/changelog pyro4-4.82/debian/changelog
--- pyro4-4.82/debian/changelog 2022-01-12 05:19:07.0 +0800
+++ pyro4-4.82/debian/changelog 2023-01-02 22:46:19.0 +0800
@@ -1,3 +1,10 @@
+pyro4 (4.82-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add patch to fix ftbfs on python3.11. (Closes: #1026628)
+
+ -- Bo Yu Mon, 02 Jan 2023 22:46:19 +0800
+
pyro4 (4.82-1) unstable; urgency=medium
* New upstream release.
diff -Nru pyro4-4.82/debian/patches/fix-ftbfs-python3.11.patch
pyro4-4.82/debian/patches/fix-ftbfs-python3.11.patch
--- pyro4-4.82/debian/patches/fix-ftbfs-python3.11.patch1970-01-01
07:30:00.0 +0730
+++ pyro4-4.82/debian/patches/fix-ftbfs-python3.11.patch2023-01-02
22:46:19.0 +0800
@@ -0,0 +1,43 @@
+Description: skip test failed on python3.11
+ This is workround to fix such issue, but upstream has decided to end pyro4's
life
+ on python3.10.
+Author: Bo YU
+Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1026628
+Forwarded: no
+Last-Update: 2023-01-02
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/tests/PyroTests/test_serialize.py
b/tests/PyroTests/test_serialize.py
+@@ -324,6 +324,7 @@
+ with self.assertRaises(ValueError):
+ self.serializer.register_type_replacement(42, lambda: None)
+
++@unittest.skip("skip tetes on python3.11")
+ def testCustomClassFail(self):
+ if self.SERIALIZER in ("pickle", "cloudpickle", "dill"):
+ self.skipTest("pickle, cloudpickle and dill simply serialize
custom classes")
+@@ -335,6 +336,7 @@
+ except Pyro4.errors.ProtocolError:
+ pass
+
++@unittest.skip("skip tetes on python3.11")
+ def testCustomClassOk(self):
+ if self.SERIALIZER in ("pickle", "cloudpickle", "dill"):
+ self.skipTest("pickle, cloudpickle and dill simply serialize
custom classes just fine")
+@@ -841,6 +843,7 @@
+ self.assertRaises(Pyro4.errors.SerializeError, lambda:
Pyro4.util.get_serializer_by_id(0))
+ self.assertRaises(Pyro4.errors.SerializeError, lambda:
Pyro4.util.get_serializer_by_id(8))
+
++@unittest.skip("skip tetes on python3.11")
+ def testDictClassFail(self):
+ o = pprint.PrettyPrinter(stream="dummy", width=42)
+ d = Pyro4.util.SerializerBase.class_to_dict(o)
+@@ -889,6 +892,7 @@
+ self.assertEqual(uri, x)
+ self.assertEqual("/tmp/socketname", x.sockname)
+
++@unittest.skip("skip tetes on python3.11")
+ def testCustomDictClass(self):
+ o = MyThingPartlyExposed("test")
+
Pyro4.util.SerializerBase.register_class_to_dict(MyThingPartlyExposed,
mything_dict)
diff -Nru pyro4-4.82/debian/patches/series pyro4-4.82/debian/patches/series
--- pyro4-4.82/debian/patches/series2022-01-12 05:19:07.0 +0800
+++ pyro4-4.82/debian/patches/series2023-01-02 21:00:46.0 +0800
@@ -1 +1,2 @@
skip_networked_tests.patch
+fix-ftbfs-python3.11.patch
signature.asc
Description: PGP signature
Bug#1026628: pyro4: FTBFS: AssertionError: must fail
Source: pyro4 Version: 4.82-1 Followup-For: Bug #1026628 Hi, From here: https://github.com/irmen/Pyro4 -- "Python 3.10 is the End of the Line for Pyro4", I am not sure how to fix the issue correctly, is it time to package pyro5[0]? [0]: https://github.com/irmen/Pyro5 -- Regards, -- Bo YU signature.asc Description: PGP signature
Bug#1026628: pyro4: FTBFS: AssertionError: must fail
Source: pyro4 Version: 4.82-1 Severity: serious Justification: FTBFS Tags: bookworm sid ftbfs User: lu...@debian.org Usertags: ftbfs-20221220 ftbfs-bookworm Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[2]: Entering directory '/<>/docs' > sphinx-build -b html -d ../build/sphinx/doctrees source ../build/sphinx/html > Running Sphinx v5.3.0 > making output directory... done > building [mo]: targets for 0 po files that are out of date > building [html]: targets for 30 source files that are out of date > updating environment: [new config] 30 added, 0 changed, 0 removed > reading sources... [ 3%] alternative > reading sources... [ 6%] api > reading sources... [ 10%] api/config > reading sources... [ 13%] api/constants > reading sources... [ 16%] api/core > reading sources... [ 20%] api/echoserver > reading sources... [ 23%] api/errors > reading sources... [ 26%] api/flame > reading sources... [ 30%] api/futures > reading sources... [ 33%] api/main > reading sources... [ 36%] api/message > reading sources... [ 40%] api/naming > reading sources... [ 43%] api/socketserver > reading sources... [ 46%] api/util > reading sources... [ 50%] changelog > reading sources... [ 53%] clientcode > reading sources... [ 56%] commandline > reading sources... [ 60%] config > reading sources... [ 63%] errors > reading sources... [ 66%] flame > reading sources... [ 70%] index > reading sources... [ 73%] install > reading sources... [ 76%] intro > reading sources... [ 80%] license > reading sources... [ 83%] nameserver > reading sources... [ 86%] pyrolite > reading sources... [ 90%] security > reading sources... [ 93%] servercode > reading sources... [ 96%] tipstricks > reading sources... [100%] tutorials > > looking for now-outdated files... none found > pickling environment... done > checking consistency... done > preparing documents... done > writing output... [ 3%] alternative > writing output... [ 6%] api > writing output... [ 10%] api/config > writing output... [ 13%] api/constants > writing output... [ 16%] api/core > writing output... [ 20%] api/echoserver > writing output... [ 23%] api/errors > writing output... [ 26%] api/flame > writing output... [ 30%] api/futures > writing output... [ 33%] api/main > writing output... [ 36%] api/message > writing output... [ 40%] api/naming > writing output... [ 43%] api/socketserver > writing output... [ 46%] api/util > writing output... [ 50%] changelog > writing output... [ 53%] clientcode > writing output... [ 56%] commandline > writing output... [ 60%] config > writing output... [ 63%] errors > writing output... [ 66%] flame > writing output... [ 70%] index > writing output... [ 73%] install > writing output... [ 76%] intro > writing output... [ 80%] license > writing output... [ 83%] nameserver > writing output... [ 86%] pyrolite > writing output... [ 90%] security > writing output... [ 93%] servercode > writing output... [ 96%] tipstricks > writing output... [100%] tutorials > > generating indices... genindex done > writing additional pages... search done > copying images... [ 25%] _static/flammable.png > copying images... [ 50%] _static/pyro-large.png > copying images... [ 75%] _static/pyro5.png > copying images... [100%] _static/tf_pyrotaunt.png > > copying static files... done > copying extra files... done > dumping search index in English (code: en)... done > dumping object inventory... done > build succeeded. > > The HTML pages are in ../build/sphinx/html. > > Build finished. The HTML pages are in ../build/sphinx/html. > make[2]: Leaving directory '/<>/docs' > make[1]: Leaving directory '/<>' >dh_auto_test -O--buildsystem=pybuild > I: pybuild base:240: python3.11 setup.py test > /usr/lib/python3/dist-packages/setuptools/config/setupcfg.py:508: > SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use > license_files instead. > warnings.warn(msg, warning_class) > Pyro version = 4.82 > running test > WARNING: Testing via this command is deprecated and will be removed in a > future version. Users looking for a generic test entry point independent of > test runner are encouraged to use tox. > running egg_info > creating src/Pyro4.egg-info > writing src/Pyro4.egg-info/PKG-INFO > writing dependency_links to src/Pyro4.egg-info/dependency_links.txt > writing entry points to src/Pyro4.egg-info/entry_points.txt > writing requirements to src/Pyro4.egg-info/requires.txt > writing top-level names to src/Pyro4.egg-info/top_level.txt > writing manifest file 'src/Pyro4.egg-info/SOURCES.txt' > reading manifest file 'src/Pyro4.egg-info/SOURCES.txt' > reading manifest template 'MANIFEST.in' > warning: no previously-included files matching '*/.svn/*' found anywhere in > distribution > warning: no previously-included files matching '*/.idea/*' found anywhere in > distribution > warning: no previously-included files matching '*.class' found anywhere in > distribution > warning:
