Bug#1034969: [Pkg-javascript-devel] Bug#1034969: Fwd: Bug#1034969: terser: missing Breaks+Replaces for uglifyjs.terser when upgrading from bullseye

2023-05-02 Thread Jonas Smedegaard
Quoting Yadd (2023-05-02 08:58:06)
> For the record, unblock issue is #1035368

Looks excellent - thanks for your work on this, Yadd!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature


Bug#1034969: Fwd: Bug#1034969: terser: missing Breaks+Replaces for uglifyjs.terser when upgrading from bullseye

2023-05-02 Thread Yadd

On 5/2/23 08:25, Jonas Smedegaard wrote:

Quoting Yadd (2023-05-02 04:58:47)

a previous "unblock" was missing here: unstable version is 5.16.5-1
while testing version is 5.16.4-1. What do you want to do, fix only this
bug with a 5.16.5-really-5.16.4-1 or a full update ?


It is a bugfix release, and as such I would consider it relevant for
stable, but I get exhausted just thinking about the need for "defending"
changes against the release team: If you do it, you can desice if you
want to try get all of it in or only a (arguably too) minimal patch.

Thanks!

  - Jonas


For the record, unblock issue is #1035368



Bug#1034969: Fwd: Bug#1034969: terser: missing Breaks+Replaces for uglifyjs.terser when upgrading from bullseye

2023-05-01 Thread Jonas Smedegaard
Quoting Yadd (2023-05-02 04:58:47)
> a previous "unblock" was missing here: unstable version is 5.16.5-1 
> while testing version is 5.16.4-1. What do you want to do, fix only this 
> bug with a 5.16.5-really-5.16.4-1 or a full update ?

It is a bugfix release, and as such I would consider it relevant for
stable, but I get exhausted just thinking about the need for "defending"
changes against the release team: If you do it, you can desice if you
want to try get all of it in or only a (arguably too) minimal patch.

Thanks!

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private

signature.asc
Description: signature


Bug#1034969: Fwd: Bug#1034969: terser: missing Breaks+Replaces for uglifyjs.terser when upgrading from bullseye

2023-05-01 Thread Yadd

Hi,

a previous "unblock" was missing here: unstable version is 5.16.5-1 
while testing version is 5.16.4-1. What do you want to do, fix only this 
bug with a 5.16.5-really-5.16.4-1 or a full update ?


On 5/1/23 08:37, Jonas Smedegaard wrote:

Thanks for the patch, Yadd - and for the bugreport, Helmut.

I am quite busy elsewhere currently - if you have the time then I would
appreciate if you would handle this issue.

Otherwise I'll try make time for it the upcoming weekend.

  - Jonas

Quoting Yadd (2023-04-28 05:38:56)

Hi Jonas,

it seems that "Breaks" fields needs to be duplicated in "Replaces":

diff --git a/debian/control b/debian/control
index 6772ac76..3d8f1174 100644
--- a/debian/control
+++ b/debian/control
@@ -34,6 +34,9 @@ Depends:
   Breaks:
uglifyjs.terser (<< 4.8.0-1~),
node-rollup-plugin-terser (<< 7.0.2+~5.0.1-3~)
+Replaces:
+ uglifyjs.terser (<< 4.8.0-1~),
+ node-rollup-plugin-terser (<< 7.0.2+~5.0.1-3~)
   Suggests:
terser,
   Multi-Arch: foreign
@@ -87,6 +90,8 @@ Recommends:
node-source-map-support,
   Breaks:
uglifyjs.terser (<< 4.8.0-1~),
+Replaces:
+ uglifyjs.terser (<< 4.8.0-1~),
   Suggests:
node-acorn,
   Multi-Arch: foreign

Cheers,
Yadd

 Forwarded Message 
Subject: [Pkg-javascript-devel] Bug#1034969: terser: missing
Breaks+Replaces for uglifyjs.terser when upgrading from bullseye
Resent-Date: Thu, 27 Apr 2023 13:11:12 +
Resent-From: Helmut Grohne 
Resent-To: debian-bugs-d...@lists.debian.org
Resent-CC: Debian Javascript Maintainers

Date: Thu, 27 Apr 2023 14:59:55 +0200
From: Helmut Grohne 
Reply-To: Helmut Grohne , 1034...@bugs.debian.org
To: sub...@bugs.debian.org

Package: terser
Version: 5.16.4-1
Severity: serious
Justification: dpkg unpack error

Attempting to unpack terser/5.16.4-1 from Debian bookworm
on a minimal Debian bullseye with uglifyjs.terser/4.1.2-8
installed, causes an unpack error from dpkg due to
/usr/share/nodejs/terser/bin/uglifyjs being contained in both packages.

| Selecting previously unselected package terser.
| dpkg: considering deconfiguration of uglifyjs.terser, which would be
broken by installation of terser ...
| dpkg: yes, will deconfigure uglifyjs.terser (broken by terser)
| (Reading database ... 4922 files and directories currently installed.)
| Preparing to unpack ./terser_5.16.4-1_all.deb ...
| De-configuring uglifyjs.terser (4.1.2-8) ...
| Unpacking terser (5.16.4-1) ...
| dpkg: error processing archive ./terser_5.16.4-1_all.deb (--unpack):
|  trying to overwrite '/usr/share/nodejs/terser/bin/uglifyjs', which is
also in package uglifyjs.terser 4.1.2-8
| Errors were encountered while processing:
|  ./terser_5.16.4-1_all.deb


Please ensure that terser has sufficient Breaks and Replaces declarations.

Helmut

--
Pkg-javascript-devel mailing list
pkg-javascript-de...@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel






Bug#1034969: Fwd: Bug#1034969: terser: missing Breaks+Replaces for uglifyjs.terser when upgrading from bullseye

2023-04-30 Thread Jonas Smedegaard
Thanks for the patch, Yadd - and for the bugreport, Helmut.

I am quite busy elsewhere currently - if you have the time then I would
appreciate if you would handle this issue.

Otherwise I'll try make time for it the upcoming weekend.

 - Jonas

Quoting Yadd (2023-04-28 05:38:56)
> Hi Jonas,
> 
> it seems that "Breaks" fields needs to be duplicated in "Replaces":
> 
> diff --git a/debian/control b/debian/control
> index 6772ac76..3d8f1174 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -34,6 +34,9 @@ Depends:
>   Breaks:
>uglifyjs.terser (<< 4.8.0-1~),
>node-rollup-plugin-terser (<< 7.0.2+~5.0.1-3~)
> +Replaces:
> + uglifyjs.terser (<< 4.8.0-1~),
> + node-rollup-plugin-terser (<< 7.0.2+~5.0.1-3~)
>   Suggests:
>terser,
>   Multi-Arch: foreign
> @@ -87,6 +90,8 @@ Recommends:
>node-source-map-support,
>   Breaks:
>uglifyjs.terser (<< 4.8.0-1~),
> +Replaces:
> + uglifyjs.terser (<< 4.8.0-1~),
>   Suggests:
>node-acorn,
>   Multi-Arch: foreign
> 
> Cheers,
> Yadd
> 
>  Forwarded Message 
> Subject: [Pkg-javascript-devel] Bug#1034969: terser: missing 
> Breaks+Replaces for uglifyjs.terser when upgrading from bullseye
> Resent-Date: Thu, 27 Apr 2023 13:11:12 +
> Resent-From: Helmut Grohne 
> Resent-To: debian-bugs-d...@lists.debian.org
> Resent-CC: Debian Javascript Maintainers 
> 
> Date: Thu, 27 Apr 2023 14:59:55 +0200
> From: Helmut Grohne 
> Reply-To: Helmut Grohne , 1034...@bugs.debian.org
> To: sub...@bugs.debian.org
> 
> Package: terser
> Version: 5.16.4-1
> Severity: serious
> Justification: dpkg unpack error
> 
> Attempting to unpack terser/5.16.4-1 from Debian bookworm
> on a minimal Debian bullseye with uglifyjs.terser/4.1.2-8
> installed, causes an unpack error from dpkg due to
> /usr/share/nodejs/terser/bin/uglifyjs being contained in both packages.
> 
> | Selecting previously unselected package terser.
> | dpkg: considering deconfiguration of uglifyjs.terser, which would be 
> broken by installation of terser ...
> | dpkg: yes, will deconfigure uglifyjs.terser (broken by terser)
> | (Reading database ... 4922 files and directories currently installed.)
> | Preparing to unpack ./terser_5.16.4-1_all.deb ...
> | De-configuring uglifyjs.terser (4.1.2-8) ...
> | Unpacking terser (5.16.4-1) ...
> | dpkg: error processing archive ./terser_5.16.4-1_all.deb (--unpack):
> |  trying to overwrite '/usr/share/nodejs/terser/bin/uglifyjs', which is 
> also in package uglifyjs.terser 4.1.2-8
> | Errors were encountered while processing:
> |  ./terser_5.16.4-1_all.deb
> 
> 
> Please ensure that terser has sufficient Breaks and Replaces declarations.
> 
> Helmut
> 
> -- 
> Pkg-javascript-devel mailing list
> pkg-javascript-de...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/
 * Sponsorship: https://ko-fi.com/drjones

 [x] quote me freely  [ ] ask before reusing  [ ] keep private