Bug#1054712: ensmallen: FTBFS: adam_test.cpp:17:10: fatal error: catch2/catch.hpp: No such file or directory

2023-10-31 Thread Drew Parsons
Source: ensmallen
Followup-For: Bug #1054712

Should be noted that the problem is linked to debian patch
0002-use-system-catch.patch, which disables upstream's local copy of
catch in order to use the system catch2 library.

So one workaround could be to disable 0002-use-system-catch.patch.



Bug#1054712: ensmallen: FTBFS: adam_test.cpp:17:10: fatal error: catch2/catch.hpp: No such file or directory

2023-10-31 Thread Drew Parsons
Source: ensmallen
Followup-For: Bug #1054712
Control: forwarded 1054712 https://github.com/mlpack/ensmallen/issues/372

This error occurs because of the upgrade of catch2 from v2 to v3.

Unfortunately ensmallen upstream don't sound very enthusiastic about
dealing with it, https://github.com/mlpack/ensmallen/issues/372

Arguably the catch developers made life unjustifiablydifficult. Maybe
they should have released catch3 rather than catch2 v3.

On the other hand, judging by the patch for termpaint, the required
changes are likely to be essentially trivial, e.g. 
  #include "catch2/catch_all.hpp"
instead of 
  #include "catch2/catch.hpp"

cf.
https://github.com/termpaint/termpaint/commit/dc293554b745b3f010445e9445e620399f8ee2f7



Bug#1054712: ensmallen: FTBFS: adam_test.cpp:17:10: fatal error: catch2/catch.hpp: No such file or directory

2023-10-27 Thread Lucas Nussbaum
Source: ensmallen
Version: 2.20.0-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20231027 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> cd /<>/obj-x86_64-linux-gnu/tests && /usr/bin/c++  
> -I/<>/include -g -O2 -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -std=gnu++11 -Wall -Wpedantic -Wunused-parameter -MD -MT 
> tests/CMakeFiles/ensmallen_tests.dir/adam_test.cpp.o -MF 
> CMakeFiles/ensmallen_tests.dir/adam_test.cpp.o.d -o 
> CMakeFiles/ensmallen_tests.dir/adam_test.cpp.o -c 
> /<>/tests/adam_test.cpp
> /<>/tests/adam_test.cpp:17:10: fatal error: catch2/catch.hpp: No 
> such file or directory
>17 | #include 
>   |  ^~
> compilation terminated.
> /<>/tests/active_cmaes_test.cpp:12:10: fatal error: 
> catch2/catch.hpp: No such file or directory
>12 | #include 
>   |  ^~
> compilation terminated.
> make[5]: *** [tests/CMakeFiles/ensmallen_tests.dir/build.make:177: 
> tests/CMakeFiles/ensmallen_tests.dir/adam_test.cpp.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2023/10/27/ensmallen_2.20.0-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20231027;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20231027=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.