Bug#1062405: dolfin: NMU diff for 64-bit time_t transition

2024-04-20 Thread Drew Parsons
Source: dolfin
Followup-For: Bug #1062405
Control: severity 1062405 testing
Control: tags 1062405 moreinfo

This time_t patch was never applied.  Is it not needed after all? 
Can we close this bug now?



Bug#1062405: dolfin: NMU diff for 64-bit time_t transition

2024-02-01 Thread mwhudson
Source: dolfin
Version: 2019.2.0~legacy20240118.982f376-1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
dolfin as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for dolfin
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru dolfin-2019.2.0~legacy20240118.982f376/debian/changelog 
dolfin-2019.2.0~legacy20240118.982f376/debian/changelog
--- dolfin-2019.2.0~legacy20240118.982f376/debian/changelog 2024-01-19 
18:21:04.0 +
+++ dolfin-2019.2.0~legacy20240118.982f376/debian/changelog 2024-02-01 
09:14:42.0 +
@@ -1,3 +1,10 @@
+dolfin (2019.2.0~legacy20240118.982f376-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Michael Hudson-Doyle   Thu, 01 Feb 2024 09:14:42 +
+
 dolfin (2019.2.0~legacy20240118.982f376-1) unstable; urgency=medium
 
   * New upstream snapshot on 2024-01-18, up to commit 982f376
diff -Nru dolfin-2019.2.0~legacy20240118.982f376/debian/control 
dolfin-2019.2.0~legacy20240118.982f376/debian/control
--- dolfin-2019.2.0~legacy20240118.982f376/debian/control   2024-01-19 
18:21:04.0 +
+++ dolfin-2019.2.0~legacy20240118.982f376/debian/control   2024-02-01 
09:14:27.0 +
@@ -77,7 +77,7 @@
  libboost-serialization-dev,
  libboost-thread-dev,
  libboost-timer-dev,
- libdolfin2019.2gcc13 (= ${binary:Version}),
+ libdolfin2019.2gcc13t64 (= ${binary:Version}),
  libeigen3-dev,
  libhdf5-mpi-dev,
  libsuitesparse-dev,
@@ -152,7 +152,10 @@
  This is the legacy version of DOLFIN, you may want to install the
  next-generation libdolfinx-dev (DOLFIN-X) instead.
 
-Package: libdolfin2019.2gcc13
+Package: libdolfin2019.2gcc13t64
+Provides: ${t64:Provides}
+Replaces: libdolfin2019.2gcc13
+Breaks: libdolfin2019.2gcc13 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -209,7 +212,7 @@
 Architecture: any
 Depends:
  libdolfin-dev (= ${binary:Version}),
- libdolfin2019.2gcc13 (= ${binary:Version}),
+ libdolfin2019.2gcc13t64 (= ${binary:Version}),
  ${python3-petsc4py-real:Depends},
  ${misc:Depends},
  ${python3:Depends},
@@ -248,7 +251,7 @@
  libboost-serialization-dev,
  libboost-thread-dev,
  libboost-timer-dev,
- libdolfin64-2019.2gcc13 (= ${binary:Version}),
+ libdolfin64-2019.2gcc13t64 (= ${binary:Version}),
  libeigen3-dev,
  libhdf5-mpi-dev,
  libsuitesparse-dev,
@@ -273,7 +276,10 @@
  This is the legacy version of DOLFIN, you may want to install the
  next-generation libdolfinx-dev (DOLFIN-X) instead.
 
-Package: libdolfin64-2019.2gcc13
+Package: libdolfin64-2019.2gcc13t64
+Provides: ${t64:Provides}
+Replaces: libdolfin64-2019.2gcc13
+Breaks: libdolfin64-2019.2gcc13 (<< ${source:Version})
 Section: libs
 Architecture: any
 Multi-Arch: same
@@ -296,7 +302,7 @@
 Architecture: any
 Depends:
  libdolfin64-dev (= ${binary:Version}),
- libdolfin64-2019.2gcc13 (= ${binary:Version}),
+ libdolfin64-2019.2gcc13t64 (= ${binary:Version}),
  ${python3-petsc4py-64-real:Depends},
  ${misc:Depends},
  ${python3:Depends},
diff -Nru 
dolfin-2019.2.0~legacy20240118.982f376/debian/libdolfin2019.2gcc13.install