Bug#1066624: xfireworks: FTBFS: etc.c:11:19: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

2024-05-07 Thread Yukiharu YABUKI
Hi,

Thanks for your comment. I'll try to enable
-Werror=implicit-function-declaratin

On Wed, 13 Mar 2024 12:58:32 +0100
Lucas Nussbaum  wrote:

[snip]
> This is most likely caused by a change in dpkg 1.22.6, that enabled
> -Werror=implicit-function-declaration. For more information, see
> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
> 
> Relevant part (hopefully):
> > cc -c arguments.c -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
> > -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> > -fstack-protector-strong -fstack-clash-protection -Wformat 
> > -Werror=format-security -fcf-protection
> > etc.c: In function ‘InitializeRand’:
> > etc.c:11:19: error: implicit declaration of function ‘time’ 
> > [-Werror=implicit-function-declaration]
> >11 |   srand((unsigned)time(NULL));
> >   |   ^~~~
> > etc.c:2:1: note: ‘time’ is defined in header ‘’; did you forget to 
> > ‘#include ’?
> > 1 | #include "etc.h"
> >   +++ |+#include 
> > 2 | 
> > cat xfireworks.1 | gzip -9 > xfireworks.6.gz
> > gzip: warning: GZIP environment variable is deprecated; use an alias or 
> > script
> > cat xfireworks.conf | ./mkconf > xfireworks_conf.h
> > cc -c XFireworks.c -I/usr/X11R6/include -Wdate-time -D_FORTIFY_SOURCE=2 -g 
> > -O2 -Werror=implicit-function-declaration 
> > -ffile-prefix-map=/<>=. -fstack-protector-strong 
> > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
> > cc1: some warnings being treated as errors
> > make[1]: *** [Makefile:73: etc.o] Error 1
[snip]

--
Yukiharu YABUKI 



Bug#1066624: xfireworks: FTBFS: etc.c:11:19: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: xfireworks
Version: 1.3-13
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> cc -c arguments.c -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection
> etc.c: In function ‘InitializeRand’:
> etc.c:11:19: error: implicit declaration of function ‘time’ 
> [-Werror=implicit-function-declaration]
>11 |   srand((unsigned)time(NULL));
>   |   ^~~~
> etc.c:2:1: note: ‘time’ is defined in header ‘’; did you forget to 
> ‘#include ’?
> 1 | #include "etc.h"
>   +++ |+#include 
> 2 | 
> cat xfireworks.1 | gzip -9 > xfireworks.6.gz
> gzip: warning: GZIP environment variable is deprecated; use an alias or script
> cat xfireworks.conf | ./mkconf > xfireworks_conf.h
> cc -c XFireworks.c -I/usr/X11R6/include -Wdate-time -D_FORTIFY_SOURCE=2 -g 
> -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:73: etc.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/xfireworks_1.3-13_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.