Bug#1069756: readability: build time test error: lxml.html.clean module is now a separate project lxml_html_clean

2024-04-26 Thread Étienne Mollier 
Hi Colin,

Colin Watson, on 2024-04-26:
> Based on https://github.com/buriy/python-readability/issues/179, it
> looks as though upstream intends to switch to bleach; I think we can
> just patch setup.py in Debian in the meantime though.  I'll do that.

Looks good to me, thanks for tackling this!

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/3, please excuse my verbosity
   `-on air: Saga - Give 'Em The Money


signature.asc
Description: PGP signature

Bug#1069756: readability: build time test error: lxml.html.clean module is now a separate project lxml_html_clean

2024-04-26 Thread Colin Watson 
On Wed, Apr 24, 2024 at 11:16:17AM +0200, Étienne Mollier wrote:
> As far as I could witness, replacing the python3-lxml build
> dependency by python3-lxml-html-clean resolved the issue at
> least for the bulid time test.  The package is subject to
> autodep8 python3 test, which raises that the binary package will
> also need it dependencies adjusted; this suggests the setup.py
> would probably need patching so this is addressed appropriately
> at a larger scale than Debian's.

Based on https://github.com/buriy/python-readability/issues/179, it
looks as though upstream intends to switch to bleach; I think we can
just patch setup.py in Debian in the meantime though.  I'll do that.

-- 
Colin Watson (he/him)  [cjwat...@debian.org]

Bug#1069756: readability: build time test error: lxml.html.clean module is now a separate project lxml_html_clean

2024-04-24 Thread Étienne Mollier 
Source: readability
Version: 0.8.1+dfsg1-3
Severity: serious
Tags: ftbfs
Justification: ftbfs

Dear Maintainer,

Attempt to run readability tests at build time results in the
following error:

==
ERROR: readability (unittest.loader._FailedTest.readability)
--
ImportError: Failed to import test module: readability
Traceback (most recent call last):
  File "/usr/lib/python3.11/unittest/loader.py", line 452, in 
_find_test_path
package = self._get_module_from_name(name)
  
  File "/usr/lib/python3.11/unittest/loader.py", line 362, in 
_get_module_from_name
__import__(name)
  File 
"/<>/.pybuild/cpython3_3.11/build/readability/__init__.py", line 
3, in 
from .readability import Document
  File 
"/<>/.pybuild/cpython3_3.11/build/readability/readability.py", 
line 11, in 
from .cleaners import clean_attributes
  File 
"/<>/.pybuild/cpython3_3.11/build/readability/cleaners.py", line 
3, in 
from lxml.html.clean import Cleaner
  File "/usr/lib/python3/dist-packages/lxml/html/clean.py", line 18, in 

raise ImportError(
ImportError: lxml.html.clean module is now a separate project 
lxml_html_clean.
Install lxml[html_clean] or lxml_html_clean directly.

As far as I could witness, replacing the python3-lxml build
dependency by python3-lxml-html-clean resolved the issue at
least for the bulid time test.  The package is subject to
autodep8 python3 test, which raises that the binary package will
also need it dependencies adjusted; this suggests the setup.py
would probably need patching so this is addressed appropriately
at a larger scale than Debian's.  The missing dependency on
python3-lxml-html-clean is also causing a regression in offpunk
autopkgtest[1], although that could be easily worked around by
pulling the missing dependency there.

[1]: https://ci.debian.net/packages/o/offpunk/unstable/amd64/44684161/

Have a nice day,  :)
-- 
  .''`.  Étienne Mollier 
 : :' :  pgp: 8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
 `. `'   sent from /dev/pts/4, please excuse my verbosity
   `-on air: Mike Oldfield - Lion


signature.asc
Description: PGP signature