Bug#299939: gkdial

[Justin Pryzby]

#299939 and #218014 likely have the same cause.  Someone might
consider downgrading #299939 and/or merging them.

It seems that both are caused by a user-trigged disconnect event while
in a state when disconnect should be disallowed.  A proper solution
probably requires glib synchronization, but I'll bet that the problems
can be visibly solved by something like:

  /*
   * runs the command the user defined to disconnect 
   */
  void
  gk_disconnect (GtkWidget * button, gpointer data)
  {
GkDial *gkdial = (GkDial *) data;
gchar *disconnect_cmd = DOWNCMD;
+   
+   if (!disconnect_valid) return;
+   disconnect_valid=0;
  
/*
 * this shows that gkdial was the responsible for the connection
 * being 
 * closed 
 */
gkdial-was_gkdial = FALSE;
gkdial_exec (gkdial, disconnect_cmd, DISCONNECTING);
  }

where disconnect_valid is a global variable, set to TRUE at the
appropriate time, and set to FALSE above, and while redialing.

I'm having trouble testing this since I don't have a linmodem..

Justin 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#299939: gkdial: Double-click on Disconnect causes a crash

[Frank Lichtenheld]

tag 299939 - patch
thanks

On Thu, Mar 17, 2005 at 02:02:14PM +0100, Luca Bruno wrote:
 I have not attached more infos because it is marked solved in 
 gnome 2.10, and probably the same updated code should be used as 
 patch also for gkdial.

Hmm, it may be fixed in gnome 2.10 but the only information in the
gnome BTS is modemlights was rewritten for G10. Without someone
actually digging into these changes and producing a patch I don't think
the patch tag is really warranted, so removing.

Gruesse,
-- 
Frank Lichtenheld [EMAIL PROTECTED]
www: http://www.djpig.de/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#299939: gkdial: Double-click on Disconnect causes a crash

[Luca Bruno]

Package: gkdial
Version: 1:1.8.0-3
Severity: grave
Tags: patch
Justification: causes non-serious data loss

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

After the connection, when there is the window with 
connection statistics, duoble-click on the Disconnect 
button causes a crash...
Also, if gkdial was started inside of gnome, it causes the
silently close of every other windows opened (in all workspaces).

Digging in the source, I noted a comment for a piece of code 
re-used from modemligth gnome-applet. So I think this is the 
same bug as in Debian Bug #220796 and Gnome Bug #135464.

I have not attached more infos because it is marked solved in 
gnome 2.10, and probably the same updated code should be used as 
patch also for gkdial.

Ciao, Luca

- -- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.9
Locale: LANG=it_IT, LC_CTYPE=it_IT (charmap=ISO-8859-1)

Versions of packages gkdial depends on:
ii  libart-2.0-22.3.17-1 Library of functions for 2D graphi
ii  libatk1.0-0 1.8.0-4  The ATK accessibility toolkit
ii  libbonobo2-02.8.1-2  Bonobo CORBA interfaces library
ii  libbonoboui2-0  2.8.1-1  The Bonobo UI library
ii  libc6   2.3.2.ds1-20 GNU C Library: Shared libraries an
ii  libgconf2-4 2.8.1-4  GNOME configuration database syste
ii  libglade2-0 1:2.4.2-1library to load .glade files at ru
ii  libglib2.0-02.6.2-1  The GLib library of C routines
ii  libgnome2-0 2.8.0-6  The GNOME 2 library - runtime file
ii  libgnomecanvas2-0   2.8.0-1  A powerful object-oriented display
ii  libgnomeui-02.8.0-3  The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0  2.8.3-11 The GNOME virtual file-system libr
ii  libgtk2.0-0 2.6.2-3  The GTK+ graphical user interface 
ii  libice6 4.3.0.dfsg.1-10  Inter-Client Exchange library
ii  liborbit2   1:2.10.5-0.1 libraries for ORBit2 - a CORBA ORB
ii  libpango1.0-0   1.8.0-3  Layout and rendering of internatio
ii  libpopt01.7-5lib for parsing cmdline parameters
ii  libsm6  4.3.0.dfsg.1-10  X Window System Session Management
ii  libx11-64.3.0.dfsg.1-10  X Window System protocol client li
ii  libxml2 2.6.16-3 GNOME XML library
ii  ppp 2.4.2+20040428-6 Point-to-Point Protocol (PPP) daem
ii  xlibs   4.3.0.dfsg.1-11  X Keyboard Extension (XKB) configu
ii  zlib1g  1:1.2.2-4compression library - runtime

- -- no debconf information

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFCOX/WRqobajv7n7MRAiukAKCkE+K3Jbjcd4drRlbnn3Fd43BK/wCfVimq
J0tZ6df/xsn0HoTUH8uSrEk=
=Xinz
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]