Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-07 Thread Marco d'Itri
On Nov 08, Rusty Russell [EMAIL PROTECTED] wrote:

 The current simple fix for that (thanks Pozsar!) is to poll while a
 module we rely on is still loading as indicated in /proc/modules.  This
 fix will be needed to cover existing kernels, even if we were to get
 fancy in new kernels.
I have *not* been able to verify this, but at least two people still
reported problems after using this patch.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Marco d'Itri
On Nov 05, Pozsar Balazs [EMAIL PROTECTED] wrote:

 With my patch, modprobe waits until the needed modules come out of the 
 Loading or Unloading state.
Looks like it works, I will upload a new package today.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Harald Dunkel
Harald Dunkel wrote:
 
 For testing I have added it to Debian's
 module-init-tools 3.2-pre9. Works for me.
 

No, it doesn't. After the 3rd reboot the
problem was back.


Regards

Harri


signature.asc
Description: OpenPGP digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Pozsar Balazs
On Sun, Nov 06, 2005 at 03:50:05PM +0100, Harald Dunkel wrote:
 Harald Dunkel wrote:
  
  For testing I have added it to Debian's
  module-init-tools 3.2-pre9. Works for me.
  
 
 No, it doesn't. After the 3rd reboot the
 problem was back.

Well, that's really wierd, It Should Work(tm) :)
Did you apply both patches (Rusty's + mine), or only the latter?

Could you send me debug output please? The first time I met the problem, 
I used a modprobe wrapper which dumped /proc/modules and modprobe 
stdout/stderr to a temp file.

I would like to also mention, that my patch leaves a very little time 
window open, but that's only a problem if module unloading is also 
happening: after parsing /proc/modules, but before actually loading the 
module, it is possible that an rmmod unloads (starts to unload) a 
dependant module. But this does not affect booting.


-- 
pozsy


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Harald Dunkel
Pozsar Balazs wrote:
 
 Well, that's really wierd, It Should Work(tm) :)
 Did you apply both patches (Rusty's + mine), or only the latter?
 

I hadn't seen Rusty's patch on Debian's bts, until you mentioned
it. I have applied both patches now, and rebooted twice: By now
it worked. But that's what I thought before.

 Could you send me debug output please? The first time I met the problem, 
 I used a modprobe wrapper which dumped /proc/modules and modprobe 
 stdout/stderr to a temp file.
 
If the problem comes back then I will do.

 I would like to also mention, that my patch leaves a very little time 
 window open, but that's only a problem if module unloading is also 
 happening: after parsing /proc/modules, but before actually loading the 
 module, it is possible that an rmmod unloads (starts to unload) a 
 dependant module. But this does not affect booting.
 
 

Are there several modprobe's running in parallel? Or does modprobe
return SUCCESS while the kernel is still busy making the module
usable somehow?


Regards

Harri


modprobe.patch.gz
Description: Unix tar archive


signature.asc
Description: OpenPGP digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Marco d'Itri
On Nov 06, Harald Dunkel [EMAIL PROTECTED] wrote:

 I hadn't seen Rusty's patch on Debian's bts, until you mentioned
 it. I have applied both patches now, and rebooted twice: By now
 it worked. But that's what I thought before.
It cannot be relevant, because when the bug is triggered / is still
read-only.

 Are there several modprobe's running in parallel? Or does modprobe
Yes.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-06 Thread Harald Dunkel
Marco d'Itri wrote:
 
Are there several modprobe's running in parallel? Or does modprobe
 
 Yes.
 
Is this supposed to be synchronized in user space, or in the
kernel?

Regards

Harri


signature.asc
Description: OpenPGP digital signature


Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-05 Thread Pozsar Balazs

On Sat, Nov 05, 2005 at 06:31:04PM +0100, Kay Sievers wrote:
 I've got these messages several times on the experimental SUSE too,
 but can't reproduce it so far, even without Rusty's patch to modprobe
 they have disappeared. See here for the details:
   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=333052


Just to let you know, I've also met this problem (on another distro), 
and did not know about this bugreport until now.
So I've done another workaround: modprobe already parses /proc/modules 
to check whether the modules needed are already loaded, and this file 
also shows us the state of the modules, being Loading, Live or 
Unloading.

With my patch, modprobe waits until the needed modules come out of the 
Loading or Unloading state.


-- 
pozsy


--- module-init-tools-3.2-pre4.orig/modprobe.c  2005-05-08 09:38:52.0 
+0200
+++ module-init-tools-3.2-pre4/modprobe.c   2005-10-24 13:19:39.0 
+0200
@@ -363,6 +363,7 @@
FILE *proc_modules;
char *line;
 
+start:
/* Might not be mounted yet.  Don't fail. */
proc_modules = fopen(/proc/modules, r);
if (!proc_modules)
@@ -373,12 +374,31 @@
 
if (entry  strcmp(entry, modname) == 0) {
/* If it exists, usecount is the third entry. */
-   if (usecount) {
-   entry = strtok(NULL,  \n);
-   if (entry
-(entry = strtok(NULL,  \n)) != NULL)
+   if (!(entry = strtok(NULL,  \n)))
+   goto out;
+
+   if (!(entry = strtok(NULL,  \n))) /* usecount */
+   goto out;
+   else
+   if (usecount)
*usecount = atoi(entry);
+
+   if (!(entry = strtok(NULL,  \n))) /* - */
+   goto out;
+
+   if (!(entry = strtok(NULL,  \n))) /* status */
+   goto out;
+   else {
+   if (!strcmp(entry, Loading) || !strcmp(entry, 
Unloading)) {
+   usleep(10);
+   free(line);
+   fclose(proc_modules);
+   goto start;
+   }
+   goto out;
}
+
+   out:
free(line);
fclose(proc_modules);
return 1;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#333052: 2.6.14, udev: unknown symbols for ehci_hcd

2005-11-05 Thread Harald Dunkel
Pozsar Balazs wrote:
 On Sat, Nov 05, 2005 at 06:31:04PM +0100, Kay Sievers wrote:
 
 
 With my patch, modprobe waits until the needed modules come out of the 
 Loading or Unloading state.
 
 

For testing I have added it to Debian's
module-init-tools 3.2-pre9. Works for me.


Regards

Harri


signature.asc
Description: OpenPGP digital signature