Bug#337391: libcgi-ssi-perl: FTBFS: Missing Build-Depends on netbase
Hello people,
Also, you need to make sure the package builds on a machine which is
offline, since requiring network access during a package build is a
serious problem -- although I haven't yet been able to check whether
that's the case here.
I can confirm that the package doesn't build correctly when the host is
offline, see below.
regards,
Thijs
make test
make[1]: Entering directory `/tmp/debian/libcgi-ssi-perl-0.88'
PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/lib -Iblib/arch test.pl
1..26
ok 1 - use CGI::SSI;
ok 2 - set/echo 1
ok 3 - set/echo 2
ok 4 - data encapsulation
ok 5 - new()
ok 6 - config 1
ok 7 - config 2
ok 8 - config 3
CGI::SSI error: failed to get('http://www.yahoo.com/'): 500 Can't
connect to www.yahoo.com:80 (Bad hostname 'www.yahoo.com').
not ok 9 - include virtual 1
# Failed test (test.pl at line 107)
ok 10 - include virtual 2
CGI::SSI error: failed to get('http://www.yahoo.com/').
not ok 11 - exec cgi
# Failed test (test.pl at line 125)
ok 12 - exec cmd
ok 13 - if/else
ok 14 - if/elif
ok 15 - if/elif/else
ok 16 - if 1
ok 17 - if 2
ok 18 - if 3
ok 19 - if/elif/else
ok 20 - inherit 1
ok 21 - inherit 2
ok 22 - config{timefmt}
ok 23 - recursion check
CGI::SSI error: failed to
get('http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi'): 500
Can't connect to www.bitperfect.com:80 (Bad hostname
'www.bitperfect.com').
not ok 24 - cookie support
# Failed test (test.pl at line 276)
ok 25 - tied object isa CGI::SSI
ok 26 - close()
# Looks like you failed 3 tests of 26.
make[1]: *** [test_dynamic] Error 3
make[1]: Leaving directory `/tmp/debian/libcgi-ssi-perl-0.88'
make: *** [debian/build-stamp] Error 2
debuild: fatal error at line 765:
dpkg-buildpackage failed!
signature.asc
Description: This is a digitally signed message part
Bug#337391: libcgi-ssi-perl: FTBFS: Missing Build-Depends on netbase
Hello all,
You need netbase to be installed for /etc/protocols to be available.
I can confirm that the package doesn't build correctly when the host
is offline, see below.
I fixed both of these issues. Please see attached patch. If no
objections arise, I'm planning to NMU this. Of course this is not
intended as an offence; it's part of my NM-process to fix an RC bug and
prepare an NMU for it.
regards,
Thijs Kinkhorst
diff -u libcgi-ssi-perl-0.88/debian/changelog libcgi-ssi-perl-0.88/debian/changelog
--- libcgi-ssi-perl-0.88/debian/changelog
+++ libcgi-ssi-perl-0.88/debian/changelog
@@ -1,3 +1,11 @@
+libcgi-ssi-perl (0.88-1.1) unstable; urgency=high
+
+ * NMU for release critical bug.
+ * Add netbase to depends (Closes: #337391).
+ * Skip tests in 'make test' that try to access remote sites.
+
+ -- Thijs Kinkhorst [EMAIL PROTECTED] Thu, 17 Nov 2005 02:54:10 +0100
+
libcgi-ssi-perl (0.88-1) unstable; urgency=low
* New upstream release. Closes: #329501.
diff -u libcgi-ssi-perl-0.88/debian/packages libcgi-ssi-perl-0.88/debian/packages
--- libcgi-ssi-perl-0.88/debian/packages
+++ libcgi-ssi-perl-0.88/debian/packages
@@ -41,6 +41,7 @@
Build-Depends-Indep: libwww-perl
Build-Depends-Indep: liburi-perl
Build-Depends-Indep: libtimedate-perl
+Build-Depends-Indep: netbase
%endif
Build: sh
PERL=${PERL:-/usr/bin/perl}
diff -u libcgi-ssi-perl-0.88/debian/control libcgi-ssi-perl-0.88/debian/control
--- libcgi-ssi-perl-0.88/debian/control
+++ libcgi-ssi-perl-0.88/debian/control
@@ -4,7 +4,7 @@
Priority: extra
Standards-Version: 3.6.2
Build-Depends: yada (= 0.48)
-Build-Depends-Indep: perl (= 5.8), libhtml-simpleparse-perl, perl-modules, libwww-perl, liburi-perl, libtimedate-perl, yada (= 0.48)
+Build-Depends-Indep: perl (= 5.8), libhtml-simpleparse-perl, perl-modules, libwww-perl, liburi-perl, libtimedate-perl, netbase, yada (= 0.48)
Package: libcgi-ssi-perl
Architecture: all
--- libcgi-ssi-perl-0.88.orig/test.pl
+++ libcgi-ssi-perl-0.88/test.pl
@@ -101,10 +101,12 @@
# include file - with many types of input
# include virtual - with different types of input
-{
-my $ssi = CGI::SSI-new();
-my $html = $ssi-process(q[!--#include virtual=http://www.yahoo.com; --]);
-ok($html =~ /yahoo/i $html =~ /mail/i,'include virtual 1');
+SKIP: {
+# Thijs Kinkhorst: disable tests that require network access
+#my $ssi = CGI::SSI-new();
+#my $html = $ssi-process(q[!--#include virtual=http://www.yahoo.com; --]);
+#ok($html =~ /yahoo/i $html =~ /mail/i,'include virtual 1');
+skip(skipping include virtual 1, remote test,1);
}
# tough to do these well, without more info...
@@ -119,10 +121,12 @@
# exec cgi - with different input
-{
-my $ssi = CGI::SSI-new();
-my $html = $ssi-process(q[!--#exec cgi=http://www.yahoo.com/; --]);
-ok($html =~ /yahoo/i,'exec cgi');
+SKIP: {
+# Thijs Kinkhorst: disable tests that require network access
+#my $ssi = CGI::SSI-new();
+#my $html = $ssi-process(q[!--#exec cgi=http://www.yahoo.com/; --]);
+#ok($html =~ /yahoo/i,'exec cgi');
+skip(skipping exec cgi, remote test,1);
}
# exec cmd - with different input
@@ -267,13 +271,15 @@
# test cookie support
SKIP: {
- eval use HTTP::Cookies; 1 or skip(HTTP::Cookies not installed, 1);
- my $jar = HTTP::Cookies-new({});
- $jar-set_cookie(1,'mycookie','COOKIEVAL','/','www.bitperfect.com',80,0,0,100);
-
- my $ssi = CGI::SSI-new(COOKIE_JAR = $jar);
- my $html = $ssi-process(qq[!--#include virtual=http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi--]);
- ok($html =~ m'COOKIEVAL', cookie support);
+# Thijs Kinkhorst: disable tests that require network access
+# eval use HTTP::Cookies; 1 or skip(HTTP::Cookies not installed, 1);
+# my $jar = HTTP::Cookies-new({});
+# $jar-set_cookie(1,'mycookie','COOKIEVAL','/','www.bitperfect.com',80,0,0,100);
+#
+# my $ssi = CGI::SSI-new(COOKIE_JAR = $jar);
+# my $html = $ssi-process(qq[!--#include virtual=http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi--]);
+# ok($html =~ m'COOKIEVAL', cookie support);
+ skip(skipping cookie test, remote test, 1);
}
SKIP: {
signature.asc
Description: This is a digitally signed message part
Bug#337391: libcgi-ssi-perl: FTBFS: Missing Build-Depends on netbase
Package: libcgi-ssi-perl
Severity: serious
Version: 0.88-1
From my pbuilder build log:
...
make test
make[1]: Entering directory `/tmp/buildd/libcgi-ssi-perl-0.88'
PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/lib -Iblib/arch test.pl
1..26
ok 1 - use CGI::SSI;
ok 2 - set/echo 1
ok 3 - set/echo 2
ok 4 - data encapsulation
ok 5 - new()
ok 6 - config 1
ok 7 - config 2
ok 8 - config 3
CGI::SSI error: failed to get('http://www.yahoo.com/'): 500 Can't connect to
www.yahoo.com:80 (Bad protocol 'tcp').
not ok 9 - include virtual 1
# Failed test (test.pl at line 107)
ok 10 - include virtual 2
CGI::SSI error: failed to get('http://www.yahoo.com/').
not ok 11 - exec cgi
# Failed test (test.pl at line 125)
ok 12 - exec cmd
ok 13 - if/else
ok 14 - if/elif
ok 15 - if/elif/else
ok 16 - if 1
ok 17 - if 2
ok 18 - if 3
ok 19 - if/elif/else
ok 20 - inherit 1
ok 21 - inherit 2
ok 22 - config{timefmt}
ok 23 - recursion check
CGI::SSI error: failed to
get('http://www.bitperfect.com/cgi-bin/cgi-ssi/cookietest.cgi'): 500 Can't
connect to www.bitperfect.com:80 (Bad protocol 'tcp').
not ok 24 - cookie support
# Failed test (test.pl at line 276)
ok 25 - tied object isa CGI::SSI
ok 26 - close()
# Looks like you failed 3 tests of 26.
make[1]: *** [test_dynamic] Error 3
make[1]: Leaving directory `/tmp/buildd/libcgi-ssi-perl-0.88'
make: *** [debian/build-stamp] Error 2
You need netbase to be installed for /etc/protocols to be available.
Also, you need to make sure the package builds on a machine which is
offline, since requiring network access during a package build is a
serious problem -- although I haven't yet been able to check whether
that's the case here.
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-1-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
