Bug#391689: python-support: 0.5.3 doesn't always generate python dependencies (python-script-but-no-python-dep)

2006-10-09 Thread Pierre HABOUZIT 
severity 391689 important
thanks

On Sun, Oct 08, 2006 at 12:29:09AM -0700, Cameron Dale wrote:
 Package: python-support
 Version: 0.5.3
 Severity: serious
 Justification: Policy 2.4 of the Python Policy
 
 
 I filed a bug about this before (#383958), and it was fixed in 0.4.2. 
 However, 
 some time between 0.4.3 (which worked) and 0.5.2 (which doesn't) this change 
 was removed (I just checked, and 0.5 worked fine, but 0.5.1 didn't). Using 
 the 
 recommended implementation of python-support again generates no python 
 dependencies to be included in the Depends line.
 
 Even though the changelog for 0.5.3 says:
* dh_pysupport: always generate dependencies.
 it also doesn't generate the correct dependencies

 Interestingly, the control file for my package (bittornado) is for 2 binary 
 packages, bittornado and bittornado-gui. The ${python:Depends} for the first 
 gets replaced with python-support (= 0.2) which leads to the error, while
 the second gets python. This seems strange too, as I think both should be 
 getting python, python-support (= 0.2), but maybe because the second 
 depends on the first it doens't include the python-support depend for that 
 one. I'll try to attach my control file to see if that helps explain it.

  oh and for that part:

  bittornado-gui only provides scripts, and has no modules, so
python-support does nothing with that, you only need to add 'python' to
the depends, because those binaries uses #! /usr/bin/python. (and here
you *have* $need_python set to 1, see other mail with the patch)

  bittornado comes with modules, and needs python-support. Though it
does not get python yet because of a regression.

  So again, there is nothing serions, depends are correct, just a bit
weak. I suppose josselin will fix that soon

-- 
·O·  Pierre Habouzit
··O[EMAIL PROTECTED]
OOOhttp://www.madism.org


signature.asc
Description: Digital signature

Bug#391689: python-support: 0.5.3 doesn't always generate python dependencies (python-script-but-no-python-dep)

2006-10-09 Thread Pierre HABOUZIT 
On Sun, Oct 08, 2006 at 12:29:09AM -0700, Cameron Dale wrote:
 Package: python-support
 Version: 0.5.3
 Severity: serious
 Justification: Policy 2.4 of the Python Policy
 
 
 I filed a bug about this before (#383958), and it was fixed in 0.4.2. 
 However, 
 some time between 0.4.3 (which worked) and 0.5.2 (which doesn't) this change 
 was removed (I just checked, and 0.5 worked fine, but 0.5.1 didn't). Using 
 the 
 recommended implementation of python-support again generates no python 
 dependencies to be included in the Depends line.
 
 Even though the changelog for 0.5.3 says:
* dh_pysupport: always generate dependencies.
 it also doesn't generate the correct dependencies
 
 Interestingly, the control file for my package (bittornado) is for 2 binary 
 packages, bittornado and bittornado-gui. The ${python:Depends} for the first 
 gets replaced with python-support (= 0.2) which leads to the error, while
 the second gets python. This seems strange too, as I think both should be 
 getting python, python-support (= 0.2), but maybe because the second 
 depends on the first it doens't include the python-support depend for that 
 one. I'll try to attach my control file to see if that helps explain it.
 
 I felt the severity was justified, as dh_python is now deprecated in 
 debhelper, so for users of python-support this is the only way to specify 
 the python dependencies. If I've made a mistake somewhere, please let me 
 know, as my package's latest version being included in Etch may be at stake.

  I'm not sure, IMHO that's important, but as python-support depends
upon python himself, the correct chain of depends exists. so that's not
a major problem, merely an important one.

  attached is the patch that should solve that problem.

-- 
·O·  Pierre Habouzit
··O[EMAIL PROTECTED]
OOOhttp://www.madism.org
--- debhelper/dh_pysupport.old  2006-10-09 09:15:36.0 +0200
+++ debhelper/dh_pysupport  2006-10-09 09:15:40.0 +0200
@@ -309,7 +309,7 @@
}
}
# If nothing has added a python dependency yet, add it
-   if ($need_pydep and not $have_pydep) {
+   if (not $have_pydep) {
addsubstvar($package, python:Depends, python);
}
}


signature.asc
Description: Digital signature

Bug#391689: python-support: 0.5.3 doesn't always generate python dependencies (python-script-but-no-python-dep)

2006-10-08 Thread Cameron Dale 
Package: python-support
Version: 0.5.3
Severity: serious
Justification: Policy 2.4 of the Python Policy


I filed a bug about this before (#383958), and it was fixed in 0.4.2. However, 
some time between 0.4.3 (which worked) and 0.5.2 (which doesn't) this change 
was removed (I just checked, and 0.5 worked fine, but 0.5.1 didn't). Using the 
recommended implementation of python-support again generates no python 
dependencies to be included in the Depends line.

Even though the changelog for 0.5.3 says:
   * dh_pysupport: always generate dependencies.
it also doesn't generate the correct dependencies

Interestingly, the control file for my package (bittornado) is for 2 binary 
packages, bittornado and bittornado-gui. The ${python:Depends} for the first 
gets replaced with python-support (= 0.2) which leads to the error, while
the second gets python. This seems strange too, as I think both should be 
getting python, python-support (= 0.2), but maybe because the second 
depends on the first it doens't include the python-support depend for that 
one. I'll try to attach my control file to see if that helps explain it.

I felt the severity was justified, as dh_python is now deprecated in 
debhelper, so for users of python-support this is the only way to specify 
the python dependencies. If I've made a mistake somewhere, please let me 
know, as my package's latest version being included in Etch may be at stake.

You may also want to refer to these debian-python list threads:

http://lists.debian.org/debian-python/2006/08/msg00097.html
http://lists.debian.org/debian-python/2006/08/msg00100.html

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-amd64-k8
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)

Versions of packages python-support depends on:
ii  python2.4.3-11   An interactive high-level object-o

python-support recommends no packages.

-- no debconf information
Source: bittornado
Section: net
Priority: optional
Maintainer: Micah Anderson [EMAIL PROTECTED]
Uploaders: Cameron Dale [EMAIL PROTECTED]
Build-Depends: dpatch, debhelper (= 5.0.37.2)
Build-Depends-Indep: python-dev, python-support (= 0.4.2), docbook-to-man
Standards-Version: 3.7.2

Package: bittornado
Architecture: all
Depends: ${python:Depends}
Conflicts: bittorrent (= 3.4.2-2)
Replaces: bittorrent
Suggests: bittornado-gui, python-psyco
Recommends: mime-support
Provides: python-bittornado
Description: bittorrent client with enhanced curses interface
 bittorrent is a tool for distributing files.  Whenever more than one
 person is downloading at once they send pieces of the file(s) to each
 other, thus relieving the central server's bandwidth burden. Even with
 many simultaneous downloads, the upload burden on the central server
 remains quite small, since each new downloader introduces new upload
 capacity. 
 .
 BitTornado is the next generation bittorrent client built on
 the original BitTorrent. This client features an enhanced
 console/curses mode, lots of new features under the hood, and is
 generally one of the most advanced clients out there. Get this if you
 need to limit your bandwidth, or you want more control of your
 torrents. It does everything the original bittorrent does, plus more...
 .
 This package only contains the curses interfaces, install the package
 bittornado-gui to get the GUI components
 .
 Homepage: http://bittornado.com

Package: bittornado-gui
Architecture: all
Depends: ${python:Depends}, bittornado (= ${Source-Version}), python-wxgtk2.6, 
python-wxversion
Conflicts: bittorrent (= 3.4.2-2), libfreetype6 (= 2.1.7-2.4)
Replaces: bittorrent
Suggests: python-psyco, python-wxgtk2.4
Recommends: mime-support
Description: bittorrent client with enhanced GUI interface
 bittorrent is a tool for distributing files. It's extremely easy to
 use - downloads are started by clicking on hyperlinks. Whenever more
 than one person is downloading at once they send pieces of the
 file(s) to each other, thus relieving the central server's bandwidth
 burden. Even with many simultaneous downloads, the upload burden on
 the central server remains quite small, since each new downloader
 introduces new upload capacity.
 . 
 BitTornado is the next generation bittorrent client built on
 the original BitTorrent. This client features an enhanced GUI, lots
 of new features under the hood, and is generally one of the most
 advanced clients out there. Get this if you need to limit your
 bandwidth, or you want more control of your torrents. It does
 everything the original bittorrent does, plus more...