Bug#412387: [#412387] patch doesn't fix the real issue

2007-03-06 Thread Ben Hutchings 
You wrote:
 Setting up apt-proxy (1.9.35-0.2) ...
 Disabling inetd's apt-proxy v1 line.
 invoke-rc.d: unknown initscript, /etc/init.d/inetd not found.
 dpkg: error processing apt-proxy (--configure):
  subprocess post-installation script returned error exit status 100
 Errors were encountered while processing:
  apt-proxy

It looks like you were attempting to upgrade a package from woody
(apt-proxy 1.3.0) - or at least earlier than sarge (1.9.29) - to etch
(apt-proxy 1.9.35).  Is that the case?

Ben.

-- 
Ben Hutchings
Any smoothly functioning technology is indistinguishable from a rigged demo.


signature.asc
Description: This is a digitally signed message part

Bug#412387: [#412387] patch doesn't fix the real issue

2007-03-03 Thread Ben Hutchings 
Why depend on anything to do with inetd when it's only ever needed on
upgrades from very old versions?  The stable version is 1.9.29, so there
is no need to support upgrades from pre-1.9.

I propose to remove this part of the upgrade logic altogether:

diff -ur apt-proxy-1.9.35.orig/debian/postinst apt-proxy-1.9.35/debian/postinst
--- apt-proxy-1.9.35.orig/debian/postinst
+++ apt-proxy-1.9.35/debian/postinst
@@ -31,11 +31,6 @@
 had_v2_conf=$RET
 
 if dpkg --compare-versions $PREV  lt-nl 1.9; then
-if [ -x /usr/sbin/update-inetd ]; then
-  echo Disabling inetd's apt-proxy v1 line.
-  update-inetd --comment-chars #apt-proxy-v2#  --disable 
-  invoke-rc.d inetd restart
-fi
 db_fset $NAME/upgrading-v2 seen false || true
 db_input medium $NAME/upgrading-v2 || true
 db_go
-- END --

Ben.

-- 
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999


signature.asc
Description: This is a digitally signed message part

Bug#412387: [#412387] patch doesn't fix the real issue

2007-03-03 Thread Damyan Ivanov 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

- -=| Ben Hutchings,  3.03.2007 14:24 |=-
 Why depend on anything to do with inetd when it's only ever needed on
 upgrades from very old versions?  The stable version is 1.9.29, so there
 is no need to support upgrades from pre-1.9.
 
 I propose to remove this part of the upgrade logic altogether:

This indeed seems fine (to me).


dam
- --
Damyan Ivanov   Modular Software Systems
phone +359(2)928-2611, 929-3993  fax +359(2)920-0994
mobile +359(88)856-6067  JID [EMAIL PROTECTED]
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF6ZZFHqjlqpcl9jsRAskbAKCBha3cFUv9z61vFzhL9mfI5fdFEACgrJ3u
0ED/v3TMw/ahb+lHFzwAR4o=
=7/0o
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#412387: [#412387] patch doesn't fix the real issue

2007-03-02 Thread Damyan Ivanov 
Hi,

Looking at the .postinst, there is no need to restart inetd at all,
since this will be done by update-inetd. Quoting from update-inetd(8):

-
After the /etc/inetd.conf file has been changed, update-inetd will
send a SIGHUP signal to the inetd process to make sure that  inetd
will use  the new /etc/inetd.conf file.
-

I am wondering what would happen if update-inetd is not present on the
system. IMO, the postinst will fail, due to pre-1.9 version still
listening on the port. Adding update-inetd to dependencies would avoid
this.

Attached is a patch for both issues.


dam
-- 
Damyan Ivanov   Modular Software Systems
phone +359(2)928-2611, 929-3993  fax +359(2)920-0994
mobile +359(88)856-6067  JID [EMAIL PROTECTED]
diff -ur apt-proxy-1.9.35.orig/debian/control apt-proxy-1.9.35/debian/control
--- apt-proxy-1.9.35.orig/debian/control	2006-08-14 15:46:05.0 +0300
+++ apt-proxy-1.9.35/debian/control	2007-03-02 14:10:46.0 +0200
@@ -10,7 +10,7 @@
 
 Package: apt-proxy
 Architecture: all
-Depends: debconf (= 0.5.00) | debconf-2.0, ${python:Depends}, python-twisted-web (= 0.6), python-apt (= 0.5.8), bzip2, logrotate, adduser
+Depends: debconf (= 0.5.00) | debconf-2.0, ${python:Depends}, python-twisted-web (= 0.6), python-apt (= 0.5.8), bzip2, logrotate, adduser, update-inetd
 Conflicts: apt-proxy-v2 (= 1.9.5)
 Replaces: apt-proxy-v2 (= 1.9.5)
 Suggests: rsync
diff -ur apt-proxy-1.9.35.orig/debian/postinst apt-proxy-1.9.35/debian/postinst
--- apt-proxy-1.9.35.orig/debian/postinst	2006-08-04 02:54:46.0 +0300
+++ apt-proxy-1.9.35/debian/postinst	2007-03-02 14:11:38.0 +0200
@@ -31,11 +31,9 @@
 had_v2_conf=$RET
 
 if dpkg --compare-versions $PREV  lt-nl 1.9; then
-if [ -x /usr/sbin/update-inetd ]; then
-  echo Disabling inetd's apt-proxy v1 line.
-  update-inetd --comment-chars #apt-proxy-v2#  --disable 
-  invoke-rc.d inetd restart
-fi
+echo Disabling inetd's apt-proxy v1 line.
+update-inetd --comment-chars #apt-proxy-v2#  --disable 
+
 db_fset $NAME/upgrading-v2 seen false || true
 db_input medium $NAME/upgrading-v2 || true
 db_go


signature.asc
Description: OpenPGP digital signature