Bug#413184: [powerpci/mac] partman-md appears to not write back the raid flag to partitions.

2007-03-06 Thread Steve Langasek
I've found some time to confirm for myself that this patch fixes the problem
of not being able to set the RAID flag in partman.  I've tweaked the patch
slighly to tighten it up; the final version is attached.

I'll upload this NMU to incoming shortly.

Thanks,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
[EMAIL PROTECTED]   http://www.debian.org/
diff -Nru /tmp/YHHh2qwAgl/parted-1.7.1/debian/changelog /tmp/J973m06W3f/parted-1.7.1/debian/changelog
--- /tmp/YHHh2qwAgl/parted-1.7.1/debian/changelog	2007-01-22 02:44:06.0 -0800
+++ /tmp/J973m06W3f/parted-1.7.1/debian/changelog	2007-03-06 01:06:02.0 -0800
@@ -1,3 +1,14 @@
+parted (1.7.1-5.1) unstable; urgency=high
+
+  * Non-maintainer upload.
+  * High-urgency upload for RC bugfix.
+  * Patch to ensure changes to RAID/LVM flags on mac partitions are
+saved and reloaded correctly, so that debian-installer can use RAID for
+install on mac powerpcs; thanks to David Härdeman for the patch.
+Closes: #413184.
+
+ -- Steve Langasek [EMAIL PROTECTED]  Tue,  6 Mar 2007 00:51:09 -0800
+
 parted (1.7.1-5) unstable; urgency=low
 
   * ntfs-align.dpatch: Disabled. We found regressions on it.
diff -Nru /tmp/YHHh2qwAgl/parted-1.7.1/libparted/labels/mac.c /tmp/J973m06W3f/parted-1.7.1/libparted/labels/mac.c
--- /tmp/YHHh2qwAgl/parted-1.7.1/libparted/labels/mac.c	2006-05-25 10:28:55.0 -0700
+++ /tmp/J973m06W3f/parted-1.7.1/libparted/labels/mac.c	2007-03-06 01:06:16.0 -0800
@@ -1260,19 +1260,19 @@
 		return 1;
 
 	case PED_PARTITION_LVM:
-		mac_data-is_lvm = state;
 		if (state)
 			strcpy (mac_data-system_name, Linux_LVM);
-		else
+		else if (mac_data-is_lvm)
 			mac_partition_set_system (part, part-fs_type);
+		mac_data-is_lvm = state;
 		return 1;
 
 	case PED_PARTITION_RAID:
-		mac_data-is_raid = state;
 		if (state)
 			strcpy (mac_data-system_name, Linux_RAID);
-		else
+		else if (mac_data-is_raid)
 			mac_partition_set_system (part, part-fs_type);
+		mac_data-is_raid = state;
 		return 1;
 
 	default:


Bug#413184: [Parted-maintainers] Bug#413184: [powerpci/mac] partman-md appears to not write back the raid flag to partitions.

2007-03-06 Thread Sven Luther
On Tue, Mar 06, 2007 at 02:55:11AM -0800, Steve Langasek wrote:
 I've found some time to confirm for myself that this patch fixes the problem
 of not being able to set the RAID flag in partman.  I've tweaked the patch
 slighly to tighten it up; the final version is attached.
 
 I'll upload this NMU to incoming shortly.

nice catch.

I am still curious that this issue if present in libparted was seen from
partman and not from parted itself. No wonder i didn't find anything in the
partman code himself.

Friendly,

Sven Luther


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]